43994 2010-08-13 15:50:23 -0700 [GTK] GTK+ drawing idle starved 2010-08-16 10:52:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://themaninblue.com/experiment/AnimationBenchmark/canvas/ Gtk P2 Normal --- 1 gustavo gustavo abarth eric mrobinson webkit.review.bot oldest_to_newest 264524 0 gustavo 2010-08-13 15:50:23 -0700 The page at http://themaninblue.com/experiment/AnimationBenchmark/canvas/ is able to starve the idle that is responsible for redrawing in GTK+. We need to further fine tune the priorities we use in our various timeouts. 264529 1 64383 gustavo 2010-08-13 15:59:24 -0700 Created attachment 64383 proposed fix This fixes the issue with that site for me, even with the browser under great stress, such as playing flash videos, some chromeexperiments, the "video blow up" demo, and playing http://trailers.apple.com/movies/paramount/ironman2/ironman2-34rgrwt9-tlr2_720p.mov. The priority used is the one GTK+ uses for its redraw idle. 264777 2 mrobinson 2010-08-14 17:43:04 -0700 Wow! That was a fast fix. Maybe you should change the priority to GDK_PRIORITY_REDRAW? http://library.gnome.org/devel/gdk/stable/gdk-Events.html#GDK-PRIORITY-REDRAW:CAPS 265057 3 gustavo 2010-08-16 06:12:39 -0700 I could, but then I'd need to add the gdk include to this file, do you think it's worth it? =) 265111 4 mrobinson 2010-08-16 08:12:54 -0700 Hrm. My preference is either the GDK include or a comment explaining where the "+ 20" comes from. 265154 5 gustavo 2010-08-16 10:12:01 -0700 I landed this as r65438 adding the include. Thanks for the reviews! 265162 6 webkit.review.bot 2010-08-16 10:52:59 -0700 http://trac.webkit.org/changeset/65438 might have broken SnowLeopard Intel Release (Tests) 64383 2010-08-13 15:59:24 -0700 2010-08-14 08:10:38 -0700 proposed fix 0001-Fine-tune-priorities.patch text/plain 1530 gustavo RnJvbSBjZWNmNzYzNTU4OTQzNTVjOTExOWY2ODUwMmI5NGNhMTdiMTliYTU4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IEZyaSwgMTMgQXVnIDIwMTAgMTk6NTU6NDQgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aW5lIHR1bmUgcHJpb3JpdGllcy4KCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL2d0ay9TaGFy ZWRUaW1lckd0ay5jcHAgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA5MzE5MThkLi4yZmRlYmI5IDEwMDY0NAotLS0gYS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEw LTA4LTEzICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3Jh LmNvLnVrPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtHVEtdIEdUSysgZHJhd2luZyBpZGxlIHN0YXJ2ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzOTk0CisKKyAgICAgICAgVHVuZSBkb3duIHRoZSBw cmlvcml0eSBvZiB0aGUgc2hhcmVkIHRpbWVycyB0byBndWFyYW50ZWUgR1RLKyBoYXMKKyAgICAg ICAgYW4gb3Bwb3J0dW5pdHkgdG8gcmVkcmF3LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1No YXJlZFRpbWVyR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNldFNoYXJlZFRpbWVyRmlyZVRp bWUpOgorCiAyMDEwLTA4LTEzICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2hhcmVkVGltZXJHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9y bS9ndGsvU2hhcmVkVGltZXJHdGsuY3BwCmluZGV4IDA5MmRmOTUuLjJmMzUwNTggMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1NoYXJlZFRpbWVyR3RrLmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9TaGFyZWRUaW1lckd0ay5jcHAKQEAgLTYzLDcgKzYzLDcgQEAgdm9pZCBz ZXRTaGFyZWRUaW1lckZpcmVUaW1lKGRvdWJsZSBmaXJlVGltZSkKICAgICB9CiAKICAgICBzdG9w U2hhcmVkVGltZXIoKTsKLSAgICBzaGFyZWRUaW1lciA9IGdfdGltZW91dF9hZGQoaW50ZXJ2YWxJ bk1TLCB0aW1lb3V0X2NiLCBOVUxMKTsKKyAgICBzaGFyZWRUaW1lciA9IGdfdGltZW91dF9hZGRf ZnVsbChHX1BSSU9SSVRZX0hJR0hfSURMRSArIDIwLCBpbnRlcnZhbEluTVMsIHRpbWVvdXRfY2Is IDAsIDApOwogfQogCiB2b2lkIHN0b3BTaGFyZWRUaW1lcigpCi0tIAoxLjcuMQoK