<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43984</bug_id>
          
          <creation_ts>2010-08-13 11:21:21 -0700</creation_ts>
          <short_desc>[CMake] Add preprocessor detection for generator scripts</short_desc>
          <delta_ts>2010-08-14 09:34:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>43906</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>leandro</cc>
    
    <cc>zimmermann</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>264445</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2010-08-13 11:21:21 -0700</bug_when>
    <thetext>see patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>264448</commentid>
    <comment_count>1</comment_count>
      <attachid>64359</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2010-08-13 11:27:03 -0700</bug_when>
    <thetext>Created attachment 64359
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>264449</commentid>
    <comment_count>2</comment_count>
    <who name="Leandro Pereira">leandro</who>
    <bug_when>2010-08-13 11:30:10 -0700</bug_when>
    <thetext>I&apos;m not a reviewer, but patch looks fine to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>264673</commentid>
    <comment_count>3</comment_count>
      <attachid>64359</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-08-14 07:53:04 -0700</bug_when>
    <thetext>Comment on attachment 64359
Patch

LGTM</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>264700</commentid>
    <comment_count>4</comment_count>
      <attachid>64359</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-14 09:34:50 -0700</bug_when>
    <thetext>Comment on attachment 64359
Patch

Clearing flags on attachment: 64359

Committed r65369: &lt;http://trac.webkit.org/changeset/65369&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>264701</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-14 09:34:55 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>64359</attachid>
            <date>2010-08-13 11:27:03 -0700</date>
            <delta_ts>2010-08-14 09:34:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>0001-detection.patch</filename>
            <type>text/plain</type>
            <size>2446</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiMmYxYTcyLi41ZTVhZjJk
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK
KzIwMTAtMDgtMTMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHBhcm9nYS5jb20+CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0NNYWtlXSBBZGQg
cHJlcHJvY2Vzc29yIGRldGVjdGlvbiBmb3IgZ2VuZXJhdG9yIHNjcmlwdHMKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzOTg0CisKKyAgICAgICAgKiBj
bWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlOgorCiAyMDEwLTA4LTEzICBMZWFuZHJvIFBlcmVpcmEg
IDxsZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIFVucmV2aWV3ZWQgYnVp
bGQgZml4LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQgYi9KYXZh
U2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBhOTQ0MzYzLi41ZmNmNjQzIDEwMDY0NAot
LS0gYS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9KYXZhU2NyaXB0Q29yZS9D
TWFrZUxpc3RzLnR4dApAQCAtMjAzLDEzICsyMDMsMTAgQEAgR0VORVJBVEVfSEFTSF9MVVQoJHtK
QVZBU0NSSVBUQ09SRV9ESVJ9L3BhcnNlci9LZXl3b3Jkcy50YWJsZSAke0RFUklWRURfU09VUkNF
U18KIExJU1QoQVBQRU5EIEphdmFTY3JpcHRDb3JlX0hFQURFUlMgJHtERVJJVkVEX1NPVVJDRVNf
RElSfS9MZXhlci5sdXQuaCkKIAogIyBHRU5FUkFUT1I6ICJjaGFydGFibGVzLmMiOiBjb21waWxl
IGFuZCBleGVjdXRlIHRoZSBjaGFydGFibGVzIGdlbmVyYXRvciAoYW5kIGFkZCBpdCB0byBzb3Vy
Y2VzKQotSUYgKE1TVkMpCi0gICAgU0VUKEpTQ19ERlRBQkxFU19QUkVQUk9DRVNTT1IgLS1wcmVw
cm9jZXNzb3I9Y2wuZXhlKQotRU5ESUYgKCkKIEFERF9DVVNUT01fQ09NTUFORCgKICAgICBPVVRQ
VVQgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9jaGFydGFibGVzLmMKICAgICBNQUlOX0RFUEVOREVO
Q1kgJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3BjcmUvZGZ0YWJsZXMKLSAgICBDT01NQU5EICR7UEVS
TF9FWEVDVVRBQkxFfSAke0pBVkFTQ1JJUFRDT1JFX0RJUn0vcGNyZS9kZnRhYmxlcyAke0pTQ19E
RlRBQkxFU19QUkVQUk9DRVNTT1J9ICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vY2hhcnRhYmxlcy5j
CisgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3Bj
cmUvZGZ0YWJsZXMgLS1wcmVwcm9jZXNzb3IgIiR7Q09ERV9HRU5FUkFUT1JfUFJFUFJPQ0VTU09S
fSIgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9jaGFydGFibGVzLmMKICAgICBWRVJCQVRJTSkKIEFE
RF9TT1VSQ0VfREVQRU5ERU5DSUVTKCR7SkFWQVNDUklQVENPUkVfRElSfS9wY3JlL3BjcmVfdGFi
bGVzLmNwcCAke0RFUklWRURfU09VUkNFU19ESVJ9L2NoYXJ0YWJsZXMuYykKIApkaWZmIC0tZ2l0
IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmlu
ZGV4IDAyNGU2OGMuLjEzMTFiZjkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxv
ZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0w
OC0xMyAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAcGFyb2dhLmNvbT4KKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ01ha2VdIEFkZCBwcmVwcm9j
ZXNzb3IgZGV0ZWN0aW9uIGZvciBnZW5lcmF0b3Igc2NyaXB0cworICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM5ODQKKworICAgICAgICAqIENNYWtlTGlz
dHMudHh0OgorCiAyMDEwLTA4LTEzICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpkaWZmIC0tZ2l0IGEvY21ha2Uv
T3B0aW9uc0NvbW1vbi5jbWFrZSBiL2NtYWtlL09wdGlvbnNDb21tb24uY21ha2UKaW5kZXggYjBk
MDM3NS4uOGIwYjljMyAxMDA2NDQKLS0tIGEvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZQorKysg
Yi9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBAIC0xNiwzICsxNiw5IEBAIFNFVChXVEZfSU5D
TFVERV9ESVJFQ1RPUklFUwogSUYgKFdURl9PU19VTklYKQogICAgIEFERF9ERUZJTklUSU9OUygt
RFhQX1VOSVgpCiBFTkRJRiAoV1RGX09TX1VOSVgpCisKK0lGIChNU1ZDKQorICAgIFNFVChDT0RF
X0dFTkVSQVRPUl9QUkVQUk9DRVNTT1IgImNsLmV4ZSAvbm9sb2dvIC9FUCIpCitFTFNFICgpCisg
ICAgU0VUKENPREVfR0VORVJBVE9SX1BSRVBST0NFU1NPUiAiY3BwIikKK0VORElGICgpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>