43982 2010-08-13 11:11:11 -0700 A flaw in detecting mobile WebKit in WebKitSite/misc/WebKitDetect.js 2010-09-06 02:57:26 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) All All RESOLVED FIXED http://webkit.org/misc/WebKitDetect.html P2 Normal --- 0 robin.qiu webkit-unassigned charles.wei commit-queue levin mrowe staikos timothy oldest_to_newest 264442 0 robin.qiu 2010-08-13 11:11:11 -0700 http://trac.webkit.org/browser/trunk/WebKitSite/misc/WebKitDetect.js It seems to be a popular script for detecting mobile WebKit but it has a flaw that makes it fail on Android and BlackBerry. The issue is that it looks for "Mobile/" but Android and BlackBerry use "Mobile" with no numbering after it. 264477 1 64368 robin.qiu 2010-08-13 13:06:32 -0700 Created attachment 64368 Patch v1 264790 2 64368 abarth 2010-08-14 23:06:58 -0700 Comment on attachment 64368 Patch v1 What character do they have after Mobile? It seems like this might match MobileOpera or something silly like that. 265095 3 robin.qiu 2010-08-16 07:37:50 -0700 (In reply to comment #2) > (From update of attachment 64368 [details]) > What character do they have after Mobile? It seems like this might match MobileOpera or something silly like that. It's a space, so, should we use " Mobile\b" as pattern? 265892 4 levin 2010-08-17 18:28:39 -0700 Before landing, please add a bug link to your ChangeLog. 272008 5 64368 kenneth 2010-08-31 03:09:22 -0700 Comment on attachment 64368 Patch v1 r-, due to missing bug link in changelog, plus didn't you want to add the \b to make sure that you match "Mobile/" and "Mobile "? 272084 6 66048 robin.qiu 2010-08-31 07:31:41 -0700 Created attachment 66048 patch v2 Change " Mobile/" to " Mobile\\b". Add bugzilla link. 272578 7 66048 abarth 2010-08-31 19:28:30 -0700 Comment on attachment 66048 patch v2 ok 272817 8 robin.qiu 2010-09-01 08:36:17 -0700 (In reply to comment #7) > (From update of attachment 66048 [details]) > ok Thanks for your review. :) 274525 9 66048 commit-queue 2010-09-06 02:57:21 -0700 Comment on attachment 66048 patch v2 Clearing flags on attachment: 66048 Committed r66819: <http://trac.webkit.org/changeset/66819> 274526 10 commit-queue 2010-09-06 02:57:26 -0700 All reviewed patches have been landed. Closing bug. 64368 2010-08-13 13:06:32 -0700 2010-08-31 07:31:41 -0700 Patch v1 mobile.detect.patch text/plain 1258 robin.qiu ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggNTA4YTVlYy4uZjY4ZGU4ZSAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0xMyAg Um9iaW4gUWl1ICA8cm9iaW4ucWl1QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGpzIGZpbGUgc2VlbXMgdG8g YmUgYSBwb3B1bGFyIHNjcmlwdCBmb3IgZGV0ZWN0aW5nIG1vYmlsZSBXZWJLaXQgYnV0CisgICAg ICAgIGl0IGhhcyBhIGZsYXcgdGhhdCBtYWtlcyBpdCBmYWlsIG9uIEFuZHJvaWQgYW5kIEJsYWNr QmVycnkuICAKKworICAgICAgICBUaGUgaXNzdWUgaXMgdGhhdCBpdCBsb29rcyBmb3IgIk1vYmls ZS8iIGJ1dCBBbmRyb2lkIGFuZCBCbGFja0JlcnJ5CisgICAgICAgIHVzZSAiTW9iaWxlIiB3aXRo IG5vIG51bWJlcmluZyBhZnRlciBpdC4KKworICAgICAgICAqIG1pc2MvV2ViS2l0RGV0ZWN0Lmpz OgorICAgICAgICAoV2ViS2l0RGV0ZWN0LmlzTW9iaWxlKToKKwogMjAxMC0wNy0zMCAgUmVuYXRh IEhvZG92YW4gIDxyZW5pQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdlZCBieSBO aWtvbGFzIFppbW1lcm1hbm4uCmRpZmYgLS1naXQgYS9XZWJLaXRTaXRlL21pc2MvV2ViS2l0RGV0 ZWN0LmpzIGIvV2ViS2l0U2l0ZS9taXNjL1dlYktpdERldGVjdC5qcwppbmRleCAxYzVjNjkyLi45 YmEzYTM2IDEwMDY0NAotLS0gYS9XZWJLaXRTaXRlL21pc2MvV2ViS2l0RGV0ZWN0LmpzCisrKyBi L1dlYktpdFNpdGUvbWlzYy9XZWJLaXREZXRlY3QuanMKQEAgLTEwMSw3ICsxMDEsNyBAQCBXZWJL aXREZXRlY3QudmVyc2lvbklzQXRMZWFzdCA9IGZ1bmN0aW9uIHZlcnNpb25Jc0F0TGVhc3QobWlu aW11bVN0cmluZykKIAogV2ViS2l0RGV0ZWN0LmlzTW9iaWxlID0gZnVuY3Rpb24gaXNNb2JpbGUo KQogewotICAgIHJldHVybiBXZWJLaXREZXRlY3QuaXNXZWJLaXQoKSAmJiBSZWdFeHAoIiBNb2Jp bGUvIikudGVzdChuYXZpZ2F0b3IudXNlckFnZW50KTsKKyAgICByZXR1cm4gV2ViS2l0RGV0ZWN0 LmlzV2ViS2l0KCkgJiYgUmVnRXhwKCIgTW9iaWxlIikudGVzdChuYXZpZ2F0b3IudXNlckFnZW50 KTsKIH0KIAogV2ViS2l0RGV0ZWN0Lm1vYmlsZURldmljZSA9IGZ1bmN0aW9uIG1vYmlsZURldmlj ZSgpCg== 66048 2010-08-31 07:31:41 -0700 2010-09-06 02:57:21 -0700 patch v2 mobile.detect.patch text/plain 1407 robin.qiu ZGlmZiAtLWdpdCBhL1dlYktpdFNpdGUvQ2hhbmdlTG9nIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK aW5kZXggMzRjNGMwMi4uM2NjZmI1ZiAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0zMSAg Um9iaW4gUWl1ICA8cm9iaW4ucWl1QHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDM5ODIKKyAgICAgICAgVGhpcyBqcyBmaWxlIHNlZW1zIHRvIGJl IGEgcG9wdWxhciBzY3JpcHQgZm9yIGRldGVjdGluZyBtb2JpbGUgV2ViS2l0IGJ1dAorICAgICAg ICBpdCBoYXMgYSBmbGF3IHRoYXQgbWFrZXMgaXQgZmFpbCBvbiBBbmRyb2lkIGFuZCBCbGFja0Jl cnJ5LiAgCisKKyAgICAgICAgVGhlIGlzc3VlIGlzIHRoYXQgaXQgbG9va3MgZm9yICJNb2JpbGUv IiBidXQgQW5kcm9pZCBhbmQgQmxhY2tCZXJyeQorICAgICAgICB1c2UgIk1vYmlsZSIgd2l0aCBu byBudW1iZXJpbmcgYWZ0ZXIgaXQuCisgICAgICAgIENoYW5nZWQgUmVnRXhwIHBhdHRlcm4gIiBN b2JpbGUvIiB0byAiIE1vYmlsZVxcYiIuCisKKyAgICAgICAgKiBtaXNjL1dlYktpdERldGVjdC5q czoKKyAgICAgICAgKFdlYktpdERldGVjdC5pc01vYmlsZSk6CisKIDIwMTAtMDgtMjcgIERhcmlu IEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgICogY29kaW5nL1JlZlB0ci5odG1s OiBNaW5vciByZXZpc2lvbiwgaW1wcm92ZSBjbGFyaXR5IGFuZCBtZW50aW9uIHNvbWUKZGlmZiAt LWdpdCBhL1dlYktpdFNpdGUvbWlzYy9XZWJLaXREZXRlY3QuanMgYi9XZWJLaXRTaXRlL21pc2Mv V2ViS2l0RGV0ZWN0LmpzCmluZGV4IDFjNWM2OTIuLmYwMzhkNjggMTAwNjQ0Ci0tLSBhL1dlYktp dFNpdGUvbWlzYy9XZWJLaXREZXRlY3QuanMKKysrIGIvV2ViS2l0U2l0ZS9taXNjL1dlYktpdERl dGVjdC5qcwpAQCAtMTAxLDcgKzEwMSw3IEBAIFdlYktpdERldGVjdC52ZXJzaW9uSXNBdExlYXN0 ID0gZnVuY3Rpb24gdmVyc2lvbklzQXRMZWFzdChtaW5pbXVtU3RyaW5nKQogCiBXZWJLaXREZXRl Y3QuaXNNb2JpbGUgPSBmdW5jdGlvbiBpc01vYmlsZSgpCiB7Ci0gICAgcmV0dXJuIFdlYktpdERl dGVjdC5pc1dlYktpdCgpICYmIFJlZ0V4cCgiIE1vYmlsZS8iKS50ZXN0KG5hdmlnYXRvci51c2Vy QWdlbnQpOworICAgIHJldHVybiBXZWJLaXREZXRlY3QuaXNXZWJLaXQoKSAmJiBSZWdFeHAoIiBN b2JpbGVcXGIiKS50ZXN0KG5hdmlnYXRvci51c2VyQWdlbnQpOwogfQogCiBXZWJLaXREZXRlY3Qu bW9iaWxlRGV2aWNlID0gZnVuY3Rpb24gbW9iaWxlRGV2aWNlKCkK