43957 2010-08-13 01:40:11 -0700 Need a LayoutTest to check that pages using Geolocation are not put in the page cache 2010-08-13 09:24:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39879 1 steveblock webkit-unassigned ap steveblock oldest_to_newest 264242 0 steveblock 2010-08-13 01:40:11 -0700 Currently, pages that use Geolocation are explicitly prevented from entering the page cache. This is planned to be fixed in Bug 43956 but until then, we should add a test to make sure that such pages do no enter the page cache. 264252 1 64314 steveblock 2010-08-13 02:07:36 -0700 Created attachment 64314 Patch 264256 2 64314 ap 2010-08-13 02:25:53 -0700 Comment on attachment 64314 Patch As mentioned elsewhere, having a separate JS file is harmful in several ways. This is not grounds for r-, since many existing tests do the same, but I think that we should stop doing that, and maybe even convert existing tests. +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode (if needed). 264394 3 steveblock 2010-08-13 08:57:16 -0700 > The HTML5 doctype is <!DOCTYPE html>, we should be using that for strict mode > (if needed). I don't think we need strict mode here. However, this DOCTYPE comes from TEMPLATE.html for the Geolocation tests. Looking at other TEMPLATE.html files, almost all specify a DOCTYPE [1] and of those, all but two [2] use this HTML2 DOCTYPE. I could file a bug to change or remove the DOCTYPE for all Geolocation tests. [1] No DOCTYPE ... fast/dom/DeviceMotion/script-tests/TEMPLATE.html fast/dom/DeviceOrientation/script-tests/TEMPLATE.html storage/domstorage/events/script-tests/TEMPLATE.html storage/domstorage/script-tests/TEMPLATE.html storage/indexeddb/script-tests/TEMPLATE.html [2] HTML5 DOCTYPE ... platform/win/editing/selection/script-tests/TEMPLATE.html platform/mac/editing/selection/script-tests/TEMPLATE.html 264403 4 steveblock 2010-08-13 09:24:07 -0700 Committed r65325: <http://trac.webkit.org/changeset/65325> 64314 2010-08-13 02:07:36 -0700 2010-08-13 02:25:53 -0700 Patch bug-43957-20100813100733.patch text/plain 5306 steveblock SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY1MzA4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMTMgIFN0ZXZlIEJsb2NrICA8c3Rl dmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5lZWQgYSBMYXlvdXRUZXN0IHRvIGNoZWNrIHRoYXQgcGFnZXMgdXNpbmcg R2VvbG9jYXRpb24gYXJlIG5vdCBwdXQgaW4gdGhlIHBhZ2UgY2FjaGUKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzOTU3CisKKyAgICAgICAgKiBmYXN0 L2RvbS9HZW9sb2NhdGlvbi9uby1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAg ICAgICogZmFzdC9kb20vR2VvbG9jYXRpb24vbm8tcGFnZS1jYWNoZS5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2RvbS9HZW9sb2NhdGlvbi9yZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMS5odG1s OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9HZW9sb2NhdGlvbi9yZXNvdXJjZXMvY2FjaGVk LXBhZ2UtMi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9HZW9sb2NhdGlvbi9zY3Jp cHQtdGVzdHMvbm8tcGFnZS1jYWNoZS5qczogQWRkZWQuCisgICAgICAgIChyZXBvcnRQYWdlT25l T25sb2FkKToKKwogMjAxMC0wOC0xMiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEdhdmluIEJhcnJhY2xvdWdoLgpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9kb20vR2VvbG9jYXRpb24vbm8tcGFnZS1jYWNoZS1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vR2VvbG9jYXRpb24vbm8tcGFnZS1jYWNoZS1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlv bi9uby1wYWdlLWNhY2hlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBA QAorVGVzdHMgdGhhdCBwYWdlcyB0aGF0IHVzZSBHZW9sb2NhdGlvbiBhcmUgbm90IHB1dCBpbiB0 aGUgcGFnZSBjYWNoZS4KKworQ3VycmVudGx5LCBHZW9sb2NhdGlvbiBkb2VzIG5vdCB3b3JrIHdp dGggdGhlIHBhZ2UgY2FjaGUgc28gcGFnZXMgdGhhdCB1c2UgR2VvbG9jYXRpb24gYXJlIGV4cGxp Y2l0bHkgcHJldmVudGVkIGZyb20gZW50ZXJpbmcgdGhlIGNhY2hlLiBUaGlzIHRlc3QgY2hlY2tz IGZvciBhY2NpZGVudGFsIGVuYWJsaW5nIG9mIHRoZSBwYWdlIENhY2hlIGZvciBHZW9sb2NhdGlv bi4gU2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzk1NiBmb3Ig ZGV0YWlscy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBt ZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK01haW4gcGFnZSBvcGVu aW5nIHJlc291cmNlcy9jYWNoZWQtcGFnZS0xLmh0bWwKK3Jlc291cmNlcy9jYWNoZWQtcGFnZS0x Lmh0bWwgZmlyZWQsIGNvdW50ID0gMQorcmVzb3VyY2VzL2NhY2hlZC1wYWdlLTEuaHRtbCBhYm91 dCB0byBuYXZpZ2F0ZSB0byByZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMi5odG1sCityZXNvdXJjZXMv Y2FjaGVkLXBhZ2UtMi5odG1sIGFib3V0IHRvIGdvIGJhY2sgdG8gcmVzb3VyY2VzL2NhY2hlZC1w YWdlLTEuaHRtbAorcmVzb3VyY2VzL2NhY2hlZC1wYWdlLTEuaHRtbCBmaXJlZCwgY291bnQgPSAy CitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9kb20vR2VvbG9jYXRpb24vbm8tcGFnZS1jYWNoZS5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9uL25vLXBhZ2UtY2Fj aGUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9u L25vLXBhZ2UtY2FjaGUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPCFET0NU WVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4K KzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt c3R5bGUuY3NzIj4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4K KzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBzcmM9InNjcmlwdC10ZXN0cy9uby1w YWdlLWNhY2hlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMv anMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9uL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0xLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vR2VvbG9jYXRpb24vcmVzb3VyY2Vz L2NhY2hlZC1wYWdlLTEuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9t L0dlb2xvY2F0aW9uL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0xLmh0bWwJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMTAgQEAKKzxzY3JpcHQ+CitmdW5jdGlvbiBsb2FkTmV4dCgpIHsKKyAgICB2YXIg Z2VvbG9jYXRpb24gPSBuYXZpZ2F0b3IuZ2VvbG9jYXRpb247CisgICAgaWYgKHdpbmRvdy5vcGVu ZXIucmVwb3J0UGFnZU9uZU9ubG9hZCgpID09IDEpIHsKKyAgICAgICAgd2luZG93Lm9wZW5lci5k ZWJ1ZygncmVzb3VyY2VzL2NhY2hlZC1wYWdlLTEuaHRtbCBhYm91dCB0byBuYXZpZ2F0ZSB0byBy ZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMi5odG1sJykKKyAgICAgICAgbG9jYXRpb24uaHJlZiA9ICdj YWNoZWQtcGFnZS0yLmh0bWwnOworICAgIH0KK30KKzwvc2NyaXB0PgorPGJvZHkgb25sb2FkPSJs b2FkTmV4dCgpIj48L2JvZHk+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlv bi9yZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZG9tL0dlb2xvY2F0aW9uL3Jlc291cmNlcy9jYWNoZWQtcGFnZS0yLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9HZW9sb2NhdGlvbi9yZXNvdXJjZXMvY2Fj aGVkLXBhZ2UtMi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDggQEAKKzxzY3JpcHQ+Citm dW5jdGlvbiBpbml0KCkgeworICAgIHdpbmRvdy5vcGVuZXIucGFnZVR3b0xvYWRlZCA9IHRydWU7 CisgICAgd2luZG93Lm9wZW5lci5kZWJ1ZygncmVzb3VyY2VzL2NhY2hlZC1wYWdlLTIuaHRtbCBh Ym91dCB0byBnbyBiYWNrIHRvIHJlc291cmNlcy9jYWNoZWQtcGFnZS0xLmh0bWwnKTsKKyAgICBo aXN0b3J5LmJhY2soKTsKK30KKzwvc2NyaXB0PgorPGJvZHkgb25sb2FkPSJpbml0KCkiPjwvYm9k eT4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xvY2F0aW9uL3NjcmlwdC10ZXN0cy9u by1wYWdlLWNhY2hlLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL0dlb2xv Y2F0aW9uL3NjcmlwdC10ZXN0cy9uby1wYWdlLWNhY2hlLmpzCShyZXZpc2lvbiAwKQorKysgTGF5 b3V0VGVzdHMvZmFzdC9kb20vR2VvbG9jYXRpb24vc2NyaXB0LXRlc3RzL25vLXBhZ2UtY2FjaGUu anMJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjQgQEAKK2Rlc2NyaXB0aW9uKCJUZXN0cyB0aGF0 IHBhZ2VzIHRoYXQgdXNlIEdlb2xvY2F0aW9uIGFyZSBub3QgcHV0IGluIHRoZSBwYWdlIGNhY2hl Ljxicj48YnI+Q3VycmVudGx5LCBHZW9sb2NhdGlvbiBkb2VzIG5vdCB3b3JrIHdpdGggdGhlIHBh Z2UgY2FjaGUgc28gcGFnZXMgdGhhdCB1c2UgR2VvbG9jYXRpb24gYXJlIGV4cGxpY2l0bHkgcHJl dmVudGVkIGZyb20gZW50ZXJpbmcgdGhlIGNhY2hlLiBUaGlzIHRlc3QgY2hlY2tzIGZvciBhY2Np ZGVudGFsIGVuYWJsaW5nIG9mIHRoZSBwYWdlIENhY2hlIGZvciBHZW9sb2NhdGlvbi4gU2VlIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzk1NiBmb3IgZGV0YWlscy4i KTsKKworaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RD b250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRD YW5PcGVuV2luZG93cygpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVy ZW5jZSgiV2ViS2l0VXNlc1BhZ2VDYWNoZVByZWZlcmVuY2VLZXkiLCAxKTsKK30gZWxzZQorICAg IGRlYnVnKCdUaGlzIHRlc3QgY2FuIG5vdCBiZSBydW4gd2l0aG91dCB0aGUgTGF5b3V0VGVzdENv bnRyb2xsZXInKTsKKwordmFyIHBhZ2VPbmVPbmxvYWRDb3VudCA9IDA7CitmdW5jdGlvbiByZXBv cnRQYWdlT25lT25sb2FkKCkgeworICAgICsrcGFnZU9uZU9ubG9hZENvdW50OworICAgIGRlYnVn KCdyZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMS5odG1sIGZpcmVkLCBjb3VudCA9ICcgKyBwYWdlT25l T25sb2FkQ291bnQpOworICAgIGlmIChwYWdlT25lT25sb2FkQ291bnQgPT0gMikgeworICAgICAg ICBmaW5pc2hKU1Rlc3QoKTsKKyAgICB9CisgICAgcmV0dXJuIHBhZ2VPbmVPbmxvYWRDb3VudDsK K30KKworZGVidWcoIk1haW4gcGFnZSBvcGVuaW5nIHJlc291cmNlcy9jYWNoZWQtcGFnZS0xLmh0 bWwiKTsKK3dpbmRvdy5vcGVuKCJyZXNvdXJjZXMvY2FjaGVkLXBhZ2UtMS5odG1sIik7CisKK3dp bmRvdy5qc1Rlc3RJc0FzeW5jID0gdHJ1ZTsKK3dpbmRvdy5zdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOwo=