4393 2005-08-11 11:02:51 -0700 REGRESSION: Unconfirmed text ignored in input type=text 2018-11-10 23:18:13 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 VERIFIED FIXED http://www.google.com P1 Major --- 1 ap darin farizdeni oldest_to_newest 16442 0 ap 2005-08-11 11:02:51 -0700 If a form field contains unconfirmed inline input, its contents is ignored. Steps to reproduce: 1. Open the attached file (inputtext.html) in Safari 2. With any input method that uses inline input (such as Kotoeri Hiragana), type something tinto the input field 3. Click the "Start Search" button Results: An alert "Search field appears empty". Alternatively: try a Google search (from www.google.com, not the Google bar) without confirming the inline input Regression: was OK in WebKit/412 (OS X 10.4.2) Discussion: Necessity to manually confirm all inline input sessions is a major hurdle for people using inline input. 16444 1 3345 ap 2005-08-11 11:12:23 -0700 Created attachment 3345 test case 18658 2 ap 2005-09-04 08:10:27 -0700 Still present in Safari 2.0.1 (412.5) with ToT WebKit. 18697 3 darin 2005-09-04 13:35:26 -0700 This sounds a lot like <rdar://problem/4094066> REGRESSION (1.2.5-1.3): unconfirmed inline input is ignored in <textarea>, lost when form is submitted, which I fixed a while back. 18708 4 darin 2005-09-04 14:44:44 -0700 I've got a fix. 18709 5 3764 darin 2005-09-04 14:45:17 -0700 Created attachment 3764 fix that uses the same method we used a while back to fix <textarea> 3345 2005-08-11 11:12:23 -0700 2005-08-11 11:12:23 -0700 test case inputtext.html text/html 709 ap PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMCBUcmFuc2l0aW9uYWwv L0VOIj4KPGh0bWw+CjxoZWFkPgoJPHRpdGxlPklubGluZSBpbnB1dDwvdGl0bGU+CjwvaGVhZD4K CjxjZW50ZXI+Cjx0YWJsZT4KPGZvcm0gbmFtZT0ic2VhcmNoZm9ybSI+Cjx0cj4KPHRkPjxpbnB1 dCB0eXBlPXRleHQgbmFtZT1zZWFyY2h3b3JkcyB2YWx1ZT0iIiBzaXplPTU3PjxpbnB1dCB0eXBl PWJ1dHRvbiB2YWx1ZT0iU3RhcnQgU2VhcmNoIiBvbkNsaWNrPSJzZWFyY2hBbGwodGhpcy5mb3Jt LnNlYXJjaHdvcmRzLnZhbHVlKSI+PC90ZD4KPC90cj4KPHRyPgo8dGQgPjxmb250IGZhY2U9YXJp YWwgc2l6ZT0yPjxiPkVudGVyIHNvbWUgdGV4dCB1c2luZyBpbmxpbmUgaW5wdXQgKGUuZy4gS290 b2VyaSBIaXJhZ2FuYSkgYW5kIGNsaWNrIHRoZSBidXR0b24gd2l0aG91dCBjbG9zaW5nIHRoZSBp bnB1dCBhcmVhPC9iPjwvZm9udD48L3RkPgo8L3RyPgo8L2Zvcm0+CjwvdGFibGU+CjwvY2VudGVy PgoKPHNjcmlwdCBsYW5ndWFnZT1qYXZhc2NyaXB0IDEuMT4KCmZ1bmN0aW9uIHNlYXJjaEFsbChr ZXl3b3JkKSB7CglpZiAoa2V5d29yZCA9PSAiIikKCQlhbGVydCgiU2VhcmNoIGZpZWxkIGFwcGVh cnMgZW1wdHkiKTsKCWVsc2UKCQlhbGVydCgiU2VhcmNoIGZpZWxkOiAiICsga2V5d29yZCk7Cn0K Cjwvc2NyaXB0PjwvYm9keT48L2h0bWw+Cg== 3764 2005-09-04 14:45:17 -0700 2005-09-04 18:44:14 -0700 fix that uses the same method we used a while back to fix <textarea> TextFieldInlineInputPatch.txt text/plain 2369 darin SW5kZXg6IGt3cS9LV1FUZXh0RmllbGQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L1dlYkNvcmUva3dxL0tXUVRleHRGaWVsZC5tbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS44NQpk aWZmIC1wIC11IC1yMS44NSBrd3EvS1dRVGV4dEZpZWxkLm1tCi0tLSBrd3EvS1dRVGV4dEZpZWxk Lm1tCTE2IEF1ZyAyMDA1IDE5OjAzOjE5IC0wMDAwCTEuODUKKysrIGt3cS9LV1FUZXh0RmllbGQu bW0JNCBTZXAgMjAwNSAyMTozMzo1NyAtMDAwMApAQCAtMzgsMTMgKzM4LDE3IEBACiBAZW5kCiAK IEBpbnRlcmZhY2UgTlNUZXh0RmllbGQgKEtXUVRleHRGaWVsZCkKLS0gKE5TVGV4dCAqKV9LV1Ff Y3VycmVudEVkaXRvcjsKKy0gKE5TVGV4dFZpZXcgKilfS1dRX2N1cnJlbnRFZGl0b3I7CiBAZW5k CiAKIEBpbnRlcmZhY2UgTlNDZWxsIChLV1FUZXh0RmllbGRLbm93c0FwcEtpdFNlY3JldHMpCiAt IChOU011dGFibGVEaWN0aW9uYXJ5ICopX3RleHRBdHRyaWJ1dGVzOwogQGVuZAogCitAaW50ZXJm YWNlIE5TVGV4dFZpZXcgKEtXUVRleHRGaWVsZEFwcEtpdFNlY3JldHMpCistICh2b2lkKXNldFdh bnRzTm90aWZpY2F0aW9uRm9yTWFya2VkVGV4dDooQk9PTCl3YW50c05vdGlmaWNhdGlvbjsKK0Bl bmQKKwogLy8gVGhlIHRocmVlIGNlbGwgc3ViY2xhc3NlcyBhbGxvdyB1cyB0byB0ZWxsIHdoZW4g d2UgZ2V0IGZvY3VzIHdpdGhvdXQgYW4gZWRpdG9yIHN1YmNsYXNzLAogLy8gYW5kIG92ZXJyaWRl IHRoZSBiYXNlIHdyaXRpbmcgZGlyZWN0aW9uLgogQGludGVyZmFjZSBLV1FUZXh0RmllbGRDZWxs IDogTlNUZXh0RmllbGRDZWxsCkBAIC0xNTgsNiArMTYyLDggQEAKICAgICBpZiAoIXdpZGdldCkK IAlyZXR1cm47CiAgICAgCisgICAgW1tmaWVsZCBfS1dRX2N1cnJlbnRFZGl0b3JdIHNldFdhbnRz Tm90aWZpY2F0aW9uRm9yTWFya2VkVGV4dDpZRVNdOworCiAgICAgV2ViQ29yZUJyaWRnZSAqYnJp ZGdlID0gS1dRS0hUTUxQYXJ0OjpicmlkZ2VGb3JXaWRnZXQod2lkZ2V0KTsKICAgICBbYnJpZGdl IHRleHRGaWVsZERpZEJlZ2luRWRpdGluZzooRE9NSFRNTElucHV0RWxlbWVudCAqKVticmlkZ2Ug ZWxlbWVudEZvclZpZXc6ZmllbGRdXTsKIH0KQEAgLTE4MiwxMyArMTg4LDE0IEBACiAgICAgaWYg KEtXUUtIVE1MUGFydDo6aGFuZGxlS2V5Ym9hcmRPcHRpb25UYWJJblZpZXcoZmllbGQpKQogICAg ICAgICByZXR1cm47CiAgICAgCi0gICAgV2ViQ29yZUJyaWRnZSAqYnJpZGdlID0gS1dRS0hUTUxQ YXJ0OjpicmlkZ2VGb3JXaWRnZXQod2lkZ2V0KTsKLSAgICBbYnJpZGdlIHRleHREaWRDaGFuZ2VJ blRleHRGaWVsZDooRE9NSFRNTElucHV0RWxlbWVudCAqKVticmlkZ2UgZWxlbWVudEZvclZpZXc6 ZmllbGRdXTsKKyAgICBpZiAoIVtbZmllbGQgX0tXUV9jdXJyZW50RWRpdG9yXSBoYXNNYXJrZWRU ZXh0XSkgeworICAgICAgICBXZWJDb3JlQnJpZGdlICpicmlkZ2UgPSBLV1FLSFRNTFBhcnQ6OmJy aWRnZUZvcldpZGdldCh3aWRnZXQpOworICAgICAgICBbYnJpZGdlIHRleHREaWRDaGFuZ2VJblRl eHRGaWVsZDooRE9NSFRNTElucHV0RWxlbWVudCAqKVticmlkZ2UgZWxlbWVudEZvclZpZXc6Zmll bGRdXTsKKyAgICB9CiAgICAgCiAgICAgZWRpdGVkID0gWUVTOwotICAgIGlmICh3aWRnZXQpIHsK KyAgICBpZiAod2lkZ2V0KQogICAgICAgICB3aWRnZXQtPnRleHRDaGFuZ2VkKCk7Ci0gICAgfQog fQogCiAtIChCT09MKWNvbnRyb2w6KE5TQ29udHJvbCAqKWNvbnRyb2wgdGV4dFNob3VsZEJlZ2lu RWRpdGluZzooTlNUZXh0ICopZmllbGRFZGl0b3IKQEAgLTExNDUsMTAgKzExNTQsMTAgQEAKIAog Ly8gVGhlIGN1cnJlbnRFZGl0b3IgbWV0aG9kIGRvZXMgbm90IHdvcmsgZm9yIHNlY3VyZSB0ZXh0 IGZpZWxkcy4KIC8vIFRoaXMgd29ya3MgYXJvdW5kIHRoYXQgbGltaXRhdGlvbi4KLS0gKE5TVGV4 dCAqKV9LV1FfY3VycmVudEVkaXRvcgorLSAoTlNUZXh0VmlldyAqKV9LV1FfY3VycmVudEVkaXRv cgogewogICAgIE5TUmVzcG9uZGVyICpmaXJzdFJlc3BvbmRlciA9IFtbc2VsZiB3aW5kb3ddIGZp cnN0UmVzcG9uZGVyXTsKLSAgICBpZiAoW2ZpcnN0UmVzcG9uZGVyIGlzS2luZE9mQ2xhc3M6W05T VGV4dCBjbGFzc11dKSB7CisgICAgaWYgKFtmaXJzdFJlc3BvbmRlciBpc0tpbmRPZkNsYXNzOltO U1RleHRWaWV3IGNsYXNzXV0pIHsKICAgICAgICAgTlNUZXh0ICplZGl0b3IgPSAoTlNUZXh0ICop Zmlyc3RSZXNwb25kZXI7CiAgICAgICAgIGlkIGRlbGVnYXRlID0gW2VkaXRvciBkZWxlZ2F0ZV07 CiAgICAgICAgIGlmIChkZWxlZ2F0ZSA9PSBzZWxmKQo=