43927 2010-08-12 11:39:38 -0700 [Qt] ARMv5 Compiling error in FrameLoaderClientQt.cpp if QT_USE_FAST_OPERATOR_PLUS is defined globally 2010-08-17 12:04:13 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Hardware Other RESOLVED FIXED P3 Normal --- 0 hui_huang hui_huang cshu hao.1.lu hui_huang laszlo.gombos oldest_to_newest 263898 0 64244 hui_huang 2010-08-12 11:39:38 -0700 Created attachment 64244 ARM compiler output When building webkit trunk for S60 hardware using ARMv5 Compiler (RCVT 2.2 Build 686) with QT 4.7, the compiler reported the following error: "X:\sf.plat\mw\qt\src\3rdparty\webkit\WebKit\qt\WebCoreSupport\FrameLoaderClientQt.cpp", line 1124: Error: #135: class "QStringBuilder<char [19], QString>" has no member "toLocal8Bit" (node) ? qPrintable(" originating from " + drtDescriptionSuitableForTestResult(node, 0)) : ""); The compiler output is attached as "ARM compiler output". The compiler uses the option -DQT_USE_FAST_OPERATOR_PLUS. According to http://doc.trolltech.com/4.7-snapshot/qstring.html, when QT_USE_FAST_OPERATOR_PLUS is defined globally, QString '+' operator is performed by internal template class QStringBuilder which does not have the member "toLocal8bit" which the qPrintable Macro uses. 263900 1 64245 hui_huang 2010-08-12 11:50:23 -0700 Created attachment 64245 Proposed patch The attached proposed patch makes the compiler happy. 264519 2 64245 laszlo.gombos 2010-08-13 15:26:15 -0700 Comment on attachment 64245 Proposed patch The ChangeLog should have had the [Qt] prefix as well, and perhaps some of the solution description should go to the ChnageLog and not to the bug, but otherwise the patch looks good to me, r+. I will land the patch manually. 264714 3 hui_huang 2010-08-14 11:08:03 -0700 Laszlo, thanks a lot for reviewing the patch. Thanks for the suggestions. 265665 4 64245 laszlo.gombos 2010-08-17 11:28:22 -0700 Comment on attachment 64245 Proposed patch Committed as http://trac.webkit.org/changeset/65521. 265683 5 hui_huang 2010-08-17 12:04:13 -0700 Laszlo, thanks again. 64244 2010-08-12 11:39:38 -0700 2010-08-12 11:39:38 -0700 ARM compiler output frameloaderclientqt_armv5compilingerror.TXT text/plain 10846 hui_huang QzovQVBQUy9ydmN0MjJfNjg2L2Jpbi9hcm1jYy5leGUgLU8yIC0tZHdhcmYyIC0tZGxsaW1wb3J0 X3J1bnRpbWUgLS1leGNlcHRpb25zIC0tZXhjZXB0aW9uc191bndpbmQgLS1kaWFnX3N1cHByZXNz IDE2MSw2MTEsNjU0LDk5NywxMTUyLDEzMDAsMTQ2NCwxNDg4LDI1MjMsNjMxOCw2MzMxIC0tZGlh Z19lcnJvciAxMjY3IC0tY3B1IDVUIC0tZW51bV9pc19pbnQgLU9ub19rbm93bl9saWJyYXJ5IC0t ZnBtb2RlIGllZWVfbm9fZmVudiAtLW1lbWFjY2VzcyAtVUw0MSAtLW5vX3ZmZSAtLWFwY3MgL2lu dGVyIC1jIC0tYXJtIC0tZnB1IHNvZnR2ZnAgLS12aXNpYmlsaXR5X2lubGluZXNfaGlkZGVuIC1P VGltZSAtTzMgLS1nbnUgLS1kaWFnX3N1cHByZXNzIDY4LDExMSwxNzcsMzY4LDgzMCwxMjkzIC0t bm9fcGFyc2VfdGVtcGxhdGVzIC0tZGlhZ19zdXBwcmVzcyAxMTEsMTg1LDE5MSwzNjgsMTI5Mywx Mjk0LDI4NzQgLS1jcHAgLURfX01BUk1fSU5URVJXT1JLX18gLURfX1NVUFBPUlRfQ1BQX0VYQ0VQ VElPTlNfXyAtRF9VTklDT0RFIC1EX19TWU1CSUFOMzJfXyAtRF9fRVBPQzMyX18gLURfX01BUk1f XyAtRF9fRUFCSV9fICctRF9fUFJPRFVDVF9JTkNMVURFX189Ilg6L2Vwb2MzMi9pbmNsdWRlL2Zl YXR1cmVfc2V0dGluZ3MuaHJoIicgLURVTklDT0RFIC1EUVRfS0VZUEFEX05BVklHQVRJT04gLURR VF9TT0ZUS0VZU19FTkFCTEVEIC1EUVRfVVNFX01BVEhfSF9GTE9BVFMgLURFTkFCTEVfU1ZHPTAg LURCVUlMRElOR19RVF9fPTEgLURXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HIC1EVVNF X1NZU1RFTV9NQUxMT0MgLUROREVCVUcgLURRVF9OT19VSVRPT0xTIC1EUVRfUUNIQVJfQ09OU1RS VUNUT1IgLURRVF9NQUtFRExMIC1EUVRfTk9fQ0FTVF9UT19BU0NJSSAtRFFUX0FTQ0lJX0NBU1Rf V0FSTklOR1MgLURRVF9NT0NfQ09NUEFUIC1EUVRfVVNFX0ZBU1RfT1BFUkFUT1JfUExVUyAtRFFU X1VTRV9GQVNUX0NPTkNBVEVOQVRJT04gLURCVUlMRF9XRUJLSVQgLURFTkFCTEVfRkFTVF9NT0JJ TEVfU0NST0xMSU5HPTEgLURXVEZfVVNFX1FUX01PQklMRV9USEVNRT0xIC1ERU5BQkxFX05PX0xJ U1RCT1hfUkVOREVSSU5HPTEgLURCVUlMRElOR19RVF9fIC1EQlVJTERJTkdfSmF2YVNjcmlwdENv cmUgLURCVUlMRElOR19XVEYgLURFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUj0xIC1ERU5BQkxF X0RBVEFCQVNFPTEgLURFTkFCTEVfRVZFTlRTT1VSQ0U9MSAtREVOQUJMRV9PRkZMSU5FX1dFQl9B UFBMSUNBVElPTlM9MSAtREVOQUJMRV9ET01fU1RPUkFHRT0xIC1ERU5BQkxFX0lDT05EQVRBQkFT RT0xIC1ERU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HPTEgLURFTkFCTEVfT1JJRU5UQVRJT05fRVZF TlRTPTAgLURFTkFCTEVfRElSRUNUT1JZX1VQTE9BRD0wIC1ERU5BQkxFX0ZJTEVfU1lTVEVNPTAg LURFTkFCTEVfU1FMSVRFPTEgLURFTkFCTEVfREFTSEJPQVJEX1NVUFBPUlQ9MCAtREVOQUJMRV9G SUxURVJTPTEgLURFTkFCTEVfWFBBVEg9MSAtREVOQUJMRV9XQ1NTPTAgLURFTkFCTEVfV01MPTAg LURFTkFCTEVfU0hBUkVEX1dPUktFUlM9MSAtREVOQUJMRV9XT1JLRVJTPTEgLURFTkFCTEVfWEhU TUxNUD0wIC1ERU5BQkxFX0RBVEFHUklEPTAgLURFTkFCTEVfUlVCWT0xIC1ERU5BQkxFX1NBTkRC T1g9MSAtREVOQUJMRV9NRVRFUl9UQUc9MSAtREVOQUJMRV9QUk9HUkVTU19UQUc9MSAtREVOQUJM RV9CTE9CPTAgLURFTkFCTEVfTk9USUZJQ0FUSU9OUz0xIC1ERU5BQkxFX0lNQUdFX1JFU0laRVI9 MCAtREVOQUJMRV9JTlBVVF9TUEVFQ0g9MCAtREVOQUJMRV8zRF9SRU5ERVJJTkc9MSAtREVOQUJM RV9TVkdfRk9OVFM9MCAtREVOQUJMRV9TVkdfRk9SRUlHTl9PQkpFQ1Q9MCAtREVOQUJMRV9TVkdf QU5JTUFUSU9OPTAgLURFTkFCTEVfU1ZHX0FTX0lNQUdFPTAgLURFTkFCTEVfU1ZHX1VTRT0wIC1E RU5BQkxFX0RBVEFMSVNUPTEgLURFTkFCTEVfVElMRURfQkFDS0lOR19TVE9SRT0xIC1ERU5BQkxF X05FVFNDQVBFX1BMVUdJTl9BUEk9MSAtREVOQUJMRV9XRUJfU09DS0VUUz0xIC1ERU5BQkxFX1dF Ql9USU1JTkc9MCAtREVOQUJMRV9YU0xUPTEgLURFTkFCTEVfUVRfQkVBUkVSPTEgLURFTkFCTEVf VE9VQ0hfRVZFTlRTPTEgLURFTkFCTEVfVklERU89MSAtRFdURl9VU0VfUVRfTVVMVElNRURJQSAt RFFUX05PX0RFQlVHIC1EUVRfWE1MUEFUVEVSTlNfTElCIC1EUVRfR1VJX0xJQiAtRFFUX05FVFdP UktfTElCIC1EUVRfQ09SRV9MSUIgLURRVF9TSEFSRUQgLURfX01BUk1fQVJNVjVfXyAtRF9fQVJN Q0NfMl9fIC1EX19BUk1DQ18yXzJfXyAtRE5ERUJVRyAtRF9fQVJNQ0NfXyAtRF9fRExMX18gLURf X1NZTUJJQU5fU1REQ1BQX1NVUFBPUlRfXyAtLXByZWluY2x1ZGUgWDovZXBvYzMyL2luY2x1ZGUv cnZjdC9ydmN0LmggLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0IC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0 L1dlYkNvcmUgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9i cmlkZ2UgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0 Zm9ybS9hbmltYXRpb24gLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2Vi Q29yZS9wbGF0Zm9ybS90ZXh0IC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0 L1dlYkNvcmUvcmVuZGVyaW5nIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0 L0phdmFTY3JpcHRDb3JlL3Byb2ZpbGVyIC1KWDovc2YucGxhdC9tdy9xdC9pbmNsdWRlL1F0Q29y ZSAtSlg6L3NmLnBsYXQvbXcvcXQvaW5jbHVkZS9RdE5ldHdvcmsgLUpYOi9zZi5wbGF0L213L3F0 L2luY2x1ZGUvUXRHdWkgLUpYOi9zZi5wbGF0L213L3F0L2luY2x1ZGUvUXRYbWxQYXR0ZXJucyAt Slg6L3NmLnBsYXQvbXcvcXQvaW5jbHVkZSAtSlg6L3NmLnBsYXQvbXcvcXQvaW5jbHVkZS9RdE11 bHRpbWVkaWFLaXQgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29y ZS9icmlkZ2UvcXQgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29y ZS9wYWdlL3F0IC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJr aXQvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0IC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3Jk cGFydHkvd2Via2l0L1dlYkNvcmUvcGxhdGZvcm0vcXQgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8z cmRwYXJ0eS93ZWJraXQvV2ViS2l0L3F0L0FwaSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBh cnR5L3dlYmtpdC9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQgLUpYOi9zZi5wbGF0L213L3F0L3Ny Yy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5 L3dlYmtpdC9XZWJDb3JlL2FjY2Vzc2liaWxpdHkgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRw YXJ0eS93ZWJraXQvV2ViQ29yZS9iaW5kaW5ncyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBh cnR5L3dlYmtpdC9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMgLUpYOi9zZi5wbGF0L213L3F0L3Ny Yy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9iaW5kaW5ncy9qcyAtSlg6L3NmLnBsYXQvbXcvcXQv c3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL2JyaWRnZSAtSlg6L3NmLnBsYXQvbXcvcXQvc3Jj LzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL2JyaWRnZS9jIC1KWDovc2YucGxhdC9tdy9xdC9zcmMv M3JkcGFydHkvd2Via2l0L1dlYkNvcmUvYnJpZGdlL2pzYyAtSlg6L3NmLnBsYXQvbXcvcXQvc3Jj LzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL2NzcyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBh cnR5L3dlYmtpdC9XZWJDb3JlL2RvbSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dl YmtpdC9XZWJDb3JlL2RvbS9kZWZhdWx0IC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkv d2Via2l0L1dlYkNvcmUvZWRpdGluZyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dl YmtpdC9XZWJDb3JlL2hpc3RvcnkgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJr aXQvV2ViQ29yZS9odG1sIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dl YkNvcmUvaHRtbC9jYW52YXMgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQv V2ViQ29yZS9pbnNwZWN0b3IgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQv V2ViQ29yZS9sb2FkZXIgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2Vi Q29yZS9sb2FkZXIvYXBwY2FjaGUgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJr aXQvV2ViQ29yZS9sb2FkZXIvYXJjaGl2ZSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5 L3dlYmtpdC9XZWJDb3JlL2xvYWRlci9pY29uIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFy dHkvd2Via2l0L1dlYkNvcmUvbWF0aG1sIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkv d2Via2l0L1dlYkNvcmUvbm90aWZpY2F0aW9ucyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBh cnR5L3dlYmtpdC9XZWJDb3JlL3BhZ2UgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93 ZWJraXQvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbiAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBh cnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFy dHkvd2Via2l0L1dlYkNvcmUvcGxhdGZvcm0vYW5pbWF0aW9uIC1KWDovc2YucGxhdC9tdy9xdC9z cmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MgLUpYOi9zZi5wbGF0 L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0 ZXJzIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdHJhbnNmb3JtcyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dl YmtpdC9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzIC1KWDovc2YucGxhdC9tdy9xdC9z cmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvcGxhdGZvcm0vbW9jayAtSlg6L3NmLnBsYXQvbXcv cXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsgLUpYOi9zZi5w bGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9zcWwgLUpYOi9z Zi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0IC1K WDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC90cmFuc2NvZGVyIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNv cmUvcGx1Z2lucyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3Jl L3JlbmRlcmluZyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3Jl L3JlbmRlcmluZy9zdHlsZSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9X ZWJDb3JlL3N0b3JhZ2UgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2Vi Q29yZS9zdmcgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9z dmcvYW5pbWF0aW9uIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNv cmUvc3ZnL2dyYXBoaWNzIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dl YkNvcmUvc3ZnL2dyYXBoaWNzL2ZpbHRlcnMgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0 eS93ZWJraXQvV2ViQ29yZS93ZWJzb2NrZXRzIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFy dHkvd2Via2l0L1dlYkNvcmUvd21sIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Vi a2l0L1dlYkNvcmUvd29ya2VycyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtp dC9XZWJDb3JlL3htbCAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJD b3JlL2dlbmVyYXRlZCAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZh U2NyaXB0Q29yZSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdCAtSlg6L3Nm LnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIg LUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvSmF2YVNjcmlwdENv cmUvYnl0ZWNvbXBpbGVyIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L0ph dmFTY3JpcHRDb3JlL2RlYnVnZ2VyIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Vi a2l0L0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3Jk cGFydHkvd2Via2l0L0phdmFTY3JpcHRDb3JlL2ppdCAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNy ZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9wYXJzZXIgLUpYOi9zZi5wbGF0L213L3F0L3Ny Yy8zcmRwYXJ0eS93ZWJraXQvSmF2YVNjcmlwdENvcmUvcGNyZSAtSlg6L3NmLnBsYXQvbXcvcXQv c3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9wcm9maWxlciAtSlg6L3NmLnBsYXQv bXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9ydW50aW1lIC1KWDovc2Yu cGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L0phdmFTY3JpcHRDb3JlL3d0ZiAtSlg6L3Nm LnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS93dGYvc3ltYmlh biAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS93 dGYvdW5pY29kZSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZhU2Ny aXB0Q29yZS95YXJyIC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L0phdmFT Y3JpcHRDb3JlL0FQSSAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9KYXZh U2NyaXB0Q29yZS9Gb3J3YXJkaW5nSGVhZGVycyAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBh cnR5L3dlYmtpdC9KYXZhU2NyaXB0Q29yZS9nZW5lcmF0ZWQgLUpYOi9zZi9tdy9xdC9ta3NwZWNz L2NvbW1vbi9zeW1iaWFuIC1KWDovZXBvYzMyL2luY2x1ZGUgLUpYOi9lcG9jMzIvaW5jbHVkZS9z dGRhcGlzIC1KWDovZXBvYzMyL2luY2x1ZGUvc3RkYXBpcy9zeXMgLUpYOi9lcG9jMzIvaW5jbHVk ZS9tdyAtSlg6L2Vwb2MzMi9pbmNsdWRlL3BsYXRmb3JtL213IC1KWDovZXBvYzMyL2luY2x1ZGUv cGxhdGZvcm0gLUpYOi9lcG9jMzIvaW5jbHVkZS9wbGF0Zm9ybS9sb2MgLUpYOi9lcG9jMzIvaW5j bHVkZS9wbGF0Zm9ybS9tdy9sb2MgLUpYOi9lcG9jMzIvaW5jbHVkZS9wbGF0Zm9ybS9sb2Mvc2Mg LUpYOi9lcG9jMzIvaW5jbHVkZS9wbGF0Zm9ybS9tdy9sb2Mvc2MgLUpYOi9zZi5wbGF0L213L3F0 L3NyYy8zcmRwYXJ0eS93ZWJraXQvaW5jbHVkZS9RdFdlYktpdCAtSlg6L3NmLnBsYXQvbXcvcXQv aW5jbHVkZS9RdFdlYktpdCAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9X ZWJDb3JlL3RtcC9yY2MvZGVidWdfc2hhcmVkIC1KWDovUXRNdWx0aW1lZGlhS2l0IC1KWDovc2Yu cGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYkNvcmUvdG1wL21vYy9kZWJ1Z19zaGFy ZWQgLUpYOi9lcG9jMzIvaW5jbHVkZS9zdGRhcGlzL3N0bHBvcnR2NSAtSlg6L3NmLnBsYXQvbXcv cXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQgLUpYOi9zZi5w bGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbHVnaW5zL3dpbiAtSlg6L3Nm LnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL3BsdWdpbnMvc3ltYmlhbiAt Slg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJDb3JlL2hpc3RvcnkvcXQg LUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViQ29yZS9wbGF0Zm9ybS9p bWFnZS1kZWNvZGVycy9xdCAtSlg6L3NmLnBsYXQvbXcvcXQvc3JjLzNyZHBhcnR5L3dlYmtpdC9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvcXQgLUpYOi9zZi5wbGF0L213L3F0L3NyYy8zcmRwYXJ0eS93 ZWJraXQvV2ViQ29yZS9lZGl0aW5nL3F0IC1KWDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkv d2Via2l0L1dlYkNvcmUvcGx1Z2lucy9xdCAtSlg6L2Vwb2MzMi9pbmNsdWRlIC1KWDovZXBvYzMy L2luY2x1ZGUvc3RkYXBpcyAtLWRlcGVuZF9mb3JtYXQ9dW5peCAtLWRlcGVuZCBYOi9lcG9jMzIv YnVpbGQvd2Via2l0L2NfNDdhOTIzMmE4M2FiMDU3YS9xdHdlYmtpdF9kbGwvYXJtdjUvdXJlbC9G cmFtZUxvYWRlckNsaWVudFF0Lm8uZCAtbyBYOi9lcG9jMzIvYnVpbGQvd2Via2l0L2NfNDdhOTIz MmE4M2FiMDU3YS9xdHdlYmtpdF9kbGwvYXJtdjUvdXJlbC9GcmFtZUxvYWRlckNsaWVudFF0Lm8g WDovc2YucGxhdC9tdy9xdC9zcmMvM3JkcGFydHkvd2Via2l0L1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcA0KIlg6XHNmLnBsYXRcbXdccXRcc3JjXDNyZHBh cnR5XHdlYmtpdFxXZWJLaXRccXRcV2ViQ29yZVN1cHBvcnRcRnJhbWVMb2FkZXJDbGllbnRRdC5j cHAiLCBsaW5lIDEwOTogV2FybmluZzogICMxMzYxLUQ6IHVzZSBvZiBmdW5jdGlvbiAiUVN0cmlu Zzo6UVN0cmluZyhjb25zdCBjaGFyICopIiAoZGVjbGFyZWQgYXQgbGluZSA0Mjggb2YgIlg6L3Nm LnBsYXQvbXcvcXQvaW5jbHVkZS9RdENvcmUvLi4vLi4vc3JjL2NvcmVsaWIvdG9vbHMvcXN0cmlu Zy5oIikgaXMgZGVwcmVjYXRlZA0KICAgICAgcmV0dXJuIFFTdHJpbmcoX3VybC5zdHJpbmcoKSku cmVwbGFjZShXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0OjpkdW1wUmVzb3VyY2VMb2FkQ2Fs bGJhY2tzUGF0aCwgIiIpLm1pZCgxKTsNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIF4NCiJYOlxzZi5wbGF0XG13XHF0XHNyY1wzcmRwYXJ0eVx3ZWJraXRc V2ViS2l0XHF0XFdlYkNvcmVTdXBwb3J0XEZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwIiwgbGluZSAx Mzc6IFdhcm5pbmc6ICAjMTM2MS1EOiB1c2Ugb2YgZnVuY3Rpb24gIlFTdHJpbmc6OmFwcGVuZChj b25zdCBjaGFyICopIiAoZGVjbGFyZWQgYXQgbGluZSA0NDUgb2YgIlg6L3NmLnBsYXQvbXcvcXQv aW5jbHVkZS9RdENvcmUvLi4vLi4vc3JjL2NvcmVsaWIvdG9vbHMvcXN0cmluZy5oIikgaXMgZGVw cmVjYXRlZA0KICAgICAgICAgIHJlc3VsdC5hcHBlbmQoIkVSUk9SIik7DQogICAgICAgICAgICAg ICAgIF4NCiJYOlxzZi5wbGF0XG13XHF0XHNyY1wzcmRwYXJ0eVx3ZWJraXRcV2ViS2l0XHF0XFdl YkNvcmVTdXBwb3J0XEZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwIiwgbGluZSAxNDE6IFdhcm5pbmc6 ICAjMTM2MS1EOiB1c2Ugb2YgZnVuY3Rpb24gIlFTdHJpbmc6OmFwcGVuZChjb25zdCBjaGFyICop IiAoZGVjbGFyZWQgYXQgbGluZSA0NDUgb2YgIlg6L3NmLnBsYXQvbXcvcXQvaW5jbHVkZS9RdENv cmUvLi4vLi4vc3JjL2NvcmVsaWIvdG9vbHMvcXN0cmluZy5oIikgaXMgZGVwcmVjYXRlZA0KICAg ICAgICAgIHJlc3VsdC5hcHBlbmQoIk5VTEwiKTsNCiAgICAgICAgICAgICAgICAgXg0KIlg6XHNm LnBsYXRcbXdccXRcc3JjXDNyZHBhcnR5XHdlYmtpdFxXZWJLaXRccXRcV2ViQ29yZVN1cHBvcnRc RnJhbWVMb2FkZXJDbGllbnRRdC5jcHAiLCBsaW5lIDE0NzogV2FybmluZzogICMxMzYxLUQ6IHVz ZSBvZiBmdW5jdGlvbiAiUVN0cmluZzo6YXBwZW5kKGNvbnN0IGNoYXIgKikiIChkZWNsYXJlZCBh dCBsaW5lIDQ0NSBvZiAiWDovc2YucGxhdC9tdy9xdC9pbmNsdWRlL1F0Q29yZS8uLi8uLi9zcmMv Y29yZWxpYi90b29scy9xc3RyaW5nLmgiKSBpcyBkZXByZWNhdGVkDQogICAgICAgICAgcmVzdWx0 LmFwcGVuZCgiID4gIik7DQogICAgICAgICAgICAgICAgIF4NCiJYOlxzZi5wbGF0XG13XHF0XHNy Y1wzcmRwYXJ0eVx3ZWJraXRcV2ViS2l0XHF0XFdlYkNvcmVTdXBwb3J0XEZyYW1lTG9hZGVyQ2xp ZW50UXQuY3BwIiwgbGluZSAxMTI0OiBFcnJvcjogICMxMzU6IGNsYXNzICJRU3RyaW5nQnVpbGRl cjxjaGFyIFsxOV0sIFFTdHJpbmc+IiBoYXMgbm8gbWVtYmVyICJ0b0xvY2FsOEJpdCINCiAgICAg ICAgICAgICAgICAgKG5vZGUpID8gcVByaW50YWJsZSgiIG9yaWdpbmF0aW5nIGZyb20gIiArIGRy dERlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0UmVzdWx0KG5vZGUsIDApKSA6ICIiKTsNCiAgICAg ICAgICAgICAgICAgICAgICAgICAgXg0KWDpcc2YucGxhdFxtd1xxdFxzcmNcM3JkcGFydHlcd2Vi a2l0XFdlYktpdFxxdFxXZWJDb3JlU3VwcG9ydFxGcmFtZUxvYWRlckNsaWVudFF0LmNwcDogNCB3 YXJuaW5ncywgMSBlcnJvcg== 64245 2010-08-12 11:50:23 -0700 2010-08-17 11:28:22 -0700 Proposed patch bug43927patch.txt text/plain 1447 hui_huang SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjUyNjApCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMTIgIEh1aSBIdWFuZyAgPGh1aS4yLmh1YW5n QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggQVJNNSBjb21waWxpbmcgZXJyb3IgaW4gRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzOTI3CisK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OmRpc3BhdGNoRGVjaWRlUG9saWN5Rm9y TmF2aWdhdGlvbkFjdGlvbik6CisKIDIwMTAtMDgtMTIgIEplcmVteSBPcmxvdyAgPGpvcmxvd0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2ZXJ0IGZvciBub3cKSW5kZXg6IFdlYktpdC9xdC9X ZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAJKHJldmlzaW9uIDY1 MjU5KQorKysgV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMTIxLDcgKzExMjEsNyBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xp ZW50UXQ6OmRpc3BhdGNoRGVjaWRlCiAKICAgICAgICAgcHJpbnRmKCJQb2xpY3kgZGVsZWdhdGU6 IGF0dGVtcHQgdG8gbG9hZCAlcyB3aXRoIG5hdmlnYXRpb24gdHlwZSAnJXMnJXNcbiIsCiAgICAg ICAgICAgICAgICBxUHJpbnRhYmxlKGRydERlc2NyaXB0aW9uU3VpdGFibGVGb3JUZXN0UmVzdWx0 KHJlcXVlc3QudXJsKCkpKSwgbmF2aWdhdGlvblR5cGVUb1N0cmluZyhhY3Rpb24udHlwZSgpKSwK LSAgICAgICAgICAgICAgIChub2RlKSA/IHFQcmludGFibGUoIiBvcmlnaW5hdGluZyBmcm9tICIg KyBkcnREZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdChub2RlLCAwKSkgOiAiIik7Cisg ICAgICAgICAgICAgICAobm9kZSkgPyBxUHJpbnRhYmxlKFFTdHJpbmcoIiBvcmlnaW5hdGluZyBm cm9tICIgKyBkcnREZXNjcmlwdGlvblN1aXRhYmxlRm9yVGVzdFJlc3VsdChub2RlLCAwKSkpIDog IiIpOwogCiAgICAgICAgIGlmIChwb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmUpCiAgICAgICAgICAg ICByZXN1bHQgPSBQb2xpY3lVc2U7Cg==