43920 2010-08-12 08:23:19 -0700 Fix warning in WebCore\plugins\win\PluginPackageWin.cpp 2013-11-22 08:54:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Windows XP RESOLVED WONTFIX P2 Normal --- 43191 1 ossy webkit-unassigned allan.jensen aroben oldest_to_newest 263826 0 ossy 2010-08-12 08:23:19 -0700 warning on Windows in debug mode with MinGW: ..\..\..\WebCore\plugins\win\PluginPackageWin.cpp: In member function 'bool WebCore::PluginPackage::fetchInfo()': ..\..\..\WebCore\plugins\win\PluginPackageWin.cpp:184: warning: deprecated conversion from string constant to 'WCHAR*' WebCore\plugins\win\PluginPackageWin.cpp:184: if (!VerQueryValue(versionInfoData.get(), TEXT("\\"), (LPVOID*) &info, &infoSize) || infoSize < sizeof(VS_FIXEDFILEINFO)) return false; 265118 1 64498 ossy 2010-08-16 08:35:48 -0700 Created attachment 64498 proposed fix Adam, I tested your idea, it works with Qt-Windows-MinGW trio. 265119 2 ossy 2010-08-16 08:36:16 -0700 Let's see the Win EWS. 265129 3 64498 aroben 2010-08-16 08:59:05 -0700 Comment on attachment 64498 proposed fix r=me 265141 4 ossy 2010-08-16 09:33:12 -0700 Landed in http://trac.webkit.org/changeset/65432 275709 5 ossy 2010-09-08 03:12:47 -0700 ..\..\..\WebCore\plugins\win\PluginPackageWin.cpp: In member function 'bool WebCore::PluginPackage::fetchInfo()': ..\..\..\WebCore\plugins\win\PluginPackageWin.cpp:184: warning: deprecated conversion from string constant to 'WCHAR*' if (!VerQueryValueW(versionInfoData.get(), L"\\", (LPVOID*) &info, &infoSize) || infoSize < sizeof(VS_FIXEDFILEINFO)) return false; Unfortunately MinGW still warns. I thought it worked, because I missed --debug option. :( 275811 6 aroben 2010-09-08 07:07:24 -0700 (In reply to comment #5) > ..\..\..\WebCore\plugins\win\PluginPackageWin.cpp: In member function 'bool WebCore::PluginPackage::fetchInfo()': > ..\..\..\WebCore\plugins\win\PluginPackageWin.cpp:184: warning: deprecated conversion from string constant to 'WCHAR*' > > if (!VerQueryValueW(versionInfoData.get(), L"\\", (LPVOID*) &info, &infoSize) || infoSize < sizeof(VS_FIXEDFILEINFO)) > return false; > > Unfortunately MinGW still warns. I thought > it worked, because I missed --debug option. :( I don't see any WCHAR* involved here. VerQueryValue's second parameter is an LPCTSTR, so VerQueryValueW's second parameter should be an LPCWSTR, i.e. const WCHAR*. L"\\" should give us a const WCHAR*. I don't understand the error, nor what "string constant" it is referring to. 64498 2010-08-16 08:35:48 -0700 2010-09-08 03:13:07 -0700 proposed fix 1.patch text/plain 1257 ossy ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Nzg3ZGJjMi4uYmRkOGQ4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0xNiAgQ3NhYmEgT3N6dHJv Z29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEZpeCB3YXJuaW5nIGluIFdlYkNvcmUvcGx1Z2lucy93aW4vUGx1 Z2luUGFja2FnZVdpbi5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQzOTIwCisKKyAgICAgICAgKiBwbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2lu LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmZldGNoSW5mbyk6CisKIDIw MTAtMDgtMTYgIEFyaXlhIEhpZGF5YXQgIDxhcml5YUBzZW5jaGEuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcCBiL1dlYkNvcmUvcGx1Z2lucy93aW4v UGx1Z2luUGFja2FnZVdpbi5jcHAKaW5kZXggODBkZWE5My4uZjNkZDc4MSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5QYWNrYWdlV2luLmNwcAorKysgYi9XZWJDb3JlL3Bs dWdpbnMvd2luL1BsdWdpblBhY2thZ2VXaW4uY3BwCkBAIC0xODEsNyArMTgxLDcgQEAgYm9vbCBQ bHVnaW5QYWNrYWdlOjpmZXRjaEluZm8oKQogCiAgICAgVlNfRklYRURGSUxFSU5GTyogaW5mbzsK ICAgICBVSU5UIGluZm9TaXplOwotICAgIGlmICghVmVyUXVlcnlWYWx1ZSh2ZXJzaW9uSW5mb0Rh dGEuZ2V0KCksIFRFWFQoIlxcIiksIChMUFZPSUQqKSAmaW5mbywgJmluZm9TaXplKSB8fCBpbmZv U2l6ZSA8IHNpemVvZihWU19GSVhFREZJTEVJTkZPKSkKKyAgICBpZiAoIVZlclF1ZXJ5VmFsdWVX KHZlcnNpb25JbmZvRGF0YS5nZXQoKSwgTCJcXCIsIChMUFZPSUQqKSAmaW5mbywgJmluZm9TaXpl KSB8fCBpbmZvU2l6ZSA8IHNpemVvZihWU19GSVhFREZJTEVJTkZPKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIG1fbW9kdWxlVmVyc2lvbi5sZWFzdFNpZyA9IGluZm8tPmR3RmlsZVZlcnNp b25MUzsKICAgICBtX21vZHVsZVZlcnNpb24ubW9zdFNpZyA9IGluZm8tPmR3RmlsZVZlcnNpb25N UzsK