43909 2010-08-12 05:26:19 -0700 REGRESSION(r65181): It broke 35 layout tests fail on chromium-win (Requested by hamaji on #webkit). 2010-08-18 23:28:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 44168 43648 1 webkit.review.bot webkit.review.bot commit-queue dimich eric hamaji jhawkins oldest_to_newest 263732 0 webkit.review.bot 2010-08-12 05:26:19 -0700 http://trac.webkit.org/changeset/65181 broke the build: It broke 35 layout tests fail on chromium-win (Requested by hamaji on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 263733 1 64212 webkit.review.bot 2010-08-12 05:26:28 -0700 Created attachment 64212 ROLLOUT of r65181 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 263738 2 hamaji 2010-08-12 05:36:01 -0700 Interestingly, it didn't fail on canary nor trybot, but the following URLs says this revision broke these tests. http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/26011 http://build.chromium.org/buildbot/waterfall/builders/Webkit/builds/26012 263739 3 hamaji 2010-08-12 05:37:09 -0700 Committed r65238: <http://trac.webkit.org/changeset/65238> 263763 4 64212 commit-queue 2010-08-12 06:08:40 -0700 Comment on attachment 64212 ROLLOUT of r65181 Rejecting patch 64212 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 1. patching file WebKit/chromium/public/WebFrameClient.h Hunk #1 FAILED at 90. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/public/WebFrameClient.h.rej patching file WebKit/chromium/src/FrameLoaderClientImpl.cpp Hunk #1 FAILED at 248. 1 out of 1 hunk FAILED -- saving rejects to file WebKit/chromium/src/FrameLoaderClientImpl.cpp.rej Full output: http://queues.webkit.org/results/3709091 265026 5 hamaji 2010-08-16 05:04:52 -0700 I've heard that this type of bot failures may be fixed by clobbering. I'll try re-reverting this patch when Chromium's WebKit revision is up-to-date. Unfortunately, non-PST WebKit roll has not been done yet, so I'll check this tomorrow again. 266204 6 hamaji 2010-08-18 10:20:35 -0700 Re-landed in: http://trac.webkit.org/changeset/65604 It seems clobber build worked! 266234 7 eric 2010-08-18 10:48:56 -0700 (In reply to comment #6) > Re-landed in: http://trac.webkit.org/changeset/65604 > > It seems clobber build worked! Does that mean we've filed a bug about the build system problem? :) 266565 8 hamaji 2010-08-18 23:28:51 -0700 (In reply to comment #7) > (In reply to comment #6) > > Re-landed in: http://trac.webkit.org/changeset/65604 > > > > It seems clobber build worked! > > Does that mean we've filed a bug about the build system problem? :) Done :) http://code.google.com/p/chromium/issues/detail?id=52693 64212 2010-08-12 05:26:28 -0700 2010-08-12 07:50:14 -0700 ROLLOUT of r65181 bug-43909-20100812122626.patch text/plain 2537 webkit.review.bot ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGViMjQ2Njg0OTZkOGM1YWUzNmFlZjliOWNhMDc1ZTg1ODEwOTc0OGQu LjY2MzFiMGJlMTM2NmUxNzJkMmNjY2FhOGNlNmMyN2QzMjFlNDhkZWUgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDE4IEBACiAyMDEwLTA4LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcu Ym90QGdtYWlsLmNvbT4KIAorICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjUxODEu CisgICAgICAgIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY1MTgxCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzkwOQorCisgICAgICAg IEl0IGJyb2tlIDM1IGxheW91dCB0ZXN0cyBmYWlsIG9uIGNocm9taXVtLXdpbiAoUmVxdWVzdGVk IGJ5CisgICAgICAgIGhhbWFqaSBvbiAjd2Via2l0KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJG cmFtZUNsaWVudC5oOgorICAgICAgICAqIHNyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwOgor ICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6OmRldGFjaGVkRnJvbVBhcmVu dDMpOgorCisyMDEwLTA4LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjUyMjEuCiAgICAgICAg IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzY1MjIxCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzg5NgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJGcmFtZUNsaWVudC5oCmluZGV4IDkxZjBlMzgzYjQ5ZTFiMDk0ODM0NGRlYjlkNzUyZGY1 ZDUwNGExN2IuLjJiN2VlMGQzMDdjYWFlMmUwODAyNDM2NjEwM2QxYmI5YjdkNzUxZGYgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaAorKysgYi9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKQEAgLTkwLDEyICs5MCw2IEBAIHB1 YmxpYzoKIAogICAgIC8vIEdlbmVyYWwgbm90aWZpY2F0aW9ucyAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCi0gICAgLy8gVGhpcyBmcmFtZSBoYXMgYmVl biBkZXRhY2hlZCBmcm9tIHRoZSB2aWV3LgotICAgIC8vCi0gICAgLy8gRklYTUU6IERvIG5vdCB1 c2UgdGhpcyBpbiBuZXcgY29kZS4gQ3VycmVudGx5IHRoaXMgaXMgdXNlZCBieSBjb2RlIGluCi0g ICAgLy8gQ2hyb21pdW0gdGhhdCBlcnJhbnRseSBjYWNoZXMgV2ViS2l0IG9iamVjdHMuCi0gICAg dmlydHVhbCB2b2lkIGZyYW1lRGV0YWNoZWQoV2ViRnJhbWUqKSB7IH0KLQogICAgIC8vIFRoaXMg ZnJhbWUgaXMgYWJvdXQgdG8gYmUgY2xvc2VkLgogICAgIHZpcnR1YWwgdm9pZCB3aWxsQ2xvc2Uo V2ViRnJhbWUqKSB7IH0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxv YWRlckNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVu dEltcGwuY3BwCmluZGV4IDc0MTg2YmZmODRmYmVlODQxZjdhODViYjlmYzU5MGJlMjU0MmU0NDIu LmRiNzQwODBjZjQ3NzEzZjU3MTUwNmQ5NzUyOWU0MmQ3MDEwYzQ3ODEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAorKysgYi9XZWJLaXQv Y2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKQEAgLTI0OCwxMiArMjQ4LDcg QEAgdm9pZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmRldGFjaGVkRnJvbVBhcmVudDMoKQogICAg IC8vIGdvIHRvIGEgcGFnZSBhbmQgdGhlbiBuYXZpZ2F0ZSB0byBhIG5ldyBwYWdlIHdpdGhvdXQg Z2V0dGluZyBhbnkgYXNzZXJ0cwogICAgIC8vIG9yIGNyYXNoZXMuCiAgICAgbV93ZWJGcmFtZS0+ ZnJhbWUoKS0+c2NyaXB0KCktPnByb3h5KCktPmNsZWFyRm9yQ2xvc2UoKTsKLQotICAgIC8vIEFs ZXJ0IHRoZSBjbGllbnQgdGhhdCB0aGUgZnJhbWUgaXMgYmVpbmcgZGV0YWNoZWQuIFRoaXMgaXMg dGhlIGxhc3QKLSAgICAvLyBjaGFuY2Ugd2UgaGF2ZSB0byBjb21tdW5pY2F0ZSB3aXRoIHRoZSBj bGllbnQuCi0gICAgaWYgKG1fd2ViRnJhbWUtPmNsaWVudCgpKQotICAgICAgICBtX3dlYkZyYW1l LT5jbGllbnQoKS0+ZnJhbWVEZXRhY2hlZChtX3dlYkZyYW1lKTsKLQorICAgIAogICAgIC8vIFN0 b3AgY29tbXVuaWNhdGluZyB3aXRoIHRoZSBXZWJGcmFtZUNsaWVudCBhdCB0aGlzIHBvaW50IHNp bmNlIHdlIGFyZSBubwogICAgIC8vIGxvbmdlciBhc3NvY2lhdGVkIHdpdGggdGhlIFBhZ2UuCiAg ICAgbV93ZWJGcmFtZS0+c2V0Q2xpZW50KDApOwo=