43907 2010-08-12 05:00:18 -0700 V8 code generator does not add V8BindingMacros.h include in all places it is needed 2010-08-12 06:28:22 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm android-webkit-unforking commit-queue dumi steveblock oldest_to_newest 263724 0 benm 2010-08-12 05:00:18 -0700 V8BindingMacros.h was added in http://trac.webkit.org/changeset/65005 and defines two macros: EXCEPTION_BLOCK and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK. In the V8 CodeGenerator, we push this header when we generate code using EXCEPTION_BLOCK, but not STRING_TO_V8PARAMETER_EXCEPTION_BLOCK (see http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L1233 and http://trac.webkit.org/browser/trunk/WebCore/bindings/scripts/CodeGeneratorV8.pm#L1240) Patch to follow. 263725 1 dumi 2010-08-12 05:04:46 -0700 Thanks for catching this problem, and sorry I didn't notice it when changing that code... 263730 2 64211 benm 2010-08-12 05:22:34 -0700 Created attachment 64211 Patch. 263731 3 benm 2010-08-12 05:23:23 -0700 (In reply to comment #1) > Thanks for catching this problem, and sorry I didn't notice it when changing that code... No problem! 263753 4 64211 steveblock 2010-08-12 05:51:57 -0700 Comment on attachment 64211 Patch. r=me 263770 5 64211 commit-queue 2010-08-12 06:28:18 -0700 Comment on attachment 64211 Patch. Clearing flags on attachment: 64211 Committed r65240: <http://trac.webkit.org/changeset/65240> 263771 6 commit-queue 2010-08-12 06:28:22 -0700 All reviewed patches have been landed. Closing bug. 64211 2010-08-12 05:22:34 -0700 2010-08-12 06:28:18 -0700 Patch. 43907.txt text/plain 1584 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTIzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMTIgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4IGNv ZGUgZ2VuZXJhdG9yIGRvZXMgbm90IGFkZCBWOEJpbmRpbmdNYWNyb3MuaCBpbmNsdWRlIGluIGFs bCBwbGFjZXMgaXQgaXMgbmVlZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MzkwNworCisgICAgICAgIEFkZHMgdGhlIFY4QmluZGluZ01hY3Jvcy5o IGhlYWRlciBiZWZvcmUgdXNpbmcgdGhlIFNUUklOR19UT19WOFBBUkFNRVRFUl9FWENFUFRJT05f QkxPQ0sKKyAgICAgICAgbWFjcm8uCisKKyAgICAgICAgQnVpbGQgZml4IHNvIG5vIG5ldyB0ZXN0 cy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtOiBpbmNs dWRlIHRoZSBoZWFkZXIgYXQgdGhlIHJpZ2h0IHRpbWUuCisKIDIwMTAtMDgtMTIgIEplcmVteSBP cmxvdyAgPGpvcmxvd0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2ZXJ0IGZvciBub3cKSW5k ZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNp b24gNjUyMzUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt CSh3b3JraW5nIGNvcHkpCkBAIC0xMjMwLDYgKzEyMzAsNyBAQCBFTkQKICAgICAgICAgfSBlbHNp ZiAoJG5hdGl2ZVR5cGUgPX4gL15WOFBhcmFtZXRlci8pIHsKICAgICAgICAgICAgIG15ICR2YWx1 ZSA9IEpTVmFsdWVUb05hdGl2ZSgkcGFyYW1ldGVyLCAiYXJnc1skcGFyYW1JbmRleF0iLCBCYXNp Y1R5cGVDYW5GYWlsQ29udmVyc2lvbigkcGFyYW1ldGVyKSA/ICAiJHtwYXJhbWV0ZXJOYW1lfU9r IiA6IHVuZGVmKTsKICAgICAgICAgICAgIGlmICgkcGFyYW1ldGVyLT50eXBlIGVxICJET01TdHJp bmciKSB7CisgICAgICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siVjhCaW5kaW5nTWFjcm9zLmgi fSA9IDE7CiAgICAgICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywgIiAgICBTVFJJ TkdfVE9fVjhQQVJBTUVURVJfRVhDRVBUSU9OX0JMT0NLKCRuYXRpdmVUeXBlLCAkcGFyYW1ldGVy TmFtZSwgJHZhbHVlKTtcbiIpOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAg ICAjIERvbid0IGtub3cgaG93IHRvIHByb3Blcmx5IGNoZWNrIGZvciBjb252ZXJzaW9uIGV4Y2Vw dGlvbnMgd2hlbiAkcGFyYW1ldGVyLT50eXBlIGlzICJET01Vc2VyRGF0YSIK