<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43904</bug_id>
          
          <creation_ts>2010-08-12 03:27:38 -0700</creation_ts>
          <short_desc>[Qt] QGWV: Canvas never updates after first frame when using GL viewport</short_desc>
          <delta_ts>2010-08-21 04:08:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.mrspeaker.net/dev/parcycle/</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Critical</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="QtWebKit Unassigned">webkit-qt-unassigned</assigned_to>
          <cc>ariya.hidayat</cc>
    
    <cc>benjamin</cc>
    
    <cc>kling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>263700</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-08-12 03:27:38 -0700</bug_when>
    <thetext>When a QGraphicsWebView is used in a GraphicsView with a QGLWidget as the viewport, the view is never updated for canvas updates.

To reproduce:
-start QtTestBrowser on http://www.mrspeaker.net/dev/parcycle/
-change the mode to GraphicsView
-enable the GL widget as a viewport
-enjoy</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267513</commentid>
    <comment_count>1</comment_count>
      <attachid>65016</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-08-20 19:47:03 -0700</bug_when>
    <thetext>Created attachment 65016
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267516</commentid>
    <comment_count>2</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-08-20 19:54:29 -0700</bug_when>
    <thetext>What about other asynchronous APIs like openVG and X11?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267523</commentid>
    <comment_count>3</comment_count>
      <attachid>65016</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-08-20 20:29:41 -0700</bug_when>
    <thetext>Comment on attachment 65016
Proposed patch

r-ing myself, this is a bit more hairy than I first realized..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267556</commentid>
    <comment_count>4</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-08-21 04:08:13 -0700</bug_when>
    <thetext>This has been fixed in Qt with commit f46cb7033fc3bfc17c4ccf9125d670810322a0f5 in oslo-staging-1.

The problem was that the GL texture for the QPixmap backing store of the ImageBuffer was never synced after the first time since the QPainter::begin() call is what marks it dirty (detach_no is incremented which alters the cacheKey().)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65016</attachid>
            <date>2010-08-20 19:47:03 -0700</date>
            <delta_ts>2010-08-20 20:29:41 -0700</delta_ts>
            <desc>Proposed patch</desc>
            <filename>bug-43904.diff</filename>
            <type>text/plain</type>
            <size>2185</size>
            <attacher name="Andreas Kling">kling</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
N2EwYzhlNC4uMTNmYmFlNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yMCAgQW5kcmVhcyBLbGlu
ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUUdXVjogQ2FudmFzIG5ldmVyIHVwZGF0ZXMgYWZ0
ZXIgZmlyc3QgZnJhbWUgd2hlbiB1c2luZyBHTCB2aWV3cG9ydAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM5MDQKKworICAgICAgICAqIHBsYXRmb3Jt
L2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VC
dWZmZXI6OmRyYXcpOiBNYWtlIGEgY29weSBvZiB0aGUgSW1hZ2VCdWZmZXIgd2hlbiBkcmF3aW5n
CisgICAgICAgIGl0IG9udG8gYW4gT3BlbkdMIHBhaW50IGRldmljZS4KKwogMjAxMC0wOC0yMCAg
RGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh
dmUgS2lsemVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFn
ZUJ1ZmZlclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJR
dC5jcHAKaW5kZXggMTFjYTM3Ny4uODllNGYwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dy
YXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCkBAIC0xMTQsOCArMTE0LDIyIEBAIFBhc3NSZWZQ
dHI8SW1hZ2U+IEltYWdlQnVmZmVyOjpjb3B5SW1hZ2UoKSBjb25zdAogdm9pZCBJbWFnZUJ1ZmZl
cjo6ZHJhdyhHcmFwaGljc0NvbnRleHQqIGRlc3RDb250ZXh0LCBDb2xvclNwYWNlIHN0eWxlQ29s
b3JTcGFjZSwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3QgRmxvYXRSZWN0JiBzcmNS
ZWN0LAogICAgICAgICAgICAgICAgICAgICAgICBDb21wb3NpdGVPcGVyYXRvciBvcCwgYm9vbCB1
c2VMb3dRdWFsaXR5U2NhbGUpCiB7Ci0gICAgaWYgKGRlc3RDb250ZXh0ID09IGNvbnRleHQoKSkg
ewotICAgICAgICAvLyBXZSdyZSBkcmF3aW5nIGludG8gb3VyIG93biBidWZmZXIuICBJbiBvcmRl
ciBmb3IgdGhpcyB0byB3b3JrLCB3ZSBuZWVkIHRvIGNvcHkgdGhlIHNvdXJjZSBidWZmZXIgZmly
c3QuCisgICAgLy8gSWYgd2UncmUgZHJhd2luZyBpbnRvIG91ciBvd24gYnVmZmVyLCBhbHdheXMg
ZHJhdyBhIGNvcHkgb2YgdGhlIHNvdXJjZSBidWZmZXIuCisgICAgYm9vbCBkcmF3Q29weSA9IGRl
c3RDb250ZXh0ID09IGNvbnRleHQoKTsKKworICAgIGlmICghZHJhd0NvcHkpIHsKKyAgICAgICAg
UVBhaW50RGV2aWNlKiBwYWludERldmljZSA9IGRlc3RDb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQo
KS0+ZGV2aWNlKCk7CisgICAgICAgIGlmIChwYWludERldmljZSkgeworICAgICAgICAgICAgLy8g
SWYgd2UncmUgdXNpbmcgUXQncyBPcGVuR0wgcGFpbnQgZW5naW5lLCB3ZSBuZWVkIHRvIG1ha2Ug
YSBjb3B5CisgICAgICAgICAgICAvLyBvZiB0aGUgaW1hZ2Ugc2luY2UgaXQgd29uJ3QgZmx1c2gg
YW55dGhpbmcgdW50aWwgUVBhaW50ZXI6OmVuZCgpCisgICAgICAgICAgICAvLyB3aGljaCB3b24n
dCBoYXBwZW4gZm9yIEltYWdlQnVmZmVycy4KKyAgICAgICAgICAgIFFQYWludEVuZ2luZTo6VHlw
ZSB0eXBlID0gcGFpbnREZXZpY2UtPnBhaW50RW5naW5lKCktPnR5cGUoKTsKKyAgICAgICAgICAg
IGlmICh0eXBlID09IFFQYWludEVuZ2luZTo6T3BlbkdMIHx8IHR5cGUgPT0gUVBhaW50RW5naW5l
OjpPcGVuR0wyKQorICAgICAgICAgICAgICAgIGRyYXdDb3B5ID0gdHJ1ZTsKKyAgICAgICAgfQor
ICAgIH0KKworICAgIGlmIChkcmF3Q29weSkgewogICAgICAgICBSZWZQdHI8SW1hZ2U+IGNvcHkg
PSBjb3B5SW1hZ2UoKTsKICAgICAgICAgZGVzdENvbnRleHQtPmRyYXdJbWFnZShjb3B5LmdldCgp
LCBEZXZpY2VDb2xvclNwYWNlLCBkZXN0UmVjdCwgc3JjUmVjdCwgb3AsIHVzZUxvd1F1YWxpdHlT
Y2FsZSk7CiAgICAgfSBlbHNlCg==
</data>
<flag name="review"
          id="53701"
          type_id="1"
          status="-"
          setter="kling"
    />
          </attachment>
      

    </bug>

</bugzilla>