43897 2010-08-12 00:37:06 -0700 The JITStackFrame is wrong using Thumb-2 JIT with JSVALUE32_64 2010-08-18 03:28:22 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P1 Blocker --- 1 loki webkit-unassigned abarth barraclough commit-queue eric webkit.review.bot oldest_to_newest 263638 0 loki 2010-08-12 00:37:06 -0700 The asserts in JITThunks::JITThunks complain about the wrong offset values. 263646 1 64191 loki 2010-08-12 01:10:46 -0700 Created attachment 64191 Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 A 64 bits wide data is aligned to 8 bytes on ARM by default, but the ..._OFFSET macros in JITStubs.cpp are calculated as the args member is started from the fourth byte. So, the macros are updated and the type of reserved member is replaced with JITStubArg, in order not to make any mistake about the offsets. 264232 2 barraclough 2010-08-13 01:01:33 -0700 Hey Gabor, looks good but I'd like to test this patch doesn't break anything on darwin. I'll test tomorrow morning & land assuming all is good. 265989 3 64191 barraclough 2010-08-18 01:48:13 -0700 Comment on attachment 64191 Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 All good! 266012 4 64191 commit-queue 2010-08-18 03:03:37 -0700 Comment on attachment 64191 Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 Clearing flags on attachment: 64191 Committed r65596: <http://trac.webkit.org/changeset/65596> 266013 5 commit-queue 2010-08-18 03:03:41 -0700 All reviewed patches have been landed. Closing bug. 266023 6 webkit.review.bot 2010-08-18 03:28:22 -0700 http://trac.webkit.org/changeset/65596 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597 64191 2010-08-12 01:10:46 -0700 2010-08-18 03:03:37 -0700 Fix the JITStackFrame in Thumb2 JIT with JSValue32_64 0001-Fix-the-JITStackFrame-in-Thumb2-JIT-with-JSValue32_6.patch text/plain 2935 loki RnJvbSBjNDIwZjYxZjFlZjdhY2RhMmZjZmEzN2Q5M2ZjODk5ZTZkY2MzYTM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVGh1LCAxMiBBdWcgMjAxMCAwOTo0ODoyMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCB0 aGUgSklUU3RhY2tGcmFtZSBpbiBUaHVtYjIgSklUIHdpdGggSlNWYWx1ZTMyXzY0CgpTaWduZWQt b2ZmLWJ5OiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogSmF2YVNjcmlwdENv cmUvaml0L0pJVFN0dWJzLmNwcCB8ICAgMTggKysrKysrKysrLS0tLS0tLS0tCiBKYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnMuaCAgIHwgICAgMiArLQogMyBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNl cnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggODA1NzhmOC4uYjRiOGE0 MyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA4LTEyICBHYWJvciBMb2tpICA8 bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBKSVRTdGFja0ZyYW1lIGlzIHdyb25nIHVzaW5nIFRodW1iLTIgSklUIHdp dGggSlNWQUxVRTMyXzY0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00Mzg5NworCisgICAgICAgIEEgNjQgYml0cyB3aWRlIG1lbWJlciBpbiBhIHN0cnVj dHVyZSBpcyBhbGlnbmVkIHRvIDggYnl0ZXMgb24gQVJNIGJ5CisgICAgICAgIGRlZmF1bHQsIGJ1 dCB0aGlzIGlzIG5vdCB0YWtlbiBpbnRvIGFjY291bnQgaW4gdGhlIG9mZnNldCBkZWZpbmVzIG9m CisgICAgICAgIEpJVFN0YWNrRnJhbWUuCisKKyAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOgor ICAgICAgICAqIGppdC9KSVRTdHVicy5oOgorCiAyMDEwLTA4LTExICBHYXZpbiBCYXJyYWNsb3Vn aCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZpeC4K ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAgYi9KYXZhU2NyaXB0 Q29yZS9qaXQvSklUU3R1YnMuY3BwCmluZGV4IGM1ZGNkNDEuLjA2NmEwMzIgMTAwNjQ0Ci0tLSBh L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaml0 L0pJVFN0dWJzLmNwcApAQCAtMjI5LDE1ICsyMjksMTUgQEAgU1lNQk9MX1NUUklORyhjdGlPcFRo cm93Tm90Q2F1Z2h0KSAiOiIgIlxuIgogCiAjZWxpZiBDT01QSUxFUihHQ0MpICYmIENQVShBUk1f VEhVTUIyKQogCi0jZGVmaW5lIFRIVU5LX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgICAgIDB4M0MK LSNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNFVCAgMHg0MAotI2RlZmluZSBQ UkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAweDQ0Ci0jZGVmaW5lIFBSRVNFUlZFRF9S NV9PRkZTRVQgICAgICAgICAgICAgIDB4NDgKLSNkZWZpbmUgUFJFU0VSVkVEX1I2X09GRlNFVCAg ICAgICAgICAgICAgMHg0QwotI2RlZmluZSBSRUdJU1RFUl9GSUxFX09GRlNFVCAgICAgICAgICAg ICAweDUwCi0jZGVmaW5lIENBTExGUkFNRV9PRkZTRVQgICAgICAgICAgICAgICAgIDB4NTQKLSNk ZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAgICAgICAgMHg1OAotI2RlZmluZSBFTkFC TEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDYwCisjZGVmaW5lIFRIVU5LX1JFVFVSTl9B RERSRVNTX09GRlNFVCAgICAgIDB4NDAKKyNkZWZpbmUgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNT X09GRlNFVCAgMHg0NAorI2RlZmluZSBQUkVTRVJWRURfUjRfT0ZGU0VUICAgICAgICAgICAgICAw eDQ4CisjZGVmaW5lIFBSRVNFUlZFRF9SNV9PRkZTRVQgICAgICAgICAgICAgIDB4NEMKKyNkZWZp bmUgUFJFU0VSVkVEX1I2X09GRlNFVCAgICAgICAgICAgICAgMHg1MAorI2RlZmluZSBSRUdJU1RF Ul9GSUxFX09GRlNFVCAgICAgICAgICAgICAweDU0CisjZGVmaW5lIENBTExGUkFNRV9PRkZTRVQg ICAgICAgICAgICAgICAgIDB4NTgKKyNkZWZpbmUgRVhDRVBUSU9OX09GRlNFVCAgICAgICAgICAg ICAgICAgMHg1QworI2RlZmluZSBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVCAweDY0 CiAKICNlbGlmIChDT01QSUxFUihHQ0MpIHx8IENPTVBJTEVSKFJWQ1QpKSAmJiBDUFUoQVJNX1RS QURJVElPTkFMKQogCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuaCBi L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5oCmluZGV4IDk0ZTMxOWYuLjQzZjNkMTkgMTAw NjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5oCisrKyBiL0phdmFTY3JpcHRD b3JlL2ppdC9KSVRTdHVicy5oCkBAIC0xNDQsNyArMTQ0LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAj ZW5kaWYgLy8gQ09NUElMRVIoTVNWQykgfHwgKE9TKFdJTkRPV1MpICYmIENPTVBJTEVSKEdDQykp CiAjZWxpZiBDUFUoQVJNX1RIVU1CMikKICAgICBzdHJ1Y3QgSklUU3RhY2tGcmFtZSB7Ci0gICAg ICAgIHZvaWQqIHJlc2VydmVkOyAvLyBVbnVzZWQKKyAgICAgICAgSklUU3R1YkFyZyByZXNlcnZl ZDsgLy8gVW51c2VkCiAgICAgICAgIEpJVFN0dWJBcmcgYXJnc1s2XTsKICNpZiBVU0UoSlNWQUxV RTMyXzY0KQogICAgICAgICB2b2lkKiBwYWRkaW5nWzJdOyAvLyBNYWludGFpbiAxNi1ieXRlIHN0 YWNrIGFsaWdubWVudC4KLS0gCjEuNy4wLjQKCg==