43887 2010-08-11 16:02:05 -0700 HTMLSelectElement.size defaults to 0 2010-12-02 19:30:37 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED WONTFIX http://jsbin.com/aqana/2/ P2 Normal --- 50380 0 miketaylr webkit-unassigned ap dmikurube mounir tkent oldest_to_newest 263503 0 miketaylr 2010-08-11 16:02:05 -0700 Per the HTML5 spec, a select element without a required attribute should have its size attribute default to 1. (http://www.whatwg.org/specs/web-apps/current-work/complete.html#the-select-element) `The size attribute gives the number of options to show to the user. The size attribute, if specified, must have a value that is a valid non-negative integer greater than zero. If the multiple attribute is present, then the size attribute's default value is 4. If the multiple attribute is absent, then the size attribute's default value is 1.` Current builds default to 0. Code used in test case (http://jsbin.com/aqana/2/edit): var select = document.createElement('select'); function testSize(el) { return el.size == 1; } testSize(select); // false 263661 1 ap 2010-08-12 02:05:22 -0700 What do other browsers do? Firefox seems to match WebKit, but I didn't test IE. 263774 2 miketaylr 2010-08-12 06:31:48 -0700 Hmm, it appears that Webkit, Firefox 4 and IE8 all do the same thing, that is set @size to 0. I thought Gecko was doing something else last night, but I was mistaken. 263797 3 ap 2010-08-12 07:33:23 -0700 Would you be willing to report a bug against HTML5? You can file it at <http://www.w3.org/Bugs/Public/enter_bug.cgi?product=HTML%20WG>, or simply e-mail the working group. 264009 4 miketaylr 2010-08-12 14:59:40 -0700 I've written the working group about this: http://lists.w3.org/Archives/Public/public-html/2010Aug/0126.html 316043 5 dmikurube 2010-12-02 01:23:13 -0800 (In reply to comment #4) Reading the message on the working group, it looks better to change the default size to 1 or 4. > http://lists.w3.org/Archives/Public/public-html/2010Aug/0126.html I'll be starting to work on this since it blocks the bug 50380. 316072 6 75366 dmikurube 2010-12-02 03:30:20 -0800 Created attachment 75366 Patch 316074 7 mounir 2010-12-02 03:33:49 -0800 FYI, we did this change for Gecko and some sites broke [1]. So, we've reverted to returning 0. By the way, the specs require to return 1 as a default value even if multiple is set (but I agree this non-sense). There is a bug filed for that [2]. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=603141 [2] http://www.w3.org/Bugs/Public/show_bug.cgi?id=11162 316179 8 75366 ap 2010-12-02 09:04:16 -0800 Comment on attachment 75366 Patch So I guess that we don't want to do this. 316611 9 tkent 2010-12-02 19:13:51 -0800 (In reply to comment #8) > (From update of attachment 75366 [details]) > So I guess that we don't want to do this. I agree. We shouldn't change this for now. 316612 10 dmikurube 2010-12-02 19:16:57 -0800 Ok, let's close it. 75366 2010-12-02 03:30:20 -0800 2010-12-02 09:04:16 -0800 Patch bug-43887-20101202203027.patch text/plain 6193 dmikurube ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2OGYxNjQxMmRmNjUyZWNhMTJmNWIwNmVhOThhNTFhOWY0NGMwYTY0Li45ZDNmZThl NTkxNjA2NWEyNjM2NTk1YTRiOTJiMjNhZmM4M2UyZDJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTItMDIgIERhaSBNaWt1cnViZSAgPGRtaWt1cnViZUBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhUTUxTZWxlY3RFbGVt ZW50LnNpemUgZGVmYXVsdHMgdG8gMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDM4ODcKKworICAgICAgICAqIGZhc3QvZm9ybXMvbGlzdGJveC1jbGlw Lmh0bWw6IFRoZSBvcmlnaW5hbCB0ZXN0IGRpZG4ndCBzcGVjaWZ5IHNpemUuIEl0IHdhcyByZW5k ZXJlZCBhcyBzaXplPTUgYmVjYXVzZSBSZW5kZXJMaXN0Qm94IGFzc3VtZWQgYSBzaXplIGFzIHRo ZSBzYW1lIGFzIHRoZSBudW1iZXIgb2Ygb3B0aW9ucyBmb3IgbGVzcyBvcHRpb25zIHRoYW4gMTEu IFRoaXMgY2hhbmdlIGV4cGxpY2l0bHkgc3BlY2lmaWVzIHNpemU9NS4KKyAgICAgICAgKiBmYXN0 L2Zvcm1zL3NjcmlwdC10ZXN0cy9zZWxlY3QtZGVmYXVsdC1zaXplLmpzOiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2Zvcm1zL3NlbGVjdC1kZWZhdWx0LXNpemUtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlbGVjdC1kZWZhdWx0LXNpemUuaHRtbDogQWRkZWQuCisK IDIwMTAtMTItMDEgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFVucmV2aWV3ZWQuICBSZW1vdmluZyBvdXQgb2YgZGF0ZSBleHBlY3RhdGlvbi4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGlzdGJveC1jbGlwLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL2xpc3Rib3gtY2xpcC5odG1sCmluZGV4IDQ4MDYyMGQ1YjdjNGI1MDZi Yzg2OTk1OTM3ZTM4NWFkNTc1YWQ2MDguLmIwYTA5MDFlYzdiMDhhMGRkZmI5MjVkOTg5MzNiMmQy YWRmN2U5YWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbGlzdGJveC1jbGlw Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9saXN0Ym94LWNsaXAuaHRtbApAQCAt Myw3ICszLDcgQEAKICAgICA8dGl0bGU+VGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTExMzM8L3RpdGxlPgogPC9oZWFkPgogPGJvZHk+Ci0gICAgPHNlbGVj dCBtdWx0aXBsZSBzdHlsZT0id2lkdGg6IDEwMHB4OyBmb250LXNpemU6IDIwcHg7IGZvbnQtZmFt aWx5OiBBaGVtOyI+CisgICAgPHNlbGVjdCBtdWx0aXBsZSBzdHlsZT0id2lkdGg6IDEwMHB4OyBm b250LXNpemU6IDIwcHg7IGZvbnQtZmFtaWx5OiBBaGVtOyIgc2l6ZT0iNSI+CiAgICAgPG9wdGlv bj5hYWFhYWE8L29wdGlvbj4KICAgICA8b3B0aW9uPmFhYWFhYTwvb3B0aW9uPgogICAgIDxvcHRp b24+YWFhYWFhPC9vcHRpb24+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Nj cmlwdC10ZXN0cy9zZWxlY3QtZGVmYXVsdC1zaXplLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9zY3JpcHQtdGVzdHMvc2VsZWN0LWRlZmF1bHQtc2l6ZS5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xYmM0NWVi MjkyOTkwMDFjZTgxNzY3YWJhYjQ2Y2M4NjUxMGVhZDFkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9zY3JpcHQtdGVzdHMvc2VsZWN0LWRlZmF1bHQtc2l6ZS5qcwpA QCAtMCwwICsxLDIzIEBACitkZXNjcmlwdGlvbignVGhpcyB0ZXN0IGNoZWNrcyB0aGUgZGVmYXVs dCBzaXplIG9mIHNlbGVjdCB0YWdzLicpOworCit2YXIgd3JhcHBlciA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoJ2RpdicpOworZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZCh3cmFwcGVyKTsKKwor dmFyIHNlbGVjdCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ3NlbGVjdCcpOworZG9jdW1lbnQu Ym9keS5hcHBlbmRDaGlsZChzZWxlY3QpOworc2hvdWxkQmUoJ3NlbGVjdC5zaXplJywgJzEnKTsK Kword3JhcHBlci5pbm5lckhUTUwgPSAnPHNlbGVjdCBpZD0idGhlU2VsZWN0Ij48L3NlbGVjdD4n CitzZWxlY3QgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGhlU2VsZWN0Jyk7CitzaG91bGRC ZSgnc2VsZWN0LnNpemUnLCAnMScpOworCitzZWxlY3QgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCdzZWxlY3QnKTsKK3NlbGVjdC5tdWx0aXBsZSA9IHRydWU7Citkb2N1bWVudC5ib2R5LmFwcGVu ZENoaWxkKHNlbGVjdCk7CitzaG91bGRCZSgnc2VsZWN0LnNpemUnLCAnNCcpOworCit3cmFwcGVy LmlubmVySFRNTCA9ICc8c2VsZWN0IGlkPSJ0aGVNdWx0aVNlbGVjdCIgbXVsdGlwbGU+PC9zZWxl Y3Q+Jworc2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3RoZU11bHRpU2VsZWN0Jyk7 CitzaG91bGRCZSgnc2VsZWN0LnNpemUnLCAnNCcpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2Vk ID0gdHJ1ZTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0LWRlZmF1 bHQtc2l6ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC1kZWZh dWx0LXNpemUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI4MThkZjg3MTQzNTUyZDQ5MGYyMTRj MGNlNDVlNzI4MjU5YjE2OGYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zv cm1zL3NlbGVjdC1kZWZhdWx0LXNpemUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTQgQEAKK1Ro aXMgdGVzdCBjaGVja3MgdGhlIGRlZmF1bHQgc2l6ZSBvZiBzZWxlY3QgdGFncy4KKworT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mgc2VsZWN0LnNpemUgaXMgMQorUEFTUyBzZWxl Y3Quc2l6ZSBpcyAxCitQQVNTIHNlbGVjdC5zaXplIGlzIDQKK1BBU1Mgc2VsZWN0LnNpemUgaXMg NAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtZGVmYXVsdC1zaXplLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC1kZWZhdWx0LXNpemUuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi40ODA3MDE4YTA0NTk1Y2UxY2ViZTkwMmJiMGQ0OWZlZjgzZDAzZmY2Ci0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zZWxlY3QtZGVmYXVsdC1zaXplLmh0 bWwKQEAgLTAsMCArMSwxMyBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQg SFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0i Li4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9 Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVh ZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48 L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvc2VsZWN0LWRlZmF1bHQtc2l6ZS5qcyI+ PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1w b3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWJkZGRlNTk4OTM0MTQyMGM1NDZi NjkzZGQwYTZlNWNlMzFjMTAzOS4uNzFlM2QyZGFmZTkxOGQyYWJiODcxODdkYjVkM2IwNzAwM2M5 MjBlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMi0wMiAgRGFpIE1pa3VydWJlICA8ZG1pa3VydWJl QGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSFRNTFNlbGVjdEVsZW1lbnQuc2l6ZSBkZWZhdWx0cyB0byAwCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzg4NworCisgICAgICAgIFRlc3Q6 IGZhc3QvZm9ybXMvc2VsZWN0LWRlZmF1bHQtc2l6ZS5odG1sCisKKyAgICAgICAgKiBkb20vU2Vs ZWN0RWxlbWVudC5jcHA6IERlZmF1bHQgLnNpemUgdG8gYmUgMSBmb3Igc2luZ2xlIDxzZWxlY3Q+ IGFuZCA0IGZvciBtdWx0aXBsZSA8c2VsZWN0PiB3aXRob3V0IHNwZWNpZnlpbmcgYSBzaXplLgor ICAgICAgICAoV2ViQ29yZTo6U2VsZWN0RWxlbWVudERhdGE6OnNpemUpOgorICAgICAgICAqIGRv bS9TZWxlY3RFbGVtZW50Lmg6CisKIDIwMTAtMTItMDEgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVu QGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXg6IEFkZGVkIGEgZm9yd2FyZGluZyBoZWFk ZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmNwcCBiL1dlYkNvcmUv ZG9tL1NlbGVjdEVsZW1lbnQuY3BwCmluZGV4IGQyMzZjOTY2NWRjOWUyYWZiZWEyMWUxZGIzNTAx OGZlMTIxMzRiMjUuLjQ0ZmNlMzM3YmRhZDU5MzhiMjA1OGY0Y2I2MGU5MjRlOTE2MzFjYWYgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUvZG9t L1NlbGVjdEVsZW1lbnQuY3BwCkBAIC03MSw2ICs3MSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogc3RhdGljIGNvbnN0IERPTVRpbWVTdGFtcCB0eXBlQWhlYWRUaW1lb3V0ID0gMTAwMDsKIAor c3RhdGljIGNvbnN0IGludCBzaXplT2ZTaW5nbGVTZWxlY3QgPSAxOworc3RhdGljIGNvbnN0IGlu dCBzaXplT2ZNdWx0aXBsZVNlbGVjdCA9IDQ7CisKIHZvaWQgU2VsZWN0RWxlbWVudDo6c2VsZWN0 QWxsKFNlbGVjdEVsZW1lbnREYXRhJiBkYXRhLCBFbGVtZW50KiBlbGVtZW50KQogewogICAgIEFT U0VSVCghZGF0YS51c2VzTWVudUxpc3QoKSk7CkBAIC05ODksNiArOTkyLDE1IEBAIFNlbGVjdEVs ZW1lbnREYXRhOjp+U2VsZWN0RWxlbWVudERhdGEoKQogewogfQogCitpbnQgU2VsZWN0RWxlbWVu dERhdGE6OnNpemUoKSBjb25zdAoreworICAgIGlmIChtX3NpemUgPiAwKQorICAgICAgICByZXR1 cm4gbV9zaXplOworICAgIGlmIChtX211bHRpcGxlKQorICAgICAgICByZXR1cm4gc2l6ZU9mTXVs dGlwbGVTZWxlY3Q7CisgICAgcmV0dXJuIHNpemVPZlNpbmdsZVNlbGVjdDsKK30KKwogdm9pZCBT ZWxlY3RFbGVtZW50RGF0YTo6Y2hlY2tMaXN0SXRlbXMoY29uc3QgRWxlbWVudCogZWxlbWVudCkg Y29uc3QKIHsKICNpZiAhQVNTRVJUX0RJU0FCTEVECmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9T ZWxlY3RFbGVtZW50LmggYi9XZWJDb3JlL2RvbS9TZWxlY3RFbGVtZW50LmgKaW5kZXggNTM4MTVm MmFlYmU1YjA5NWJmZGEwNTg0M2U1MTRjN2UwYzkxYmExMi4uYTk3ODJiMDA5NmNkZDkxOTI4Nzdm NTdjNWExYTQ3YzQ5ZGZlNzY4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vU2VsZWN0RWxlbWVu dC5oCisrKyBiL1dlYkNvcmUvZG9tL1NlbGVjdEVsZW1lbnQuaApAQCAtMTE4LDcgKzExOCw3IEBA IHB1YmxpYzoKICAgICBib29sIG11bHRpcGxlKCkgY29uc3QgeyByZXR1cm4gbV9tdWx0aXBsZTsg fQogICAgIHZvaWQgc2V0TXVsdGlwbGUoYm9vbCB2YWx1ZSkgeyBtX211bHRpcGxlID0gdmFsdWU7 IH0KIAotICAgIGludCBzaXplKCkgY29uc3QgeyByZXR1cm4gbV9zaXplOyB9CisgICAgaW50IHNp emUoKSBjb25zdDsKICAgICB2b2lkIHNldFNpemUoaW50IHZhbHVlKSB7IG1fc2l6ZSA9IHZhbHVl OyB9CiAKICAgICBib29sIHVzZXNNZW51TGlzdCgpIGNvbnN0Cg==