43884 2010-08-11 15:48:39 -0700 [GTK] Geolocation policy decision object leaking 2010-08-11 16:26:07 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 263487 0 gustavo 2010-08-11 15:48:39 -0700 In ChromeClient::requestGeolocationPermissionForFrame, we create the policy decision object but never unref it. 263492 1 64171 gustavo 2010-08-11 15:50:43 -0700 Created attachment 64171 proposed fix 263497 2 64171 mrobinson 2010-08-11 15:56:05 -0700 Comment on attachment 64171 proposed fix LGTM! 263513 3 gustavo 2010-08-11 16:26:07 -0700 Landed as r65195. 64171 2010-08-11 15:50:43 -0700 2010-08-11 15:56:04 -0700 proposed fix 0001-Fix-leak.patch text/plain 2276 gustavo RnJvbSBiMGU5ODBjNGNjMmVlNmJmOWU2ZTMyNDJiYzFmNjExNTFhYTc5MDE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFdlZCwgMTEgQXVnIDIwMTAgMTk6NDk6MTkgLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggbGVhawoKLS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9DaHJvbWVD bGllbnRHdGsuY3BwIHwgICAgNiArKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBi L1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IDFkOWUwZGUuLjBiNDkyZjkgMTAwNjQ0Ci0tLSBh L1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTAtMDgtMTEgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9y b25oYUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0dUS10gR2VvbG9jYXRpb24gcG9saWN5IGRlY2lzaW9uIG9iamVjdCBs ZWFraW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 Mzg4NAorCisgICAgICAgIFVzZSBHUmVmUHRyIG9uIHRoZSBwb2xpY3kgZGVjaXNpb24gb2JqZWN0 IHRvIGZpeCB0aGUgbGVhay4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVu dEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudDo6cmVxdWVzdEdlb2xvY2F0 aW9uUGVybWlzc2lvbkZvckZyYW1lKToKKwogMjAxMC0wOC0xMCAgR2F2aW4gQmFycmFjbG91Z2gg IDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyIHN0YW1wZWQgYnkgU2Ft IFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xp ZW50R3RrLmNwcCBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50R3RrLmNw cAppbmRleCBhMDZkNjM3Li4xODVhYzE2IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNvcmVT dXBwb3J0L0Nocm9tZUNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y dC9DaHJvbWVDbGllbnRHdGsuY3BwCkBAIC02MTEsMTIgKzYxMSwxMiBAQCB2b2lkIENocm9tZUNs aWVudDo6cmVxdWVzdEdlb2xvY2F0aW9uUGVybWlzc2lvbkZvckZyYW1lKEZyYW1lKiBmcmFtZSwg R2VvbG9jYXRpbwogICAgIFdlYktpdFdlYkZyYW1lKiB3ZWJGcmFtZSA9IGtpdChmcmFtZSk7CiAg ICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IGdldFZpZXdGcm9tRnJhbWUod2ViRnJhbWUpOwog Ci0gICAgV2ViS2l0R2VvbG9jYXRpb25Qb2xpY3lEZWNpc2lvbiogcG9saWN5RGVjaXNpb24gPSB3 ZWJraXRfZ2VvbG9jYXRpb25fcG9saWN5X2RlY2lzaW9uX25ldyh3ZWJGcmFtZSwgZ2VvbG9jYXRp b24pOworICAgIEdSZWZQdHI8V2ViS2l0R2VvbG9jYXRpb25Qb2xpY3lEZWNpc2lvbj4gcG9saWN5 RGVjaXNpb24oYWRvcHRHUmVmKHdlYmtpdF9nZW9sb2NhdGlvbl9wb2xpY3lfZGVjaXNpb25fbmV3 KHdlYkZyYW1lLCBnZW9sb2NhdGlvbikpKTsKIAogICAgIGdib29sZWFuIGlzSGFuZGxlZCA9IEZB TFNFOwotICAgIGdfc2lnbmFsX2VtaXRfYnlfbmFtZSh3ZWJWaWV3LCAiZ2VvbG9jYXRpb24tcG9s aWN5LWRlY2lzaW9uLXJlcXVlc3RlZCIsIHdlYkZyYW1lLCBwb2xpY3lEZWNpc2lvbiwgJmlzSGFu ZGxlZCk7CisgICAgZ19zaWduYWxfZW1pdF9ieV9uYW1lKHdlYlZpZXcsICJnZW9sb2NhdGlvbi1w b2xpY3ktZGVjaXNpb24tcmVxdWVzdGVkIiwgd2ViRnJhbWUsIHBvbGljeURlY2lzaW9uLmdldCgp LCAmaXNIYW5kbGVkKTsKICAgICBpZiAoIWlzSGFuZGxlZCkKLSAgICAgICAgd2Via2l0X2dlb2xv Y2F0aW9uX3BvbGljeV9kZW55KHBvbGljeURlY2lzaW9uKTsKKyAgICAgICAgd2Via2l0X2dlb2xv Y2F0aW9uX3BvbGljeV9kZW55KHBvbGljeURlY2lzaW9uLmdldCgpKTsKIH0KIAogdm9pZCBDaHJv bWVDbGllbnQ6OmNhbmNlbEdlb2xvY2F0aW9uUGVybWlzc2lvblJlcXVlc3RGb3JGcmFtZShXZWJD b3JlOjpGcmFtZSogZnJhbWUsIFdlYkNvcmU6Okdlb2xvY2F0aW9uKikKLS0gCjEuNy4xCgo=