43882 2010-08-11 15:20:31 -0700 [Qt] Move the accelerated compositing build flag to the right place 2010-09-22 12:18:46 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 noam webkit-unassigned commit-queue kbalazs kling ossy oldest_to_newest 263479 0 noam 2010-08-11 15:20:31 -0700 WTF flags should be in Platform.h, not in WebCore.pro. This causes build issues on some platforms. 263481 1 64169 noam 2010-08-11 15:25:34 -0700 Created attachment 64169 Patch 263846 2 64169 ariya.hidayat 2010-08-12 09:36:26 -0700 Comment on attachment 64169 Patch LGTM. 263949 3 64169 commit-queue 2010-08-12 13:41:41 -0700 Comment on attachment 64169 Patch Rejecting patch 64169 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20832 test cases. fast/loader/recursive-before-unload-crash.html -> failed Exiting early after 1 failures. 14235 tests run. 242.80s total testing time 14234 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3739096 263957 4 noam 2010-08-12 14:00:27 -0700 I can't really get how my change would have broken that layout test :) 265477 5 ossy 2010-08-17 05:00:03 -0700 (In reply to comment #4) > I can't really get how my change would have broken that layout test :) Your change is unrelated to Snow Leopard, it must be a flakey test. 265541 6 64169 commit-queue 2010-08-17 07:54:56 -0700 Comment on attachment 64169 Patch Clearing flags on attachment: 64169 Committed r65502: <http://trac.webkit.org/changeset/65502> 265542 7 commit-queue 2010-08-17 07:55:01 -0700 All reviewed patches have been landed. Closing bug. 265829 8 kbalazs 2010-08-17 16:16:28 -0700 We are defining WTF_USE_ACCELERATED_COMPOSITING in WebKit.pri too (line 48): greaterThan(QT_MINOR_VERSION, 5):DEFINES += WTF_USE_ACCELERATED_COMPOSITING If it should be done in Platform.h then I think it should be done this way: #if PLATFORM(QT) #ifndef !defined(WTF_USE_ACCELERATED_COMPOSITING) && QT_VERSION_GREATER_THEN(4, 5, 0) #define WTF_USE_ACCELERATED_COMPOSITING 1 #endif #endif With this the feature could be disabled at compile time and the version check would still exist. Do you agree? (I am not sure that the QT_VERSION_GREATER_THEN macro exist but I know there is something like that.) 265919 9 tonikitoo 2010-08-17 20:21:29 -0700 (In reply to comment #8) > We are defining WTF_USE_ACCELERATED_COMPOSITING in WebKit.pri too (line 48): > greaterThan(QT_MINOR_VERSION, 5):DEFINES += WTF_USE_ACCELERATED_COMPOSITING It sounds bogus now. Could you please file a bug? > If it should be done in Platform.h then I think it should be done this way: > #if PLATFORM(QT) > #ifndef !defined(WTF_USE_ACCELERATED_COMPOSITING) && QT_VERSION_GREATER_THEN(4, 5, 0) > #define WTF_USE_ACCELERATED_COMPOSITING 1 > #endif > #endif > > With this the feature could be disabled at compile time and the version check would still exist. Do you agree? > (I am not sure that the QT_VERSION_GREATER_THEN macro exist but I know there is something like that.) "#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0)" Personally, I support moving all "#defined" dealed here to Platform.h 265990 10 noam 2010-08-18 01:57:03 -0700 Reopening to accomodate the above comments 265991 11 64676 noam 2010-08-18 01:59:50 -0700 Created attachment 64676 Patch 266050 12 64676 tonikitoo 2010-08-18 05:16:30 -0700 Comment on attachment 64676 Patch Noam, the patch looks good. One major comment below though. > 2010-08-17 Gavin Barraclough <barraclough@apple.com> > > Reviewed by Sam Weinig. > diff --git a/JavaScriptCore/wtf/Platform.h b/JavaScriptCore/wtf/Platform.h > index f653adb2c0a59e6add35b821d1ec139a2c38583a..78968a900d12df7728f1b258a9c546ab1d9ea2e5 100644 > --- a/JavaScriptCore/wtf/Platform.h > +++ b/JavaScriptCore/wtf/Platform.h > @@ -1052,7 +1052,7 @@ on MinGW. See https://bugs.webkit.org/show_bug.cgi?id=29268 */ > #define WTF_USE_ACCELERATED_COMPOSITING 1 > #endif > > -#if PLATFORM(QT) > +#if PLATFORM(QT) && !(defined(QT_VERSION) && QT_VERSION < 0x040600) && !defined(WTF_USE_ACCELERATED_COMPOSITING) > #define WTF_USE_ACCELERATED_COMPOSITING 1 > #endif in bug 43695, we moved away from using the encoded hex for qt version check. could you keep the consistency? The rest is fine. 281071 13 kling 2010-09-17 19:39:52 -0700 @No'am: Ping, this has been in pending-commit for a month. 283070 14 68398 noam 2010-09-22 11:12:06 -0700 Created attachment 68398 Patch 283101 15 68398 kenneth 2010-09-22 11:42:08 -0700 Comment on attachment 68398 Patch OK, I trust you on this one. So WTF_USE_ACCELERATED_COMPOSITING is set elsewhere now? 283105 16 noam 2010-09-22 11:50:07 -0700 Yes, in the previous patch I moved it to Platform.h, where it belongs. This is just some follow-up cleanup. 283147 17 68398 commit-queue 2010-09-22 12:18:40 -0700 Comment on attachment 68398 Patch Clearing flags on attachment: 68398 Committed r68067: <http://trac.webkit.org/changeset/68067> 283148 18 commit-queue 2010-09-22 12:18:46 -0700 All reviewed patches have been landed. Closing bug. 64169 2010-08-11 15:25:34 -0700 2010-08-18 01:59:43 -0700 Patch patch-43882.diff text/plain 4475 noam ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwODJlZmM5Li42YjY1MjRkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTAtMDgtMTEgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRd IE1vdmUgdGhlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGJ1aWxkIGZsYWcgdG8gdGhlIHJpZ2h0 IHBsYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 Mzg4MgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTAtMDgtMTEgIEtldmluIE9s bGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBCdWlsZCBm aXggZm9yIHd4IGFuZCBXZWJET00gYmluZGluZ3MsIGFkZCBDU3RyaW5nIGNsYXNzZXMgdG8gdGhl IGxpc3Qgb2YgZm9yd2FyZHMuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZv cm0uaCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGE3YzA0YjUuLmY2NTNh ZGIgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL0phdmFT Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC0xMDUyLDYgKzEwNTIsMTAgQEAgb24gTWluR1cu IFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjkyNjggKi8KICNk ZWZpbmUgV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORyAxCiAjZW5kaWYKIAorI2lmIFBM QVRGT1JNKFFUKQorI2RlZmluZSBXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HIDEKKyNl bmRpZgorCiAvKiBGSVhNRTogRGVmaW5pbmcgRU5BQkxFXzNEX1JFTkRFUklORyBoZXJlIGlzbid0 IHJlYWxseSByaWdodCwgYnV0IGl0J3MgYWx3YXlzIHVzZWQgd2l0aAogICAgd2l0aCBXVEZfVVNF X0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HLCBhbmQgaXQgYWxsb3dzIHRoZSBmZWF0dXJlIHRvIGJl IHR1cm5lZCBvbiBhbmQKICAgIG9mZiBpbiBvbmUgcGxhY2UuICovCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGJmMTZjNTEuLmE5MDNmMGUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMTEgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50 aGFsQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIE1vdmUgdGhlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGJ1aWxkIGZsYWcg dG8gdGhlIHJpZ2h0IHBsYWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00Mzg4MgorCisgICAgICAgIE5vIG5ldyB0ZXN0czogYnVpbGQgZml4LgorCisg ICAgICAgICogV2ViQ29yZS5wcm86CisKIDIwMTAtMDgtMTAgIEFhcm9uIEJvb2RtYW4gIDxhYUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCmRpZmYgLS1n aXQgYS9XZWJDb3JlL1dlYkNvcmUucHJvIGIvV2ViQ29yZS9XZWJDb3JlLnBybwppbmRleCBiYzg3 ZTI1Li5mYzJiYjE2IDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUucHJvCisrKyBiL1dlYkNv cmUvV2ViQ29yZS5wcm8KQEAgLTg5OCw2ICs4OTgsNyBAQCBTT1VSQ0VTICs9IFwKICAgICBwbGF0 Zm9ybS9ncmFwaGljcy9HZW5lcmF0ZWRJbWFnZS5jcHAgXAogICAgIHBsYXRmb3JtL2dyYXBoaWNz L0dyYWRpZW50LmNwcCBcCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNw cCBcCisgICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHAgXAogICAgIHBsYXRm b3JtL2dyYXBoaWNzL0dyYXBoaWNzVHlwZXMuY3BwIFwKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9J bWFnZS5jcHAgXAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcCBcCkBAIC0x MDA2LDYgKzEwMDcsOCBAQCBTT1VSQ0VTICs9IFwKICAgICByZW5kZXJpbmcvUmVuZGVySW5kaWNh dG9yLmNwcCBcCiAgICAgcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAgXAogICAgIHJlbmRlcmlu Zy9SZW5kZXJMYXllci5jcHAgXAorICAgIHJlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3Bw IFwKKyAgICByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcCBcCiAgICAgcmVuZGVy aW5nL1JlbmRlckxpbmVCb3hMaXN0LmNwcCBcCiAgICAgcmVuZGVyaW5nL1JlbmRlckxpc3RCb3gu Y3BwIFwKICAgICByZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwIFwKQEAgLTE2ODEsNiArMTY4 NCw4IEBAIEhFQURFUlMgKz0gXAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dlbmVyYXRlZEltYWdl LmggXAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmggXAogICAgIHBsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oIFwKKyAgICBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0xheWVyLmggXAorICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXJDbGllbnQuaCBc CiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NUeXBlcy5oIFwKICAgICBwbGF0Zm9ybS9n cmFwaGljcy9JbWFnZS5oIFwKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5oIFwK QEAgLTE2OTMsNiArMTY5OCw3IEBAIEhFQURFUlMgKz0gXAogICAgIHBsYXRmb3JtL2dyYXBoaWNz L1BhdHRlcm4uaCBcCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvUGVuLmggXAogICAgIHBsYXRmb3Jt L2dyYXBoaWNzL3F0L0ZvbnRDdXN0b21QbGF0Zm9ybURhdGEuaCBcCisgICAgcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmggXAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0lt YWdlRGVjb2RlclF0LmggXAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3F0L1N0aWxsSW1hZ2VRdC5o IFwKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9TZWdtZW50ZWRGb250RGF0YS5oIFwKQEAgLTE4MjAs NiArMTgyNiw4IEBAIEhFQURFUlMgKz0gXAogICAgIHJlbmRlcmluZy9SZW5kZXJJbmxpbmUuaCBc CiAgICAgcmVuZGVyaW5nL1JlbmRlcklucHV0U3BlZWNoLmggXAogICAgIHJlbmRlcmluZy9SZW5k ZXJMYXllci5oIFwKKyAgICByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmggXAorICAgIHJl bmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaCBcCiAgICAgcmVuZGVyaW5nL1JlbmRlckxp bmVCb3hMaXN0LmggXAogICAgIHJlbmRlcmluZy9SZW5kZXJMaXN0Qm94LmggXAogICAgIHJlbmRl cmluZy9SZW5kZXJMaXN0SXRlbS5oIFwKQEAgLTIxOTIsNiArMjIwMCw3IEBAIFNPVVJDRVMgKz0g XAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0Zsb2F0UmVjdFF0LmNwcCBcCiAgICAgcGxhdGZv cm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAgXAogICAgIHBsYXRmb3JtL2dyYXBoaWNzL3F0 L0dyYXBoaWNzQ29udGV4dFF0LmNwcCBcCisgICAgcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NMYXllclF0LmNwcCBcCiAgICAgcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSWNvblF0LmNwcCBcCiAg ICAgcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAgXAogICAgIHBsYXRmb3Jt L2dyYXBoaWNzL3F0L0ltYWdlRGVjb2RlclF0LmNwcCBcCkBAIC0zMjE2LDE5ICszMjI1LDYgQEAg d2luMzI6IXdpbjMyLWcrKyo6Y29udGFpbnMoUU1BS0VfSE9TVC5hcmNoLCB4ODZfNjQpOnsKICAg ICAgICAgICAgIHBsdWdpbnMvd2luL1BhaW50SG9va3MuYXNtCiAgICAgfQogfQotY29udGFpbnMo REVGSU5FUywgV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykgewotSEVBREVSUyArPSBc Ci0gICAgcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5oIFwKLSAgICByZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmggXAotICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5 ZXIuaCBcCi0gICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckNsaWVudC5oIFwKLSAg ICBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQuaAotU09VUkNFUyArPSBcCi0g ICAgcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHAgXAotICAgIHBsYXRmb3JtL2dy YXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHAgXAotICAgIHJlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwIFwKLSAgICByZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAot fQogCiBzeW1iaWFuIHsKICAgICBzaGFyZWQgewo= 64676 2010-08-18 01:59:50 -0700 2010-09-22 11:12:06 -0700 Patch bug-43882-20100818105946.patch text/plain 2127 noam ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBmZWY3YWQ1ZTk1M2E2ZjVh ZWE3MjdmN2FiNDg4MmJlYzUzZWIzYTE1Li5jN2FiMGQwZTcxOTkwY2I3ZGZkNmIyOGY3Y2QyYmNk NDhlNTVhY2M4IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTAtMDgtMTggIE5vYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gTW92ZSB0aGUgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgYnVpbGQgZmxhZyB0byB0aGUg cmlnaHQgcGxhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQzODgyCisKKyAgICAgICAgKiBXZWJLaXQucHJpOiByZW1vdmVkIFdURl9VU0VfQUNDRUxF UkFURURfQ09NUE9TSVRJTkcgZmxhZworCiAyMDEwLTA4LTE3ICBKZXN1cyBTYW5jaGV6LVBhbGVu Y2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2YmZkN2MyNzE3Y2RjMWJjZGEwYWFhM2NkMzQ3 YTAxYTc2OGUyNDRkLi4wNTJkZWM3Y2IwNTc3NjUyNjgyYzdkYzc4NWYyNDA4MWRmMDRkMWMwIDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDgtMTggIE5vYW0gUm9zZW50aGFsICA8 bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRdF0gTW92ZSB0aGUgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcg YnVpbGQgZmxhZyB0byB0aGUgcmlnaHQgcGxhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQzODgyCisKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoK KwogMjAxMC0wOC0xNyAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9QbGF0Zm9ybS5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKaW5k ZXggZjY1M2FkYjJjMGE1OWU2YWRkMzViODIxZDFlYzEzOWEyYzM4NTgzYS4uNzg5NjhhOTAwZDEy ZGY3NzI4ZjFiMjU4YTljNTQ2YWIxZDllYTJlNSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKQEAgLTEw NTIsNyArMTA1Miw3IEBAIG9uIE1pbkdXLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTI5MjY4ICovCiAjZGVmaW5lIFdURl9VU0VfQUNDRUxFUkFURURfQ09NUE9T SVRJTkcgMQogI2VuZGlmCiAKLSNpZiBQTEFURk9STShRVCkKKyNpZiBQTEFURk9STShRVCkgJiYg IShkZWZpbmVkKFFUX1ZFUlNJT04pICYmIFFUX1ZFUlNJT04gPCAweDA0MDYwMCkgJiYgIWRlZmlu ZWQoV1RGX1VTRV9BQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICNkZWZpbmUgV1RGX1VTRV9BQ0NF TEVSQVRFRF9DT01QT1NJVElORyAxCiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvV2ViS2l0LnByaSBi L1dlYktpdC5wcmkKaW5kZXggZDYxMWZiNTY0Y2ZhYjMxNjdmZjc0NjQ2ODhiMDQ3YmIxNmE2MTUx Yy4uMjk3YTNmOWVmNWYyZWZlNDVjOGU5ZWJlYjIxMzhjYTc2M2JhMmI3OSAxMDA2NDQKLS0tIGEv V2ViS2l0LnByaQorKysgYi9XZWJLaXQucHJpCkBAIC00NSw3ICs0NSw2IEBAIGJ1aWxkaW5nLWxp YnMgewogICAgIH0KICAgICBERVBFTkRQQVRIICs9ICQkUFdEL1dlYktpdC9xdC9BcGkKIH0KLWdy ZWF0ZXJUaGFuKFFUX01JTk9SX1ZFUlNJT04sIDUpOkRFRklORVMgKz0gV1RGX1VTRV9BQ0NFTEVS QVRFRF9DT01QT1NJVElORwogCiAhbWFjOiF1bml4fHN5bWJpYW4gewogICAgIERFRklORVMgKz0g VVNFX1NZU1RFTV9NQUxMT0MK 68398 2010-09-22 11:12:06 -0700 2010-09-22 12:18:40 -0700 Patch 43882-2.diff text/plain 824 noam ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBkOTM1MDUyLi5mYzYzZTIw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDktMjIgIE5vJ2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIE1v dmUgdGhlIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGJ1aWxkIGZsYWcgdG8gdGhlIHJpZ2h0IHBs YWNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzg4 MgorCisgICAgICAgICogV2ViS2l0LnByaTogUmVtb3ZlZCB0aGUgcmVkdW5kYW50IHZlcnNpb24g Y2hlY2suCisKIDIwMTAtMDktMjEgIEZyaWRyaWNoIFN0cmJhICA8ZnJpZHJpY2guc3RyYmFAYmx1 ZXdpbi5jaD4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYgLS1n aXQgYS9XZWJLaXQucHJpIGIvV2ViS2l0LnByaQppbmRleCA5NmRkNmM1Li4wOTc4MzJiIDEwMDY0 NAotLS0gYS9XZWJLaXQucHJpCisrKyBiL1dlYktpdC5wcmkKQEAgLTQ2LDcgKzQ2LDYgQEAgYnVp bGRpbmctbGlicyB7CiAgICAgfQogICAgIERFUEVORFBBVEggKz0gJCRQV0QvV2ViS2l0L3F0L0Fw aQogfQotZ3JlYXRlclRoYW4oUVRfTUlOT1JfVkVSU0lPTiwgNSk6REVGSU5FUyArPSBXVEZfVVNF X0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HCiAKICFtYWM6IXVuaXh8c3ltYmlhbiB7CiAgICAgREVG SU5FUyArPSBVU0VfU1lTVEVNX01BTExPQwo=