43877 2010-08-11 14:15:13 -0700 Conditionalize wrong fragment parsing code to pass more HTML5lib tests 2010-08-11 19:55:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric oldest_to_newest 263447 0 abarth 2010-08-11 14:15:13 -0700 Conditionalize wrong fragment parsing code to pass more HTML5lib tests 263448 1 64159 abarth 2010-08-11 14:17:03 -0700 Created attachment 64159 Patch 263449 2 64159 eric 2010-08-11 14:21:14 -0700 Comment on attachment 64159 Patch OK. This is ugly, but it's about to get deleted anyway... 263574 3 64159 commit-queue 2010-08-11 19:55:52 -0700 Comment on attachment 64159 Patch Clearing flags on attachment: 64159 Committed r65212: <http://trac.webkit.org/changeset/65212> 263575 4 commit-queue 2010-08-11 19:55:57 -0700 All reviewed patches have been landed. Closing bug. 64159 2010-08-11 14:17:03 -0700 2010-08-11 19:55:52 -0700 Patch bug-43877-20100811141702.patch text/plain 6121 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ODJjOTBjNDgyZGY1ZjE2OTc0YzUyYjY3YjI3MzBiYmVkZDFiYTZlLi40YmU5YzMy OGYxNDlhNjM2MWY3NmE4ODc2MzllNTU4N2E0MzRmNTM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDgtMTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb25kaXRpb25hbGl6ZSB3cm9u ZyBmcmFnbWVudCBwYXJzaW5nIGNvZGUgdG8gcGFzcyBtb3JlIEhUTUw1bGliIHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzg3NworCisgICAg ICAgIFRlc3QgcHJvZ3Jlc3Npb24uCisKKyAgICAgICAgKiBodG1sNWxpYi9ydW5uZXItZXhwZWN0 ZWQtaHRtbDUudHh0OgorCiAyMDEwLTA4LTExICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLWh0bWw1LnR4dCBiL0xheW91 dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQKaW5kZXggNWNhMjMyOTI1 OTA0MjA0NjFiYjFiOWY0ZmVkY2RjY2Y4NGIwODk4MS4uZmRiZDhkYTgxOTU2MGMxNjQ1NjU4ZTYw ODgwYzY2ODBjNWYxOWUwNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVy LWV4cGVjdGVkLWh0bWw1LnR4dAorKysgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi9ydW5uZXItZXhw ZWN0ZWQtaHRtbDUudHh0CkBAIC0xNywxOCArMTcsOCBAQCByZXNvdXJjZXMvdGVzdHMyLmRhdDog UEFTUwogcmVzb3VyY2VzL3Rlc3RzMy5kYXQ6IFBBU1MKIAogcmVzb3VyY2VzL3Rlc3RzNC5kYXQ6 Ci02CiA3CiAKLVRlc3QgNiBvZiA3IGluIHJlc291cmNlcy90ZXN0czQuZGF0IGZhaWxlZC4gSW5w dXQ6Ci1zZXR0aW5nIGh0bWwncyBpbm5lckhUTUwKLUdvdDoKLXwgInNldHRpbmcgaHRtbCdzIGlu bmVySFRNTCIKLUV4cGVjdGVkOgotfCA8aGVhZD4KLXwgPGJvZHk+Ci18ICAgInNldHRpbmcgaHRt bCdzIGlubmVySFRNTCIKLQogVGVzdCA3IG9mIDcgaW4gcmVzb3VyY2VzL3Rlc3RzNC5kYXQgZmFp bGVkLiBJbnB1dDoKIDx0aXRsZT5zZXR0aW5nIGhlYWQncyBpbm5lckhUTUw8L3RpdGxlPgogR290 OgpAQCAtNDEsNyArMzEsNiBAQCByZXNvdXJjZXMvdGVzdHM1LmRhdDogUEFTUwogcmVzb3VyY2Vz L3Rlc3RzNi5kYXQ6CiAyNwogMzAKLTQ1CiAKIFRlc3QgMjcgb2YgNTEgaW4gcmVzb3VyY2VzL3Rl c3RzNi5kYXQgZmFpbGVkLiBJbnB1dDoKIGZvbzxjb2w+CkBAIC01NiwyNyArNDUsOSBAQCBHb3Q6 CiB8IAogRXhwZWN0ZWQ6CiB8IDxmcmFtZT4KLQotVGVzdCA0NSBvZiA1MSBpbiByZXNvdXJjZXMv dGVzdHM2LmRhdCBmYWlsZWQuIElucHV0OgotPGJvZHk+PC9ib2R5PjwvaHRtbD4KLUdvdDoKLXwg Ci1FeHBlY3RlZDoKLXwgPGhlYWQ+Ci18IDxib2R5PgogcmVzb3VyY2VzL3Rlc3RzNy5kYXQ6Ci0y NAogMzAKIAotVGVzdCAyNCBvZiAzMCBpbiByZXNvdXJjZXMvdGVzdHM3LmRhdCBmYWlsZWQuIElu cHV0OgotPGJvZHk+WDwvYm9keT48L2JvZHk+Ci1Hb3Q6Ci18ICJYIgotRXhwZWN0ZWQ6Ci18IDxo ZWFkPgotfCA8Ym9keT4KLXwgICAiWCIKLQogVGVzdCAzMCBvZiAzMCBpbiByZXNvdXJjZXMvdGVz dHM3LmRhdCBmYWlsZWQuIElucHV0OgogPHNlbGVjdD48a2V5Z2VuPgogR290OgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MzBlZWIwMGU0 NGI5MjkzMjVjYThhMTVkYzgzMzAwNmQwOGQ1MDlmLi5jNzFmYWZiYjY5ZWVjOWNmNTQ1NDg1YTI2 OGNjNmFlOWQ5YzZkMzgzIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA4LTExICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ29uZGl0aW9uYWxpemUgd3JvbmcgZnJhZ21lbnQgcGFyc2luZyBjb2RlIHRv IHBhc3MgbW9yZSBIVE1MNWxpYiB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDM4NzcKKworICAgICAgICBUaGlzIGNvZGUgZXhpc3RzIHRvIHN1 cHBvcnQgdGhlIExlZ2FjeUhUTUxUcmVlQnVpbGRlci4gIFVuZm9ydHVuYXRlbHksCisgICAgICAg IGl0IGNhdXNlcyBwcm9ibGVtcyBmb3IgdGhlIG5ldyBIVE1MVHJlZUJ1aWxkZXIgKHdoaWNoIGlz IG1vcmUKKyAgICAgICAgc2VsZi1jb250YWluZWQpLgorCisgICAgICAgICogZG9tL0VsZW1lbnQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RWxlbWVudDo6Y3JlYXRlQ29udGV4dHVhbEZyYWdtZW50 KToKKwogMjAxMC0wOC0xMSAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNv bT4KIAogICAgICAgICBbd3gsIFdlYkRPTV0gQnVpbGQgZml4LiBGaXggY2FsbGJhY2sgcGFyYW1z IGFuZCBXZWJDb3JlOjpTdHJpbmcgLT4gV1RGOjpTdHJpbmcgZml4ZXMuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmluZGV4IDBl ODllOTMzMzU1N2IwYjY3YzFiMzRkODIxZDJlYzkyNGI3M2IxMWUuLmNjM2JmMWYzNzMzOGQwYWY5 YmE5NGM5NWZhMWZjODZmMTliNzAwZjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0VsZW1lbnQu Y3BwCisrKyBiL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC01MCw2ICs1MCw3IEBACiAjaW5j bHVkZSAiUmVuZGVyTGF5ZXIuaCIKICNpbmNsdWRlICJSZW5kZXJWaWV3LmgiCiAjaW5jbHVkZSAi UmVuZGVyV2lkZ2V0LmgiCisjaW5jbHVkZSAiU2V0dGluZ3MuaCIKICNpbmNsdWRlICJUZXh0SXRl cmF0b3IuaCIKICNpbmNsdWRlICJYTUxOYW1lcy5oIgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJp bmcuaD4KQEAgLTEwMiwzNiArMTAzLDM3IEBAIFBhc3NSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4g RWxlbWVudDo6Y3JlYXRlQ29udGV4dHVhbEZyYWdtZW50KGNvbnN0IFN0cmluZyYgbWFyCiAgICAg ICAgICAgICByZXR1cm4gMDsKICAgICB9CiAgICAgCi0gICAgLy8gRXhjZXB0aW9ucyBhcmUgaWdu b3JlZCBiZWNhdXNlIG5vbmUgb3VnaHQgdG8gaGFwcGVuIGhlcmUuCi0gICAgRXhjZXB0aW9uQ29k ZSBpZ25vcmVkRXhjZXB0aW9uQ29kZTsKLSAgICAKLSAgICAvLyBXZSBuZWVkIHRvIHBvcCA8aHRt bD4gYW5kIDxib2R5PiBlbGVtZW50cyBhbmQgcmVtb3ZlIDxoZWFkPiB0bwotICAgIC8vIGFjY29t bW9kYXRlIGZvbGtzIHBhc3NpbmcgY29tcGxldGUgSFRNTCBkb2N1bWVudHMgdG8gbWFrZSB0aGUK LSAgICAvLyBjaGlsZCBvZiBhbiBlbGVtZW50LgotICAgIAotICAgIFJlZlB0cjxOb2RlPiBuZXh0 Tm9kZTsKLSAgICBmb3IgKFJlZlB0cjxOb2RlPiBub2RlID0gZnJhZ21lbnQtPmZpcnN0Q2hpbGQo KTsgbm9kZTsgbm9kZSA9IG5leHROb2RlKSB7Ci0gICAgICAgIG5leHROb2RlID0gbm9kZS0+bmV4 dFNpYmxpbmcoKTsKLSAgICAgICAgaWYgKG5vZGUtPmhhc1RhZ05hbWUoaHRtbFRhZykgfHwgbm9k ZS0+aGFzVGFnTmFtZShib2R5VGFnKSkgewotICAgICAgICAgICAgTm9kZSogZmlyc3RDaGlsZCA9 IG5vZGUtPmZpcnN0Q2hpbGQoKTsKLSAgICAgICAgICAgIGlmIChmaXJzdENoaWxkKQotICAgICAg ICAgICAgICAgIG5leHROb2RlID0gZmlyc3RDaGlsZDsKLSAgICAgICAgICAgIFJlZlB0cjxOb2Rl PiBuZXh0Q2hpbGQ7Ci0gICAgICAgICAgICBmb3IgKFJlZlB0cjxOb2RlPiBjaGlsZCA9IGZpcnN0 Q2hpbGQ7IGNoaWxkOyBjaGlsZCA9IG5leHRDaGlsZCkgewotICAgICAgICAgICAgICAgIG5leHRD aGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpOwotICAgICAgICAgICAgICAgIG5vZGUtPnJlbW92 ZUNoaWxkKGNoaWxkLmdldCgpLCBpZ25vcmVkRXhjZXB0aW9uQ29kZSk7CisgICAgaWYgKCFkb2N1 bWVudCgpLT5zZXR0aW5ncygpIHx8ICFkb2N1bWVudCgpLT5zZXR0aW5ncygpLT5odG1sNVRyZWVC dWlsZGVyRW5hYmxlZCgpKSB7CisgICAgICAgIC8vIEV4Y2VwdGlvbnMgYXJlIGlnbm9yZWQgYmVj YXVzZSBub25lIG91Z2h0IHRvIGhhcHBlbiBoZXJlLgorICAgICAgICBFeGNlcHRpb25Db2RlIGln bm9yZWRFeGNlcHRpb25Db2RlOworICAgICAgICAKKyAgICAgICAgLy8gV2UgbmVlZCB0byBwb3Ag PGh0bWw+IGFuZCA8Ym9keT4gZWxlbWVudHMgYW5kIHJlbW92ZSA8aGVhZD4gdG8KKyAgICAgICAg Ly8gYWNjb21tb2RhdGUgZm9sa3MgcGFzc2luZyBjb21wbGV0ZSBIVE1MIGRvY3VtZW50cyB0byBt YWtlIHRoZQorICAgICAgICAvLyBjaGlsZCBvZiBhbiBlbGVtZW50LgorICAgICAgICAKKyAgICAg ICAgUmVmUHRyPE5vZGU+IG5leHROb2RlOworICAgICAgICBmb3IgKFJlZlB0cjxOb2RlPiBub2Rl ID0gZnJhZ21lbnQtPmZpcnN0Q2hpbGQoKTsgbm9kZTsgbm9kZSA9IG5leHROb2RlKSB7CisgICAg ICAgICAgICBuZXh0Tm9kZSA9IG5vZGUtPm5leHRTaWJsaW5nKCk7CisgICAgICAgICAgICBpZiAo bm9kZS0+aGFzVGFnTmFtZShodG1sVGFnKSB8fCBub2RlLT5oYXNUYWdOYW1lKGJvZHlUYWcpKSB7 CisgICAgICAgICAgICAgICAgTm9kZSogZmlyc3RDaGlsZCA9IG5vZGUtPmZpcnN0Q2hpbGQoKTsK KyAgICAgICAgICAgICAgICBpZiAoZmlyc3RDaGlsZCkKKyAgICAgICAgICAgICAgICAgICAgbmV4 dE5vZGUgPSBmaXJzdENoaWxkOworICAgICAgICAgICAgICAgIFJlZlB0cjxOb2RlPiBuZXh0Q2hp bGQ7CisgICAgICAgICAgICAgICAgZm9yIChSZWZQdHI8Tm9kZT4gY2hpbGQgPSBmaXJzdENoaWxk OyBjaGlsZDsgY2hpbGQgPSBuZXh0Q2hpbGQpIHsKKyAgICAgICAgICAgICAgICAgICAgbmV4dENo aWxkID0gY2hpbGQtPm5leHRTaWJsaW5nKCk7CisgICAgICAgICAgICAgICAgICAgIG5vZGUtPnJl bW92ZUNoaWxkKGNoaWxkLmdldCgpLCBpZ25vcmVkRXhjZXB0aW9uQ29kZSk7CisgICAgICAgICAg ICAgICAgICAgIEFTU0VSVCghaWdub3JlZEV4Y2VwdGlvbkNvZGUpOworICAgICAgICAgICAgICAg ICAgICBmcmFnbWVudC0+aW5zZXJ0QmVmb3JlKGNoaWxkLCBub2RlLmdldCgpLCBpZ25vcmVkRXhj ZXB0aW9uQ29kZSk7CisgICAgICAgICAgICAgICAgICAgIEFTU0VSVCghaWdub3JlZEV4Y2VwdGlv bkNvZGUpOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBmcmFnbWVudC0+cmVt b3ZlQ2hpbGQobm9kZS5nZXQoKSwgaWdub3JlZEV4Y2VwdGlvbkNvZGUpOwogICAgICAgICAgICAg ICAgIEFTU0VSVCghaWdub3JlZEV4Y2VwdGlvbkNvZGUpOwotICAgICAgICAgICAgICAgIGZyYWdt ZW50LT5pbnNlcnRCZWZvcmUoY2hpbGQsIG5vZGUuZ2V0KCksIGlnbm9yZWRFeGNlcHRpb25Db2Rl KTsKKyAgICAgICAgICAgIH0gZWxzZSBpZiAobm9kZS0+aGFzVGFnTmFtZShoZWFkVGFnKSkgewor ICAgICAgICAgICAgICAgIGZyYWdtZW50LT5yZW1vdmVDaGlsZChub2RlLmdldCgpLCBpZ25vcmVk RXhjZXB0aW9uQ29kZSk7CiAgICAgICAgICAgICAgICAgQVNTRVJUKCFpZ25vcmVkRXhjZXB0aW9u Q29kZSk7CiAgICAgICAgICAgICB9Ci0gICAgICAgICAgICBmcmFnbWVudC0+cmVtb3ZlQ2hpbGQo bm9kZS5nZXQoKSwgaWdub3JlZEV4Y2VwdGlvbkNvZGUpOwotICAgICAgICAgICAgQVNTRVJUKCFp Z25vcmVkRXhjZXB0aW9uQ29kZSk7Ci0gICAgICAgIH0gZWxzZSBpZiAobm9kZS0+aGFzVGFnTmFt ZShoZWFkVGFnKSkgewotICAgICAgICAgICAgZnJhZ21lbnQtPnJlbW92ZUNoaWxkKG5vZGUuZ2V0 KCksIGlnbm9yZWRFeGNlcHRpb25Db2RlKTsKLSAgICAgICAgICAgIEFTU0VSVCghaWdub3JlZEV4 Y2VwdGlvbkNvZGUpOwogICAgICAgICB9CiAgICAgfQotICAgIAogICAgIHJldHVybiBmcmFnbWVu dC5yZWxlYXNlKCk7CiB9CiAgICAgCg==