43866 2010-08-11 12:21:54 -0700 The #if clause enabling a feature should avoid the all includes of the feature 2019-02-06 09:02:50 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 42266 1 alex webkit-unassigned cdumez oldest_to_newest 263383 0 alex 2010-08-11 12:21:54 -0700 In this moment we are generating code like this: ... #include "config.h" #include "MathMLElementFactory.h" #include "MathMLNames.h" #if ENABLE(MATHML) #include "MathMLMathElement.h" #include "MathMLInlineContainerElement.h" #include "MathMLTextElement.h" #include "MathMLElement.h" #include <wtf/HashMap.h> ... This causes problems when you disable a feature because the includes add the symbols from the .h which are going to be undefined when you try to link the library, in gtk it fails linking our unit tests. To solve this issue we could generate something like this: ... #include "config.h" #if ENABLE(MATHML) #include "MathMLElementFactory.h" #include "MathMLNames.h" #include "MathMLMathElement.h" #include "MathMLInlineContainerElement.h" #include "MathMLTextElement.h" #include "MathMLElement.h" #include <wtf/HashMap.h> ... 263385 1 64146 alex 2010-08-11 12:23:50 -0700 Created attachment 64146 Proposed patch 263643 2 alex 2010-08-12 01:07:21 -0700 Landed r65223 1502852 3 lforschler 2019-02-06 09:02:50 -0800 Mass moving XML DOM bugs to the "DOM" Component. 64146 2010-08-11 12:23:50 -0700 2010-08-11 14:09:49 -0700 Proposed patch includes_dom.patch text/plain 1256 alex ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTBiMmI4NS4uNjJlODAxMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0xMSAgQWxlamFuZHJvIEcu IENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgI2lmIGNsYXVzZSBlbmFibGluZyBhIGZlYXR1cmUgc2hv dWxkIGF2b2lkIHRoZSBhbGwgaW5jbHVkZXMgb2YKKyAgICAgICAgdGhlIGZlYXR1cmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzODY2CisKKyAgICAg ICAgTW9kaWZpZWQgdGhlIHBvc2l0aW9uIG9mIHRoZSBndWFyZCB0byBhdm9pZCBpbmNsdWRpbmcg YWxsIHRoZQorICAgICAgICBoZWFkZXJzIGlmIHRoZSBmZWF0dXJlIGNvbnRyb2xsaW5nIHRoZSBn dWFyZCBpcyBub3QgZW5hYmxlZC4KKworICAgICAgICAqIGRvbS9tYWtlX25hbWVzLnBsOgorCiAy MDEwLTA4LTExICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20v bWFrZV9uYW1lcy5wbCBiL1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwKaW5kZXggNGI0YzdlMy4u ZTExMWViNyAxMDA3NTUKLS0tIGEvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAorKysgYi9XZWJD b3JlL2RvbS9tYWtlX25hbWVzLnBsCkBAIC02NDcsMTMgKzY0NywxNyBAQCBwcmludExpY2Vuc2VI ZWFkZXIoJEYpOwogCiBwcmludCBGIDw8RU5ECiAjaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVk ZSAiJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUVsZW1lbnRGYWN0b3J5LmgiCi0jaW5jbHVkZSAiJHBh cmFtZXRlcnN7bmFtZXNwYWNlfU5hbWVzLmgiCiBFTkQKIDsKIAogcHJpbnQgRiAiXG4jaWYgJHBh cmFtZXRlcnN7Z3VhcmRGYWN0b3J5V2l0aH1cblxuIiBpZiAkcGFyYW1ldGVyc3tndWFyZEZhY3Rv cnlXaXRofTsKIAorcHJpbnQgRiA8PEVORAorI2luY2x1ZGUgIiRwYXJhbWV0ZXJze25hbWVzcGFj ZX1FbGVtZW50RmFjdG9yeS5oIgorI2luY2x1ZGUgIiRwYXJhbWV0ZXJze25hbWVzcGFjZX1OYW1l cy5oIgorRU5ECis7CisKIHByaW50RWxlbWVudEluY2x1ZGVzKCRGKTsKIAogcHJpbnQgRiA8PEVO RAo=