43857 2010-08-11 09:26:07 -0700 Handle clicks and recognition events for the speech input button 2010-08-11 23:43:12 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned commit-queue jorlow tkent oldest_to_newest 263280 0 satish 2010-08-11 09:26:07 -0700 Maintain state in the speech input button, invoke the appropriate API calls to start/stop speech recognition on click and show appropriate UI on state changes. 263289 1 64126 satish 2010-08-11 09:36:18 -0700 Created attachment 64126 Patch 263607 2 64126 tkent 2010-08-11 22:46:33 -0700 Comment on attachment 64126 Patch Looks good. 263620 3 64126 commit-queue 2010-08-11 23:43:07 -0700 Comment on attachment 64126 Patch Clearing flags on attachment: 64126 Committed r65220: <http://trac.webkit.org/changeset/65220> 263621 4 commit-queue 2010-08-11 23:43:12 -0700 All reviewed patches have been landed. Closing bug. 64126 2010-08-11 09:36:18 -0700 2010-08-11 23:43:07 -0700 Patch bug-43857-20100811173616.patch text/plain 6131 satish ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTBiMmI4NTViYzhkMDJlMDVhZDMzNTFiODliZDM1NTkxYTdiMDMwMy4uMzhlMDg5ZTliODVkYTQz ZTBiMjQ1OGEwNDgzMWYxYTE1MzFkNWM5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOC0xMSAgU2F0 aXNoIFNhbXBhdGggIDxzYXRpc2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEhhbmRsZSBjbGlja3MgYW5kIHJlY29nbml0aW9u IGV2ZW50cyBmb3IgdGhlIHNwZWVjaCBpbnB1dCBidXR0b24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzODU3CisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVySW5wdXRTcGVlY2guY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW5wdXRTcGVl Y2g6OnBhaW50SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbik6IFNlbGVjdHMgdGhlIGltYWdlIGJhc2Vk IG9uIGN1cnJlbnQgc3RhdGUuCisgICAgICAgICogcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJF bGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxl bWVudDo6SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6 SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQ6OmRlZmF1bHRFdmVudEhhbmRsZXIpOgorICAg ICAgICAoV2ViQ29yZTo6SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQ6OnNldF9zdGF0ZSk6 IFN3aXRjaCB0byBhIG5ldyBzdGF0ZSBhbmQgdXBkYXRlIHRoZSBVSS4KKyAgICAgICAgKFdlYkNv cmU6OklucHV0RmllbGRTcGVlY2hCdXR0b25FbGVtZW50OjpkaWRDb21wbGV0ZVJlY29yZGluZyk6 IAorICAgICAgICAoV2ViQ29yZTo6SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQ6OmRpZENv bXBsZXRlUmVjb2duaXRpb24pOgorICAgICAgICAqIHJlbmRlcmluZy9UZXh0Q29udHJvbElubmVy RWxlbWVudHMuaDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0RmllbGRTcGVlY2hCdXR0b25FbGVt ZW50OjopOgorICAgICAgICAoV2ViQ29yZTo6SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQ6 OnN0YXRlKToKKwogMjAxMC0wOC0xMSAgSWx5YSBUaWtob25vdnNreSAgPGxvaXNsb0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklucHV0U3BlZWNoLmNwcCBiL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlcklucHV0U3BlZWNoLmNwcAppbmRleCBkZjE3OTQ0ZjU0NDhmMTgxZjVjNDI2ODI0 ZDFlNjlkYWM1NWJjODMwLi41NDcyMDI1YzNlN2Q5YWNjMDNhYTlmYzFjNTdlYzdmYjkxYmExMzRk IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbnB1dFNwZWVjaC5jcHAKKysr IGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5wdXRTcGVlY2guY3BwCkBAIC0zNiw2ICszNiw3 IEBACiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiSFRNTE5hbWVzLmgi CiAjaW5jbHVkZSAiUmVuZGVyQm94LmgiCisjaW5jbHVkZSAiVGV4dENvbnRyb2xJbm5lckVsZW1l bnRzLmgiCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApAQCAtNzksNyArODAsMTYgQEAgYm9vbCBS ZW5kZXJJbnB1dFNwZWVjaDo6cGFpbnRJbnB1dEZpZWxkU3BlZWNoQnV0dG9uKFJlbmRlck9iamVj dCogb2JqZWN0LCBjb25zdAogICAgIGJ1dHRvblJlY3QubW92ZShyZWN0LngoKSwgcmVjdC55KCkp OwogCiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlTm9y bWFsLCAoSW1hZ2U6OmxvYWRQbGF0Zm9ybVJlc291cmNlKCJpbnB1dFNwZWVjaCIpKSk7Ci0gICAg cGFpbnRJbmZvLmNvbnRleHQtPmRyYXdJbWFnZShpbWFnZVN0YXRlTm9ybWFsLmdldCgpLCBvYmpl Y3QtPnN0eWxlKCktPmNvbG9yU3BhY2UoKSwgYnV0dG9uUmVjdCk7CisgICAgREVGSU5FX1NUQVRJ Q19MT0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlUmVjb3JkaW5nLCAoSW1hZ2U6OmxvYWRQ bGF0Zm9ybVJlc291cmNlKCJpbnB1dFNwZWVjaFJlY29yZGluZyIpKSk7CisgICAgREVGSU5FX1NU QVRJQ19MT0NBTChSZWZQdHI8SW1hZ2U+LCBpbWFnZVN0YXRlV2FpdGluZywgKEltYWdlOjpsb2Fk UGxhdGZvcm1SZXNvdXJjZSgiaW5wdXRTcGVlY2hXYWl0aW5nIikpKTsKKworICAgIElucHV0Rmll bGRTcGVlY2hCdXR0b25FbGVtZW50KiBzcGVlY2hCdXR0b24gPSByZWludGVycHJldF9jYXN0PElu cHV0RmllbGRTcGVlY2hCdXR0b25FbGVtZW50Kj4ob2JqZWN0LT5ub2RlKCkpOworICAgIEltYWdl KiBpbWFnZSA9IGltYWdlU3RhdGVOb3JtYWwuZ2V0KCk7CisgICAgaWYgKHNwZWVjaEJ1dHRvbi0+ c3RhdGUoKSA9PSBJbnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxlbWVudDo6UmVjb3JkaW5nKQorICAg ICAgICBpbWFnZSA9IGltYWdlU3RhdGVSZWNvcmRpbmcuZ2V0KCk7CisgICAgZWxzZSBpZiAoc3Bl ZWNoQnV0dG9uLT5zdGF0ZSgpID09IElucHV0RmllbGRTcGVlY2hCdXR0b25FbGVtZW50OjpSZWNv Z25pemluZykKKyAgICAgICAgaW1hZ2UgPSBpbWFnZVN0YXRlV2FpdGluZy5nZXQoKTsKKyAgICBw YWludEluZm8uY29udGV4dC0+ZHJhd0ltYWdlKGltYWdlLCBvYmplY3QtPnN0eWxlKCktPmNvbG9y U3BhY2UoKSwgYnV0dG9uUmVjdCk7CiAKICAgICByZXR1cm4gZmFsc2U7CiB9CmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuY3BwIGIvV2ViQ29y ZS9yZW5kZXJpbmcvVGV4dENvbnRyb2xJbm5lckVsZW1lbnRzLmNwcAppbmRleCBjZjBlODY0ODY1 MmZlZDNmMGQzMDQ3NTUzYTJhOGI5ZWFkMmI3YjIwLi5mNTMyMTAxMjk5OTUyZjQ0ZDkzNjI4NzUw OGZmZmRmMDY0N2QwYWY1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29udHJv bElubmVyRWxlbWVudHMuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5u ZXJFbGVtZW50cy5jcHAKQEAgLTM0NSw2ICszNDUsNyBAQCB2b2lkIFNwaW5CdXR0b25FbGVtZW50 OjpzZXRIb3ZlcmVkKGJvb2wgZmxhZykKIGlubGluZSBJbnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxl bWVudDo6SW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQoTm9kZSogc2hhZG93UGFyZW50KQog ICAgIDogVGV4dENvbnRyb2xJbm5lckVsZW1lbnQoc2hhZG93UGFyZW50LT5kb2N1bWVudCgpLCBz aGFkb3dQYXJlbnQpCiAgICAgLCBtX2NhcHR1cmluZyhmYWxzZSkKKyAgICAsIG1fc3RhdGUoSWRs ZSkKIHsKIH0KIApAQCAtMzgzLDcgKzM4NCwxOCBAQCB2b2lkIElucHV0RmllbGRTcGVlY2hCdXR0 b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKICAgICB9CiAKICAg ICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkuY2xpY2tFdmVudCkgewotICAgICAg ICBzcGVlY2hJbnB1dCgpLT5zdGFydFJlY29nbml0aW9uKHRoaXMpOworICAgICAgICBzd2l0Y2gg KG1fc3RhdGUpIHsKKyAgICAgICAgY2FzZSBJZGxlOgorICAgICAgICAgICAgaWYgKHNwZWVjaElu cHV0KCktPnN0YXJ0UmVjb2duaXRpb24odGhpcykpCisgICAgICAgICAgICAgICAgc2V0U3RhdGUo UmVjb3JkaW5nKTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIFJlY29yZGluZzoK KyAgICAgICAgICAgIHNwZWVjaElucHV0KCktPnN0b3BSZWNvcmRpbmcoKTsKKyAgICAgICAgICAg IGJyZWFrOworICAgICAgICBjYXNlIFJlY29nbml6aW5nOgorICAgICAgICAgICAgLy8gTm90aGlu ZyB0byBkbyBoZXJlLCB3ZSB3aWxsIGNvbnRpbnVlIHRvIHdhaXQgZm9yIHJlc3VsdHMuCisgICAg ICAgICAgICBicmVhazsKKyAgICAgICAgfQogICAgICAgICBldmVudC0+c2V0RGVmYXVsdEhhbmRs ZWQoKTsKICAgICB9CiAKQEAgLTM5MSw2ICs0MDMsMTQgQEAgdm9pZCBJbnB1dEZpZWxkU3BlZWNo QnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxlcihFdmVudCogZXZlbnQpCiAgICAgICAg IEhUTUxEaXZFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKGV2ZW50KTsKIH0KIAordm9pZCBJ bnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxlbWVudDo6c2V0U3RhdGUoU3BlZWNoSW5wdXRTdGF0ZSBz dGF0ZSkKK3sKKyAgICBpZiAobV9zdGF0ZSAhPSBzdGF0ZSkgeworICAgICAgICBtX3N0YXRlID0g c3RhdGU7CisgICAgICAgIHNoYWRvd0FuY2VzdG9yTm9kZSgpLT5yZW5kZXJlcigpLT5yZXBhaW50 KCk7CisgICAgfQorfQorCiBTcGVlY2hJbnB1dCogSW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1l bnQ6OnNwZWVjaElucHV0KCkKIHsKICAgICByZXR1cm4gZG9jdW1lbnQoKS0+cGFnZSgpLT5zcGVl Y2hJbnB1dCgpOwpAQCAtMzk4LDEzICs0MTgsMTIgQEAgU3BlZWNoSW5wdXQqIElucHV0RmllbGRT cGVlY2hCdXR0b25FbGVtZW50OjpzcGVlY2hJbnB1dCgpCiAKIHZvaWQgSW5wdXRGaWVsZFNwZWVj aEJ1dHRvbkVsZW1lbnQ6OmRpZENvbXBsZXRlUmVjb3JkaW5nKCkKIHsKLSAgICAvLyBGSVhNRTog QWRkIFVJIGZlZWRiYWNrIGhlcmUgdG8gaW5kaWNhdGUgdGhhdCBhdWRpbyByZWNvcmRpbmcgc3Rv cHBlZCBhbmQgcmVjb2duaXRpb24gaXMKLSAgICAvLyBpbiBwcm9ncmVzcy4KKyAgICBzZXRTdGF0 ZShSZWNvZ25pemluZyk7CiB9CiAKIHZvaWQgSW5wdXRGaWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQ6 OmRpZENvbXBsZXRlUmVjb2duaXRpb24oKQogewotICAgIC8vIEZJWE1FOiBBZGQgVUkgZmVlZGJh Y2sgaGVyZSB0byBpbmRpY2F0ZSB0aGF0IGF1ZGlvIHJlY29nbml0aW9uIGhhcyBlbmRlZC4KKyAg ICBzZXRTdGF0ZShJZGxlKTsKIH0KIAogdm9pZCBJbnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxlbWVu dDo6c2V0UmVjb2duaXRpb25SZXN1bHQoY29uc3QgU3RyaW5nJiByZXN1bHQpCmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0Q29udHJvbElubmVyRWxlbWVudHMuaCBiL1dlYkNvcmUv cmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5oCmluZGV4IDI4NTliZDUwYmNkMmI2 Y2U5ODRkNzUzODg5Y2NjOTZlNDVhMTljYTcuLmU3ZWU5OGY1MTViYWQ5ZTZhYmEzNjYyYjM2OWFi OTJhMDM2ZjY1Y2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5u ZXJFbGVtZW50cy5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRDb250cm9sSW5uZXJFbGVt ZW50cy5oCkBAIC0xMTksMTAgKzExOSwxNyBAQCBjbGFzcyBJbnB1dEZpZWxkU3BlZWNoQnV0dG9u RWxlbWVudAogICAgIDogcHVibGljIFRleHRDb250cm9sSW5uZXJFbGVtZW50LAogICAgICAgcHVi bGljIFNwZWVjaElucHV0TGlzdGVuZXIgewogcHVibGljOgorICAgIGVudW0gU3BlZWNoSW5wdXRT dGF0ZSB7CisgICAgICAgIElkbGUsCisgICAgICAgIFJlY29yZGluZywKKyAgICAgICAgUmVjb2du aXppbmcsCisgICAgfTsKKwogICAgIHN0YXRpYyBQYXNzUmVmUHRyPElucHV0RmllbGRTcGVlY2hC dXR0b25FbGVtZW50PiBjcmVhdGUoTm9kZSopOwogCiAgICAgdmlydHVhbCB2b2lkIGRldGFjaCgp OwogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7CisgICAgU3Bl ZWNoSW5wdXRTdGF0ZSBzdGF0ZSgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhdGU7IH0KIAogICAgIC8v IFNwZWVjaElucHV0TGlzdGVuZXIgbWV0aG9kcy4KICAgICB2b2lkIGRpZENvbXBsZXRlUmVjb3Jk aW5nKCk7CkBAIC0xMzIsOCArMTM5LDEwIEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgSW5wdXRG aWVsZFNwZWVjaEJ1dHRvbkVsZW1lbnQoTm9kZSopOwogICAgIFNwZWVjaElucHV0KiBzcGVlY2hJ bnB1dCgpOworICAgIHZvaWQgc2V0U3RhdGUoU3BlZWNoSW5wdXRTdGF0ZSBzdGF0ZSk7CiAKICAg ICBib29sIG1fY2FwdHVyaW5nOworICAgIFNwZWVjaElucHV0U3RhdGUgbV9zdGF0ZTsKIH07CiAK ICNlbmRpZiAvLyBFTkFCTEUoSU5QVVRfU1BFRUNIKQo=