43856 2010-08-11 09:16:53 -0700 Perl warnings when running commit-log-editor 2010-08-11 13:01:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates darin eric hyatt tonikitoo oldest_to_newest 263275 0 dbates 2010-08-11 09:16:53 -0700 Following the patch for Bug #40548 (committed in changeset 65148 <http://trac.webkit.org/changeset/65148>), when running the commit-log-editor Perl complains with the following warnings: Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85. Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86. Bareword "true" not allowed while "strict subs" in use at ./commit-log-editor line 68. Bareword "false" not allowed while "strict subs" in use at ./commit-log-editor line 73. Bareword "false" not allowed while "strict subs" in use at ./commit-log-editor line 80. Bareword "false" not allowed while "strict subs" in use at ./commit-log-editor line 87. Execution of ./commit-log-editor aborted due to compilation errors. 263279 1 64123 dbates 2010-08-11 09:22:22 -0700 Created attachment 64123 Patch Perl doesn't have symbolic names for True/False. Instead, we should use boolean values. Moreover, the variable installedEditorApplication is unused. It looks like it should be renamed builtEditorApplication so that it uses the existing machinery to set the editor. 263375 2 hyatt 2010-08-11 12:08:32 -0700 This patch addresses some of the errors, but not these: "Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85. Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86." I still can't commit. Help! 263408 3 dbates 2010-08-11 12:57:46 -0700 Committed in changeset 65179 <http://trac.webkit.org/changeset/65179>. 263409 4 64123 dbates 2010-08-11 12:58:42 -0700 Comment on attachment 64123 Patch Clearing commit-queue flag since I committed this by hand because the queue was slow today :-( 263412 5 dbates 2010-08-11 13:01:11 -0700 (In reply to comment #2) > This patch addresses some of the errors, but not these: > > "Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 85. > Global symbol "$builtEditorApplication" requires explicit package name at ./commit-log-editor line 86." > > I still can't commit. Help! Spoke with David Hyatt on IRC. He inadvertently did not copy over the change to rename the variable installedEditorApplication to builtEditorApplication (included in this patch). He confirmed that his change resolves the "Global symbol" warnings. 64123 2010-08-11 09:22:22 -0700 2010-08-11 12:58:42 -0700 Patch Bug43856.patch text/plain 2258 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY1MTYwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMTEgIERhbmllbCBCYXRlcyAgPGRi YXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFBlcmwgd2FybmluZ3Mgd2hlbiBydW5uaW5nIGNvbW1pdC1sb2ctZWRpdG9yCisgICAg ICAgIEJ1ZyAjNDM4NTYKKworICAgICAgICBGaXhlcyBQZXJsIHdhcm5pbmdzIGludHJvZHVjZWQg YnkgdGhlIHBhdGNoIGZvciBCdWcgIzQwNTQ4LgorCisgICAgICAgIFBlcmwgZG9lc24ndCBoYXZl IHN5bWJvbGljIG5hbWVzIGZvciBUcnVlL0ZhbHNlLiBJbnN0ZWFkLCB3ZQorICAgICAgICBzaG91 bGQgdXNlIGJvb2xlYW4gdmFsdWVzLiBNb3Jlb3ZlciwgdGhlIHZhcmlhYmxlIGluc3RhbGxlZEVk aXRvckFwcGxpY2F0aW9uCisgICAgICAgIGlzIG5vdCBiZSB1c2VkIGFuZCBzaG91bGQgYmUgcmVu YW1lZCBidWlsdEVkaXRvckFwcGxpY2F0aW9uIHNvIHRoYXQgaXQKKyAgICAgICAgdXNlcyB0aGUg ZXhpc3RpbmcgbWFjaGluZXJ5IHRvIHNldCB0aGUgY29tbWl0IGxvZyBlZGl0b3IgYXBwbGljYXRp b24uCisKKyAgICAgICAgKiBTY3JpcHRzL2NvbW1pdC1sb2ctZWRpdG9yOgorCiAyMDEwLTA4LTEx ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL2NvbW1pdC1s b2ctZWRpdG9yCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvY29tbWl0LWxvZy1l ZGl0b3IJKHJldmlzaW9uIDY1MTU4KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9jb21taXQtbG9n LWVkaXRvcgkod29ya2luZyBjb3B5KQpAQCAtNjUsMjYgKzY1LDI2IEBAIG15ICRlZGl0b3IgPSAk RU5We1NWTl9MT0dfRURJVE9SfTsKICRlZGl0b3IgPSAkRU5We0NWU19MT0dfRURJVE9SfSBpZiAh JGVkaXRvcjsKICRlZGl0b3IgPSAiIiBpZiBpc0NvbW1pdExvZ0VkaXRvcigkZWRpdG9yKTsKIAot bXkgJHNwbGl0RWRpdG9yID0gdHJ1ZTsKK215ICRzcGxpdEVkaXRvciA9IDE7CiBpZiAoISRlZGl0 b3IpIHsKICAgICBteSAkYnVpbHRFZGl0b3JBcHBsaWNhdGlvbiA9ICIkYmFzZURpci9SZWxlYXNl L0NvbW1pdCBMb2cgRWRpdG9yLmFwcC9Db250ZW50cy9NYWNPUy9Db21taXQgTG9nIEVkaXRvciI7 CiAgICAgaWYgKC14ICRidWlsdEVkaXRvckFwcGxpY2F0aW9uKSB7CiAgICAgICAgICRlZGl0b3Ig PSAkYnVpbHRFZGl0b3JBcHBsaWNhdGlvbjsKLSAgICAgICAgJHNwbGl0RWRpdG9yID0gZmFsc2U7 CisgICAgICAgICRzcGxpdEVkaXRvciA9IDA7CiAgICAgfQogfQogaWYgKCEkZWRpdG9yKSB7CiAg ICAgbXkgJGJ1aWx0RWRpdG9yQXBwbGljYXRpb24gPSAiJGJhc2VEaXIvRGVidWcvQ29tbWl0IExv ZyBFZGl0b3IuYXBwL0NvbnRlbnRzL01hY09TL0NvbW1pdCBMb2cgRWRpdG9yIjsKICAgICBpZiAo LXggJGJ1aWx0RWRpdG9yQXBwbGljYXRpb24pIHsKICAgICAgICAgJGVkaXRvciA9ICRidWlsdEVk aXRvckFwcGxpY2F0aW9uOwotICAgICAgICAkc3BsaXRFZGl0b3IgPSBmYWxzZTsKKyAgICAgICAg JHNwbGl0RWRpdG9yID0gMDsKICAgICB9CiB9CiBpZiAoISRlZGl0b3IpIHsKLSAgICBteSAkaW5z dGFsbGVkRWRpdG9yQXBwbGljYXRpb24gPSAiJEVOVntIT01FfS9BcHBsaWNhdGlvbnMvQ29tbWl0 IExvZyBFZGl0b3IuYXBwL0NvbnRlbnRzL01hY09TL0NvbW1pdCBMb2cgRWRpdG9yIjsKKyAgICBt eSAkYnVpbHRFZGl0b3JBcHBsaWNhdGlvbiA9ICIkRU5We0hPTUV9L0FwcGxpY2F0aW9ucy9Db21t aXQgTG9nIEVkaXRvci5hcHAvQ29udGVudHMvTWFjT1MvQ29tbWl0IExvZyBFZGl0b3IiOwogICAg IGlmICgteCAkYnVpbHRFZGl0b3JBcHBsaWNhdGlvbikgewogICAgICAgICAkZWRpdG9yID0gJGJ1 aWx0RWRpdG9yQXBwbGljYXRpb247Ci0gICAgICAgICRzcGxpdEVkaXRvciA9IGZhbHNlOworICAg ICAgICAkc3BsaXRFZGl0b3IgPSAwOwogICAgIH0KIH0KIAo=