43853 2010-08-11 07:44:33 -0700 [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken 2010-08-24 07:09:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 43851 1 tonikitoo tonikitoo hausmann oldest_to_newest 263253 0 tonikitoo 2010-08-11 07:44:33 -0700 When bug 43851 ([Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken) gets fixed, we also have to fix the way animatedRotation and animatedYRotation slots of WebViewGraphicsBased get connected and triggerred. Patch coming. 263255 1 64114 tonikitoo 2010-08-11 07:52:44 -0700 Created attachment 64114 (committed with r65165, r=ariya) patch v1 LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly. It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected to slots at all. Patch addresses the problem. 263273 2 tonikitoo 2010-08-11 09:09:25 -0700 Wrongly pressed a button. Reopening... 263336 3 64114 ariya.hidayat 2010-08-11 10:42:33 -0700 Comment on attachment 64114 (committed with r65165, r=ariya) patch v1 LGMT with the change to qobject_cast. 263352 4 64114 tonikitoo 2010-08-11 11:30:59 -0700 Comment on attachment 64114 (committed with r65165, r=ariya) patch v1 Clearing flags on attachment: 64114 Committed r65165: <http://trac.webkit.org/changeset/65165> 263354 5 tonikitoo 2010-08-11 11:31:25 -0700 (In reply to comment #3) > (From update of attachment 64114 [details]) > LGMT with the change to qobject_cast. Done. Thank you! 263717 6 hausmann 2010-08-12 04:42:32 -0700 Revision r65165 cherry-picked into qtwebkit-2.1 with commit 2b177d4a8faf94f5ff4326cb12db242af1230253 64114 2010-08-11 07:52:44 -0700 2010-08-11 11:30:59 -0700 (committed with r65165, r=ariya) patch v1 0001-2010-08-11-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 4762 tonikitoo RnJvbSA5NGE0N2Q2MTUxNjUwMjM2NDllMzYwZGMwZDkxMzk0ODQ1NTVlOGMyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCAxMSBBdWcgMjAxMCAxMDo1MToxNCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDgtMTEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gUXRUZXN0QnJvd3Nlcjog YWZ0ZXIgc3dpdGNoaW5nIGJldHdlZW4gUVdlYlZpZXcgYW5kIFFHcmFwaGljc1dlYlZpZXcsIHJv dGF0aW9uIGFjdGlvbnMgZ2V0IGJyb2tlbgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00Mzg1MwoKICAgICAgICBMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hy b21lIGlzIGNvbm5lY3RpbmcgbWVudSBpdGVucyB0byBXZWJWaWV3R3JhcGhpY3NCYXNlZCdzIHNs b3RzIGRpcmVjdGx5LgogICAgICAgIEl0IGJlaGF2aW9ycyBiYWRseSB3aGVuIHVzZXIgbGF1bmNo ZXMgdGhlIFF0VGVzdEJyb3dzZXIgaW4gUVdlYlZpZXcgbW9kZSwgc2luY2UgdGhlbiBzd2l0Y2hp bmcgdG8KICAgICAgICBRR3JhcGhpY3NXZWJWaWV3IG1vZGUsIGNyZWF0ZUNocm9tZSBpcyBub3Qg Y2FsbGVkIGFnYWluLCBhbmQgbWVudSBpdGVtcyBlbmQgdXAgbm90IGdldHRpbmcgY29ubmVjdGVk CiAgICAgICAgdG8gc2xvdHMgYXQgYWxsLgoKICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNo ZXJ3aW5kb3cuY3BwOgogICAgICAgIChMYXVuY2hlcldpbmRvdzo6Y3JlYXRlQ2hyb21lKToKICAg ICAgICAoTGF1bmNoZXJXaW5kb3c6OmFuaW1hdGVkRmxpcCk6CiAgICAgICAgKExhdW5jaGVyV2lu ZG93OjphbmltYXRlZFlGbGlwKToKICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5k b3cuaDoKLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICB8 ICAgMTggKysrKysrKysrKysrKysrKysrCiBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5j aGVyd2luZG93LmNwcCB8ICAgMTcgKysrKysrKysrKystLS0tLS0KIFdlYktpdFRvb2xzL1F0VGVz dEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaCAgIHwgICAgMiArKwogMyBmaWxlcyBjaGFuZ2VkLCAz MSBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCBiNDEwZjM3Li5kZmQ0ZGZj IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hh bmdlTG9nCkBAIC0yLDYgKzIsMjQgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KIAorICAgICAgICBbUXRdIFF0VGVzdEJyb3dzZXI6IGFmdGVyIHN3aXRjaGluZyBiZXR3 ZWVuIFFXZWJWaWV3IGFuZCBRR3JhcGhpY3NXZWJWaWV3LCByb3RhdGlvbiBhY3Rpb25zIGdldCBi cm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQz ODUzCisKKyAgICAgICAgTGF1bmNoZXJXaW5kb3c6OmNyZWF0ZUNocm9tZSBpcyBjb25uZWN0aW5n IG1lbnUgaXRlbnMgdG8gV2ViVmlld0dyYXBoaWNzQmFzZWQncyBzbG90cyBkaXJlY3RseS4KKyAg ICAgICAgSXQgYmVoYXZpb3JzIGJhZGx5IHdoZW4gdXNlciBsYXVuY2hlcyB0aGUgUXRUZXN0QnJv d3NlciBpbiBRV2ViVmlldyBtb2RlLCBzaW5jZSB0aGVuIHN3aXRjaGluZyB0bworICAgICAgICBR R3JhcGhpY3NXZWJWaWV3IG1vZGUsIGNyZWF0ZUNocm9tZSBpcyBub3QgY2FsbGVkIGFnYWluLCBh bmQgbWVudSBpdGVtcyBlbmQgdXAgbm90IGdldHRpbmcgY29ubmVjdGVkCisgICAgICAgIHRvIHNs b3RzIGF0IGFsbC4KKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuY3Bw OgorICAgICAgICAoTGF1bmNoZXJXaW5kb3c6OmNyZWF0ZUNocm9tZSk6CisgICAgICAgIChMYXVu Y2hlcldpbmRvdzo6YW5pbWF0ZWRGbGlwKToKKyAgICAgICAgKExhdW5jaGVyV2luZG93Ojphbmlt YXRlZFlGbGlwKToKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93Lmg6CisK KzIwMTAtMDgtMTEgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBbUXRdIFF0VGVzdEJy b3dzZXI6IHN3aXRjaGluZyBiZXR3ZWVuIFFXZWJWaWV3IGFuZCBRR3JhcGhpY3NXZWJWaWV3IG1v ZGVzIGlzIGJyb2tlbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDM4NTEKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVu Y2hlcndpbmRvdy5jcHAgYi9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93 LmNwcAppbmRleCA0MDE0Y2U5Li42Yjg1ZmVjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdFRl c3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAorKysgYi9XZWJLaXRUb29scy9RdFRlc3RCcm93 c2VyL2xhdW5jaGVyd2luZG93LmNwcApAQCAtMzM5LDE2ICszMzksMTIgQEAgdm9pZCBMYXVuY2hl cldpbmRvdzo6Y3JlYXRlQ2hyb21lKCkKICAgICBRQWN0aW9uKiBmbGlwQW5pbWF0ZWQgPSBncmFw aGljc1ZpZXdNZW51LT5hZGRBY3Rpb24oIkFuaW1hdGVkIEZsaXAiKTsKICAgICBmbGlwQW5pbWF0 ZWQtPmNvbm5lY3QodG9nZ2xlR3JhcGhpY3NWaWV3LCBTSUdOQUwodG9nZ2xlZChib29sKSksIFNM T1Qoc2V0RW5hYmxlZChib29sKSkpOwogICAgIGZsaXBBbmltYXRlZC0+c2V0RW5hYmxlZChpc0dy YXBoaWNzQmFzZWQoKSk7CisgICAgY29ubmVjdChmbGlwQW5pbWF0ZWQsIFNJR05BTCh0cmlnZ2Vy ZWQoKSksIFNMT1QoYW5pbWF0ZWRGbGlwKCkpKTsKIAogICAgIFFBY3Rpb24qIGZsaXBZQW5pbWF0 ZWQgPSBncmFwaGljc1ZpZXdNZW51LT5hZGRBY3Rpb24oIkFuaW1hdGVkIFktRmxpcCIpOwogICAg IGZsaXBZQW5pbWF0ZWQtPmNvbm5lY3QodG9nZ2xlR3JhcGhpY3NWaWV3LCBTSUdOQUwodG9nZ2xl ZChib29sKSksIFNMT1Qoc2V0RW5hYmxlZChib29sKSkpOwogICAgIGZsaXBZQW5pbWF0ZWQtPnNl dEVuYWJsZWQoaXNHcmFwaGljc0Jhc2VkKCkpOwotCi0gICAgaWYgKGlzR3JhcGhpY3NCYXNlZCgp KSB7Ci0gICAgICAgIFdlYlZpZXdHcmFwaGljc0Jhc2VkKiB2aWV3ID0gc3RhdGljX2Nhc3Q8V2Vi Vmlld0dyYXBoaWNzQmFzZWQqPihtX3ZpZXcpOwotICAgICAgICBjb25uZWN0KGZsaXBBbmltYXRl ZCwgU0lHTkFMKHRyaWdnZXJlZCgpKSwgdmlldywgU0xPVChhbmltYXRlZEZsaXAoKSkpOwotICAg ICAgICBjb25uZWN0KGZsaXBZQW5pbWF0ZWQsIFNJR05BTCh0cmlnZ2VyZWQoKSksIHZpZXcsIFNM T1QoYW5pbWF0ZWRZRmxpcCgpKSk7Ci0gICAgfQorICAgIGNvbm5lY3QoZmxpcFlBbmltYXRlZCwg U0lHTkFMKHRyaWdnZXJlZCgpKSwgU0xPVChhbmltYXRlZFlGbGlwKCkpKTsKIAogICAgIFFBY3Rp b24qIGNsb25lV2luZG93ID0gZ3JhcGhpY3NWaWV3TWVudS0+YWRkQWN0aW9uKCJDbG9uZSBXaW5k b3ciLCB0aGlzLCBTTE9UKGNsb25lV2luZG93KCkpKTsKICAgICBjbG9uZVdpbmRvdy0+Y29ubmVj dCh0b2dnbGVHcmFwaGljc1ZpZXcsIFNJR05BTCh0b2dnbGVkKGJvb2wpKSwgU0xPVChzZXRFbmFi bGVkKGJvb2wpKSk7CkBAIC02OTgsNiArNjk0LDE1IEBAIHZvaWQgTGF1bmNoZXJXaW5kb3c6OnRv Z2dsZVdlYkdMKGJvb2wgdG9nZ2xlKQogICAgIHBhZ2UoKS0+c2V0dGluZ3MoKS0+c2V0QXR0cmli dXRlKFFXZWJTZXR0aW5nczo6V2ViR0xFbmFibGVkLCB0b2dnbGUpOwogfQogCit2b2lkIExhdW5j aGVyV2luZG93OjphbmltYXRlZEZsaXAoKQoreworICAgIHN0YXRpY19jYXN0PFdlYlZpZXdHcmFw aGljc0Jhc2VkKj4obV92aWV3KS0+YW5pbWF0ZWRGbGlwKCk7Cit9CisKK3ZvaWQgTGF1bmNoZXJX aW5kb3c6OmFuaW1hdGVkWUZsaXAoKQoreworICAgIHN0YXRpY19jYXN0PFdlYlZpZXdHcmFwaGlj c0Jhc2VkKj4obV92aWV3KS0+YW5pbWF0ZWRZRmxpcCgpOworfQogdm9pZCBMYXVuY2hlcldpbmRv dzo6dG9nZ2xlU3BhdGlhbE5hdmlnYXRpb24oYm9vbCBiKQogewogICAgIHBhZ2UoKS0+c2V0dGlu Z3MoKS0+c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6U3BhdGlhbE5hdmlnYXRpb25FbmFibGVk LCBiKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5k b3cuaCBiL1dlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvbGF1bmNoZXJ3aW5kb3cuaAppbmRleCBh M2RiOGFkLi5mNGVmMTM5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xh dW5jaGVyd2luZG93LmgKKysrIGIvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndp bmRvdy5oCkBAIC0xNjcsNiArMTY3LDggQEAgcHJvdGVjdGVkIHNsb3RzOgogI2VuZGlmCiAKICAg ICB2b2lkIGNoYW5nZVZpZXdwb3J0VXBkYXRlTW9kZShpbnQgbW9kZSk7CisgICAgdm9pZCBhbmlt YXRlZEZsaXAoKTsKKyAgICB2b2lkIGFuaW1hdGVkWUZsaXAoKTsKICAgICB2b2lkIHNlbGVjdEVs ZW1lbnRzKCk7CiAgICAgdm9pZCBzaG93RlBTKGJvb2wgZW5hYmxlKTsKICAgICB2b2lkIHNob3dV c2VyQWdlbnREaWFsb2coKTsKLS0gCjEuNy4wLjQKCg==