4385 2005-08-11 04:19:47 -0700 DrawTest test viewer doesn't work with WebCore tests 2005-08-11 04:57:26 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P3 Enhancement --- 1 tobiaslidskog tobiaslidskog oldest_to_newest 16415 0 tobiaslidskog 2005-08-11 04:19:47 -0700 The test viewer in DrawTest is supposed to show the rendered svg next to a reference png image. Currently it doesn't handle the directory layout in WebCore where the reference images are stored next to the svg files. 16417 1 eric 2005-08-11 04:25:26 -0700 I agree. And tobias says he already has a fix, passing bug to him... 16418 2 3339 tobiaslidskog 2005-08-11 04:29:28 -0700 Created attachment 3339 Update imagePathForSVGPath: Update to handle case where png files are in the same directory as the svg files + minor code cleanup. More code rearranging could be done later. 16419 3 3339 tobiaslidskog 2005-08-11 04:41:26 -0700 Comment on attachment 3339 Update imagePathForSVGPath: Setting review flag 16420 4 3339 eric 2005-08-11 04:44:57 -0700 Comment on attachment 3339 Update imagePathForSVGPath: Looks fine to me. 3339 2005-08-11 04:29:28 -0700 2005-08-11 04:44:57 -0700 Update imagePathForSVGPath: 4385-patch.txt text/plain 3400 tobiaslidskog SW5kZXg6IERyYXdUZXN0L1Rlc3RDb250cm9sbGVyLm0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9yb290L1dlYktpdFRvb2xzL0RyYXdUZXN0L1Rlc3RDb250cm9sbGVyLm0sdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMQpkaWZmIC1wIC11IC1yMS4xIERyYXdUZXN0L1Rlc3RDb250cm9sbGVyLm0K LS0tIERyYXdUZXN0L1Rlc3RDb250cm9sbGVyLm0JMjkgSnVsIDIwMDUgMTk6MjA6MjAgLTAwMDAJ MS4xCisrKyBEcmF3VGVzdC9UZXN0Q29udHJvbGxlci5tCTExIEF1ZyAyMDA1IDA5OjA3OjM3IC0w MDAwCkBAIC0xNzIsMzMgKzE3Miw0MiBAQCBzdGF0aWMgVGVzdENvbnRyb2xsZXIgKl9fc2hhcmVk SW5zdGFuY2UgCiB7CiAgICAgW1tOU1dvcmtzcGFjZSBzaGFyZWRXb3Jrc3BhY2VdIG9wZW5GaWxl Oltfc2VsZWN0ZWRUZXN0IHN2Z1BhdGhdXTsKIH0KLSAgICAgCisKIC0gKE5TU3RyaW5nICopaW1h Z2VQYXRoRm9yU1ZHUGF0aDooTlNTdHJpbmcgKilzdmdQYXRoCiB7CiAgICAgLy8gZXZlbnR1YWxs eSB0aGlzIGNvZGUgd2lsbCBidWlsZCBhbiBhcnJheSBpbnN0ZWFkLi4uCiAgICAgCi0gICAgTlNT dHJpbmcgKnN2Z05hbWUgPSBbc3ZnUGF0aCBsYXN0UGF0aENvbXBvbmVudF07Ci0gICAgTlNTdHJp bmcgKnRlc3ROYW1lID0gW3N2Z05hbWUgc3RyaW5nQnlEZWxldGluZ1BhdGhFeHRlbnNpb25dOwot ICAgIE5TU3RyaW5nICppbWFnZU5hbWUgPSBbdGVzdE5hbWUgc3RyaW5nQnlBcHBlbmRpbmdQYXRo RXh0ZW5zaW9uOkAicG5nIl07CiAgICAgTlNTdHJpbmcgKmN1cnJlbnREaXJlY3RvcnkgPSBbc2Vs ZiBjdXJyZW50UGF0aF07CiAgICAgTlNTdHJpbmcgKnBhcmVudERpcmVjdG9yeSA9IFtjdXJyZW50 RGlyZWN0b3J5IHN0cmluZ0J5RGVsZXRpbmdMYXN0UGF0aENvbXBvbmVudF07CiAgICAgCi0gICAg Ly8gZmlyc3QgbG9vayBmb3IgLi4vcG5nL25hbWUucG5nIC0tIFNWRyAxLjEgYmFzZWxpbmVzCi0g ICAgTlNTdHJpbmcgKmltYWdlRGlyZWN0b3J5ID0gW3BhcmVudERpcmVjdG9yeSBzdHJpbmdCeUFw cGVuZGluZ1BhdGhDb21wb25lbnQ6QCJwbmciXTsKLSAgICBOU1N0cmluZyAqZnVsbEltYWdlTmFt ZSA9IFtAImZ1bGwtIiBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzppbWFnZU5hbWVdOwotICAgIC8v IFRoZSBTVkcgMS4xIHNwZWMgaGFzIHZhcmlvdXMgZGlmZmVybmV0IHBuZ3MsIHdlIHNob3VsZCBh bGxvdyB0aGUKKyAgICBOU1N0cmluZyAqdGVzdE5hbWUgPSBbW3N2Z1BhdGggbGFzdFBhdGhDb21w b25lbnRdIHN0cmluZ0J5RGVsZXRpbmdQYXRoRXh0ZW5zaW9uXTsKKyAgICBOU1N0cmluZyAqaW1h Z2VOYW1lLCAqaW1hZ2VEaXJlY3RvcnksICppbWFnZVBhdGg7CisgICAgCisgICAgCisgICAgLy8g Zmlyc3QgbG9vayBpbiAuLi9wbmcvdGVzdC5wbmcgLS0gU1ZHIDEuMSBiYXNlbGluZXMKKyAgICAv LyBUaGUgU1ZHIDEuMSBzcGVjIGhhcyB2YXJpb3VzIGRpZmZlcmVudCBwbmdzLCB3ZSBzaG91bGQg YWxsb3cgdGhlCiAgICAgLy8gdGVzdGVyIHRvIGNob29zZS4uLgotICAgIE5TU3RyaW5nICppbWFn ZVBhdGggPSBbaW1hZ2VEaXJlY3Rvcnkgc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OmZ1 bGxJbWFnZU5hbWVdOworICAgIGltYWdlTmFtZSA9IFtbQCJmdWxsLSIgc3RyaW5nQnlBcHBlbmRp bmdTdHJpbmc6dGVzdE5hbWVdIHN0cmluZ0J5QXBwZW5kaW5nUGF0aEV4dGVuc2lvbjpAInBuZyJd OworICAgIGltYWdlRGlyZWN0b3J5ID0gW3BhcmVudERpcmVjdG9yeSBzdHJpbmdCeUFwcGVuZGlu Z1BhdGhDb21wb25lbnQ6QCJwbmciXTsKKyAgICBpbWFnZVBhdGggPSBbaW1hZ2VEaXJlY3Rvcnkg c3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OmltYWdlTmFtZV07CiAgICAgaWYgKFtbTlNG aWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gZmlsZUV4aXN0c0F0UGF0aDppbWFnZVBhdGhdKSBy ZXR1cm4gaW1hZ2VQYXRoOwogICAgIAogICAgIC8vIHRoZW4gbG9vayBmb3IgLi4vbmFtZS5wbmcg LS0gb3BlbmNsaXBhcnQub3JnCi0gICAgaW1hZ2VQYXRoID0gW2N1cnJlbnREaXJlY3Rvcnkgc3Ry aW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OmltYWdlTmFtZV07CisgICAgaW1hZ2VOYW1lID0g W3Rlc3ROYW1lIHN0cmluZ0J5QXBwZW5kaW5nUGF0aEV4dGVuc2lvbjpAInBuZyJdOworICAgIGlt YWdlRGlyZWN0b3J5ID0gcGFyZW50RGlyZWN0b3J5OworICAgIGltYWdlUGF0aCA9IFtpbWFnZURp cmVjdG9yeSBzdHJpbmdCeUFwcGVuZGluZ1BhdGhDb21wb25lbnQ6aW1hZ2VOYW1lXTsKKyAgICBp ZiAoW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2VyXSBmaWxlRXhpc3RzQXRQYXRoOmltYWdl UGF0aF0pIHJldHVybiBpbWFnZVBhdGg7CisgICAgCisgICAgLy8gdGhlbiBsb29rIGZvciAuL25h bWUtdzNjLnBuZyAtLSBXZWJDb3JlIHRlc3RzCisgICAgaW1hZ2VOYW1lID0gW1t0ZXN0TmFtZSBz dHJpbmdCeUFwcGVuZGluZ1N0cmluZzpAIi13M2MiXSBzdHJpbmdCeUFwcGVuZGluZ1BhdGhFeHRl bnNpb246QCJwbmciXTsKKyAgICBpbWFnZURpcmVjdG9yeSA9IGN1cnJlbnREaXJlY3Rvcnk7Cisg ICAgaW1hZ2VQYXRoID0gW2ltYWdlRGlyZWN0b3J5IHN0cmluZ0J5QXBwZW5kaW5nUGF0aENvbXBv bmVudDppbWFnZU5hbWVdOwogICAgIGlmIChbW05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJd IGZpbGVFeGlzdHNBdFBhdGg6aW1hZ2VQYXRoXSkgcmV0dXJuIGltYWdlUGF0aDsKICAgICAKICAg ICAvLyBmaW5hbGx5IHRyeSBuYW1lLWJhc2VsaW5lLnBuZyAtLSBrc3ZnIHJlZ3Jlc3Npb24gYmFz ZWxpbmVzCi0gICAgdGVzdE5hbWUgPSBbdGVzdE5hbWUgc3RyaW5nQnlBcHBlbmRpbmdTdHJpbmc6 QCItYmFzZWxpbmUiXTsKLSAgICBpbWFnZU5hbWUgPSBbdGVzdE5hbWUgc3RyaW5nQnlBcHBlbmRp bmdQYXRoRXh0ZW5zaW9uOkAicG5nIl07Ci0gICAgaW1hZ2VQYXRoID0gW2N1cnJlbnREaXJlY3Rv cnkgc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OmltYWdlTmFtZV07CisgICAgaW1hZ2VO YW1lID0gW1t0ZXN0TmFtZSBzdHJpbmdCeUFwcGVuZGluZ1N0cmluZzpAIi1iYXNlbGluZSJdIHN0 cmluZ0J5QXBwZW5kaW5nUGF0aEV4dGVuc2lvbjpAInBuZyJdOworICAgIGltYWdlRGlyZWN0b3J5 ID0gY3VycmVudERpcmVjdG9yeTsKKyAgICBpbWFnZVBhdGggPSBbaW1hZ2VEaXJlY3Rvcnkgc3Ry aW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OmltYWdlTmFtZV07CiAgICAgaWYgKFtbTlNGaWxl TWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gZmlsZUV4aXN0c0F0UGF0aDppbWFnZVBhdGhdKSByZXR1 cm4gaW1hZ2VQYXRoOwogICAgIAogICAgIHJldHVybiBuaWw7Cg==