43846 2010-08-11 05:26:05 -0700 Web Inspector: apply correct fix to storage panel status bar buttons. 2011-06-18 02:34:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik yurys oldest_to_newest 263194 0 pfeldman 2010-08-11 05:26:05 -0700 Patch to follow. 263195 1 64102 pfeldman 2010-08-11 05:28:04 -0700 Created attachment 64102 [PATCH] Proposed fix. 263292 2 joepeck 2010-08-11 09:39:24 -0700 This is correct. This was one of the fixes I had in my patches on: <http://webkit.org/b/41805> Web Inspector: Migrate Storage Panel to InspectorFrontend2 But those got dated too quickly and I never caught up. Thanks for fixing this. 324795 3 64102 eric 2010-12-20 22:29:57 -0800 Comment on attachment 64102 [PATCH] Proposed fix. I doubt this will land cleanly, but we can try. I assuem this might have already been landed. In either case, this bug should be closed. 324847 4 64102 commit-queue 2010-12-20 23:04:41 -0800 Comment on attachment 64102 [PATCH] Proposed fix. Rejecting attachment 64102 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--non-interactive', 64102]" exit_code: 2 Last 500 characters of output: used the wrong -p or --strip option? The text leading up to this was: -------------------------- |Index: WebCore/inspector/front-end/StoragePanel.js |index a0d0c50..2d17989 100644 |--- WebCore/inspector/front-end/StoragePanel.js |+++ WebCore/inspector/front-end/StoragePanel.js -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Yury Semikhatsky', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7249087 423064 5 64102 loislo 2011-06-18 00:23:47 -0700 Comment on attachment 64102 [PATCH] Proposed fix. was landed as r65149 64102 2010-08-11 05:28:04 -0700 2011-06-18 00:23:47 -0700 [PATCH] Proposed fix. storage_fix text/plain 1871 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGViZmMzNS4uNzZiM2RkZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0xMSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBhcHBseSBjb3JyZWN0IGZpeCB0byBz dG9yYWdlIHBhbmVsIHN0YXR1cyBiYXIgYnV0dG9ucy4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM4NDYKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvRGF0YWJhc2VUYWJsZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0 YWJhc2VUYWJsZVZpZXcucHJvdG90eXBlLmdldCBzdGF0dXNCYXJJdGVtcyk6CisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9TdG9yYWdlUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0 b3IuU3RvcmFnZVBhbmVsLnByb3RvdHlwZS5fZ2VuZXJpY1ZpZXdTZXR1cCk6CisKIDIwMTAtMDgt MTEgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEp1c3RpbiBHYXJjaWEuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRGF0YWJhc2VUYWJsZVZpZXcuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv RGF0YWJhc2VUYWJsZVZpZXcuanMKaW5kZXggOWU2ZDM3NC4uNTQ0MDc2MyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RhdGFiYXNlVGFibGVWaWV3LmpzCisrKyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9EYXRhYmFzZVRhYmxlVmlldy5qcwpAQCAtNDYsNyAr NDYsNyBAQCBXZWJJbnNwZWN0b3IuRGF0YWJhc2VUYWJsZVZpZXcucHJvdG90eXBlID0gewogCiAg ICAgZ2V0IHN0YXR1c0Jhckl0ZW1zKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBbdGhpcy5yZWZy ZXNoQnV0dG9uXTsKKyAgICAgICAgcmV0dXJuIFt0aGlzLnJlZnJlc2hCdXR0b24uZWxlbWVudF07 CiAgICAgfSwKIAogICAgIHVwZGF0ZTogZnVuY3Rpb24oKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQYW5lbC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9TdG9yYWdlUGFuZWwuanMKaW5kZXggYTBkMGM1MC4uMmQxNzk4OSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQYW5lbC5qcworKysgYi9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3RvcmFnZVBhbmVsLmpzCkBAIC0yNTksNyArMjU5LDcg QEAgV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMu c3RvcmFnZVZpZXdTdGF0dXNCYXJJdGVtc0NvbnRhaW5lci5yZW1vdmVDaGlsZHJlbigpOwogICAg ICAgICB2YXIgc3RhdHVzQmFySXRlbXMgPSB2aWV3LnN0YXR1c0Jhckl0ZW1zIHx8IFtdOwogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHN0YXR1c0Jhckl0ZW1zLmxlbmd0aDsgKytpKQotICAg ICAgICAgICAgdGhpcy5zdG9yYWdlVmlld1N0YXR1c0Jhckl0ZW1zQ29udGFpbmVyLmFwcGVuZENo aWxkKHN0YXR1c0Jhckl0ZW1zW2ldLmVsZW1lbnQpOworICAgICAgICAgICAgdGhpcy5zdG9yYWdl Vmlld1N0YXR1c0Jhckl0ZW1zQ29udGFpbmVyLmFwcGVuZENoaWxkKHN0YXR1c0Jhckl0ZW1zW2ld KTsKICAgICB9LAogCiAgICAgY2xvc2VWaXNpYmxlVmlldzogZnVuY3Rpb24oKQo=