43841 2010-08-11 03:02:13 -0700 SegmentedVector::operator== typo 2011-08-12 16:10:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 andrey154 webkit-unassigned barraclough darin ggaren oldest_to_newest 263145 0 andrey154 2010-08-11 03:02:13 -0700 WTF::SegmentedVector::operator== (in file webkit\JavaScriptCore\wtf\SegmentedVector.h:70) has typo: bool operator==(const Iterator& other) const { return (m_index == other.m_index && m_segment = other.m_segment && &m_vector == &other.m_vector); // HERE: m_segment _=_ other.m_segment } This should be: bool operator==(const Iterator& other) const { return (m_index == other.m_index && m_segment == other.m_segment && &m_vector == &other.m_vector); } Because normaly operator== should be ! operator!=. bool operator!=(const Iterator& other) const { return (m_index != other.m_index || m_segment != other.m_segment || &m_vector != &other.m_vector); // NOTE: m_segment _!=_ other.m_segment } I don't know consequences of this. Kind regards, Andrey 263269 1 darin 2010-08-11 08:58:23 -0700 Looks bad! I wonder what the symptom is. 263318 2 ggaren 2010-08-11 10:10:17 -0700 It looks like the operator isn't used. I'd suggest removing it. 263634 3 andrey154 2010-08-12 00:27:04 -0700 (In reply to comment #1) > Looks bad! I wonder what the symptom is. Darin, unfortunately, this was found by my code intrumentation utility and i don't have time to compose a unit test to reproduce erroneous behaviour. I promise to try later. Why don't change this to something like: bool operator==(const Iterator& other) const { return ! operator!= (other); } It will not consume much code space and provide full external interface to SegmentedVector. Kind regards, Andrey 263897 4 ggaren 2010-08-12 11:37:55 -0700 I'm not keen on having unused / untested code in the tree. It leads to bitrot like this. If you plan on using this function, that's a different story. 263911 5 darin 2010-08-12 12:22:38 -0700 Yes, lets remove the function as Geoff suggests. 420952 6 barraclough 2011-06-14 18:58:08 -0700 Fixed in r88892. (These operators are used by the DFG JIT). 450739 7 barraclough 2011-08-12 16:10:45 -0700 *** Bug 56289 has been marked as a duplicate of this bug. ***