4384 2005-08-11 04:13:58 -0700 Too many debugging logs in TOT WebCore+SVG 2005-08-11 11:56:56 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric oldest_to_newest 16413 0 eric 2005-08-11 04:13:58 -0700 The attached patch disables two unnecessary debugging logs, as well as fixes a crash when rendering SVGs which failed to parse fully. 16416 1 3338 eric 2005-08-11 04:20:53 -0700 Created attachment 3338 Removes logs and fixes crash 3338 2005-08-11 04:20:53 -0700 2005-08-11 11:44:38 -0700 Removes logs and fixes crash crashandlog.patch text/plain 3023 eric SW5kZXg6IFdlYkNvcmUrU1ZHL0RyYXdWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv cm9vdC9TVkdTdXBwb3J0L1dlYkNvcmUrU1ZHL0RyYXdWaWV3Lm1tLHYKcmV0cmlldmluZyByZXZp c2lvbiAxLjIKZGlmZiAtcCAtdSAtcjEuMiBXZWJDb3JlK1NWRy9EcmF3Vmlldy5tbQotLS0gV2Vi Q29yZStTVkcvRHJhd1ZpZXcubW0JNiBBdWcgMjAwNSAwODo0OToxNCAtMDAwMAkxLjIKKysrIFdl YkNvcmUrU1ZHL0RyYXdWaWV3Lm1tCTExIEF1ZyAyMDA1IDExOjE5OjM1IC0wMDAwCkBAIC0xMzEs OSArMTMxLDcgQEAgdHlwZWRlZiBlbnVtIHsKIC8vIGMrKyBlbmFibGVkIGRyYXdpbmcgY29kZS4K IC0gKHZvaWQpZHJhd1JlY3Q6KE5TUmVjdClkaXJ0eVZpZXdSZWN0CiB7Ci0gICAgaWYgKCFbZG9j dW1lbnQgY2FudmFzXSkKLSAgICAgICAgcmV0dXJuOwotICAgIGlmICghY2FudmFzVmlldykKKyAg ICBpZiAoIVtkb2N1bWVudCBjYW52YXNdIHx8ICFbZG9jdW1lbnQgY2FudmFzXS0+cm9vdENvbnRh aW5lcigpIHx8ICFjYW52YXNWaWV3KQogICAgICAgICByZXR1cm47CiAgICAgCiAgICAgLy8gcHVz aCB0aGUgZHJhd2luZyBjb250ZXh0CkluZGV4OiBrY2FudmFzL2RldmljZS9xdWFydHovS0NhbnZh c0ZpbHRlclF1YXJ0ei5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvU1ZHU3VwcG9y dC9rY2FudmFzL2RldmljZS9xdWFydHovS0NhbnZhc0ZpbHRlclF1YXJ0ei5tbSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4yCmRpZmYgLXAgLXUgLXIxLjIga2NhbnZhcy9kZXZpY2UvcXVhcnR6L0tD YW52YXNGaWx0ZXJRdWFydHoubW0KLS0tIGtjYW52YXMvZGV2aWNlL3F1YXJ0ei9LQ2FudmFzRmls dGVyUXVhcnR6Lm1tCTMxIEp1bCAyMDA1IDE5OjUxOjI0IC0wMDAwCTEuMgorKysga2NhbnZhcy9k ZXZpY2UvcXVhcnR6L0tDYW52YXNGaWx0ZXJRdWFydHoubW0JMTEgQXVnIDIwMDUgMTE6MTk6Mzkg LTAwMDAKQEAgLTE2MCw4ICsxNjAsOCBAQCB2b2lkIEtDYW52YXNGaWx0ZXJRdWFydHo6OmFwcGx5 RmlsdGVyKENHCiAJCWRlc3RPcmlnaW4ueCArPSBiYm94T3JpZ2luLng7CiAJCWRlc3RPcmlnaW4u eSArPSBiYm94T3JpZ2luLnk7CiAJCQotCQlDR1JlY3QgZXh0ZW50ID0gW291dHB1dEltYWdlIGV4 dGVudF07Ci0JCU5TTG9nKEAiRHJhd2luZyBmcm9tIHJlY3Q6IFxuJUAgXG4gYXQgcG9pbnQ6IFxu JUAgXG5leHRlbnQ6IFxuJUAgXG5tYXRyaXg6IFxuJUAiLCBOU1N0cmluZ0Zyb21SZWN0KCooTlNS ZWN0ICopJnNvdXJjZVJlY3QpLCBOU1N0cmluZ0Zyb21Qb2ludCgqKE5TUG9pbnQgKikmZGVzdE9y aWdpbiksIE5TU3RyaW5nRnJvbVJlY3QoKihOU1JlY3QgKikmZXh0ZW50KSwgQ0ZTdHJpbmdGcm9t Q0dBZmZpbmVUcmFuc2Zvcm0ob2JqZWN0VHJhbnNmb3JtKSk7CisJCS8vQ0dSZWN0IGV4dGVudCA9 IFtvdXRwdXRJbWFnZSBleHRlbnRdOworCQkvL05TTG9nKEAiRHJhd2luZyBmcm9tIHJlY3Q6IFxu JUAgXG4gYXQgcG9pbnQ6IFxuJUAgXG5leHRlbnQ6IFxuJUAgXG5tYXRyaXg6IFxuJUAiLCBOU1N0 cmluZ0Zyb21SZWN0KCooTlNSZWN0ICopJnNvdXJjZVJlY3QpLCBOU1N0cmluZ0Zyb21Qb2ludCgq KE5TUG9pbnQgKikmZGVzdE9yaWdpbiksIE5TU3RyaW5nRnJvbVJlY3QoKihOU1JlY3QgKikmZXh0 ZW50KSwgQ0ZTdHJpbmdGcm9tQ0dBZmZpbmVUcmFuc2Zvcm0ob2JqZWN0VHJhbnNmb3JtKSk7CiAJ CS8vb3V0cHV0SW1hZ2UgPSBbb3V0cHV0SW1hZ2UgaW1hZ2VCeUFwcGx5aW5nVHJhbnNmb3JtOm9i amVjdFRyYW5zZm9ybV07CiAJCVttX2ZpbHRlckNJQ29udGV4dCBkcmF3SW1hZ2U6b3V0cHV0SW1h Z2UgYXRQb2ludDpkZXN0T3JpZ2luIGZyb21SZWN0OnNvdXJjZVJlY3RdOwogCX0gZWxzZQpJbmRl eDoga2NhbnZhcy9kZXZpY2UvcXVhcnR6L0tSZW5kZXJpbmdQYWludFNlcnZlclF1YXJ0ei5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvU1ZHU3VwcG9ydC9rY2FudmFzL2RldmljZS9x dWFydHovS1JlbmRlcmluZ1BhaW50U2VydmVyUXVhcnR6Lm1tLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjEKZGlmZiAtcCAtdSAtcjEuMSBrY2FudmFzL2RldmljZS9xdWFydHovS1JlbmRlcmluZ1Bh aW50U2VydmVyUXVhcnR6Lm1tCi0tLSBrY2FudmFzL2RldmljZS9xdWFydHovS1JlbmRlcmluZ1Bh aW50U2VydmVyUXVhcnR6Lm1tCTkgSnVsIDIwMDUgMDY6NTM6MjEgLTAwMDAJMS4xCisrKyBrY2Fu dmFzL2RldmljZS9xdWFydHovS1JlbmRlcmluZ1BhaW50U2VydmVyUXVhcnR6Lm1tCTExIEF1ZyAy MDA1IDExOjE5OjM5IC0wMDAwCkBAIC0xNDEsNyArMTQxLDcgQEAgdm9pZCBLUmVuZGVyaW5nUGFp bnRTZXJ2ZXJQYXR0ZXJuUXVhcnR6OgogCS8vQ0dDb250ZXh0U2V0UGF0dGVyblBoYXNlKGNvbnRl eHQsIHBoYXNlKTsKIAlDR0NvbnRleHRTZXRQYXR0ZXJuUGhhc2UoY29udGV4dCwgQ0dTaXplWmVy byk7IC8vIEZJWE1FOiB0aGlzIG1pZ2h0IGJlIHJpZ2h0Li4uIG1pZ2h0IG5vdC4KIAkKLQlOU0xv ZyhAInBhdHRlcm4gcGhhc2U6ICVmLCAlZiB0cmFuc2Zvcm06ICVAIiwgcGhhc2Uud2lkdGgsIHBo YXNlLmhlaWdodCwgQ0ZTdHJpbmdGcm9tQ0dBZmZpbmVUcmFuc2Zvcm0odHJhbnNmb3JtKSk7CisJ Ly9OU0xvZyhAInBhdHRlcm4gcGhhc2U6ICVmLCAlZiB0cmFuc2Zvcm06ICVAIiwgcGhhc2Uud2lk dGgsIHBoYXNlLmhlaWdodCwgQ0ZTdHJpbmdGcm9tQ0dBZmZpbmVUcmFuc2Zvcm0odHJhbnNmb3Jt KSk7CiAJCiAJaWYgKCAodHlwZSAmIEFQUExZX1RPX0ZJTEwpICYmIHN0eWxlLT5pc0ZpbGxlZCgp ICkgewogCQlDR0NvbnRleHRTZXRGaWxsQ29sb3JTcGFjZShjb250ZXh0LCBwYXR0ZXJuU3BhY2Up Owo=