43827 2010-08-10 19:28:39 -0700 [Qt] Unable to load pages on QtTestBrowser after canceling a page load. 2010-10-20 15:42:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 1 alexandra.1.santos max.hong.shen ademar commit-queue cshu kling suresh.voruganti tonikitoo oldest_to_newest 262973 0 alexandra.1.santos 2010-08-10 19:28:39 -0700 The user is unable to continue loading pages after cancelling a page load. Steps to reproduce: 1.- Flash the device with symbian 4 platform. 2.- Install and launch QtTestBrowser 3.- Try to load a page and click the "cancel" button before the page finish loading. Actual results: Page loading is cancelled and the "load/reload" button does not get enabled; therefore, unable to continue loading pages. Expected results: After cancelling a page loading, the "load/reload" button would be enabled. Therefore; user would be able to continue loading pages. 295498 1 71036 max.hong.shen 2010-10-18 07:55:16 -0700 Created attachment 71036 first try 295500 2 max.hong.shen 2010-10-18 08:01:07 -0700 After triggered stop action on qwebpage to cancel page loading, the Navigation Actions (back, forward, reload, stop ...) doesn't get updated in most cases. So the patch tries to update navigation actions explicitly after calling mainFrame()->d->frame->loader()->stopForUserCancel(). 295504 3 tonikitoo 2010-10-18 08:16:54 -0700 Only STOP breaks it? 295509 4 71036 tonikitoo 2010-10-18 08:19:19 -0700 Comment on attachment 71036 first try It looks sane to me. 295510 5 tonikitoo 2010-10-18 08:19:34 -0700 Any change to have a autotest for it? 295512 6 tonikitoo 2010-10-18 08:20:04 -0700 QT = QuickTime :) 295517 7 max.hong.shen 2010-10-18 08:26:35 -0700 Thanks for super fast review, Antonio :) I don't have any any auto test for it now since there is no such test existing. Only did some tests on the QtTestBrowser. 295523 8 71036 commit-queue 2010-10-18 08:41:32 -0700 Comment on attachment 71036 first try Clearing flags on attachment: 71036 Committed r69961: <http://trac.webkit.org/changeset/69961> 295524 9 commit-queue 2010-10-18 08:41:37 -0700 All reviewed patches have been landed. Closing bug. 296881 10 suresh.voruganti 2010-10-20 11:32:25 -0700 Pls cherry pick the fix for Qtwebkit 2.1 as this is Qtwebkit2.1 Basic Acceptance test failure. 296884 11 tonikitoo 2010-10-20 11:35:52 -0700 Kling raised a concern with the patch and suggested we addressing that in FrameLoaderClient side, which I found reasonable. Yi, news on that? 296914 12 max.hong.shen 2010-10-20 12:12:05 -0700 (In reply to comment #11) > Kling raised a concern with the patch and suggested we addressing that in FrameLoaderClient side, which I found reasonable. > > Yi, news on that? Hi Antonio, I checked the FrameLoaderClientQt and FrameLoader, and I think the only place we can updateNav in FrameLoaderClientQt is in frameLoadCompleted(). The down side is that frameLoadCompleted can be called multiple times. void FrameLoaderClientQt::frameLoadCompleted() { // Note: Can be called multiple times. if (!m_loadError.isNull() && m_loadError.isCancellation()) m_webFrame->page()->d->updateNavigationActions(); } Any thoughts? 296918 13 tonikitoo 2010-10-20 12:15:50 -0700 (In reply to comment #12) > (In reply to comment #11) > > Kling raised a concern with the patch and suggested we addressing that in FrameLoaderClient side, which I found reasonable. > > > > Yi, news on that? > > Hi Antonio, I checked the FrameLoaderClientQt and FrameLoader, and I think the only place we can updateNav in FrameLoaderClientQt is in frameLoadCompleted(). The down side is that frameLoadCompleted can be called multiple times. > > void FrameLoaderClientQt::frameLoadCompleted() > { > // Note: Can be called multiple times. > if (!m_loadError.isNull() && m_loadError.isCancellation()) > m_webFrame->page()->d->updateNavigationActions(); > } > > Any thoughts? It gets called multiple times in what situations? like one per frame? 296940 14 max.hong.shen 2010-10-20 12:39:25 -0700 (In reply to comment #13) > (In reply to comment #12) > It gets called multiple times in what situations? like one per frame? No, seems one per sub resource loader. For most often, after user cancel loading, the state of frame is set to FrameStateComplete. Then all the sub resource loaders call FrameLoader::checkLoadCompleteForThisFrame when removing itself from the DocumentLoader. In checkLoadCompleteForThisFrame, it calls the FrameLoaderClientQt::frameLoadCompleted() since the state is FrameStateComplete. e.g, when cancel loading cnn.com, I saw frameLoadCompleted gets called > 30 times. 297077 15 ademar 2010-10-20 15:38:04 -0700 Revision r69961 cherry-picked into qtwebkit-2.1 with commit 230afa2 <http://gitorious.org/webkit/qtwebkit/commit/230afa2> 71036 2010-10-18 07:55:16 -0700 2010-10-18 08:41:32 -0700 first try 43827.patch text/plain 1097 max.hong.shen SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjk5NTgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMTggIFlpIFNoZW4gIDx5aS40LnNoZW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRVF0gVW5hYmxlIHRvIGxvYWQgcGFnZXMgb24gUXRUZXN0QnJvd3NlciBhZnRlciBjYW5jZWxp bmcgYSBwYWdlIGxvYWQuIAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDM4MjcKKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChR V2ViUGFnZTo6dHJpZ2dlckFjdGlvbik6CisKIDIwMTAtMTAtMTUgIFFpIFpoYW5nICA8cWkuMi56 aGFuZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KSW5k ZXg6IFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9B cGkvcXdlYnBhZ2UuY3BwCShyZXZpc2lvbiA2OTk1NikKKysrIFdlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTc0LDYgKzIxNzQsNyBAQCB2b2lkIFFXZWJQYWdl Ojp0cmlnZ2VyQWN0aW9uKFdlYkFjdGlvbiBhCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg Y2FzZSBTdG9wOgogICAgICAgICAgICAgbWFpbkZyYW1lKCktPmQtPmZyYW1lLT5sb2FkZXIoKS0+ c3RvcEZvclVzZXJDYW5jZWwoKTsKKyAgICAgICAgICAgIGQtPnVwZGF0ZU5hdmlnYXRpb25BY3Rp b25zKCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBSZWxvYWQ6CiAgICAgICAg ICAgICBtYWluRnJhbWUoKS0+ZC0+ZnJhbWUtPmxvYWRlcigpLT5yZWxvYWQoLyplbmR0b2VuZHJl bG9hZCovZmFsc2UpOwo=