43813 2010-08-10 14:48:55 -0700 Ensure that parser doesn't attach children that have been removed by JavaScript event handlers. 2010-08-12 16:23:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 40742 1 dglazkov dglazkov abarth aestes hyatt jamesr mitz oldest_to_newest 262869 0 dglazkov 2010-08-10 14:48:55 -0700 Ensure that parser doesn't attach children that have been removed by JavaScript event handlers. 262872 1 64048 dglazkov 2010-08-10 14:53:08 -0700 Created attachment 64048 Patch 262893 2 64048 abarth 2010-08-10 15:38:43 -0700 Comment on attachment 64048 Patch Oh man... This patch looks correct, but it enscarifies me. 262919 3 jamesr 2010-08-10 17:31:42 -0700 Looks good to me as well. Mitz, Hyatt - have any thoughts on this? 263598 4 dglazkov 2010-08-11 21:43:54 -0700 I land this yes? :) 263600 5 abarth 2010-08-11 21:59:12 -0700 I think so. :) 263601 6 mitz 2010-08-11 22:01:51 -0700 The change looks correct to me. Andy, if you have any test cases that you’ve developed while investigating bug 40742, other than the regression test, you can verify that this patch doesn’t regress them. 264021 7 aestes 2010-08-12 15:15:11 -0700 (In reply to comment #6) > The change looks correct to me. Andy, if you have any test cases that you’ve developed while investigating bug 40742, other than the regression test, you can verify that this patch doesn’t regress them. Looks good to me. I checked in several additional tests covering this behavior in http://trac.webkit.org/changeset/61744, and it looks like those tests are passing. Dimitri, for my own edification, I'm curious how the lazy-attach optimization affects <link> elements. I had convinced myself it wasn't when writing this patch, but I might have missed something. 264030 8 abarth 2010-08-12 15:30:25 -0700 I think we'd like to lazy attach everything. Once you have one element that doesn't support lazy attach, you have to break out of your lazy slumber for all it's ancestors. 264072 9 64048 dglazkov 2010-08-12 16:23:30 -0700 Comment on attachment 64048 Patch Clearing flags on attachment: 64048 Committed r65281: <http://trac.webkit.org/changeset/65281> 264073 10 dglazkov 2010-08-12 16:23:35 -0700 All reviewed patches have been landed. Closing bug. 64048 2010-08-10 14:53:08 -0700 2010-08-12 16:23:30 -0700 Patch bug-43813-20100810145307.patch text/plain 4755 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmQzMTIyNDY2ZTZjZjQwNjc3N2IwZDJjNTMzYmYyYWQ2MDc4YjM3Zi4uMzk0ZDIzZjc0MmQ3N2Ey YTk3NmYyMmZkMDA2YmQzMDM4NTA0N2NlMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0xMCAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3VyZSB0aGF0IHBhcnNlciBkb2Vzbid0 IGF0dGFjaCBjaGlsZHJlbiB0aGF0IGhhdmUgYmVlbiByZW1vdmVkIGJ5IEphdmFTY3JpcHQgZXZl bnQgaGFuZGxlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MzgxMworCisgICAgICAgIFRoaXMgcGF0Y2ggcmUtZml4ZXMgYnVnIDQwNzQyIGluIGEg d2F5IHRoYXQga2VlcHMgYWxsb3dpbmcgSFRNTExpbmtFbGVtZW50CisgICAgICAgIHRvIGxhenkt YXR0YWNoLgorCisgICAgICAgICogaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoKTogQWRkZWQgcGFyZW50 IGNoZWNrLgorICAgICAgICAqIGh0bWwvSFRNTExpbmtFbGVtZW50LmNwcDogQmFzaWNhbGx5IHVu ZG9lcyBjaGFuZ2VzIGludHJvZHVjZWQgYnkgcjYxNDI0LgorICAgICAgICAqIGh0bWwvSFRNTExp bmtFbGVtZW50Lmg6IERpdHRvLgorCiAyMDEwLTA4LTEwICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBh cm9nYUBwYXJvZ2EuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwIGIvV2ViQ29yZS9o dG1sL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmNwcAppbmRleCAxYTlhMzczZTAyNzg1YzkxNTVhN2Qw ODE0NzNiZGMwNWJhMDhjMzBmLi5hZGVmZTRkNTYzZTFlZmQ1NDliZGQ2MDE1NGY1NGJlYzk2NDMx ZTkwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCisr KyBiL1dlYkNvcmUvaHRtbC9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKQEAgLTk4LDYgKzk4LDEy IEBAIFBhc3NSZWZQdHI8Q2hpbGRUeXBlPiBIVE1MQ29uc3RydWN0aW9uU2l0ZTo6YXR0YWNoKE5v ZGUqIHBhcmVudCwgUGFzc1JlZlB0cjxDaGlsCiAgICAgfQogCiAgICAgcGFyZW50LT5wYXJzZXJB ZGRDaGlsZChjaGlsZCk7CisKKyAgICAvLyBBbiBldmVudCBoYW5kbGVyIChET00gTXV0YXRpb24s IGJlZm9yZWxvYWQsIGV0IGFsLikgY291bGQgaGF2ZSByZW1vdmVkCisgICAgLy8gdGhlIGNoaWxk LCBpbiB3aGljaCBjYXNlIHdlIHNob3VsZG4ndCB0cnkgYXR0YWNoaW5nIGl0LgorICAgIGlmICgh Y2hpbGQtPnBhcmVudE5vZGUoKSkKKyAgICAgICAgcmV0dXJuIGNoaWxkLnJlbGVhc2UoKTsKKwog ICAgIC8vIEl0J3Mgc2xpZ2h0bHkgdW5mb3J0dW5hdGUgdGhhdCB3ZSBuZWVkIHRvIGhvbGQgYSBy ZWZlcmVuY2UgdG8gY2hpbGQKICAgICAvLyBoZXJlIHRvIGNhbGwgYXR0YWNoKCkuICBXZSBzaG91 bGQgaW52ZXN0aWdhdGUgd2hldGhlciB3ZSBjYW4gcmVseSBvbgogICAgIC8vIHxwYXJlbnR8IHRv IGhvbGQgYSByZWYgYXQgdGhpcyBwb2ludC4gIEluIHRoZSBjb21tb24gY2FzZSAoYXQgbGVhc3QK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwIGIvV2ViQ29yZS9o dG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKaW5kZXggZmMxMzE2NWM3ZGY3ZWU5MzYzYTZlNGEzZjhm MTY1NThlZTRjYTI5OS4uYjlmYjhmMDcxMDk0MWQxMTZlOTBkYzUyNGNhMTFjMmM5ZjFiMzY0OSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKKysrIGIvV2ViQ29y ZS9odG1sL0hUTUxMaW5rRWxlbWVudC5jcHAKQEAgLTUxLDcgKzUxLDYgQEAgaW5saW5lIEhUTUxM aW5rRWxlbWVudDo6SFRNTExpbmtFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmIHRhZ05hbWUs IERvY3VtZW50KgogICAgICwgbV9kaXNhYmxlZFN0YXRlKFVuc2V0KQogICAgICwgbV9sb2FkaW5n KGZhbHNlKQogICAgICwgbV9jcmVhdGVkQnlQYXJzZXIoY3JlYXRlZEJ5UGFyc2VyKQotICAgICwg bV9zaG91bGRQcm9jZXNzQWZ0ZXJBdHRhY2goZmFsc2UpCiB7CiAgICAgQVNTRVJUKGhhc1RhZ05h bWUobGlua1RhZykpOwogfQpAQCAtMjQyLDI4ICsyNDEsMTIgQEAgdm9pZCBIVE1MTGlua0VsZW1l bnQ6OnByb2Nlc3MoKQogICAgICAgICBkb2N1bWVudCgpLT51cGRhdGVTdHlsZVNlbGVjdG9yKCk7 CiAgICAgfQogfQotICAgIAotdm9pZCBIVE1MTGlua0VsZW1lbnQ6OnByb2Nlc3NDYWxsYmFjayhO b2RlKiBub2RlKQotewotICAgIEFTU0VSVF9BUkcobm9kZSwgbm9kZSAmJiBub2RlLT5oYXNUYWdO YW1lKGxpbmtUYWcpKTsKLSAgICBzdGF0aWNfY2FzdDxIVE1MTGlua0VsZW1lbnQqPihub2RlKS0+ cHJvY2VzcygpOwotfQogCiB2b2lkIEhUTUxMaW5rRWxlbWVudDo6aW5zZXJ0ZWRJbnRvRG9jdW1l bnQoKQogewogICAgIEhUTUxFbGVtZW50OjppbnNlcnRlZEludG9Eb2N1bWVudCgpOwogICAgIGRv Y3VtZW50KCktPmFkZFN0eWxlU2hlZXRDYW5kaWRhdGVOb2RlKHRoaXMsIG1fY3JlYXRlZEJ5UGFy c2VyKTsKIAotICAgIC8vIFNpbmNlIHByb2Nlc3NpbmcgYSBzdHlsZXNoZWV0IGxpbmsgY2F1c2Vz IGEgYmVmb3JlbG9hZCBldmVudAotICAgIC8vIHRvIGZpcmUsIGl0IGlzIHBvc3NpYmxlIGZvciBK YXZhU2NyaXB0IHRvIHJlbW92ZSB0aGUgZWxlbWVudCBpbiB0aGUgbWlkc3QKLSAgICAvLyBvZiBp dCBiZWluZyBpbnNlcnRlZCBpbnRvIHRoZSBET00sIHdoaWNoIGNhbiBsZWFkIHRvIGFzc2VydGlv biBmYWlsdXJlcwotICAgIC8vIGFuZCBjcmFzaGVzLiBBdm9pZCB0aGlzIGJ5IHBvc3Rwb25pbmcg dGhlIGJlZm9yZWxvYWQvbG9hZCB1bnRpbCBhZnRlcgotICAgIC8vIGF0dGFjaCBpZiB0aGVyZSBh cmUgYmVmb3JlbG9hZCBsaXN0ZW5lcnMuCi0gICAgaWYgKGRvY3VtZW50KCktPmhhc0xpc3RlbmVy VHlwZShEb2N1bWVudDo6QkVGT1JFTE9BRF9MSVNURU5FUikpIHsKLSAgICAgICAgbV9zaG91bGRQ cm9jZXNzQWZ0ZXJBdHRhY2ggPSB0cnVlOwotICAgICAgICByZXR1cm47Ci0gICAgfQotCiAgICAg cHJvY2VzcygpOwogfQogCkBAIC0yNzYsMjAgKzI1OSw4IEBAIHZvaWQgSFRNTExpbmtFbGVtZW50 OjpyZW1vdmVkRnJvbURvY3VtZW50KCkKICAgICAvLyBGSVhNRTogSXQncyB0ZXJyaWJsZSB0byBk byBhIHN5bmNocm9ub3VzIHVwZGF0ZSBvZiB0aGUgc3R5bGUgc2VsZWN0b3IganVzdCBiZWNhdXNl IGEgPHN0eWxlPiBvciA8bGluaz4gZWxlbWVudCBnb3QgcmVtb3ZlZC4KICAgICBpZiAoZG9jdW1l bnQoKS0+cmVuZGVyZXIoKSkKICAgICAgICAgZG9jdW1lbnQoKS0+dXBkYXRlU3R5bGVTZWxlY3Rv cigpOwotICAgIAotICAgIG1fc2hvdWxkUHJvY2Vzc0FmdGVyQXR0YWNoID0gZmFsc2U7CiB9CiAK LXZvaWQgSFRNTExpbmtFbGVtZW50OjphdHRhY2goKQotewotICAgIGlmIChtX3Nob3VsZFByb2Nl c3NBZnRlckF0dGFjaCkgewotICAgICAgICBtX3Nob3VsZFByb2Nlc3NBZnRlckF0dGFjaCA9IGZh bHNlOwotICAgICAgICBxdWV1ZVBvc3RBdHRhY2hDYWxsYmFjaygmSFRNTExpbmtFbGVtZW50Ojpw cm9jZXNzQ2FsbGJhY2ssIHRoaXMpOwotICAgIH0KLQotICAgIEhUTUxFbGVtZW50OjphdHRhY2go KTsKLX0KLSAgICAKIHZvaWQgSFRNTExpbmtFbGVtZW50OjpmaW5pc2hQYXJzaW5nQ2hpbGRyZW4o KQogewogICAgIG1fY3JlYXRlZEJ5UGFyc2VyID0gZmFsc2U7CmRpZmYgLS1naXQgYS9XZWJDb3Jl L2h0bWwvSFRNTExpbmtFbGVtZW50LmggYi9XZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmgK aW5kZXggZGIwNjllYjRhOGU4NzNmNzJjNDAzYjFkMTFkZTVmN2E1NGUxY2M5Zi4uZjhjY2QxMjlk MTIyZDg5NjMxMWY0ZjMzOWVjODBiZGMwZmUxY2U4ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1s L0hUTUxMaW5rRWxlbWVudC5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuaApA QCAtNzMsOSArNzMsNiBAQCBwdWJsaWM6CiAgICAgYm9vbCBpc0Rpc2FibGVkKCkgY29uc3QgeyBy ZXR1cm4gbV9kaXNhYmxlZFN0YXRlID09IERpc2FibGVkOyB9CiAgICAgYm9vbCBpc0VuYWJsZWRW aWFTY3JpcHQoKSBjb25zdCB7IHJldHVybiBtX2Rpc2FibGVkU3RhdGUgPT0gRW5hYmxlZFZpYVNj cmlwdDsgfQogICAgIGJvb2wgaXNJY29uKCkgY29uc3QgeyByZXR1cm4gbV9yZWxBdHRyaWJ1dGUu bV9pc0ljb247IH0KLSAgICAKLSAgICB2aXJ0dWFsIHZvaWQgYXR0YWNoKCk7Ci0gICAgdmlydHVh bCBib29sIGNhbkxhenlBdHRhY2goKSB7IHJldHVybiBmYWxzZTsgfQogCiBwcml2YXRlOgogICAg IHZpcnR1YWwgSFRNTFRhZ1N0YXR1cyBlbmRUYWdSZXF1aXJlbWVudCgpIGNvbnN0IHsgcmV0dXJu IFRhZ1N0YXR1c0ZvcmJpZGRlbjsgfQpAQCAtMTI1LDcgKzEyMiw2IEBAIHByaXZhdGU6CiAgICAg UmVsQXR0cmlidXRlIG1fcmVsQXR0cmlidXRlOwogICAgIGJvb2wgbV9sb2FkaW5nOwogICAgIGJv b2wgbV9jcmVhdGVkQnlQYXJzZXI7Ci0gICAgYm9vbCBtX3Nob3VsZFByb2Nlc3NBZnRlckF0dGFj aDsKIH07CiAKIH0gLy9uYW1lc3BhY2UK