43810 2010-08-10 14:41:33 -0700 Commit-queue shouldn't land patch if cq+ was removed 2010-08-10 15:26:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 32679 P2 Normal --- 1 ossy webkit-unassigned abarth abecsi eric oldest_to_newest 262857 0 ossy 2010-08-10 14:41:33 -0700 If you set cq+ for a patch, commit queue script will add it to the commit queue. But if you realise later that you shouldn't have set cq+ and then you remove it (or set cq-), the script will land the patch irrespectively of the new cq flag. I think cq ignores modified flag only after it started landing. Otherwise it removes the patch from the queue correctly. I propose commit queue should check cq flag again after build&test finished and before landing to avoid this unwanted commit. 262861 1 eric 2010-08-10 14:44:00 -0700 This is an old bug. :( *** This bug has been marked as a duplicate of bug 32679 *** 262866 2 ossy 2010-08-10 14:47:24 -0700 (In reply to comment #1) > This is an old bug. :( > > *** This bug has been marked as a duplicate of bug 32679 *** Good to know, thanks. I will search in bugzilla next time. 262889 3 abarth 2010-08-10 15:26:50 -0700 BTW, this bug isn't too hard to fix. You just need to add a precommit callback to the parent command class to see if it wants to abort and then have CommitQueue implement logic to check the flag before landing. You can see how we do other --parent-command callbacks.