43802 2010-08-10 11:50:44 -0700 [GTK] WebBackForwardList's new_with_web_view should not be public 2010-08-18 10:47:43 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned mrobinson xan.lopez oldest_to_newest 262803 0 gustavo 2010-08-10 11:50:44 -0700 Someone trying to use WebKitGTK+ through GObject Introspection bumped into a problem with WebBackForwardList - instantiating it using the default constructor fails badly because the WebKit object is not backed by an appropriate WebCore object. I think that is by design - the backforwardlist seems to only be useful when attached to a WebView anyway, and every WebView has its backforwardlist already. I think that means we want to do two things: * Annotate WebBackForwardList as a type that should not allow instantiation - the WebView is the one who creates the only instances that should exist * Deprecate webkit_web_back_forward_list_new_with_web_view as a publicly exported function, and make it private instead Anyone knows better? I found no users of this API. 262844 1 mrobinson 2010-08-10 14:05:31 -0700 This sounds fine to me. What was the user trying to accomplish by the way? Perhaps our documentation isn't clear enough about whatever it was. I'd be willing to improve it here. 262904 2 gustavo 2010-08-10 16:39:07 -0700 This has come second-hand to me, so I couldn't find out what the user was trying to accomplish - he asked Tomeu (who works in introspection) for help, and Tomeu told me about it. Looks like the person who got confused with this is 'lucian', and hangs out on IRC, so it should be possible for us to ask him =) 266211 3 64731 gustavo 2010-08-18 10:31:21 -0700 Created attachment 64731 deprecate the function 266215 4 64731 mrobinson 2010-08-18 10:38:14 -0700 Comment on attachment 64731 deprecate the function LGTM! 266231 5 gustavo 2010-08-18 10:47:43 -0700 Landed as r65615. 64731 2010-08-18 10:31:21 -0700 2010-08-18 10:38:29 -0700 deprecate the function 0001-Deprecate-webkit_web_back_forward_list_new_with_web_.patch text/plain 1781 gustavo RnJvbSA3ZjNiMmZjODZmNzlmNjJjNGE3M2NjZDAxZjg2MDlmODVkMDQyNGE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IFdlZCwgMTggQXVnIDIwMTAgMTQ6MzA6MzcgLTAzMDAKU3ViamVjdDogW1BBVENIXSBE ZXByZWNhdGUgd2Via2l0X3dlYl9iYWNrX2ZvcndhcmRfbGlzdF9uZXdfd2l0aF93ZWJfdmlldwoK LS0tCiBXZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAx MiArKysrKysrKysrKysKIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmJhY2tmb3J3YXJkbGlz dC5jcHAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAwIGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKaW5kZXggZGFiZGRhYS4uM2Q2MjcyNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxMC0wOC0xOCAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxh Ym9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbR1RLXSBXZWJCYWNrRm9yd2FyZExpc3QncyBuZXdfd2l0aF93ZWJfdmlldyBzaG91bGQg bm90IGJlIHB1YmxpYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDM4MDIKKworICAgICAgICBEZXByZWNhdGUgdGhlIGNvbnN0cnVjdG9yLiBUaGUgaW50 cm9zcGVjdGlvbiBhbm5vdGF0aW9uIGhhcyBiZWVuCisgICAgICAgIGZpeGVkIGluIGEgcHJldmlv dXMgY29tbWl0LgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYmJhY2tmb3J3YXJkbGlzdC5j cHA6CisKIDIwMTAtMDgtMTcgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYmJhY2tmb3J3YXJkbGlzdC5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJiYWNrZm9yd2FyZGxpc3QuY3BwCmluZGV4IGUxYmRhYzQuLjQ3ODlkZTkgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmJhY2tmb3J3YXJkbGlzdC5jcHAKKysr IGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViYmFja2ZvcndhcmRsaXN0LmNwcApAQCAtMTAy LDYgKzEwMiw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfYmFja19mb3J3YXJkX2xpc3RfaW5p dChXZWJLaXRXZWJCYWNrRm9yd2FyZExpc3QqIHdlYkJhY2tGCiAgKiBDcmVhdGVzIGFuIGluc3Rh bmNlIG9mIHRoZSBiYWNrIGZvcndhcmQgbGlzdCB3aXRoIGEgY29udHJvbGxpbmcgI1dlYktpdFdl YlZpZXcKICAqCiAgKiBSZXR1cm4gdmFsdWU6IGEgI1dlYktpdFdlYkJhY2tGb3J3YXJkTGlzdAor ICoKKyAqIERlcHJlY2F0ZWQ6IDEuMy40OiBJbnN0YW5jZXMgb2YgI1dlYktpdFdlYkJhY2tGb3J3 YXJkTGlzdCBhcmUKKyAqIGNyZWF0ZWQgYW5kIG93bmVkIGJ5ICNXZWJLaXRXZWJWaWV3IGluc3Rh bmNlcyBvbmx5LgogICovCiBXZWJLaXRXZWJCYWNrRm9yd2FyZExpc3QqIHdlYmtpdF93ZWJfYmFj a19mb3J3YXJkX2xpc3RfbmV3X3dpdGhfd2ViX3ZpZXcoV2ViS2l0V2ViVmlldyogd2ViVmlldykK IHsKLS0gCjEuNy4xCgo=