43790 2010-08-10 06:58:57 -0700 [EFL] Add video files to enable video in WebKit EFL 2010-08-24 03:07:55 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 44098 0 gyuyoung.kim webkit-unassigned barbieri commit-queue eric.carlson eric kenneth leandro lucas.de.marchi oldest_to_newest 262663 0 gyuyoung.kim 2010-08-10 06:58:57 -0700 WebKit EFL doesn't support to enable video yet. This patch just can enable video without build breaks. HTML5's video is not run in WebKit EFL yet. I will contribute more patches in order to run html5video. Thanks. 262666 1 64009 gyuyoung.kim 2010-08-10 07:05:27 -0700 Created attachment 64009 Patch 262668 2 64010 gyuyoung.kim 2010-08-10 07:08:16 -0700 Created attachment 64010 patch There was coding style error. I fix it. 262673 3 64010 tonikitoo 2010-08-10 07:24:39 -0700 Comment on attachment 64010 patch r=me 262686 4 64010 commit-queue 2010-08-10 08:09:15 -0700 Comment on attachment 64010 patch Rejecting patch 64010 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: CommitQueue/LayoutTests Testing 20806 test cases. media/video-volume.html -> timed out Sampling process 87309 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 87309 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 17218 tests run. 697.74s total testing time 17217 test cases (99%) succeeded 1 test case (<1%) timed out 33 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3765018 262964 5 gyuyoung.kim 2010-08-10 19:15:13 -0700 Hello eric, I don't know why layout test is failed by this patch. This patch doesn't enable VIDEO in WebKit EFL. Just add files regarding html5 video. You know, WebKit EFL doesn't have DRT yet. (But, Our engineer will contribute DRT soon.) I run the media/video-volume.html on EWebLauncher directly. There is no time-out. Could you let me know how to solve this problem ? Thanks. 262969 6 64010 eric 2010-08-10 19:25:52 -0700 Comment on attachment 64010 patch There seems to be some sort of problem on the bot. 262970 7 eric 2010-08-10 19:26:47 -0700 This is the old "all media tests hang or crash" bug that we saw long ago. Which iirc was a CoreVideo bug which was fixed in a later version of quicktime. I'll look at the commit-bot this evening, but I believe it's a completely up-to-date leopard install. 262977 8 64010 commit-queue 2010-08-10 19:53:31 -0700 Comment on attachment 64010 patch Clearing flags on attachment: 64010 Committed r65117: <http://trac.webkit.org/changeset/65117> 262978 9 commit-queue 2010-08-10 19:53:37 -0700 All reviewed patches have been landed. Closing bug. 64009 2010-08-10 07:05:27 -0700 2010-08-10 07:08:16 -0700 Patch patch-enable-video.txt text/plain 3322 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9XZWJDb3JlL0NNYWtlTGlzdHMu dHh0CmluZGV4IGZkZmY2MjcuLjFjMjRkODggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTc1OCw2ICsxNzU4LDIyIEBA IElGIChFTkFCTEVfU1ZHKQogICAgICkKIEVORElGKCkKIAorSUYgKEVOQUJMRV9WSURFTykKKyAg ICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNf RElSfS9KU1RpbWVSYW5nZXMuY3BwCisgICAgICAgIGJpbmRpbmdzL2pzL0pTQXVkaW9Db25zdHJ1 Y3Rvci5jcHAKKyAgICAgICAgaHRtbC9IVE1MQXVkaW9FbGVtZW50LmNwcAorICAgICAgICBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCisgICAgICAgIGh0bWwvSFRNTFNvdXJjZUVsZW1lbnQuY3Bw CisgICAgICAgIGh0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKKyAgICAgICAgaHRtbC9UaW1lUmFu Z2VzLmNwcAorICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKKyAgICAg ICAgcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorICAgICAgICByZW5kZXJpbmcv UmVuZGVyTWVkaWEuY3BwCisgICAgICAgIHJlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKKyAgICAp CitFTkRJRigpCisKIElGIChFTkFCTEVfV01MKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09V UkNFUwogICAgICAgICAke0RFUklWRURfU09VUkNFU19ESVJ9L1dNTEVsZW1lbnRGYWN0b3J5LmNw cApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAwN2EwNmVlLi44NWNhMGZhIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEwLTA4LTEwICBHeXV5b3VuZyBL aW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gQWRkIHZpZGVvIGZpbGVzIHRvIGVuYWJsZSB2 aWRlbyBpbiBXZWJLaXQgRUZMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00Mzc5MAorCisgICAgICAgIEFkZCBmaWxlcyByZWdhcmRpbmcgaHRtbDUgdmlk ZW8gdG8gQ01ha2VMaXN0LnR4dCBmb3IgV2ViS2l0IEVmbC4KKyAgICAgICAgQnV0LCB0aGlzIHBh dGNoIGlzIG5vdCBydW4gaHRtbDUgdmlkZW8gb24gV2ViS2l0IEVGTCB5ZXQuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDogQWRkIGZpbGVzIHJlbGF0ZWQgdG8gaHRtbDV2aWRlby4KKyAgICAg ICAgKiBwbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHA6IEFkZCBmdW5jdGlvbnMg Zm9yIGh0bWw1IHZpZGVvLgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVkTWVkaWFDb250cm9s RWxlbWVudFN0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjpsb2NhbGl6ZWRNZWRpYUNvbnRyb2xF bGVtZW50SGVscFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVkTWVkaWFUaW1lRGVz Y3JpcHRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Omluc3RhbGxlZE1lZGlhRW5naW5lcyk6IERpc2FibGUgTWVkaWFQ bGF5ZXJQcml2YXRlOjpyCisgICAgICBlZ2lzdGVyTWVkaWFFbmdpbmUgZm9yIFdlYktpdCBFRkwu CisKIDIwMTAtMDgtMTAgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcAppbmRleCBhNThkYmEyLi5jNmE4Njlm IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcApAQCAt MzUwLDYgKzM1MCwyNiBAQCBTdHJpbmcgaW1hZ2VUaXRsZShjb25zdCBTdHJpbmcmIGZpbGVuYW1l LCBjb25zdCBJbnRTaXplJiBzaXplKQogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIAorI2lmIEVO QUJMRShWSURFTykKK1N0cmluZyBsb2NhbGl6ZWRNZWRpYUNvbnRyb2xFbGVtZW50U3RyaW5nKGNv bnN0IFN0cmluZyYgbmFtZSkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiBT dHJpbmcoKTsKK30KKworU3RyaW5nIGxvY2FsaXplZE1lZGlhQ29udHJvbEVsZW1lbnRIZWxwVGV4 dChjb25zdCBTdHJpbmcmIG5hbWUpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICByZXR1 cm4gU3RyaW5nKCk7Cit9CisKK1N0cmluZyBsb2NhbGl6ZWRNZWRpYVRpbWVEZXNjcmlwdGlvbihm bG9hdCB0aW1lKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIFN0cmluZygp OworfQorI2VuZGlmICAvLyBFTkFCTEUoVklERU8pCisKIFN0cmluZyBtZWRpYUVsZW1lbnRMb2Fk aW5nU3RhdGVUZXh0KCkKIHsKICAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiTG9hZGluZy4u LiIpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5j cHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAppbmRleCAwNzMy MTE2Li4wN2Y3NzYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlh UGxheWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNw cApAQCAtMTcxLDcgKzE3MSw3IEBAIHN0YXRpYyBWZWN0b3I8TWVkaWFQbGF5ZXJGYWN0b3J5Kj4m IGluc3RhbGxlZE1lZGlhRW5naW5lcygpCiAKICNpZiBQTEFURk9STShXSU4pCiAgICAgICAgIE1l ZGlhUGxheWVyUHJpdmF0ZVF1aWNrVGltZVZpc3VhbENvbnRleHQ6OnJlZ2lzdGVyTWVkaWFFbmdp bmUoYWRkTWVkaWFFbmdpbmUpOwotI2VsaWYgIVBMQVRGT1JNKEdUSykKKyNlbGlmICFQTEFURk9S TShHVEspICYmICFQTEFURk9STShFRkwpCiAgICAgICAgIC8vIEZJWE1FOiBjdXJyZW50bHkgYWxs IHRoZSBNZWRpYUVuZ2luZXMgYXJlIG5hbWVkCiAgICAgICAgIC8vIE1lZGlhUGxheWVyUHJpdmF0 ZS4gVGhpcyBjb2RlIHdpbGwgbmVlZCBhbiB1cGRhdGUgd2hlbiBidWcKICAgICAgICAgLy8gMzY2 NjMgaXMgYWRyZXNzZWQuCg== 64010 2010-08-10 07:08:16 -0700 2010-08-10 19:53:31 -0700 patch patch-enable-video.txt text/plain 3304 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9XZWJDb3JlL0NNYWtlTGlzdHMu dHh0CmluZGV4IGZkZmY2MjcuLjFjMjRkODggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTc1OCw2ICsxNzU4LDIyIEBA IElGIChFTkFCTEVfU1ZHKQogICAgICkKIEVORElGKCkKIAorSUYgKEVOQUJMRV9WSURFTykKKyAg ICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgJHtERVJJVkVEX1NPVVJDRVNf RElSfS9KU1RpbWVSYW5nZXMuY3BwCisgICAgICAgIGJpbmRpbmdzL2pzL0pTQXVkaW9Db25zdHJ1 Y3Rvci5jcHAKKyAgICAgICAgaHRtbC9IVE1MQXVkaW9FbGVtZW50LmNwcAorICAgICAgICBodG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCisgICAgICAgIGh0bWwvSFRNTFNvdXJjZUVsZW1lbnQuY3Bw CisgICAgICAgIGh0bWwvSFRNTFZpZGVvRWxlbWVudC5jcHAKKyAgICAgICAgaHRtbC9UaW1lUmFu Z2VzLmNwcAorICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKKyAgICAg ICAgcmVuZGVyaW5nL01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorICAgICAgICByZW5kZXJpbmcv UmVuZGVyTWVkaWEuY3BwCisgICAgICAgIHJlbmRlcmluZy9SZW5kZXJWaWRlby5jcHAKKyAgICAp CitFTkRJRigpCisKIElGIChFTkFCTEVfV01MKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09V UkNFUwogICAgICAgICAke0RFUklWRURfU09VUkNFU19ESVJ9L1dNTEVsZW1lbnRGYWN0b3J5LmNw cApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCAwN2EwNmVlLi44NWNhMGZhIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEwLTA4LTEwICBHeXV5b3VuZyBL aW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0VGTF0gQWRkIHZpZGVvIGZpbGVzIHRvIGVuYWJsZSB2 aWRlbyBpbiBXZWJLaXQgRUZMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00Mzc5MAorCisgICAgICAgIEFkZCBmaWxlcyByZWdhcmRpbmcgaHRtbDUgdmlk ZW8gdG8gQ01ha2VMaXN0LnR4dCBmb3IgV2ViS2l0IEVmbC4KKyAgICAgICAgQnV0LCB0aGlzIHBh dGNoIGlzIG5vdCBydW4gaHRtbDUgdmlkZW8gb24gV2ViS2l0IEVGTCB5ZXQuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDogQWRkIGZpbGVzIHJlbGF0ZWQgdG8gaHRtbDV2aWRlby4KKyAgICAg ICAgKiBwbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHA6IEFkZCBmdW5jdGlvbnMg Zm9yIGh0bWw1IHZpZGVvLgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVkTWVkaWFDb250cm9s RWxlbWVudFN0cmluZyk6CisgICAgICAgIChXZWJDb3JlOjpsb2NhbGl6ZWRNZWRpYUNvbnRyb2xF bGVtZW50SGVscFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVkTWVkaWFUaW1lRGVz Y3JpcHRpb24pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Omluc3RhbGxlZE1lZGlhRW5naW5lcyk6IERpc2FibGUgTWVkaWFQ bGF5ZXJQcml2YXRlOjpyCisgICAgICBlZ2lzdGVyTWVkaWFFbmdpbmUgZm9yIFdlYktpdCBFRkwu CisKIDIwMTAtMDgtMTAgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcAppbmRleCBhNThkYmEyLi42MDIzMjA1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcApAQCAt MzUwLDYgKzM1MCwyNiBAQCBTdHJpbmcgaW1hZ2VUaXRsZShjb25zdCBTdHJpbmcmIGZpbGVuYW1l LCBjb25zdCBJbnRTaXplJiBzaXplKQogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIAorI2lmIEVO QUJMRShWSURFTykKK1N0cmluZyBsb2NhbGl6ZWRNZWRpYUNvbnRyb2xFbGVtZW50U3RyaW5nKGNv bnN0IFN0cmluZyYgbmFtZSkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiBT dHJpbmcoKTsKK30KKworU3RyaW5nIGxvY2FsaXplZE1lZGlhQ29udHJvbEVsZW1lbnRIZWxwVGV4 dChjb25zdCBTdHJpbmcmIG5hbWUpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKKyAgICByZXR1 cm4gU3RyaW5nKCk7Cit9CisKK1N0cmluZyBsb2NhbGl6ZWRNZWRpYVRpbWVEZXNjcmlwdGlvbihm bG9hdCB0aW1lKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIFN0cmluZygp OworfQorI2VuZGlmCisKIFN0cmluZyBtZWRpYUVsZW1lbnRMb2FkaW5nU3RhdGVUZXh0KCkKIHsK ICAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgiTG9hZGluZy4uLiIpOwpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAppbmRleCAwNzMyMTE2Li4wN2Y3NzYxIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcApAQCAtMTcxLDcgKzE3MSw3 IEBAIHN0YXRpYyBWZWN0b3I8TWVkaWFQbGF5ZXJGYWN0b3J5Kj4mIGluc3RhbGxlZE1lZGlhRW5n aW5lcygpCiAKICNpZiBQTEFURk9STShXSU4pCiAgICAgICAgIE1lZGlhUGxheWVyUHJpdmF0ZVF1 aWNrVGltZVZpc3VhbENvbnRleHQ6OnJlZ2lzdGVyTWVkaWFFbmdpbmUoYWRkTWVkaWFFbmdpbmUp OwotI2VsaWYgIVBMQVRGT1JNKEdUSykKKyNlbGlmICFQTEFURk9STShHVEspICYmICFQTEFURk9S TShFRkwpCiAgICAgICAgIC8vIEZJWE1FOiBjdXJyZW50bHkgYWxsIHRoZSBNZWRpYUVuZ2luZXMg YXJlIG5hbWVkCiAgICAgICAgIC8vIE1lZGlhUGxheWVyUHJpdmF0ZS4gVGhpcyBjb2RlIHdpbGwg bmVlZCBhbiB1cGRhdGUgd2hlbiBidWcKICAgICAgICAgLy8gMzY2NjMgaXMgYWRyZXNzZWQuCg==