4379 2005-08-10 18:55:01 -0700 negative margins allowed where they should not 2005-08-19 15:11:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 koivisto hyatt darin oldest_to_newest 16400 0 koivisto 2005-08-10 18:55:01 -0700 When making window narrow, the navigation bar on top of moneycentral.msn.com flows out of the view from left. The behavior is different from Gecko/IE where it stays fully in the view even when window is narrow. The problem is that in webcore a table with margin-left:auto is allowed to have negative calculated margin. Acutally, it seems that the following rule (css2.1, 10.3.3) is not respected, even with normal block boxes: If 'width' is not 'auto' and 'border-left-width' + 'padding-left' + 'width' + 'padding-right' + 'border-right-width' (plus any of 'margin-left' or 'margin-right' that are not 'auto') is larger than the width of the containing block, then any 'auto' values for 'margin-left' or 'margin-right' are, for the following rules, treated as zero. 16401 1 3330 koivisto 2005-08-10 19:00:53 -0700 Created attachment 3330 test case for tables make page narrow to see the problem 16402 2 3331 koivisto 2005-08-10 19:01:35 -0700 Created attachment 3331 test case for blocks 16462 3 3347 dacarson 2005-08-11 17:00:22 -0700 Created attachment 3347 margin calculation patch for boxes in normal flow with non-auto width, treat auto margins as 0 if width>containing width 16471 4 hyatt 2005-08-11 22:56:17 -0700 Yup, this patch is a flawless fix. Good job. r=me 16472 5 3347 hyatt 2005-08-11 22:58:02 -0700 Comment on attachment 3347 margin calculation patch r=me. Might be worth adding a comment that when you fall into the final else case, auto margins will end up being 0 when you call minWidth and assign into m_marginLeft and m_marginRight. 16540 6 3356 koivisto 2005-08-12 12:13:14 -0700 Created attachment 3356 margin calculation patch with comment (i was apparently logged in as David when submitting the patch) Added comment 16673 7 darin 2005-08-14 20:41:01 -0700 I'm ready to land this, but I'll need to change the test cases into suitable files for the layout-tests directory (explaining what they are testing and what good vs. bad results look like). 16685 8 darin 2005-08-14 22:02:57 -0700 I tried, but I can't figure out the desired results from the test cases. I'm going to leave this patch until someone who does understand them (Antti or Dave perhaps?) turns them into suitable layout tests by adding some explanation, or puts notes here enough to let me do that. 16686 9 darin 2005-08-14 22:03:12 -0700 I tried, but I can't figure out the desired results from the test cases. I'm going to leave this patch until someone who does understand them (Antti or Dave perhaps?) turns them into suitable layout tests by adding some explanation, or puts notes here enough to let me do that. 16752 10 3417 koivisto 2005-08-15 21:29:45 -0700 Created attachment 3417 cleaned up test case with an explanation 3330 2005-08-10 19:00:53 -0700 2005-08-15 21:29:45 -0700 test case for tables msn.html text/html 413 koivisto PGh0bWw+PGhlYWQ+DQo8c3R5bGU+DQp0YWJsZXttYXJnaW46MCAwIDAgYXV0b30NCnRke3doaXRl LXNwYWNlOm5vd3JhcDsgZm9udC1zaXplOiAzMHB4fQ0KPC9zdHlsZT4NCg0KPGJvZHkgc3R5bGU9 ImJvcmRlcjogMnB4IHNvbGlkIGJsdWUiPg0KCTx0YWJsZSBzdHlsZT0iYm9yZGVyOiAycHggc29s aWQgcmVkIj4NCgkJPHRib2R5Pg0KCQkJPHRyPg0KCQkJCTx0ZD4NCgkJCQkJTVNOIEhvbWUNCgkJ CQkJTXkgTVNODQoJCQkJCUhvdG1haWwNCgkJCQkJU2hvcHBpbmcNCgkJCQkJTW9uZXkgYWZldWFr ZndlYQ0KCQkJCQlQZW9wbGUgQ2hhdA0KCQkJCQlTaG9wcGluZw0KCQkJCQlNb25leSBhZmV1YWtm d2VhDQoJCQkJCVANCgkJCQk8L3RkPg0KCQkJPC90cj4NCgkJPC90Ym9keT4NCgk8L3RhYmxlPg0K PC9ib2R5PjwvaHRtbD4= 3331 2005-08-10 19:01:35 -0700 2005-08-15 21:29:45 -0700 test case for blocks msn2.html text/html 252 koivisto PGh0bWwgPjxoZWFkPg0KPHN0eWxlPg0KI04xYSBkaXZ7bWFyZ2luOjAgMCAwIGF1dG87IGJvcmRl cjogMnB4IHNvbGlkIHJlZDsgZm9udC1zaXplOiAzMHB4OyB3aWR0aDogODAwcHh9DQo8L3N0eWxl Pg0KDQo8Ym9keSBpZD0iTjFhIiBzdHlsZT0iYm9yZGVyOiAycHggc29saWQgYmx1ZSI+DQoNCgk8 ZGl2Pg0KCQkJCQlNU05Ib21lTXlNU05Ib3RtYWlsU2hvcHBpbmdNb25leWFmZXVha2Z3ZWENCg0K PC9kaXY+DQoNCjwvYm9keT48L2h0bWw+ 3347 2005-08-11 17:00:22 -0700 2005-08-14 20:40:19 -0700 margin calculation patch margin.diff text/plain 1591 dacarson SW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2JveC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTYwCmRpZmYgLXAgLXUgLXIxLjE2MCBraHRtbC9yZW5kZXJpbmcv cmVuZGVyX2JveC5jcHAKLS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAkzMCBKdWwg MjAwNSAwMjozMzoyMiAtMDAwMAkxLjE2MAorKysga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ib3gu Y3BwCTExIEF1ZyAyMDA1IDIzOjQ2OjEyIC0wMDAwCkBAIC05MjAsNyArOTIwLDcgQEAgdm9pZCBS ZW5kZXJCb3g6OmNhbGNIb3Jpem9udGFsTWFyZ2lucyhjbwogICAgIH0KICAgICBlbHNlCiAgICAg ewotICAgICAgICBpZiAoIChtbC50eXBlID09IFZhcmlhYmxlICYmIG1yLnR5cGUgPT0gVmFyaWFi bGUpIHx8CisgICAgICAgIGlmICggKG1sLnR5cGUgPT0gVmFyaWFibGUgJiYgbXIudHlwZSA9PSBW YXJpYWJsZSAmJiBtX3dpZHRoPGN3KSB8fAogICAgICAgICAgICAgIChtbC50eXBlICE9IFZhcmlh YmxlICYmIG1yLnR5cGUgIT0gVmFyaWFibGUgJiYKICAgICAgICAgICAgICAgICBjb250YWluaW5n QmxvY2soKS0+c3R5bGUoKS0+dGV4dEFsaWduKCkgPT0gS0hUTUxfQ0VOVEVSKSApCiAgICAgICAg IHsKQEAgLTkyOCwxNCArOTI4LDE0IEBAIHZvaWQgUmVuZGVyQm94OjpjYWxjSG9yaXpvbnRhbE1h cmdpbnMoY28KICAgICAgICAgICAgIGlmIChtX21hcmdpbkxlZnQ8MCkgbV9tYXJnaW5MZWZ0PTA7 CiAgICAgICAgICAgICBtX21hcmdpblJpZ2h0ID0gY3cgLSBtX3dpZHRoIC0gbV9tYXJnaW5MZWZ0 OwogICAgICAgICB9Ci0gICAgICAgIGVsc2UgaWYgKG1yLnR5cGUgPT0gVmFyaWFibGUgfHwKKyAg ICAgICAgZWxzZSBpZiAoIChtci50eXBlID09IFZhcmlhYmxlICYmIG1fd2lkdGg8Y3cpIHx8CiAg ICAgICAgICAgICAgICAgIChtbC50eXBlICE9IFZhcmlhYmxlICYmIGNvbnRhaW5pbmdCbG9jaygp LT5zdHlsZSgpLT5kaXJlY3Rpb24oKSA9PSBSVEwgJiYKICAgICAgICAgICAgICAgICAgIGNvbnRh aW5pbmdCbG9jaygpLT5zdHlsZSgpLT50ZXh0QWxpZ24oKSA9PSBLSFRNTF9MRUZUKSkKICAgICAg ICAgewogICAgICAgICAgICAgbV9tYXJnaW5MZWZ0ID0gbWwud2lkdGgoY3cpOwogICAgICAgICAg ICAgbV9tYXJnaW5SaWdodCA9IGN3IC0gbV93aWR0aCAtIG1fbWFyZ2luTGVmdDsKICAgICAgICAg fQotICAgICAgICBlbHNlIGlmIChtbC50eXBlID09IFZhcmlhYmxlIHx8CisgICAgICAgIGVsc2Ug aWYgKCAobWwudHlwZSA9PSBWYXJpYWJsZSAmJiBtX3dpZHRoPGN3KSB8fAogICAgICAgICAgICAg ICAgICAobXIudHlwZSAhPSBWYXJpYWJsZSAmJiBjb250YWluaW5nQmxvY2soKS0+c3R5bGUoKS0+ ZGlyZWN0aW9uKCkgPT0gTFRSICYmCiAgICAgICAgICAgICAgICAgICBjb250YWluaW5nQmxvY2so KS0+c3R5bGUoKS0+dGV4dEFsaWduKCkgPT0gS0hUTUxfUklHSFQpKQogICAgICAgICB7Cg== 3356 2005-08-12 12:13:14 -0700 2005-08-14 20:40:10 -0700 margin calculation patch with comment margin2.diff text/plain 1886 koivisto SW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2JveC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTYwCmRpZmYgLXAgLXUgLXIxLjE2MCBraHRtbC9yZW5kZXJpbmcv cmVuZGVyX2JveC5jcHAKLS0tIGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAkzMCBKdWwg MjAwNSAwMjozMzoyMiAtMDAwMAkxLjE2MAorKysga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9ib3gu Y3BwCTEyIEF1ZyAyMDA1IDE5OjA4OjE5IC0wMDAwCkBAIC05MjAsNyArOTIwLDcgQEAgdm9pZCBS ZW5kZXJCb3g6OmNhbGNIb3Jpem9udGFsTWFyZ2lucyhjbwogICAgIH0KICAgICBlbHNlCiAgICAg ewotICAgICAgICBpZiAoIChtbC50eXBlID09IFZhcmlhYmxlICYmIG1yLnR5cGUgPT0gVmFyaWFi bGUpIHx8CisgICAgICAgIGlmICggKG1sLnR5cGUgPT0gVmFyaWFibGUgJiYgbXIudHlwZSA9PSBW YXJpYWJsZSAmJiBtX3dpZHRoPGN3KSB8fAogICAgICAgICAgICAgIChtbC50eXBlICE9IFZhcmlh YmxlICYmIG1yLnR5cGUgIT0gVmFyaWFibGUgJiYKICAgICAgICAgICAgICAgICBjb250YWluaW5n QmxvY2soKS0+c3R5bGUoKS0+dGV4dEFsaWduKCkgPT0gS0hUTUxfQ0VOVEVSKSApCiAgICAgICAg IHsKQEAgLTkyOCwxNCArOTI4LDE0IEBAIHZvaWQgUmVuZGVyQm94OjpjYWxjSG9yaXpvbnRhbE1h cmdpbnMoY28KICAgICAgICAgICAgIGlmIChtX21hcmdpbkxlZnQ8MCkgbV9tYXJnaW5MZWZ0PTA7 CiAgICAgICAgICAgICBtX21hcmdpblJpZ2h0ID0gY3cgLSBtX3dpZHRoIC0gbV9tYXJnaW5MZWZ0 OwogICAgICAgICB9Ci0gICAgICAgIGVsc2UgaWYgKG1yLnR5cGUgPT0gVmFyaWFibGUgfHwKKyAg ICAgICAgZWxzZSBpZiAoIChtci50eXBlID09IFZhcmlhYmxlICYmIG1fd2lkdGg8Y3cpIHx8CiAg ICAgICAgICAgICAgICAgIChtbC50eXBlICE9IFZhcmlhYmxlICYmIGNvbnRhaW5pbmdCbG9jaygp LT5zdHlsZSgpLT5kaXJlY3Rpb24oKSA9PSBSVEwgJiYKICAgICAgICAgICAgICAgICAgIGNvbnRh aW5pbmdCbG9jaygpLT5zdHlsZSgpLT50ZXh0QWxpZ24oKSA9PSBLSFRNTF9MRUZUKSkKICAgICAg ICAgewogICAgICAgICAgICAgbV9tYXJnaW5MZWZ0ID0gbWwud2lkdGgoY3cpOwogICAgICAgICAg ICAgbV9tYXJnaW5SaWdodCA9IGN3IC0gbV93aWR0aCAtIG1fbWFyZ2luTGVmdDsKICAgICAgICAg fQotICAgICAgICBlbHNlIGlmIChtbC50eXBlID09IFZhcmlhYmxlIHx8CisgICAgICAgIGVsc2Ug aWYgKCAobWwudHlwZSA9PSBWYXJpYWJsZSAmJiBtX3dpZHRoPGN3KSB8fAogICAgICAgICAgICAg ICAgICAobXIudHlwZSAhPSBWYXJpYWJsZSAmJiBjb250YWluaW5nQmxvY2soKS0+c3R5bGUoKS0+ ZGlyZWN0aW9uKCkgPT0gTFRSICYmCiAgICAgICAgICAgICAgICAgICBjb250YWluaW5nQmxvY2so KS0+c3R5bGUoKS0+dGV4dEFsaWduKCkgPT0gS0hUTUxfUklHSFQpKQogICAgICAgICB7CkBAIC05 NDQsNiArOTQ0LDcgQEAgdm9pZCBSZW5kZXJCb3g6OmNhbGNIb3Jpem9udGFsTWFyZ2lucyhjbwog ICAgICAgICB9CiAgICAgICAgIGVsc2UKICAgICAgICAgeworICAgICAgICAgICAgLy8gdGhpcyBt YWtlcyBhdXRvIG1hcmdpbnMgMCBpZiB3ZSBmYWlsZWQgYSBtX3dpZHRoPGN3IHRlc3QgYWJvdmUg KGNzczIuMSwgMTAuMy4zKQogICAgICAgICAgICAgbV9tYXJnaW5MZWZ0ID0gbWwubWluV2lkdGgo Y3cpOwogICAgICAgICAgICAgbV9tYXJnaW5SaWdodCA9IG1yLm1pbldpZHRoKGN3KTsKICAgICAg ICAgfQo= 3417 2005-08-15 21:29:45 -0700 2005-08-15 21:29:45 -0700 cleaned up test case with an explanation margin-auto.html text/html 747 koivisto PGh0bWw+PGhlYWQ+CjxzdHlsZT4KI2NvbnRhaW5lciB7Ym9yZGVyOiAycHggc29saWQgYmx1ZX0K dGFibGV7bWFyZ2luOiAwIDAgMCBhdXRvIDsgYm9yZGVyOiAycHggc29saWQgcmVkfQp0ZHt3aGl0 ZS1zcGFjZTogbm93cmFwO30KI2Ige21hcmdpbjogMCAwIDAgYXV0bzsgd2lkdGg6IDkwMHB4OyBi b3JkZXI6IDJweCBzb2xpZCByZWQ7fQo8L3N0eWxlPgoKPGJvZHk+CjxkaXYgaWQ9Y29udGFpbmVy PgoJUmVzaXplIHRoZSB3aW5kb3cuIFJlZCBib3hlcyBiZWxvdyBtdXN0IG5vdCBvdmVyZmxvdyB0 aGUgYmx1ZSBib3ggKG9yIHdpbmRvdykgZnJvbSB0aGUgCglsZWZ0IHNpZGUsIHRob3VnaCB0aGV5 IG1heSBvdmVyZmxvdyBmcm9tIHJpZ2h0Ljxicj48YnI+Cgk8dGFibGU+CgkJPHRib2R5PgoJCQk8 dHI+CgkJCQk8dGQ+CgkJCQlCbGFibGEgYmxhaC4gQmxhYmxhIGJsYWguIEJsYWJsYSBibGFoLiBC bGFibGEgYmxhaC4gQmxhYmxhIGJsYWguIEJsYWJsYSBibGFoLgoJCQkJQmxhYmxhIGJsYWguIEJs YWJsYSBibGFoLiBCbGFibGEgYmxhaC4gQmxhYmxhIGJsYWguIEJsYWJsYSBibGFoLiBCbGFibGEg YmxhaC4KCQkJCTwvdGQ+CgkJCTwvdHI+CgkJPC90Ym9keT4KCTwvdGFibGU+CgkKCTxkaXYgaWQ9 Yj4KCQkJQmxhYmxhIGJsYWguIEJsYWJsYSBibGFoLiBCbGFibGEgYmxhaC4gQmxhYmxhIGJsYWgu IEJsYWJsYSBibGFoLiBCbGFibGEgYmxhaC4KICAgPC9kaXY+CQo8L2Rpdj4gICAKPC9ib2R5Pgo8 L2h0bWw+