43784 2010-08-10 04:55:23 -0700 Make CSSSelector::specificity() non-recursive. 2010-08-10 22:21:23 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 42806 0 hayato webkit-unassigned commit-queue oldest_to_newest 262623 0 hayato 2010-08-10 04:55:23 -0700 Please see the master bug for details. https://bugs.webkit.org/show_bug.cgi?id=42806 We have to make CSSSelector::specificity() non-recursive in order to avoid stack overflow when a long CSS selector is used. 262629 1 64001 hayato 2010-08-10 05:23:00 -0700 Created attachment 64001 make-it-iterative 262992 2 64001 tkent 2010-08-10 22:02:30 -0700 Comment on attachment 64001 make-it-iterative Looks good. 263003 3 64001 commit-queue 2010-08-10 22:21:19 -0700 Comment on attachment 64001 make-it-iterative Clearing flags on attachment: 64001 Committed r65123: <http://trac.webkit.org/changeset/65123> 263004 4 commit-queue 2010-08-10 22:21:23 -0700 All reviewed patches have been landed. Closing bug. 64001 2010-08-10 05:23:00 -0700 2010-08-10 22:21:19 -0700 make-it-iterative bug-43784-20100810212258.patch text/plain 4138 hayato ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWNjNjAwNzUzODQ2NWQ5M2RlMjI3MjhiNmVlMTkxM2UxYTY4YjE5Ni4uMDk0NmFjYTJmMzhhMDg2 NDEyYjEyNTNmNDFjN2E5YTBkNTczNzE4MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOC0xMCAgSGF5 YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBDU1NTZWxlY3Rvcjo6c3BlY2lmaWNpdHkoKSBu b24tcmVjdXJzaXZlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDM3ODQKKworICAgICAgICBUaGlzIGNoYW5nZSBpcyBvbmUgb2YgdGhlIHJlcXVpcmVk IGNoYW5nZXMgdG8gZml4IHRoZSBmb2xsb3dpbmcgbWFzdGVyIGJ1ZzoKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQyODA2CisKKyAgICAgICAgTm8gZnVu Y3Rpb25hbCBjaGFuZ2UsIHRodXMgbm8gdGVzdHMuCisKKyAgICAgICAgKiBjc3MvQ1NTU2VsZWN0 b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTU2VsZWN0b3I6OnNwZWNpZmljaXR5KToKKyAg ICAgICAgKFdlYkNvcmU6OkNTU1NlbGVjdG9yOjpzcGVjaWZpY2l0eUZvck9uZVNlbGVjdG9yKToK KyAgICAgICAgKFdlYkNvcmU6OkNTU1NlbGVjdG9yOjpzcGVjaWZpY2l0eUZvclBhZ2UpOgorICAg ICAgICAqIGNzcy9DU1NTZWxlY3Rvci5oOgorCiAyMDEwLTA4LTA5ICBBZGFtIEJhcnRoICA8YWJh cnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NTZWxlY3Rvci5jcHAgYi9XZWJDb3JlL2Nzcy9DU1NTZWxl Y3Rvci5jcHAKaW5kZXggY2E2Y2MzZDFlZWFiOTIzMmIzMzgwZDM3NjgwZDhhZWJmNzVlN2ExMS4u NzZhMTI0NjYwZmNjN2E1OTA3ZGNiMjA3MDA0ZTNiZWIzYmY5YTgxMyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9jc3MvQ1NTU2VsZWN0b3IuY3BwCisrKyBiL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmNw cApAQCAtNjksNDIgKzY5LDQ2IEBAIHByaXZhdGU6CiAgICAgVmVjdG9yPENTU1NlbGVjdG9yKiwg MTY+IG1fc3RhY2s7CiB9OwogCi11bnNpZ25lZCBpbnQgQ1NTU2VsZWN0b3I6OnNwZWNpZmljaXR5 KCkKK3Vuc2lnbmVkIENTU1NlbGVjdG9yOjpzcGVjaWZpY2l0eSgpIGNvbnN0CiB7Ci0gICAgaWYg KG1faXNGb3JQYWdlKQotICAgICAgICByZXR1cm4gc3BlY2lmaWNpdHlGb3JQYWdlKCk7CisgICAg Ly8gbWFrZSBzdXJlIHRoZSByZXN1bHQgZG9lc24ndCBvdmVyZmxvdworICAgIHN0YXRpYyBjb25z dCB1bnNpZ25lZCBtYXhWYWx1ZU1hc2sgPSAweGZmZmZmZjsKKyAgICB1bnNpZ25lZCB0b3RhbCA9 IDA7CisgICAgZm9yIChjb25zdCBDU1NTZWxlY3Rvciogc2VsZWN0b3IgPSB0aGlzOyBzZWxlY3Rv cjsgc2VsZWN0b3IgPSBzZWxlY3Rvci0+dGFnSGlzdG9yeSgpKSB7CisgICAgICAgIGlmIChzZWxl Y3Rvci0+bV9pc0ZvclBhZ2UpCisgICAgICAgICAgICByZXR1cm4gKHRvdGFsICsgc2VsZWN0b3It PnNwZWNpZmljaXR5Rm9yUGFnZSgpKSAmIG1heFZhbHVlTWFzazsKKyAgICAgICAgdG90YWwgPSAo dG90YWwgKyBzZWxlY3Rvci0+c3BlY2lmaWNpdHlGb3JPbmVTZWxlY3RvcigpKSAmIG1heFZhbHVl TWFzazsKKyAgICB9CisgICAgcmV0dXJuIHRvdGFsOworfQogCitpbmxpbmUgdW5zaWduZWQgQ1NT U2VsZWN0b3I6OnNwZWNpZmljaXR5Rm9yT25lU2VsZWN0b3IoKSBjb25zdAorewogICAgIC8vIEZJ WE1FOiBQc2V1ZG8tZWxlbWVudHMgYW5kIHBzZXVkby1jbGFzc2VzIGRvIG5vdCBoYXZlIHRoZSBz YW1lIHNwZWNpZmljaXR5LiBUaGlzIGZ1bmN0aW9uCiAgICAgLy8gaXNuJ3QgcXVpdGUgY29ycmVj dC4KLSAgICBpbnQgcyA9IChtX3RhZy5sb2NhbE5hbWUoKSA9PSBzdGFyQXRvbSA/IDAgOiAxKTsK KyAgICB1bnNpZ25lZCBzID0gKG1fdGFnLmxvY2FsTmFtZSgpID09IHN0YXJBdG9tID8gMCA6IDEp OwogICAgIHN3aXRjaCAobV9tYXRjaCkgewotICAgICAgICBjYXNlIElkOgotICAgICAgICAgICAg cyArPSAweDEwMDAwOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgRXhhY3Q6Ci0g ICAgICAgIGNhc2UgQ2xhc3M6Ci0gICAgICAgIGNhc2UgU2V0OgotICAgICAgICBjYXNlIExpc3Q6 Ci0gICAgICAgIGNhc2UgSHlwaGVuOgotICAgICAgICBjYXNlIFBzZXVkb0NsYXNzOgotICAgICAg ICBjYXNlIFBzZXVkb0VsZW1lbnQ6Ci0gICAgICAgIGNhc2UgQ29udGFpbjoKLSAgICAgICAgY2Fz ZSBCZWdpbjoKLSAgICAgICAgY2FzZSBFbmQ6Ci0gICAgICAgICAgICBzICs9IDB4MTAwOwotICAg ICAgICBjYXNlIE5vbmU6Ci0gICAgICAgICAgICBicmVhazsKKyAgICBjYXNlIElkOgorICAgICAg ICBzICs9IDB4MTAwMDA7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgRXhhY3Q6CisgICAgY2Fz ZSBDbGFzczoKKyAgICBjYXNlIFNldDoKKyAgICBjYXNlIExpc3Q6CisgICAgY2FzZSBIeXBoZW46 CisgICAgY2FzZSBQc2V1ZG9DbGFzczoKKyAgICBjYXNlIFBzZXVkb0VsZW1lbnQ6CisgICAgY2Fz ZSBDb250YWluOgorICAgIGNhc2UgQmVnaW46CisgICAgY2FzZSBFbmQ6CisgICAgICAgIHMgKz0g MHgxMDA7CisgICAgY2FzZSBOb25lOgorICAgICAgICBicmVhazsKICAgICB9Ci0KLSAgICAvLyBG SVhNRTogQXZvaWQgcmVjdXJzaXZlIGNhbGxzIHRvIHByZXZlbnQgcG9zc2libGUgc3RhY2sgb3Zl cmZsb3cuCi0gICAgaWYgKENTU1NlbGVjdG9yKiB0YWdIaXN0b3J5ID0gdGhpcy0+dGFnSGlzdG9y eSgpKQotICAgICAgICBzICs9IHRhZ0hpc3RvcnktPnNwZWNpZmljaXR5KCk7Ci0KLSAgICAvLyBt YWtlIHN1cmUgaXQgZG9lc24ndCBvdmVyZmxvdwotICAgIHJldHVybiBzICYgMHhmZmZmZmY7Cisg ICAgcmV0dXJuIHM7CiB9CiAKLXVuc2lnbmVkIENTU1NlbGVjdG9yOjpzcGVjaWZpY2l0eUZvclBh Z2UoKQordW5zaWduZWQgQ1NTU2VsZWN0b3I6OnNwZWNpZmljaXR5Rm9yUGFnZSgpIGNvbnN0CiB7 CiAgICAgLy8gU2VlIGh0dHA6Ly9kZXYudzMub3JnL2Nzc3dnL2NzczMtcGFnZS8jY2FzY2FkaW5n LWFuZC1wYWdlLWNvbnRleHQKICAgICB1bnNpZ25lZCBzID0gKG1fdGFnLmxvY2FsTmFtZSgpID09 IHN0YXJBdG9tID8gMCA6IDQpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3Iu aCBiL1dlYkNvcmUvY3NzL0NTU1NlbGVjdG9yLmgKaW5kZXggMzRlNGFmMDg3ZDRmNDdmZTBjYTNl MWRiZTgwYjhhZGNjY2JhNGVhYy4uZTI1Mzk0OTMzYzgwZGRmYzZhM2M1M2Q4OGIwZDljNDE4ZmU0 ODZjYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvQ1NTU2VsZWN0b3IuaAorKysgYi9XZWJDb3Jl L2Nzcy9DU1NTZWxlY3Rvci5oCkBAIC04NSw3ICs4NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAogICAgICAgICAvLyB0YWcgPT0gLTEgbWVhbnMgYXBwbHkgdG8gYWxsIGVsZW1lbnRzIChTZWxl Y3RvciA9ICopCiAKLSAgICAgICAgdW5zaWduZWQgc3BlY2lmaWNpdHkoKTsKKyAgICAgICAgdW5z aWduZWQgc3BlY2lmaWNpdHkoKSBjb25zdDsKIAogICAgICAgICAvKiBob3cgdGhlIGF0dHJpYnV0 ZSB2YWx1ZSBoYXMgdG8gbWF0Y2guLi4uIERlZmF1bHQgaXMgRXhhY3QgKi8KICAgICAgICAgZW51 bSBNYXRjaCB7CkBAIC0yOTQsNyArMjk0LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAg ICB2b2lkIHJlbGVhc2VPd25lZFNlbGVjdG9yc1RvQmFnKENTU1NlbGVjdG9yQmFnJik7CiAgICAg ICAgIHZvaWQgZGVsZXRlUmVhY2hhYmxlU2VsZWN0b3JzKCk7CiAKLSAgICAgICAgdW5zaWduZWQg c3BlY2lmaWNpdHlGb3JQYWdlKCk7CisgICAgICAgIHVuc2lnbmVkIHNwZWNpZmljaXR5Rm9yT25l U2VsZWN0b3IoKSBjb25zdDsKKyAgICAgICAgdW5zaWduZWQgc3BlY2lmaWNpdHlGb3JQYWdlKCkg Y29uc3Q7CiAgICAgICAgIHZvaWQgZXh0cmFjdFBzZXVkb1R5cGUoKSBjb25zdDsKIAogICAgICAg ICBzdHJ1Y3QgUmFyZURhdGEgOiBOb25jb3B5YWJsZSB7Cg==