43770 2010-08-09 23:43:25 -0700 Web Inspector: small refactoring for CodeGeneratorInspector. 2010-08-10 06:24:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 262514 0 loislo 2010-08-09 23:43:25 -0700 a number of push calls can be replaced by embedded text. Just for improve code readability. 262518 1 63979 loislo 2010-08-09 23:57:28 -0700 Created attachment 63979 [patch] initial version. 262651 2 loislo 2010-08-10 06:24:54 -0700 Committed r65058 M WebCore/ChangeLog M WebCore/inspector/CodeGeneratorInspector.pm r65058 = ac17d303ac2e5bdc08f5a04aef7993f597abab10 (refs/remotes/trunk) 63979 2010-08-09 23:57:28 -0700 2010-08-09 23:58:14 -0700 [patch] initial version. patch text/plain 5716 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg M2NhMjQwYi4uYzgwOTdhNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0wOSAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc21hbGwgcmVmYWN0b3JpbmcgZm9y IENvZGVHZW5lcmF0b3JJbnNwZWN0b3IuCisgICAgICAgIEEgbnVtYmVyIG9mIHB1c2ggY2FsbHMg d2VyZSByZXBsYWNlZCBieSBlbWJlZGRlZCB0ZXh0LgorICAgICAgICBKdXN0IGZvciBpbXByb3Zl IGNvZGUgcmVhZGFiaWxpdHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00Mzc3MAorCisgICAgICAgICogaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNw ZWN0b3IucG06CisKIDIwMTAtMDgtMDkgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hA YXBwbGUuY29tPgogCiAgICAgICAgIFF0IGJ1aWxkIGZpeCBhdHRlbXB0IFZJSUkuCmRpZmYgLS1n aXQgYS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnBtIGIvV2ViQ29y ZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQppbmRleCBkNGE3MGZjLi4wZDM3 NTBhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9y LnBtCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucG0KQEAg LTM5Myw1NCArMzkzLDU3IEBAIHN1YiBnZW5lcmF0ZUJhY2tlbmREaXNwYXRjaGVyCiB7CiAgICAg bXkgQGJvZHk7CiAgICAgbXkgQG1ldGhvZHMgPSBtYXAoJGJhY2tlbmRNZXRob2RzeyRffSwga2V5 cyAlYmFja2VuZE1ldGhvZHMpOwotICAgIG15IEBtYXBFbnRyaWVzID0gbWFwKCJkaXNwYXRjaE1h cC5hZGQoXCIkX1wiLCAmJHtiYWNrZW5kQ2xhc3NOYW1lfTo6JF8pOyIsIEBtZXRob2RzKTsKLQot ICAgIHB1c2goQGJvZHksICJ2b2lkICR7YmFja2VuZENsYXNzTmFtZX06OmRpc3BhdGNoKGNvbnN0 IFN0cmluZyYgbWVzc2FnZSkiKTsKLSAgICBwdXNoKEBib2R5LCAieyIpOwotICAgIHB1c2goQGJv ZHksICIgICAgdHlwZWRlZiB2b2lkICgke2JhY2tlbmRDbGFzc05hbWV9OjoqQ2FsbEhhbmRsZXIp KFBhc3NSZWZQdHI8SW5zcGVjdG9yQXJyYXk+IGFyZ3MpOyIpOwotICAgIHB1c2goQGJvZHksICIg ICAgdHlwZWRlZiBIYXNoTWFwPFN0cmluZywgQ2FsbEhhbmRsZXI+IERpc3BhdGNoTWFwOyIpOwot ICAgIHB1c2goQGJvZHksICIgICAgREVGSU5FX1NUQVRJQ19MT0NBTChEaXNwYXRjaE1hcCwgZGlz cGF0Y2hNYXAsICk7Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICBpZiAoZGlzcGF0Y2hNYXAuaXNF bXB0eSgpKSB7Iik7Ci0gICAgcHVzaChAYm9keSwgbWFwKCIgICAgICAgICRfIiwgQG1hcEVudHJp ZXMpKTsKLSAgICBwdXNoKEBib2R5LCAiICAgIH0iKTsKLSAgICBwdXNoKEBib2R5LCAiIik7Ci0g ICAgcHVzaChAYm9keSwgIiAgICBSZWZQdHI8SW5zcGVjdG9yVmFsdWU+IHBhcnNlZE1lc3NhZ2Ug PSBJbnNwZWN0b3JWYWx1ZTo6cGFyc2VKU09OKG1lc3NhZ2UpOyIpOwotICAgIHB1c2goQGJvZHks ICIgICAgaWYgKCFwYXJzZWRNZXNzYWdlKSB7Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICAgICAgcmVwb3J0 UHJvdG9jb2xFcnJvcigwLCBcImRpc3BhdGNoXCIsIFwiRXJyb3I6IEludmFsaWQgbWVzc2FnZSBm b3JtYXQuIE1lc3NhZ2Ugc2hvdWxkIGJlIGluIEpTT04gZm9ybWF0LlwiKTsiKTsKLSAgICBwdXNo KEBib2R5LCAiICAgICAgICByZXR1cm47Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICB9Iik7Ci0g ICAgcHVzaChAYm9keSwgIiIpOwotICAgIHB1c2goQGJvZHksICIgICAgUmVmUHRyPEluc3BlY3Rv ckFycmF5PiBtZXNzYWdlQXJyYXkgPSBwYXJzZWRNZXNzYWdlLT5hc0FycmF5KCk7Iik7Ci0gICAg cHVzaChAYm9keSwgIiAgICBpZiAoIW1lc3NhZ2VBcnJheSkgeyIpOwotICAgIHB1c2goQGJvZHks ICIgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOyIpOwotICAgIHB1c2goQGJvZHksICIgICAg ICAgIHJlcG9ydFByb3RvY29sRXJyb3IoMCwgXCJkaXNwYXRjaFwiLCBcIkVycm9yOiBJbnZhbGlk IG1lc3NhZ2UgZm9ybWF0LiBUaGUgbWVzc2FnZSBzaG91bGQgYmUgYSBKU09OaWZpZWQgYXJyYXkg b2YgYXJndW1lbnRzLlwiKTsiKTsKLSAgICBwdXNoKEBib2R5LCAiICAgICAgICByZXR1cm47Iik7 Ci0gICAgcHVzaChAYm9keSwgIiAgICB9Iik7Ci0gICAgcHVzaChAYm9keSwgIiIpOwotICAgIHB1 c2goQGJvZHksICIgICAgaWYgKCFtZXNzYWdlQXJyYXktPmxlbmd0aCgpKSB7Iik7Ci0gICAgcHVz aChAYm9keSwgIiAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Iik7Ci0gICAgcHVzaChAYm9k eSwgIiAgICAgICAgcmVwb3J0UHJvdG9jb2xFcnJvcigwLCBcImRpc3BhdGNoXCIsIFwiRXJyb3I6 IEludmFsaWQgbWVzc2FnZSBmb3JtYXQuIEVtcHR5IG1lc3NhZ2Ugd2FzIHJlY2VpdmVkLlwiKTsi KTsKLSAgICBwdXNoKEBib2R5LCAiICAgICAgICByZXR1cm47Iik7Ci0gICAgcHVzaChAYm9keSwg IiAgICB9Iik7Ci0gICAgcHVzaChAYm9keSwgIiIpOwotICAgIHB1c2goQGJvZHksICIgICAgU3Ry aW5nIG1ldGhvZE5hbWU7Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICBpZiAoIW1lc3NhZ2VBcnJh eS0+Z2V0KDApLT5hc1N0cmluZygmbWV0aG9kTmFtZSkpIHsiKTsKLSAgICBwdXNoKEBib2R5LCAi ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsiKTsKLSAgICBwdXNoKEBib2R5LCAiICAgICAg ICByZXBvcnRQcm90b2NvbEVycm9yKDAsIFwiZGlzcGF0Y2hcIiwgXCJFcnJvcjogSW52YWxpZCBt ZXNzYWdlIGZvcm1hdC4gVGhlIGZpcnN0IGVsZW1lbnQgb2YgdGhlIG1lc3NhZ2Ugc2hvdWxkIGJl IG1ldGhvZCBuYW1lLlwiKTsiKTsKLSAgICBwdXNoKEBib2R5LCAiICAgICAgICByZXR1cm47Iik7 Ci0gICAgcHVzaChAYm9keSwgIiAgICB9Iik7Ci0gICAgcHVzaChAYm9keSwgIiIpOwotICAgIHB1 c2goQGJvZHksICIgICAgSGFzaE1hcDxTdHJpbmcsIENhbGxIYW5kbGVyPjo6aXRlcmF0b3IgaXQg PSBkaXNwYXRjaE1hcC5maW5kKG1ldGhvZE5hbWUpOyIpOwotICAgIHB1c2goQGJvZHksICIgICAg aWYgKGl0ID09IGRpc3BhdGNoTWFwLmVuZCgpKSB7Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Iik7Ci0gICAgcHVzaChAYm9keSwgIiAgICAgICAgcmVw b3J0UHJvdG9jb2xFcnJvcigwLCBcImRpc3BhdGNoXCIsIFN0cmluZzo6Zm9ybWF0KFwiRXJyb3I6 IEludmFsaWQgbWV0aG9kIG5hbWUuICclcycgd2Fzbid0IGZvdW5kLlwiLCBtZXRob2ROYW1lLnV0 ZjgoKS5kYXRhKCkpKTsiKTsKLSAgICBwdXNoKEBib2R5LCAiICAgICAgICByZXR1cm47Iik7Ci0g ICAgcHVzaChAYm9keSwgIiAgICB9Iik7Ci0gICAgcHVzaChAYm9keSwgIiIpOwotICAgIHB1c2go QGJvZHksICIgICAgKCgqdGhpcykuKml0LT5zZWNvbmQpKG1lc3NhZ2VBcnJheSk7Iik7Ci0gICAg cHVzaChAYm9keSwgIn0iKTsKLSAgICByZXR1cm4gQGJvZHk7CisgICAgbXkgQG1hcEVudHJpZXMg PSBtYXAoIiAgICAgICAgZGlzcGF0Y2hNYXAuYWRkKFwiJF9cIiwgJiR7YmFja2VuZENsYXNzTmFt ZX06OiRfKTsiLCBAbWV0aG9kcyk7CisgICAgbXkgJG1hcEVudHJpZXMgPSBqb2luKCJcbiIsIEBt YXBFbnRyaWVzKTsKKworICAgIG15ICRiYWNrZW5kRGlzcGF0Y2hlckJvZHkgPSA8PCAiRU9GIjsK K3ZvaWQgJHtiYWNrZW5kQ2xhc3NOYW1lfTo6ZGlzcGF0Y2goY29uc3QgU3RyaW5nJiBtZXNzYWdl KQoreworICAgIHR5cGVkZWYgdm9pZCAoJHtiYWNrZW5kQ2xhc3NOYW1lfTo6KkNhbGxIYW5kbGVy KShQYXNzUmVmUHRyPEluc3BlY3RvckFycmF5PiBhcmdzKTsKKyAgICB0eXBlZGVmIEhhc2hNYXA8 U3RyaW5nLCBDYWxsSGFuZGxlcj4gRGlzcGF0Y2hNYXA7CisgICAgREVGSU5FX1NUQVRJQ19MT0NB TChEaXNwYXRjaE1hcCwgZGlzcGF0Y2hNYXAsICk7CisgICAgaWYgKGRpc3BhdGNoTWFwLmlzRW1w dHkoKSkgeworJG1hcEVudHJpZXMKKyAgICB9CisKKyAgICBSZWZQdHI8SW5zcGVjdG9yVmFsdWU+ IHBhcnNlZE1lc3NhZ2UgPSBJbnNwZWN0b3JWYWx1ZTo6cGFyc2VKU09OKG1lc3NhZ2UpOworICAg IGlmICghcGFyc2VkTWVzc2FnZSkgeworICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAg ICAgICAgcmVwb3J0UHJvdG9jb2xFcnJvcigwLCAiZGlzcGF0Y2giLCAiRXJyb3I6IEludmFsaWQg bWVzc2FnZSBmb3JtYXQuIE1lc3NhZ2Ugc2hvdWxkIGJlIGluIEpTT04gZm9ybWF0LiIpOworICAg ICAgICByZXR1cm47CisgICAgfQorCisgICAgUmVmUHRyPEluc3BlY3RvckFycmF5PiBtZXNzYWdl QXJyYXkgPSBwYXJzZWRNZXNzYWdlLT5hc0FycmF5KCk7CisgICAgaWYgKCFtZXNzYWdlQXJyYXkp IHsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIHJlcG9ydFByb3RvY29s RXJyb3IoMCwgImRpc3BhdGNoIiwgIkVycm9yOiBJbnZhbGlkIG1lc3NhZ2UgZm9ybWF0LiBUaGUg bWVzc2FnZSBzaG91bGQgYmUgYSBKU09OaWZpZWQgYXJyYXkgb2YgYXJndW1lbnRzLiIpOworICAg ICAgICByZXR1cm47CisgICAgfQorCisgICAgaWYgKCFtZXNzYWdlQXJyYXktPmxlbmd0aCgpKSB7 CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXBvcnRQcm90b2NvbEVy cm9yKDAsICJkaXNwYXRjaCIsICJFcnJvcjogSW52YWxpZCBtZXNzYWdlIGZvcm1hdC4gRW1wdHkg bWVzc2FnZSB3YXMgcmVjZWl2ZWQuIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBT dHJpbmcgbWV0aG9kTmFtZTsKKyAgICBpZiAoIW1lc3NhZ2VBcnJheS0+Z2V0KDApLT5hc1N0cmlu ZygmbWV0aG9kTmFtZSkpIHsKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAg IHJlcG9ydFByb3RvY29sRXJyb3IoMCwgImRpc3BhdGNoIiwgIkVycm9yOiBJbnZhbGlkIG1lc3Nh Z2UgZm9ybWF0LiBUaGUgZmlyc3QgZWxlbWVudCBvZiB0aGUgbWVzc2FnZSBzaG91bGQgYmUgbWV0 aG9kIG5hbWUuIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBIYXNoTWFwPFN0cmlu ZywgQ2FsbEhhbmRsZXI+OjppdGVyYXRvciBpdCA9IGRpc3BhdGNoTWFwLmZpbmQobWV0aG9kTmFt ZSk7CisgICAgaWYgKGl0ID09IGRpc3BhdGNoTWFwLmVuZCgpKSB7CisgICAgICAgIEFTU0VSVF9O T1RfUkVBQ0hFRCgpOworICAgICAgICByZXBvcnRQcm90b2NvbEVycm9yKDAsICJkaXNwYXRjaCIs IFN0cmluZzo6Zm9ybWF0KCJFcnJvcjogSW52YWxpZCBtZXRob2QgbmFtZS4gJyVzJyB3YXNuJ3Qg Zm91bmQuIiwgbWV0aG9kTmFtZS51dGY4KCkuZGF0YSgpKSk7CisgICAgICAgIHJldHVybjsKKyAg ICB9CisKKyAgICAoKCp0aGlzKS4qaXQtPnNlY29uZCkobWVzc2FnZUFycmF5KTsKK30KK0VPRgor ICAgIHJldHVybiBzcGxpdCgiXG4iLCAkYmFja2VuZERpc3BhdGNoZXJCb2R5KTsKIH0KIAogc3Vi IGdlbmVyYXRlSGVhZGVyCg==