43760 2010-08-09 17:08:14 -0700 [GTK] Inputs of type 'search' have weird looking checkboxes instead of search/clear icons 2010-08-11 16:21:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Gtk P2 Normal --- 1 gustavo webkit-unassigned mrobinson oldest_to_newest 262423 0 gustavo 2010-08-09 17:08:14 -0700 Subject says it all. If you have, say, <input type="search" results="0"> this should be drawing a nice search icon in the left corner of the entry, and a clear icon in the right corner, when something is entered, but we get weird checkboxes instead. 262425 1 63958 gustavo 2010-08-09 17:13:39 -0700 Created attachment 63958 proposed patch 262695 2 63958 xan.lopez 2010-08-10 08:36:07 -0700 Comment on attachment 63958 proposed patch Good. 262714 3 mrobinson 2010-08-10 09:38:47 -0700 I think it might be good to make these icons members of the RenderTheme, much like the images used for media buttons. What do you think? 262718 4 gustavo 2010-08-10 09:49:53 -0700 Oops, sorry Martin, I just landed r65074 before reading your comment. I thought about doing it that way, but I didn't really see advantages to adding the complexity, do you see any advantage in having member variables? 262720 5 63958 gustavo 2010-08-10 09:50:32 -0700 Comment on attachment 63958 proposed patch Landed as r65074. I'm leaving the bug open while we explore Martin's suggestion. 263511 6 mrobinson 2010-08-11 16:21:08 -0700 The reason I suggested was in case we could track changes to the icon theme. Perhaps we cannot, but either way this could easily be a followup patch. I'll close this issue for now! :) 63958 2010-08-09 17:13:39 -0700 2010-08-10 09:50:32 -0700 proposed patch 0001-Fix-drawing-of-search-clear-images-in-search-entries.patch text/plain 3351 gustavo RnJvbSBlNTljZjhiYjkyZjAyNTRkMDQ5MDIxM2UwNmQ1YjJhNjVlY2ZhYjRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGduc0Bnbm9tZS5vcmc+ CkRhdGU6IE1vbiwgOSBBdWcgMjAxMCAyMTowMjoxOCAtMDMwMApTdWJqZWN0OiBbUEFUQ0hdIEZp eCBkcmF3aW5nIG9mIHNlYXJjaC9jbGVhciBpbWFnZXMgaW4gc2VhcmNoIGVudHJpZXMKCi0tLQog V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysr KysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwIHwgICAxNyArKysr KysrKysrKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAzIGRlbGV0 aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VM b2cKaW5kZXggZGU5Zjc4OC4uOGRjNDA2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0wOSAgR3Vz dGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3JvbmhhQGNvbGxhYm9yYS5jby51az4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBJbnB1 dHMgb2YgdHlwZSAnc2VhcmNoJyBoYXZlIHdlaXJkIGxvb2tpbmcgY2hlY2tib3hlcyBpbnN0ZWFk IG9mIHNlYXJjaC9jbGVhciBpY29ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDM3NjAKKworICAgICAgICBEcmF3IGFwcHJvcHJpYXRlIEdUSysgc3Rv Y2sgaW1hZ2VzIGZvciBzZWFyY2gvY2xlYXIgaWNvbnMgaW4gc2VhcmNoIGVudHJpZXMuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6UmVuZGVyVGhlbWVHdGs6OnBhaW50U2VhcmNoRmllbGRSZXN1bHRzQnV0dG9uKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwYWludFNlYXJjaEZpZWxkUmVzdWx0c0RlY29y YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVHdGs6OnBhaW50U2VhcmNoRmll bGRDYW5jZWxCdXR0b24pOgorCiAyMDEwLTA4LTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZp ZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjQ5 OTMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKaW5kZXggYmMwZDE0Ny4u MzZmY2NmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtNDg1 LDcgKzQ4NSw3IEBAIHZvaWQgUmVuZGVyVGhlbWVHdGs6OmFkanVzdFNlYXJjaEZpZWxkUmVzdWx0 c0J1dHRvblN0eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjCiAKIGJvb2wgUmVuZGVyVGhlbWVH dGs6OnBhaW50U2VhcmNoRmllbGRSZXN1bHRzQnV0dG9uKFJlbmRlck9iamVjdCogbywgY29uc3Qg UGFpbnRJbmZvJiBpLCBjb25zdCBJbnRSZWN0JiByZWN0KQogewotICAgIHJldHVybiBwYWludE1v emlsbGFHdGtXaWRnZXQodGhpcywgTU9aX0dUS19EUk9QRE9XTl9BUlJPVywgbywgaSwgcmVjdCk7 CisgICAgcmV0dXJuIHBhaW50U2VhcmNoRmllbGRSZXN1bHRzRGVjb3JhdGlvbihvLCBpLCByZWN0 KTsKIH0KIAogdm9pZCBSZW5kZXJUaGVtZUd0azo6YWRqdXN0U2VhcmNoRmllbGRSZXN1bHRzRGVj b3JhdGlvblN0eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBSZW5kZXJTdHlsZSogc3R5 bGUsIEVsZW1lbnQqIGUpIGNvbnN0CkBAIC01MDEsNyArNTAxLDEyIEBAIHZvaWQgUmVuZGVyVGhl bWVHdGs6OmFkanVzdFNlYXJjaEZpZWxkUmVzdWx0c0RlY29yYXRpb25TdHlsZShDU1NTdHlsZVNl bGVjdG9yKiBzCiAKIGJvb2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50U2VhcmNoRmllbGRSZXN1bHRz RGVjb3JhdGlvbihSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50 UmVjdCYgcmVjdCkKIHsKLSAgICByZXR1cm4gcGFpbnRNb3ppbGxhR3RrV2lkZ2V0KHRoaXMsIE1P Wl9HVEtfQ0hFQ0tNRU5VSVRFTSwgbywgaSwgcmVjdCk7CisgICAgR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0ID0gaS5jb250ZXh0OworCisgICAgc3RhdGljIEltYWdlKiBzZWFyY2hJbWFnZSA9IElt YWdlOjpsb2FkUGxhdGZvcm1UaGVtZUljb24oR1RLX1NUT0NLX0ZJTkQsIHJlY3Qud2lkdGgoKSku cmVsZWFzZVJlZigpOworICAgIGNvbnRleHQtPmRyYXdJbWFnZShzZWFyY2hJbWFnZSwgRGV2aWNl Q29sb3JTcGFjZSwgcmVjdCk7CisKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIHZvaWQgUmVuZGVy VGhlbWVHdGs6OmFkanVzdFNlYXJjaEZpZWxkQ2FuY2VsQnV0dG9uU3R5bGUoQ1NTU3R5bGVTZWxl Y3Rvciogc2VsZWN0b3IsIFJlbmRlclN0eWxlKiBzdHlsZSwgRWxlbWVudCogZSkgY29uc3QKQEAg LTUxNyw3ICs1MjIsMTMgQEAgdm9pZCBSZW5kZXJUaGVtZUd0azo6YWRqdXN0U2VhcmNoRmllbGRD YW5jZWxCdXR0b25TdHlsZShDU1NTdHlsZVNlbGVjdG9yKiBzZWxlY3QKIAogYm9vbCBSZW5kZXJU aGVtZUd0azo6cGFpbnRTZWFyY2hGaWVsZENhbmNlbEJ1dHRvbihSZW5kZXJPYmplY3QqIG8sIGNv bnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50UmVjdCYgcmVjdCkKIHsKLSAgICByZXR1cm4gcGFp bnRNb3ppbGxhR3RrV2lkZ2V0KHRoaXMsIE1PWl9HVEtfQ0hFQ0tNRU5VSVRFTSwgbywgaSwgcmVj dCk7CisgICAgR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0ID0gaS5jb250ZXh0OworCisgICAgLy8g VE9ETzogQnJpZ2h0ZW5pbmcgdXAgdGhlIGltYWdlIG9uIGhvdmVyIGlzIGRlc2lyYWJsZSBoZXJl LCBJIGJlbGlldmUuCisgICAgc3RhdGljIEltYWdlKiBjYW5jZWxJbWFnZSA9IEltYWdlOjpsb2Fk UGxhdGZvcm1UaGVtZUljb24oR1RLX1NUT0NLX0NMRUFSLCByZWN0LndpZHRoKCkpLnJlbGVhc2VS ZWYoKTsKKyAgICBjb250ZXh0LT5kcmF3SW1hZ2UoY2FuY2VsSW1hZ2UsIERldmljZUNvbG9yU3Bh Y2UsIHJlY3QpOworCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB2b2lkIFJlbmRlclRoZW1lR3Rr OjphZGp1c3RTZWFyY2hGaWVsZFN0eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBSZW5k ZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqIGUpIGNvbnN0Ci0tIAoxLjcuMQoK