43757 2010-08-09 16:33:58 -0700 Fix compilation of VideoLayerChromium on Mac OS X with compositor 2010-08-09 21:00:52 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr abarth ajwong dglazkov eric hclam japhet levin scherkus vangelis vrk webkit.review.bot oldest_to_newest 262397 0 kbr 2010-08-09 16:33:58 -0700 VideoLayerChromium is not compiling on Mac OS X when use_accelerated_compositing=1 in GYP_DEFINES. 262404 1 63952 kbr 2010-08-09 16:50:07 -0700 Created attachment 63952 Patch Thanks to Vangelis for initial patch. 262406 2 hclam 2010-08-09 16:51:14 -0700 Thanks for fixing this! 262407 3 webkit.review.bot 2010-08-09 16:52:42 -0700 Attachment 63952 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:128: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 262411 4 63952 levin 2010-08-09 16:59:28 -0700 Comment on attachment 63952 Patch Please fix the tab issue before landing. (I doubt that svn will let you commit it with a tab anyway.) 262416 5 kbr 2010-08-09 17:01:31 -0700 (In reply to comment #4) > (From update of attachment 63952 [details]) > Please fix the tab issue before landing. (I doubt that svn will let you commit it with a tab anyway.) Will do. 262421 6 kbr 2010-08-09 17:06:33 -0700 Committed r65018: <http://trac.webkit.org/changeset/65018> 262481 7 webkit.review.bot 2010-08-09 21:00:52 -0700 http://trac.webkit.org/changeset/65018 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65017 http://trac.webkit.org/changeset/65018 63952 2010-08-09 16:50:07 -0700 2010-08-09 16:59:28 -0700 Patch video-layer.patch text/plain 3817 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTAxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMDkgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBjb21waWxhdGlvbiBvZiBWaWRlb0xheWVyQ2hyb21pdW0gb24gTWFjIE9TIFggd2l0aCBjb21w b3NpdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 Mzc1NworCisgICAgICAgIE5vIG5ldyB0ZXN0czsgYnVpbGQgZml4IG9ubHkgKGFzc29jaWF0ZWQg ZnVuY3Rpb25hbGl0eSBub3QgaW1wbGVtZW50ZWQgeWV0KS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OlZpZGVvTGF5ZXJDaHJvbWl1bSk6CisgICAgICAgIChX ZWJDb3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OnVwZGF0ZVRleHR1cmVDb250ZW50cyk6CisgICAg ICAgIChXZWJDb3JlOjpWaWRlb0xheWVyQ2hyb21pdW06OmNyZWF0ZVRleHR1cmVSZWN0KToKKyAg ICAgICAgKFdlYkNvcmU6OlZpZGVvTGF5ZXJDaHJvbWl1bTo6dXBkYXRlVGV4dHVyZVJlY3QpOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5o OgorCiAyMDEwLTA4LTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEp1c3RpbiBHYXJjaWEuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0xheWVyQ2hyb21pdW0uY3BwCShy ZXZpc2lvbiA2NTAxMSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlk ZW9MYXllckNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTYsOCArNTYsMTAgQEAgUGFz c1JlZlB0cjxWaWRlb0xheWVyQ2hyb21pdW0+IFZpZGVvTGF5ZQogVmlkZW9MYXllckNocm9taXVt OjpWaWRlb0xheWVyQ2hyb21pdW0oR3JhcGhpY3NMYXllckNocm9taXVtKiBvd25lcikKICAgICA6 IExheWVyQ2hyb21pdW0ob3duZXIpCiAgICAgLCBtX2FsbG9jYXRlZFRleHR1cmVJZCgwKQorI2lm IFBMQVRGT1JNKFNLSUEpCiAgICAgLCBtX2NhbnZhcygwKQogICAgICwgbV9za2lhQ29udGV4dCgw KQorI2VuZGlmCiAgICAgLCBtX2dyYXBoaWNzQ29udGV4dCgwKQogewogfQpAQCAtMTE0LDcgKzEx Niw4IEBAIHZvaWQgVmlkZW9MYXllckNocm9taXVtOjp1cGRhdGVUZXh0dXJlQ28KICAgICBlbHNl CiAgICAgICAgIHVwZGF0ZVRleHR1cmVSZWN0KGRpcnR5UmVjdCwgdGV4dHVyZUlkKTsKICNlbHNl Ci0jZXJyb3IgIk5lZWQgdG8gaW1wbGVtZW50IGZvciB5b3VyIHBsYXRmb3JtLiIKKyAgICAvLyBG SVhNRTogSW1wbGVtZW50IG5vbi1za2lhIHBhdGgKKyAgICBub3RJbXBsZW1lbnRlZCgpOwogI2Vu ZGlmCiB9CiAKQEAgLTEyMiwxMiArMTI1LDEzIEBAIHZvaWQgVmlkZW9MYXllckNocm9taXVtOjpj cmVhdGVUZXh0dXJlUmUKIHsKICAgICAvLyBQYWludCBpbnRvIGdyYXBoaWNzIGNvbnRleHQgYW5k IGdldCBiaXRtYXAuCiAgICAgbV9vd25lci0+cGFpbnRHcmFwaGljc0xheWVyQ29udGVudHMoKm1f Z3JhcGhpY3NDb250ZXh0LCB1cGRhdGVSZWN0KTsKKwl2b2lkKiBwaXhlbHMgPSAwOworICAgIElu dFNpemUgYml0bWFwU2l6ZSA9IEludFNpemUoKTsKKyNpZiBQTEFURk9STShTS0lBKQogICAgIGNv bnN0IFNrQml0bWFwJiBiaXRtYXAgPSBtX2NhbnZhcy0+Z2V0RGV2aWNlKCktPmFjY2Vzc0JpdG1h cChmYWxzZSk7CiAgICAgY29uc3QgU2tCaXRtYXAqIHNraWFCaXRtYXAgPSAmYml0bWFwOwogICAg IEFTU0VSVChza2lhQml0bWFwKTsKIAotICAgIHZvaWQqIHBpeGVscyA9IDA7Ci0gICAgSW50U2l6 ZSBiaXRtYXBTaXplOwogICAgIFNrQXV0b0xvY2tQaXhlbHMgbG9jaygqc2tpYUJpdG1hcCk7CiAg ICAgU2tCaXRtYXA6OkNvbmZpZyBza2lhQ29uZmlnID0gc2tpYUJpdG1hcC0+Y29uZmlnKCk7CiAg ICAgLy8gRklYTUU6IERvIHdlIG5lZWQgdG8gc3VwcG9ydCBtb3JlIGltYWdlIGNvbmZpZ3VyYXRp b25zPwpAQCAtMTM1LDcgKzEzOSwxMCBAQCB2b2lkIFZpZGVvTGF5ZXJDaHJvbWl1bTo6Y3JlYXRl VGV4dHVyZVJlCiAgICAgICAgIHBpeGVscyA9IHNraWFCaXRtYXAtPmdldFBpeGVscygpOwogICAg ICAgICBiaXRtYXBTaXplID0gSW50U2l6ZShza2lhQml0bWFwLT53aWR0aCgpLCBza2lhQml0bWFw LT5oZWlnaHQoKSk7CiAgICAgfQotCisjZWxzZQorICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgbm9u LXNraWEgcGF0aAorICAgIG5vdEltcGxlbWVudGVkKCk7CisjZW5kaWYKICAgICBpZiAoIXBpeGVs cykKICAgICAgICAgcmV0dXJuOwogCkBAIC0xNTEsNiArMTU4LDcgQEAgdm9pZCBWaWRlb0xheWVy Q2hyb21pdW06OmNyZWF0ZVRleHR1cmVSZQogCiB2b2lkIFZpZGVvTGF5ZXJDaHJvbWl1bTo6dXBk YXRlVGV4dHVyZVJlY3QoY29uc3QgSW50UmVjdCYgdXBkYXRlUmVjdCwgdW5zaWduZWQgdGV4dHVy ZUlkKQogeworI2lmIFBMQVRGT1JNKFNLSUEpCiAgICAgY29uc3QgU2tCaXRtYXAmIGJpdG1hcCA9 IG1fY2FudmFzLT5nZXREZXZpY2UoKS0+YWNjZXNzQml0bWFwKHRydWUpOwogICAgIFNrQml0bWFw KiBza2lhQml0bWFwID0gY29uc3RfY2FzdDxTa0JpdG1hcCo+KCZiaXRtYXApOwogICAgIEFTU0VS VChza2lhQml0bWFwKTsKQEAgLTE2Nyw2ICsxNzUsMTAgQEAgdm9pZCBWaWRlb0xheWVyQ2hyb21p dW06OnVwZGF0ZVRleHR1cmVSZQogICAgIH0KIAogICAgIHVwZGF0ZUNvbXBsZXRlZCgpOworI2Vs c2UKKyAgICAvLyBGSVhNRTogSW1wbGVtZW50IG5vbi1za2lhIHBhdGgKKyAgICBub3RJbXBsZW1l bnRlZCgpOworI2VuZGlmCiB9CiAKIHZvaWQgVmlkZW9MYXllckNocm9taXVtOjp1cGRhdGVDb21w bGV0ZWQoKQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9WaWRlb0xh eWVyQ2hyb21pdW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1ZpZGVvTGF5ZXJDaHJvbWl1bS5oCShyZXZpc2lvbiA2NTAxMSkKKysrIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVmlkZW9MYXllckNocm9taXVtLmgJKHdvcmtpbmcg Y29weSkKQEAgLTUzLDggKzUzLDEwIEBAIHByaXZhdGU6CiAKICAgICB1bnNpZ25lZCBtX2FsbG9j YXRlZFRleHR1cmVJZDsKICAgICBJbnRTaXplIG1fYWxsb2NhdGVkVGV4dHVyZVNpemU7CisjaWYg UExBVEZPUk0oU0tJQSkKICAgICBPd25QdHI8c2tpYTo6UGxhdGZvcm1DYW52YXM+IG1fY2FudmFz OwogICAgIE93blB0cjxQbGF0Zm9ybUNvbnRleHRTa2lhPiBtX3NraWFDb250ZXh0OworI2VuZGlm CiAgICAgT3duUHRyPEdyYXBoaWNzQ29udGV4dD4gbV9ncmFwaGljc0NvbnRleHQ7CiB9OwogCg==