<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>43756</bug_id>
          
          <creation_ts>2010-08-09 16:21:19 -0700</creation_ts>
          <short_desc>[chromium] Feature defines are out of sync between features.gypi and downstream feature_overrides.gypi</short_desc>
          <delta_ts>2010-08-10 11:13:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="James Robinson">jamesr</reporter>
          <assigned_to name="James Robinson">jamesr</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>262388</commentid>
    <comment_count>0</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-08-09 16:21:19 -0700</bug_when>
    <thetext>[chromium] Feature defines are out of sync between features.gypi and downstream feature_overrides.gypi</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262390</commentid>
    <comment_count>1</comment_count>
      <attachid>63948</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-08-09 16:24:23 -0700</bug_when>
    <thetext>Created attachment 63948
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262391</commentid>
    <comment_count>2</comment_count>
      <attachid>63948</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-08-09 16:25:20 -0700</bug_when>
    <thetext>Comment on attachment 63948
Patch

&lt;3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262491</commentid>
    <comment_count>3</comment_count>
      <attachid>63948</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-08-09 21:50:26 -0700</bug_when>
    <thetext>Comment on attachment 63948
Patch

Rejecting patch 63948 from commit-queue.

Failed to run &quot;[&apos;WebKitTools/Scripts/update-webkit&apos;]&quot; exit_code: 2
Updating OpenSource
fatal: Unable to create &apos;/Users/eseidel/Projects/CommitQueue/.git/svn/refs/remotes/trunk/index.lock&apos;: File exists.

If no other git process is currently running, this probably means a
git process crashed in this repository earlier. Make sure no other git
process is running and remove the file manually to continue.
write-tree: command returned error: 128

Died at WebKitTools/Scripts/update-webkit line 129.

Full output: http://queues.webkit.org/results/3709005</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262746</commentid>
    <comment_count>4</comment_count>
      <attachid>63948</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-08-10 10:27:31 -0700</bug_when>
    <thetext>Comment on attachment 63948
Patch

Will land manually.  c-q is borked</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262750</commentid>
    <comment_count>5</comment_count>
      <attachid>63948</attachid>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-08-10 10:34:27 -0700</bug_when>
    <thetext>Comment on attachment 63948
Patch

Clearing flags on attachment: 63948

Committed r65076: &lt;http://trac.webkit.org/changeset/65076&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262751</commentid>
    <comment_count>6</comment_count>
    <who name="James Robinson">jamesr</who>
    <bug_when>2010-08-10 10:34:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>262778</commentid>
    <comment_count>7</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-08-10 11:13:48 -0700</bug_when>
    <thetext>Sorry.  The commit-queue has not been feeling well as of late.  I put it back on its original hardware last night, but it had a git lock left around from being unceremoniously powered down before the move. :(

I believe it should be feeling better now.   Then again, I&apos;ve said that before and been wrong...</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>63948</attachid>
            <date>2010-08-09 16:24:23 -0700</date>
            <delta_ts>2010-08-10 10:34:27 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-43756-20100809162422.patch</filename>
            <type>text/plain</type>
            <size>2978</size>
            <attacher name="James Robinson">jamesr</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v
Q2hhbmdlTG9nCmluZGV4IGM0MmU2M2IzNTMxMmI4NWM3NWQ2NDcxMGViMDJhODg2YWNlMTk2OTgu
LjU0OWIzOTM0NDExNjc5MzI0OTMzMGNiYjRiMzdkMTI2ZTIyYTgwYjAgMTAwNjQ0Ci0tLSBhL1dl
YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA
QCAtMSwzICsxLDE2IEBACisyMDEwLTA4LTA5ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJv
bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgW2Nocm9taXVtXSBGZWF0dXJlIGRlZmluZXMgYXJlIG91dCBvZiBzeW5jIGJldHdlZW4gZmVh
dHVyZXMuZ3lwaSBhbmQgZG93bnN0cmVhbSBmZWF0dXJlX292ZXJyaWRlcy5neXBpCisgICAgICAg
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzc1NgorCisgICAgICAg
IFRoaXMgc3luY2hyb25pemVzIHRoZSBmZWF0dXJlIGRlZmluZXMgdG8gd2hhdCdzIGN1cnJlbnRs
eSBkb3duc3RyZWFtIChhdCByNTU0NjgpLgorICAgICAgICBUaGUgZGlmZmVyZW5jZSBiZXR3ZWVu
IHRoZSBidWlsZC53ZWJraXQub3JnIGJvdHMgYW5kIHRoZSBjaHJvbWl1bSBib3RzIGhhcworICAg
ICAgICBjYXVzZWQgc3RyYW5nZSBjb21waWxhdGlvbiBmYWlsdXJlcyBsYXRlbHkuCisKKyAgICAg
ICAgKiBmZWF0dXJlcy5neXBpOgorCiAyMDEwLTA4LTA5ICBWYW5nZWxpcyBLb2trZXZpcyAgPHZh
bmdlbGlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXpr
b3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaSBiL1dlYktpdC9j
aHJvbWl1bS9mZWF0dXJlcy5neXBpCmluZGV4IDliNzU4ZjlkNjYzODZjZWUzNTA0NmZlODNhMWI4
YjU5NTRiN2NjOGIuLjc1YTE1Nzc4MzZlYTAwNmJiMGEzMTRkZjEzZGEwODI3NmMxZDdmNzYgMTAw
NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCisrKyBiL1dlYktpdC9jaHJv
bWl1bS9mZWF0dXJlcy5neXBpCkBAIC0zOCw5ICszOCwxMCBAQAogICAgICAgIyBXQVJOSU5HOiBi
dWlsZC9mZWF0dXJlc19vdmVycmlkZS5neXBpIHdoaWNoIGlzIGluY2x1ZGVkIGluIGEgZnVsbAog
ICAgICAgIyBjaHJvbWl1bSBidWlsZCwgb3ZlcnJpZGVzIHRoaXMgbGlzdCB3aXRoIGl0cyBvd24g
dmFsdWVzLiBTZWUKICAgICAgICMgZmVhdHVyZXNfb3ZlcnJpZGUuZ3lwaSBpbmxpbmUgZG9jdW1l
bnRhdGlvbiBmb3IgbW9yZSBkZXRhaWxzLgotICAgICAgJ2ZlYXR1cmVfZGVmaW5lcyUnOiBbCisg
ICAgICAnZmVhdHVyZV9kZWZpbmVzJzogWwogICAgICAgICAnRU5BQkxFXzNEX0NBTlZBUz0xJywK
ICAgICAgICAgJ0VOQUJMRV9CTE9CPTEnLAorICAgICAgICAnRU5BQkxFX0JMT0JfU0xJQ0U9MScs
CiAgICAgICAgICdFTkFCTEVfQ0hBTk5FTF9NRVNTQUdJTkc9MScsCiAgICAgICAgICdFTkFCTEVf
REFTSEJPQVJEX1NVUFBPUlQ9MCcsCiAgICAgICAgICdFTkFCTEVfREFUQUJBU0U9MScsCkBAIC00
OSwxNiArNTAsMTUgQEAKICAgICAgICAgJ0VOQUJMRV9ESVJFQ1RPUllfVVBMT0FEPTEnLAogICAg
ICAgICAnRU5BQkxFX0RPTV9TVE9SQUdFPTEnLAogICAgICAgICAnRU5BQkxFX0VWRU5UU09VUkNF
PTEnLAotICAgICAgICAnRU5BQkxFX0ZJTEVfV1JJVEVSPTEnLAotICAgICAgICAnRU5BQkxFX0ZJ
TEVfU1lTVEVNPTEnLAorICAgICAgICAnRU5BQkxFX0ZJTEVfUkVBREVSPTEnLAogICAgICAgICAn
RU5BQkxFX0ZJTFRFUlM9MScsCiAgICAgICAgICdFTkFCTEVfR0VPTE9DQVRJT049MScsCiAgICAg
ICAgICdFTkFCTEVfSUNPTkRBVEFCQVNFPTAnLAotICAgICAgICAnRU5BQkxFX0lNQUdFX1JFU0la
RVI9MCcsCiAgICAgICAgICdFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRT0xJywKICAgICAgICAgJ0VO
QUJMRV9JTlBVVF9TUEVFQ0g9MScsCiAgICAgICAgICdFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dF
Uj0xJywKICAgICAgICAgJ0VOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFEUz0wJywKKyAgICAgICAg
J0VOQUJMRV9MSU5LX1BSRUZFVENIPTEnLAogICAgICAgICAnRU5BQkxFX01FVEVSX1RBRz0xJywK
ICAgICAgICAgJ0VOQUJMRV9OT1RJRklDQVRJT05TPTEnLAogICAgICAgICAnRU5BQkxFX09GRkxJ
TkVfV0VCX0FQUExJQ0FUSU9OUz0xJywKQEAgLTc1LDE2ICs3NSwyNCBAQAogICAgICAgICAnRU5B
QkxFX1NWR19GT1JFSUdOX09CSkVDVD0xJywKICAgICAgICAgJ0VOQUJMRV9TVkdfVVNFPTEnLAog
ICAgICAgICAnRU5BQkxFX1RPVUNIX0VWRU5UUz0xJywKKyAgICAgICAgJ0VOQUJMRV9WOF9TQ1JJ
UFRfREVCVUdfU0VSVkVSPTEnLAogICAgICAgICAnRU5BQkxFX1ZJREVPPTEnLAogICAgICAgICAn
RU5BQkxFX1dFQl9TT0NLRVRTPTEnLAogICAgICAgICAnRU5BQkxFX1dFQl9USU1JTkc9MScsCiAg
ICAgICAgICdFTkFCTEVfV09SS0VSUz0xJywKLSAgICAgICAgJ0VOQUJMRV9YSFRNTE1QPTAnLAog
ICAgICAgICAnRU5BQkxFX1hQQVRIPTEnLAogICAgICAgICAnRU5BQkxFX1hTTFQ9MScsCi0gICAg
ICAgICdXVEZfVVNFX0FDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HPTAnLAogICAgICAgXSwKLSAgICAg
IAorCisgICAgICAnY29uZGl0aW9ucyc6IFsKKyAgICAgICAgWydPUz09IndpbiIgb3IgT1M9PSJs
aW51eCInLCB7CisgICAgICAgICAgJ2ZlYXR1cmVfZGVmaW5lcyc6IFsKKyAgICAgICAgICAgJ1dU
Rl9VU0VfQUNDRUxFUkFURURfQ09NUE9TSVRJTkc9MScsCisgICAgICAgICAgICdFTkFCTEVfM0Rf
UkVOREVSSU5HPTEnLAorICAgICAgICAgIF0sCisgICAgICAgIH1dLAorICAgICAgXSwKKwogICAg
ICAgJ3VzZV9hY2NlbGVyYXRlZF9jb21wb3NpdGluZyUnOiAwLAogICAgICAgJ2VuYWJsZV9zdmcl
JzogMSwKICAgICB9LAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>