43755 2010-08-09 15:57:24 -0700 fast/dom/Window/window-properties.html is pretty slow 2010-08-10 18:38:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue eric.carlson eric ggaren jamesr oldest_to_newest 262375 0 mihaip 2010-08-09 15:57:24 -0700 It takes 5.9 seconds to run on my Mac Pro, it looks like there's some pretty easy performance tweaks. Geoff, I'm cc-ing you since I'm hoping you can review this, since you're the original author of this (incarnation of this) test. 262378 1 63947 mihaip 2010-08-09 16:01:33 -0700 Created attachment 63947 Patch 262462 2 63947 commit-queue 2010-08-09 20:08:50 -0700 Comment on attachment 63947 Patch Rejecting patch 63947 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20806 test cases. http/tests/misc/image-blocked-src-change.html -> failed Exiting early after 1 failures. 20032 tests run. 673.67s total testing time 20031 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 88 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3756008 262493 3 63947 mihaip 2010-08-09 22:05:11 -0700 Comment on attachment 63947 Patch I see no reason why this should have made http/tests/misc/image-blocked-src-change.html fail, and per bug 33153 and bug 37557 it may be a flaky test, so I'd like the commit queue to try again. 262495 4 63947 commit-queue 2010-08-09 22:08:37 -0700 Comment on attachment 63947 Patch Rejecting patch 63947 from commit-queue. mihaip@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 262496 5 63947 rniwa 2010-08-09 22:25:53 -0700 Comment on attachment 63947 Patch Adding back to the commit queue since the failure seems to be caused by a flaky test. 262508 6 63947 commit-queue 2010-08-09 23:17:03 -0700 Comment on attachment 63947 Patch Rejecting patch 63947 from commit-queue. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: Unable to create '/Users/eseidel/Projects/CommitQueue/.git/svn/refs/remotes/trunk/index.lock': File exists. If no other git process is currently running, this probably means a git process crashed in this repository earlier. Make sure no other git process is running and remove the file manually to continue. write-tree: command returned error: 128 Died at WebKitTools/Scripts/update-webkit line 129. Full output: http://queues.webkit.org/results/3755007 262543 7 63947 commit-queue 2010-08-10 01:07:00 -0700 Comment on attachment 63947 Patch Rejecting patch 63947 from commit-queue. Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource fatal: Unable to create '/Users/eseidel/Projects/CommitQueue/.git/svn/refs/remotes/trunk/index.lock': File exists. If no other git process is currently running, this probably means a git process crashed in this repository earlier. Make sure no other git process is running and remove the file manually to continue. write-tree: command returned error: 128 Died at WebKitTools/Scripts/update-webkit line 129. Full output: http://queues.webkit.org/results/3709012 262883 8 63947 commit-queue 2010-08-10 15:17:42 -0700 Comment on attachment 63947 Patch Rejecting patch 63947 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20822 test cases. media/video-aspect-ratio.html -> crashed Exiting early after 1 failures. 17166 tests run. 683.55s total testing time 17165 test cases (99%) succeeded 1 test case (<1%) crashed 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3756046 262902 9 63947 jamesr 2010-08-10 16:27:46 -0700 Comment on attachment 63947 Patch Test flaked 262920 10 63947 commit-queue 2010-08-10 17:31:53 -0700 Comment on attachment 63947 Patch Rejecting patch 63947 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: mmitQueue/LayoutTests Testing 20822 test cases. media/video-autoplay.html -> timed out Sampling process 28075 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 28075 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 17167 tests run. 664.86s total testing time 17166 test cases (99%) succeeded 1 test case (<1%) timed out 35 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3727028 262940 11 mihaip 2010-08-10 18:24:04 -0700 *sigh* Another seemingly irrelevant test failure. Per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#maxResults=750&tests=media%2Fvideo-autoplay.html it may be flaky. James Robinson said he'll land this for me. 262945 12 63947 jamesr 2010-08-10 18:28:46 -0700 Comment on attachment 63947 Patch Clearing flags on attachment: 63947 Committed r65109: <http://trac.webkit.org/changeset/65109> 262946 13 jamesr 2010-08-10 18:28:51 -0700 All reviewed patches have been landed. Closing bug. 262953 14 eric 2010-08-10 18:38:11 -0700 I think we must be hitting the CoreVideo random crasher again? Except I thought that was fixed? The leopard box running the commit-queue is up to date as far as I know. Maybe it has (or needs) a hacked CoreVideo version again? 63947 2010-08-09 16:01:33 -0700 2010-08-10 18:28:46 -0700 Patch bug-43755-20100809160131.patch text/plain 3120 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwYzY0ZWFkY2JiMDRiNjY1MjRmYmE0OGRjNDQ1NzdhYjg0YjkzNWI5Li4yZTFlMGQx MDg5NzhlMWZmNDU1MmMyZmQ5NWVlMWIxMWYwMjA3OTcwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTAtMDgtMDkgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgIGZhc3QvZG9tL1dp bmRvdy93aW5kb3ctcHJvcGVydGllcy5odG1sIGlzIHByZXR0eSBzbG93CisgICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM3NTUKKyAgICAgICAgIAorICAg ICAgICAgd2luZG93LXByb3BlcnRpZXMuaHRtbCB3b3VsZCB0YWtlIDUuOSBzZWNvbmRzIHRvIHJ1 biBvbiBteSBNYWMgUHJvLgorICAgICAgICAgLSBDaGFuZ2luZyB0aGUgb3JkZXIgb2YgY2hlY2tz IGluIGxvZ1ZhbHVlIHRvIGhhdmUgbW9yZSBlYXJseSByZXR1cm5zCisgICAgICAgICAgIGJlZm9y ZSB3ZSBnZXQgdmFsdWUgYW5kIHZhbHVlVHlwZSBicmluZ3MgdGhpcyBkb3duIHRvIDMuNjYgc2Vj b25kcworICAgICAgICAgLSBDaGFuZ2luZyBsb2dCdWZmZXIgdG8gYmUgYSBzdHJpbmcgdGhhdCB3 ZSBhcHBlbmQgdG8gaW5zdGVhZCBvZiBhbgorICAgICAgICAgICBhcnJheSB0aGF0IHdlIHB1c2go KSB0byBicmluZ3MgdGhpcyB0byAwLjcgc2Vjb25kcyAoc3RyaW5nIGFwcGVuZHMKKyAgICAgICAg ICAgYXJlIGZhc3RlciB0aGFuIGFycmF5IHB1c2goKS1lcyBmb2xsb3dlZCBieSBhIGpvaW4oJycp IGluIGFsbAorICAgICAgICAgICBicm93c2VycyBleGNlcHQgSUUgcGVyIAorICAgICAgICAgICBo dHRwOi8vY2xvc3VyZS1saWJyYXJ5Lmdvb2dsZWNvZGUuY29tL3N2bi9kb2NzL2Nsb3N1cmVfZ29v Z19zdHJpbmdfc3RyaW5nYnVmZmVyLmpzLnNvdXJjZS5odG1sCisKKyAgICAgICAgKiBmYXN0L2Rv bS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMuaHRtbDoKKwogMjAxMC0wOC0wOSAgWmhlbnlhbyBN byAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVz Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMuaHRt bAppbmRleCBiNjBhMzY4MDVjNDU4NTQ2ZGVjNGE3NjRmOTU0MjhmNDJlOWM2MTI2Li5lODI4ZDg2 MmU0YjJhOGJkOWQyZWVmZmUxZDczYjQxYzU3OWI5YzdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnRpZXMuaHRtbApAQCAtNywxNyArNywxNiBA QCBvYmplY3QsIGFsb25nIHdpdGggdGhlaXIgdHlwZXMuPC9wPgogaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAg ICAgCi12YXIgbG9nQnVmZmVyID0gW107Cit2YXIgbG9nQnVmZmVyID0gJyc7CiBmdW5jdGlvbiBs b2cocykKIHsKLSAgICBsb2dCdWZmZXIucHVzaChzKTsKKyAgICBsb2dCdWZmZXIgKz0gczsKIH0K IAogdmFyIHByZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdwcmUnKTsKIGZ1bmN0aW9uIGZs dXNoTG9nKCkKIHsKLSAgICB2YXIgbG9nTWVzc2FnZSA9IGxvZ0J1ZmZlci5qb2luKCIiKTsKLSAg ICBwcmUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobG9nTWVzc2FnZSkpOwor ICAgIHByZS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShsb2dCdWZmZXIpKTsK IH0KIAogZnVuY3Rpb24gdHJ5RXZhbChzdHJpbmcpCkBAIC05OCwxMyArOTcsNiBAQCB2YXIgX19z a2lwX18gPSB7CiAKIGZ1bmN0aW9uIGxvZ1ZhbHVlKHZhbHVlTmFtZSkKIHsKLSAgICB2YXIgdmFs dWUgPSB0cnlFdmFsKHZhbHVlTmFtZSk7Ci0gICAgdmFyIHZhbHVlVHlwZSA9IHR5cGVPZk51bGxB d2FyZSh2YWx1ZSk7Ci0KLSAgICAvLyBEb24ndCB0YWludCB0aGUgdGVzdCB3aXRoIG91ciBvd24g dmFyaWFibGVzCi0gICAgaWYgKHZhbHVlID09IGxvZ0J1ZmZlciB8fCB2YWx1ZSA9PSBwcmUpCi0g ICAgICAgIHJldHVybjsKLQogICAgIC8vIERvbid0IHRhaW50IHRoZSB0ZXN0IHdpdGggb3VyIG93 biBwcm9wZXJ0aWVzCiAgICAgaWYgKC9fX3Zpc2l0ZWRCeUxvZ1ZhbHVlX18vLnRlc3QodmFsdWVO YW1lKSB8fCAvX19uYW1lV2hlblZpc2l0ZWRCeUxvZ1ZhbHVlX18vLnRlc3QodmFsdWVOYW1lKSkK ICAgICAgICAgcmV0dXJuOwpAQCAtMTE2LDYgKzEwOCwxNCBAQCBmdW5jdGlvbiBsb2dWYWx1ZSh2 YWx1ZU5hbWUpCiAgICAgaWYgKC9cLlswLTldLy50ZXN0KHZhbHVlTmFtZSkpCiAgICAgICAgIHJl dHVybjsKIAorICAgIHZhciB2YWx1ZSA9IHRyeUV2YWwodmFsdWVOYW1lKTsKKworICAgIC8vIERv bid0IHRhaW50IHRoZSB0ZXN0IHdpdGggb3VyIG93biB2YXJpYWJsZXMKKyAgICBpZiAodmFsdWUg PT09IGxvZ0J1ZmZlciB8fCB2YWx1ZSA9PT0gcHJlKQorICAgICAgICByZXR1cm47CisKKyAgICB2 YXIgdmFsdWVUeXBlID0gdHlwZU9mTnVsbEF3YXJlKHZhbHVlKTsKKwogICAgIC8vIEF2b2lkIGlu ZmluaXRlIHJlY3Vyc2lvbgogICAgIGlmICh2YWx1ZVR5cGUgPT0gIm9iamVjdCIgJiYgdmFsdWUu X192aXNpdGVkQnlMb2dWYWx1ZV9fKSB7IC8vOwogICAgICAgICBsb2codmFsdWVOYW1lICsgIiBb cHJpbnRlZCBhYm92ZSBhcyAiICsgdmFsdWUuX19uYW1lV2hlblZpc2l0ZWRCeUxvZ1ZhbHVlX18g KyAiXVxuIik7CkBAIC0xNjMsNCArMTYzLDUgQEAgZnVuY3Rpb24gbG9nUHJvcGVydGllcyhvYmpl Y3QsIG9iamVjdE5hbWUpCiBsb2dWYWx1ZSgnd2luZG93Jyk7CiBsb2dWYWx1ZSgnd2luZG93Lmdl dFNlbGVjdGlvbigpJyk7CiBmbHVzaExvZygpOworCiA8L3NjcmlwdD4K