43753 2010-08-09 15:45:43 -0700 [chromium] Geolocation breaks the compile if ENABLE_GEOLOCATION is set to 0 2010-08-11 16:47:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr webkit-unassigned commit-queue jochen steveblock oldest_to_newest 262363 0 jamesr 2010-08-09 15:45:43 -0700 If the feature is off the build should still work. Instead there are compile errors: WebCore/bindings/v8/custom/V8CustomPositionCallback.cpp:68: error: no matching function for call to ‘toV8(WebCore::Geoposition*&)’ out/Release/obj/gen/webkit/bindings/V8Event.h:49: note: candidates are: v8::Handle<v8::Value> WebCore::toV8(WebCore::Event*) out/Release/obj/gen/webkit/bindings/V8Event.h:50: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::Event>) out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:47: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::XPathNSResolver*) out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:48: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::XPathNSResolver>) WebCore/bindings/v8/custom/V8CustomPositionErrorCallback.cpp: In member function ‘virtual void WebCore::V8CustomPositionErrorCallback::handleEvent(WebCore::PositionError*)’: WebCore/bindings/v8/custom/V8CustomPositionErrorCallback.cpp:68: error: no matching function for call to ‘toV8(WebCore::PositionError*&)’ out/Release/obj/gen/webkit/bindings/V8Event.h:49: note: candidates are: v8::Handle<v8::Value> WebCore::toV8(WebCore::Event*) out/Release/obj/gen/webkit/bindings/V8Event.h:50: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::Event>) out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:47: note: v8::Handle<v8::Value> WebCore::toV8(WebCore::XPathNSResolver*) out/Release/obj/gen/webkit/bindings/V8XPathNSResolver.h:48: note: v8::Handle<v8::Value> WebCore::toV8(WTF::PassRefPtr<WebCore::XPathNSResolver>) make: *** [out/Release/obj.target/webcore/WebCore/bindings/v8/custom/V8CustomPositionCallback.o] Error 1 262515 1 jochen 2010-08-09 23:43:42 -0700 yeah, looks like all of these should be protected by #if ENABLE(GEOLOCATION) ... #endif 263240 2 64110 steveblock 2010-08-11 07:19:30 -0700 Created attachment 64110 Patch 263517 3 64110 commit-queue 2010-08-11 16:47:03 -0700 Comment on attachment 64110 Patch Clearing flags on attachment: 64110 Committed r65199: <http://trac.webkit.org/changeset/65199> 263518 4 commit-queue 2010-08-11 16:47:08 -0700 All reviewed patches have been landed. Closing bug. 64110 2010-08-11 07:19:30 -0700 2010-08-11 16:47:03 -0700 Patch bug-43753-20100811151928.patch text/plain 2740 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTE1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMTEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtjaHJvbWl1bV0gR2VvbG9jYXRpb24gYnJlYWtzIHRoZSBjb21waWxlIGlmIEVOQUJMRV9HRU9M T0NBVElPTiBpcyBzZXQgdG8gMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDM3NTMKKworICAgICAgICBUaGlzIGNoYW5nZSBndWFyZHMgdGhlIGVudGly ZSBjb250ZW50cyBvZiB0aGUgVjggY3VzdG9tIGJpbmRpbmdzIGZpbGVzCisgICAgICAgIHdpdGgg RU5BQkxFKEdFT0xPQ0FUSU9OKSB0byBtYXRjaCBKU0MuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz LCBidWlsZCBmaXggb25seS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3Rv bVBvc2l0aW9uQ2FsbGJhY2suY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1 c3RvbVBvc2l0aW9uRXJyb3JDYWxsYmFjay5jcHA6CisgICAgICAgICogYmluZGluZ3MvdjgvY3Vz dG9tL1Y4R2VvbG9jYXRpb25DdXN0b20uY3BwOgorCiAyMDEwLTA4LTExICBOYXRlIENoYXBpbiAg PGphcGhldEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hyb21pdW0gbWFjIGJ1aWxkIGZpeCAo dmFyaWFibGVzIHdlcmVuJ3QgYmVpbmcgaW5pdGlhbGl6ZWQpLgpJbmRleDogV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhDdXN0b21Qb3NpdGlvbkNhbGxiYWNrLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVBvc2l0aW9uQ2FsbGJhY2suY3Bw CShyZXZpc2lvbiA2NTE0OSkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9t UG9zaXRpb25DYWxsYmFjay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI2LDYgKzI2LDggQEAKICNp bmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJWOEN1c3RvbVBvc2l0aW9uQ2FsbGJhY2suaCIK IAorI2lmIEVOQUJMRShHRU9MT0NBVElPTikKKwogI2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNv bnRleHQuaCIKICNpbmNsdWRlICJWOEN1c3RvbVZvaWRDYWxsYmFjay5oIiAgLy8gRm9yIGludm9r ZUNhbGxiYWNrCiAjaW5jbHVkZSAiVjhHZW9wb3NpdGlvbi5oIgpAQCAtNzYsMyArNzgsNSBAQCB2 b2lkIFY4Q3VzdG9tUG9zaXRpb25DYWxsYmFjazo6aGFuZGxlRXZlCiB9CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKKworI2VuZGlmIC8vIEVOQUJMRShHRU9MT0NBVElPTikKSW5kZXg6IFdlYkNv cmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tUG9zaXRpb25FcnJvckNhbGxiYWNrLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVBvc2l0aW9u RXJyb3JDYWxsYmFjay5jcHAJKHJldmlzaW9uIDY1MTQ5KQorKysgV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhDdXN0b21Qb3NpdGlvbkVycm9yQ2FsbGJhY2suY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNiw2ICsyNiw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiVjhDdXN0 b21Qb3NpdGlvbkVycm9yQ2FsbGJhY2suaCIKIAorI2lmIEVOQUJMRShHRU9MT0NBVElPTikKKwog I2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIKICNpbmNsdWRlICJWOEN1c3RvbVZv aWRDYWxsYmFjay5oIiAgLy8gRm9yIGludm9rZUNhbGxiYWNrCiAjaW5jbHVkZSAiVjhQb3NpdGlv bkVycm9yLmgiCkBAIC03NiwzICs3OCw1IEBAIHZvaWQgVjhDdXN0b21Qb3NpdGlvbkVycm9yQ2Fs bGJhY2s6OmhhbmQKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYgLy8gRU5B QkxFKEdFT0xPQ0FUSU9OKQpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhHZW9s b2NhdGlvbkN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0 b20vVjhHZW9sb2NhdGlvbkN1c3RvbS5jcHAJKHJldmlzaW9uIDY1MTQ5KQorKysgV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhHZW9sb2NhdGlvbkN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI2LDYgKzI2LDggQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJWOEdlb2xv Y2F0aW9uLmgiCiAKKyNpZiBFTkFCTEUoR0VPTE9DQVRJT04pCisKICNpbmNsdWRlICJGcmFtZS5o IgogI2luY2x1ZGUgIkdlb2xvY2F0aW9uLmgiCiAjaW5jbHVkZSAiVjhCaW5kaW5nLmgiCkBAIC0y MTUsMyArMjE3LDUgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4R2VvbG9jYXRpb246OndhdAog fQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBFTkFCTEUoR0VPTE9DQVRJ T04pCg==