43752 2010-08-09 15:43:00 -0700 Remove error-prone external SegementedSubstring contructor 2010-08-09 18:48:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 262361 0 abarth 2010-08-09 15:43:00 -0700 Remove error-prone external SegementedSubstring contructor 262364 1 63945 abarth 2010-08-09 15:46:04 -0700 Created attachment 63945 Patch 262368 2 63945 eric 2010-08-09 15:49:33 -0700 Comment on attachment 63945 Patch You're just trying to make our HTML5 numbers look better. :p 262451 3 63945 eric 2010-08-09 18:47:58 -0700 Comment on attachment 63945 Patch Clearing flags on attachment: 63945 Committed r65031: <http://trac.webkit.org/changeset/65031> 262452 4 eric 2010-08-09 18:48:04 -0700 All reviewed patches have been landed. Closing bug. 63945 2010-08-09 15:46:04 -0700 2010-08-09 18:47:58 -0700 Patch bug-43752-20100809154602.patch text/plain 5384 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTdiYmQ1NzllMGE5Yzk1ZTZiYWMzMTQzYThjZjYzYTI1MTMwMzMyNC4uMzBjMjZmNGYzNGE2OWQw N2EyMWY2YjkxY2QyOTFjNzRjZTFiOGM4ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwzMiBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFJlbW92ZSBlcnJvci1wcm9uZSBleHRl cm5hbCBTZWdlbWVudGVkU3Vic3RyaW5nIGNvbnRydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNzUyCisKKyAgICAgICAgVGhlcmUncyBhIGxv dCBvZiBjb2RlIHRoYXQgYXNzdW1lcyB0aGF0IFNlZ21lbnRlZFN0cmluZyB0YWtlcyBvd25lcnNo aXAKKyAgICAgICAgb2YgaXRzIHN1YnN0cmluZ3MuICBGb3IgZXhhbXBsZSwgd2hlbiB0aGUgSFRN TCBwYXJzZXIgcGF1c2VzIGFuZAorICAgICAgICByZXN1bWVzIGFzeW5jaHJvbm91c2x5LCBpdCBj b3VsZCBleHBsb2RlIGlmIFNlZ21lbnRlZFN0cmluZyBkaWRuJ3Qgb3duCisgICAgICAgIGl0cyBz dWJzdHJpbmdzLgorCisgICAgICAgIFByaW9yIHRvIHRoaXMgcGF0Y2gsIHRoZXJlIHdhcyBhIGNv bnN0cnVjdG9yIHRoYXQgbGV0CisgICAgICAgIFNlZ21lbnRlZFN1YnN0cmluZyB1c2UgYW4gZXh0 ZXJuYWwgc3RyaW5nIGJ1ZmZlci4gIEl0IHR1cm5zIG91dCBpdCB3YXMKKyAgICAgICAgb25seSB1 c2VkIGluIGEgaGFuZGZ1bCBvZiBwbGFjZXMsIGJ1dCBJJ2QgcmF0aGVyIHBheSB0aGUgbWVtY3B5 IG9mCisgICAgICAgIHRoZXNlIHNtYWxsIHN0cmluZ3MgdGhhbiByaXNrIGhhdmluZyB0aGVtIHVz ZWQgYWZ0ZXIgZnJlZS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSFRNTERvY3VtZW50Q3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRvY3VtZW50V3JpdGUpOgorICAgICAgICAqIGh0 bWwvTGVnYWN5SFRNTERvY3VtZW50UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxlZ2Fj eUhUTUxEb2N1bWVudFBhcnNlcjo6cGFyc2VOb25IVE1MVGV4dCk6CisgICAgICAgIChXZWJDb3Jl OjpMZWdhY3lIVE1MRG9jdW1lbnRQYXJzZXI6OnNjcmlwdEhhbmRsZXIpOgorICAgICAgICAoV2Vi Q29yZTo6TGVnYWN5SFRNTERvY3VtZW50UGFyc2VyOjpwYXJzZUNvbW1lbnQpOgorICAgICAgICAq IHBsYXRmb3JtL3RleHQvU2VnbWVudGVkU3RyaW5nLmg6CisgICAgICAgIChXZWJDb3JlOjpTZWdt ZW50ZWRTdHJpbmc6OlNlZ21lbnRlZFN0cmluZyk6CisKKzIwMTAtMDgtMDkgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKwogICAgICAgICBQb3J0IHZpZXctc291cmNlIHRvIG5ldyBwYXJzZXIKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNzQ2CiAKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MRG9jdW1lbnRDdXN0b20uY3BwIGIvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3RvbS5jcHAKaW5kZXggYTBlMTg5ZTJiYzk1NTVm ODU0Y2Q0YTQyMGFjNzQwNzVhOThkYmIxNy4uMGI0MGVmMDQ0ZDVjYWRkZjIzZTk5ZDQwMzdhNzc2 MDM5MjJkYWRjNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVu dEN1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxEb2N1bWVudEN1c3Rv bS5jcHAKQEAgLTE1MCw3ICsxNTAsNyBAQCBzdGF0aWMgaW5saW5lIHZvaWQgZG9jdW1lbnRXcml0 ZShFeGVjU3RhdGUqIGV4ZWMsIEhUTUxEb2N1bWVudCogZG9jdW1lbnQsIE5ld2xpbgogICAgICAg ICB9CiAgICAgfQogICAgIGlmIChhZGROZXdsaW5lKQotICAgICAgICBzZWdtZW50ZWRTdHJpbmcu YXBwZW5kKFNlZ21lbnRlZFN0cmluZygmbmV3bGluZUNoYXJhY3RlciwgMSkpOworICAgICAgICBz ZWdtZW50ZWRTdHJpbmcuYXBwZW5kKFNlZ21lbnRlZFN0cmluZyhTdHJpbmcoJm5ld2xpbmVDaGFy YWN0ZXIsIDEpKSk7CiAKICAgICBEb2N1bWVudCogYWN0aXZlRG9jdW1lbnQgPSBhc0pTRE9NV2lu ZG93KGV4ZWMtPmxleGljYWxHbG9iYWxPYmplY3QoKSktPmltcGwoKS0+ZG9jdW1lbnQoKTsKICAg ICBkb2N1bWVudC0+d3JpdGUoc2VnbWVudGVkU3RyaW5nLCBhY3RpdmVEb2N1bWVudCk7CmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvTGVnYWN5SFRNTERvY3VtZW50UGFyc2VyLmNwcCBiL1dlYkNv cmUvaHRtbC9MZWdhY3lIVE1MRG9jdW1lbnRQYXJzZXIuY3BwCmluZGV4IDZmMTEwZGFmNWMyOTY0 MTZmZmY0OTczN2VjMWYzOTg4YjExYmZkZjIuLjBkNGQ2MTU3ZjA0OGI3MWU2N2E4YjU4MTI3M2Ux MGMyZTViNDljNjQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9MZWdhY3lIVE1MRG9jdW1lbnRQ YXJzZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9MZWdhY3lIVE1MRG9jdW1lbnRQYXJzZXIuY3Bw CkBAIC0zNDYsNyArMzQ2LDcgQEAgTGVnYWN5SFRNTERvY3VtZW50UGFyc2VyOjpTdGF0ZSBMZWdh Y3lIVE1MRG9jdW1lbnRQYXJzZXI6OnBhcnNlTm9uSFRNTFRleHQoU2VnbWUKICAgICAgICAgICAg IGlmIChzdGF0ZS5pblNjcmlwdCgpKQogICAgICAgICAgICAgICAgIHN0YXRlID0gc2NyaXB0SGFu ZGxlcihzdGF0ZSk7CiAgICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAgICBzdGF0ZSA9 IHByb2Nlc3NMaXN0aW5nKFNlZ21lbnRlZFN0cmluZyhtX3NjcmlwdENvZGUsIG1fc2NyaXB0Q29k ZVNpemUpLCBzdGF0ZSk7CisgICAgICAgICAgICAgICAgc3RhdGUgPSBwcm9jZXNzTGlzdGluZyhT ZWdtZW50ZWRTdHJpbmcoU3RyaW5nKG1fc2NyaXB0Q29kZSwgbV9zY3JpcHRDb2RlU2l6ZSkpLCBz dGF0ZSk7CiAgICAgICAgICAgICAgICAgcHJvY2Vzc1Rva2VuKCk7CiAgICAgICAgICAgICAgICAg aWYgKHN0YXRlLmluU3R5bGUoKSkgewogICAgICAgICAgICAgICAgICAgICBtX2N1cnJlbnRUb2tl bi50YWdOYW1lID0gc3R5bGVUYWcubG9jYWxOYW1lKCk7CkBAIC00NTEsNyArNDUxLDcgQEAgTGVn YWN5SFRNTERvY3VtZW50UGFyc2VyOjpTdGF0ZSBMZWdhY3lIVE1MRG9jdW1lbnRQYXJzZXI6OnNj cmlwdEhhbmRsZXIoU3RhdGUgc3QKICAgICAgICAgfQogICAgIH0KIAotICAgIHN0YXRlID0gcHJv Y2Vzc0xpc3RpbmcoU2VnbWVudGVkU3RyaW5nKG1fc2NyaXB0Q29kZSwgbV9zY3JpcHRDb2RlU2l6 ZSksIHN0YXRlKTsKKyAgICBzdGF0ZSA9IHByb2Nlc3NMaXN0aW5nKFNlZ21lbnRlZFN0cmluZyhT dHJpbmcobV9zY3JpcHRDb2RlLCBtX3NjcmlwdENvZGVTaXplKSksIHN0YXRlKTsKICAgICBSZWZQ dHI8Tm9kZT4gbm9kZSA9IHByb2Nlc3NUb2tlbigpOwogCiAgICAgaWYgKG5vZGUgJiYgbV9zY3Jp cHRpbmdQZXJtaXNzaW9uID09IEZyYWdtZW50U2NyaXB0aW5nTm90QWxsb3dlZCkgewpAQCAtNjI1 LDcgKzYyNSw3IEBAIExlZ2FjeUhUTUxEb2N1bWVudFBhcnNlcjo6U3RhdGUgTGVnYWN5SFRNTERv Y3VtZW50UGFyc2VyOjpwYXJzZUNvbW1lbnQoU2VnbWVudGVkCiAgICAgICAgICAgICAgICAgICAg IG1fc2NyaXB0Q29kZVttX3NjcmlwdENvZGVTaXplICsgMV0gPSAwOwogICAgICAgICAgICAgICAg ICAgICBtX2N1cnJlbnRUb2tlbi50YWdOYW1lID0gY29tbWVudEF0b207CiAgICAgICAgICAgICAg ICAgICAgIG1fY3VycmVudFRva2VuLmJlZ2luVGFnID0gdHJ1ZTsKLSAgICAgICAgICAgICAgICAg ICAgc3RhdGUgPSBwcm9jZXNzTGlzdGluZyhTZWdtZW50ZWRTdHJpbmcobV9zY3JpcHRDb2RlLCBt X3NjcmlwdENvZGVTaXplIC0gZW5kQ2hhcnNDb3VudCksIHN0YXRlKTsKKyAgICAgICAgICAgICAg ICAgICAgc3RhdGUgPSBwcm9jZXNzTGlzdGluZyhTZWdtZW50ZWRTdHJpbmcoU3RyaW5nKG1fc2Ny aXB0Q29kZSwgbV9zY3JpcHRDb2RlU2l6ZSAtIGVuZENoYXJzQ291bnQpKSwgc3RhdGUpOwogICAg ICAgICAgICAgICAgICAgICBwcm9jZXNzVG9rZW4oKTsKICAgICAgICAgICAgICAgICAgICAgbV9j dXJyZW50VG9rZW4udGFnTmFtZSA9IGNvbW1lbnRBdG9tOwogICAgICAgICAgICAgICAgICAgICBt X2N1cnJlbnRUb2tlbi5iZWdpblRhZyA9IGZhbHNlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS90ZXh0L1NlZ21lbnRlZFN0cmluZy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1NlZ21l bnRlZFN0cmluZy5oCmluZGV4IDc0N2Q0MjY1ZjIwZDcwNTVlMWE4MWM3NDZkNzBkNzI5OWI1M2Vk NmUuLjFkMzA5OGRlMmU2OGU0ZTdkNWJjZmM1YzQzMGY4M2Q1MmE2ODc0YTggMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9TZWdtZW50ZWRTdHJpbmcuaAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL3RleHQvU2VnbWVudGVkU3RyaW5nLmgKQEAgLTM4LDggKzM4LDYgQEAgcHVibGljOgog ICAgIHsKICAgICB9CiAKLSAgICBTZWdtZW50ZWRTdWJzdHJpbmcoY29uc3QgVUNoYXIqIHN0ciwg aW50IGxlbmd0aCkgOiBtX2xlbmd0aChsZW5ndGgpLCBtX2N1cnJlbnQobGVuZ3RoID09IDAgPyAw IDogc3RyKSwgbV9kb05vdEV4Y2x1ZGVMaW5lTnVtYmVycyh0cnVlKSB7fQotCiAgICAgdm9pZCBj bGVhcigpIHsgbV9sZW5ndGggPSAwOyBtX2N1cnJlbnQgPSAwOyB9CiAgICAgCiAgICAgYm9vbCBl eGNsdWRlTGluZU51bWJlcnMoKSBjb25zdCB7IHJldHVybiAhbV9kb05vdEV4Y2x1ZGVMaW5lTnVt YmVyczsgfQpAQCAtNzIsOCArNzAsNiBAQCBjbGFzcyBTZWdtZW50ZWRTdHJpbmcgewogcHVibGlj OgogICAgIFNlZ21lbnRlZFN0cmluZygpCiAgICAgICAgIDogbV9wdXNoZWRDaGFyMSgwKSwgbV9w dXNoZWRDaGFyMigwKSwgbV9jdXJyZW50Q2hhcigwKSwgbV9jb21wb3NpdGUoZmFsc2UpLCBtX2Ns b3NlZChmYWxzZSkge30KLSAgICBTZWdtZW50ZWRTdHJpbmcoY29uc3QgVUNoYXIqIHN0ciwgaW50 IGxlbmd0aCkgOiBtX3B1c2hlZENoYXIxKDApLCBtX3B1c2hlZENoYXIyKDApCi0gICAgICAgICwg bV9jdXJyZW50U3RyaW5nKHN0ciwgbGVuZ3RoKSwgbV9jdXJyZW50Q2hhcihtX2N1cnJlbnRTdHJp bmcubV9jdXJyZW50KSwgbV9jb21wb3NpdGUoZmFsc2UpLCBtX2Nsb3NlZChmYWxzZSkge30KICAg ICBTZWdtZW50ZWRTdHJpbmcoY29uc3QgU3RyaW5nJiBzdHIpCiAgICAgICAgIDogbV9wdXNoZWRD aGFyMSgwKSwgbV9wdXNoZWRDaGFyMigwKSwgbV9jdXJyZW50U3RyaW5nKHN0cikKICAgICAgICAg LCBtX2N1cnJlbnRDaGFyKG1fY3VycmVudFN0cmluZy5tX2N1cnJlbnQpLCBtX2NvbXBvc2l0ZShm YWxzZSksIG1fY2xvc2VkKGZhbHNlKSB7fQo=