43749 2010-08-09 15:10:13 -0700 Eliminate extra traversal of the tree when determining ability to lazy-attach a Node. 2010-08-17 10:58:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov adele eric hyatt mjs sam oldest_to_newest 262336 0 dglazkov 2010-08-09 15:10:13 -0700 Eliminate extra traversal of the tree when determining ability to lazy-attach a Node. 262338 1 63933 dglazkov 2010-08-09 15:12:32 -0700 Created attachment 63933 Patch 262340 2 dglazkov 2010-08-09 15:16:50 -0700 Since neither SVG nor Input shadow DOM aren't using this path (they use home-baked attachement), the check for whether we're inside of the shadow tree isn't needed. This gives a small, but consistent win in Dromaeo's DOM Modification. If you're really mean, you can make me write layout tests to prove that this check isn't meaningful inside of the shadow DOM. 265580 3 dglazkov 2010-08-17 09:03:26 -0700 Adding more peeps. 265585 4 63933 eric 2010-08-17 09:06:01 -0700 Comment on attachment 63933 Patch Lipstick on a pig. Eager attach needs to die. Can you explain better why this check is not needed in your ChangeLog? 265587 5 eric 2010-08-17 09:07:23 -0700 Sorry, meant to CC adele, not beth. Adele is the queen of the world of shadow DOMs, iirc. 265588 6 dglazkov 2010-08-17 09:08:01 -0700 (In reply to comment #4) > (From update of attachment 63933 [details]) > Lipstick on a pig. Eager attach needs to die. > > Can you explain better why this check is not needed in your ChangeLog? Will do. 265596 7 dglazkov 2010-08-17 09:15:27 -0700 Committed r65508: <http://trac.webkit.org/changeset/65508> 265642 8 dglazkov 2010-08-17 10:58:53 -0700 I bungled landing this and had to land the actual change in http://trac.webkit.org/changeset/65517. Sorry :-\ 63933 2010-08-09 15:12:32 -0700 2010-08-17 09:06:01 -0700 Patch bug-43749-20100809151231.patch text/plain 1647 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjRlZDA0N2Y5MDY2NDYyYzU4NGI2NTZjMTg5MDQ5NDUwOGMyZWViYi4uZjg5NDNlYTBiOTRkNDhj NTY5NTkwMWUxYzg0YTU2NmU5NGI4NTQxYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0wOSAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVsaW1pbmF0ZSBleHRyYSB0cmF2ZXJzYWwg b2YgdGhlIHRyZWUgd2hlbiBkZXRlcm1pbmluZyBhYmlsaXR5IHRvIGxhenktYXR0YWNoIGEgTm9k ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNzQ5 CisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6IFJlbW92ZWQgY2FuTGF6eUF0dGFjaCBkZWNsYXJh dGlvbi4KKyAgICAgICAgKiBkb20vTm9kZS5oOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6Y2Fu TGF6eUF0dGFjaCk6IENoYW5nZWQgdG8gYWx3YXlzIHJldHVybiB0cnVlLgorCiAyMDEwLTA4LTA5 ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vTm9kZS5jcHAg Yi9XZWJDb3JlL2RvbS9Ob2RlLmNwcAppbmRleCBlMGYwNGRlZmI1NDA1ZjdmYjMwODY2OTc5NDEw NWZjYWRlMGIzZmQ3Li4wYmM4ZDllOWFlNTIzZTExZWI0OGM4NzJkNTNkNWI0NjI4MDYyYjdmIDEw MDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9XZWJDb3JlL2RvbS9Ob2RlLmNw cApAQCAtNzc5LDExICs3NzksNiBAQCB2b2lkIE5vZGU6OmxhenlBdHRhY2goKQogICAgIH0KIH0K IAotYm9vbCBOb2RlOjpjYW5MYXp5QXR0YWNoKCkKLXsKLSAgICByZXR1cm4gc2hhZG93QW5jZXN0 b3JOb2RlKCkgPT0gdGhpczsKLX0KLSAgICAKIHZvaWQgTm9kZTo6c2V0Rm9jdXMoYm9vbCBiKQog eyAKICAgICBpZiAoYiB8fCBoYXNSYXJlRGF0YSgpKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20v Tm9kZS5oIGIvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IGUzYzE5MTBkYWFjYTU4YzNiMWQ3N2I0 OWI1ODU3Y2JjM2JkNjkwZWIuLjlmODBiOTQyZjExOGM3ZTYxZTZhZWRmZmU3NzJiYTVjZmIyYWZh M2MgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL05vZGUuaAorKysgYi9XZWJDb3JlL2RvbS9Ob2Rl LmgKQEAgLTMxOCw3ICszMTgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBjbGVhcklzTGluaygpIHsg Y2xlYXJGbGFnKElzTGlua0ZsYWcpOyB9CiAKICAgICB2b2lkIGxhenlBdHRhY2goKTsKLSAgICB2 aXJ0dWFsIGJvb2wgY2FuTGF6eUF0dGFjaCgpOworICAgIHZpcnR1YWwgYm9vbCBjYW5MYXp5QXR0 YWNoKCkgeyByZXR1cm4gdHJ1ZTsgfQogCiAgICAgdmlydHVhbCB2b2lkIHNldEZvY3VzKGJvb2wg YiA9IHRydWUpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRBY3RpdmUoYm9vbCBmID0gdHJ1ZSwgYm9v bCAvKnBhdXNlKi8gPSBmYWxzZSkgeyBzZXRGbGFnKGYsIElzQWN0aXZlRmxhZyk7IH0K