43748 2010-08-09 14:55:06 -0700 [chromium] Blue line visible at the right hand side of the window with accelerated compositor 2010-08-09 17:45:41 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 nduca webkit-unassigned abarth dglazkov eric nduca vangelis webkit.review.bot oldest_to_newest 262332 0 nduca 2010-08-09 14:55:06 -0700 When running chrome with --enable-accelerated-compositing, evenly-sized windows will have a 1px wide blue line on the right or bottom of the screen, to the right of the scroll bar. 262334 1 63932 nduca 2010-08-09 15:01:10 -0700 Created attachment 63932 Proposed fix Proposed fix. 262335 2 webkit.review.bot 2010-08-09 15:05:26 -0700 Attachment 63932 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 262341 3 63932 dglazkov 2010-08-09 15:17:52 -0700 Comment on attachment 63932 Proposed fix Style elf says no. But the patch looks reasonable. Can haz no tabs in patch? 262349 4 63940 nduca 2010-08-09 15:30:04 -0700 Created attachment 63940 Trying again, this time with no tabs :) 262359 5 63940 dglazkov 2010-08-09 15:40:31 -0700 Comment on attachment 63940 Trying again, this time with no tabs :) ok. Don't forget to mark "commit-queue?" if you want the magic bot to land it for you. 262362 6 nduca 2010-08-09 15:45:23 -0700 Ah, will do next time. Thanks! 262428 7 63940 eric 2010-08-09 17:25:34 -0700 Comment on attachment 63940 Trying again, this time with no tabs :) Clearing flags on attachment: 63940 Committed r65020: <http://trac.webkit.org/changeset/65020> 262429 8 eric 2010-08-09 17:25:41 -0700 All reviewed patches have been landed. Closing bug. 262435 9 webkit.review.bot 2010-08-09 17:45:41 -0700 http://trac.webkit.org/changeset/65020 might have broken Qt Linux Release minimal The following changes are on the blame list: http://trac.webkit.org/changeset/65020 http://trac.webkit.org/changeset/65021 63932 2010-08-09 15:01:10 -0700 2010-08-09 15:37:33 -0700 Proposed fix bluelines_43748.patch text/plain 3222 nduca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTAwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDgtMDkgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gQmx1ZSBsaW5lIHZpc2libGUgYXQgdGhlIHJpZ2h0IGhhbmQgc2lkZSBvZiB0aGUgd2lu ZG93IHdpdGggYWNjZWxlcmF0ZWQgY29tcG9zaXRvcgorCWh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00Mzc0OAorCisgICAgICAgIENvcnJlY3QgdGhlIG9ydGhvIHByb2pl Y3Rpb24gbWF0cml4IGZvciB0aGUgcm9vdCBsYXllciwgd2hpY2ggd2FzCisgICAgICAgIHRvbyBs YXJnZSBieSAwLjVweCBpbiBib3RoIHdpZHRoIGFuZCBoZWlnaHQuIEZvciBldmVuIHZpZXcgc2l6 ZXMsCisgICAgICAgIHRoaXMgd291bGQgY2F1c2UgdGhlIHZpZXdwb3J0IHRvIGFwcGVhciAxIHBp eGVsIHRvbyBzbWFsbC4KKworICAgICAgICBGaXhpbmcgdGhpcyByZXF1aXJlcyByZW1vdmFsIG9m IHNldmVyYWwgMC41IGNvcnJlY3Rpb24gZmFjdG9ycworICAgICAgICB0aGF0IHdlcmUgcHJldmlv dXNseSBhZGRlZCB0byBjb21wZW5zYXRlIGZvciB0aGUgdG9vLWxhcmdlIHZpZXdwb3J0LgorCisg ICAgICAgIEZpbmFsbHksIGNvbXB1dGUgdGhlIHRyYW5zbGF0aW9uIGZvciB0aGUgcm9vdCBsYXll ciBxdWFkIHVzaW5nCisgICAgICAgIGZsb2F0aW5nIHBvaW50IHJhdGhlciB0aGFuIGludGVnZXIg YXJpdGhtZXRpYy4gVGhpcyBhdm9pZHMgdXMgbG9zaW5nCisgICAgICAgIGEga2V5IGhhbGYtcGl4 ZWwgb2YgdHJhbnNsYXRpb24gd2hlbiB0aGUgd2lkdGggb2YgdGhlIHdpbmRvdyBpcyBvZGQuCisK KyAgICAgICAgVG8gdGVzdCwgc2l6ZSB3aW5kb3cgdG8gZXZlbi9vZGQgZGltZW5zaW9ucy4gTm8g Ymx1ZSBsaW5lIHNob3VsZCBiZSB2aXNpYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVycyk6CisKIDIwMTAtMDgtMDkgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE aW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCShyZXZpc2lvbiA2 NTAwMSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJl ckNocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzMzLDcgKzMzMyw3IEBAIHZvaWQgTGF5 ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzKGMKICAgICAgICAgbV9yb290TGF5ZXJUZXh0 dXJlV2lkdGggPSB2aXNpYmxlUmVjdC53aWR0aCgpOwogICAgICAgICBtX3Jvb3RMYXllclRleHR1 cmVIZWlnaHQgPSB2aXNpYmxlUmVjdC5oZWlnaHQoKTsKIAotICAgICAgICBtX3Byb2plY3Rpb25N YXRyaXggPSBvcnRob01hdHJpeCgwLCB2aXNpYmxlUmVjdFdpZHRoICsgMC41LCB2aXNpYmxlUmVj dEhlaWdodCArIDAuNSwgMCwgLTEwMDAsIDEwMDApOworICAgICAgICBtX3Byb2plY3Rpb25NYXRy aXggPSBvcnRob01hdHJpeCgwLCB2aXNpYmxlUmVjdFdpZHRoLCB2aXNpYmxlUmVjdEhlaWdodCwg MCwgLTEwMDAsIDEwMDApOwogICAgICAgICBnbFRleEltYWdlMkQoR0xfVEVYVFVSRV8yRCwgMCwg R0xfUkdCQSwgbV9yb290TGF5ZXJUZXh0dXJlV2lkdGgsIG1fcm9vdExheWVyVGV4dHVyZUhlaWdo dCwgMCwgR0xfUkdCQSwgR0xfVU5TSUdORURfQllURSwgMCk7CiAKICAgICAgICAgY2hlY2tHTEVy cm9yKCk7CkBAIC0zOTEsOCArMzkxLDggQEAgdm9pZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OmRy YXdMYXllcnMoYwogI2Vycm9yICJOZWVkIHRvIGltcGxlbWVudCBmb3IgeW91ciBwbGF0Zm9ybS4i CiAjZW5kaWYKIAotICAgICAgICBzY3JvbGxlZExheWVyTWF0cml4LnRyYW5zbGF0ZTNkKChpbnQp Zmxvb3JmKDAuNSAqIHZpc2libGVSZWN0LndpZHRoKCkgKyAwLjUpIC0gc2Nyb2xsRGVsdGEueCgp LAotICAgICAgICAgICAgKGludClmbG9vcmYoMC41ICogdmlzaWJsZVJlY3QuaGVpZ2h0KCkgKyAw LjUpICsgc2NhbGVGYWN0b3IgKiBzY3JvbGxEZWx0YS55KCksIDApOworICAgICAgICBzY3JvbGxl ZExheWVyTWF0cml4LnRyYW5zbGF0ZTNkKChpbnQpZmxvb3JmKDAuNSAqIHZpc2libGVSZWN0Lndp ZHRoKCkpIC0gc2Nyb2xsRGVsdGEueCgpLAorICAgICAgICAgICAgKGludClmbG9vcmYoMC41ICog dmlzaWJsZVJlY3QuaGVpZ2h0KCkpICsgc2NhbGVGYWN0b3IgKiBzY3JvbGxEZWx0YS55KCksIDAp OwogICAgICAgICBzY3JvbGxlZExheWVyTWF0cml4LnNjYWxlM2QoMSwgLTEsIDEpOwogCiAgICAg ICAgIC8vIFN3aXRjaCBzaGFkZXJzIHRvIGF2b2lkIFJHQiBzd2l6emxpbmcuCkBAIC00NTcsNyAr NDU3LDcgQEAgdm9pZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdMYXllcnMoYwogICAgIGds VW5pZm9ybTFpKG1fc2FtcGxlckxvY2F0aW9uLCAwKTsKICAgICBjaGVja0dMRXJyb3IoKTsKICAg ICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCBsYXllck1hdHJpeDsKLSAgICBsYXllck1hdHJpeC50cmFu c2xhdGUzZCh2aXNpYmxlUmVjdC53aWR0aCgpIC8gMiwgdmlzaWJsZVJlY3QuaGVpZ2h0KCkgLyAy LCAwKTsKKyAgICBsYXllck1hdHJpeC50cmFuc2xhdGUzZCh2aXNpYmxlUmVjdC53aWR0aCgpICog MC41ZiwgdmlzaWJsZVJlY3QuaGVpZ2h0KCkgKiAwLjVmLCAwKTsKICAgICBkcmF3VGV4dHVyZWRR dWFkKGxheWVyTWF0cml4LCB2aXNpYmxlUmVjdC53aWR0aCgpLCB2aXNpYmxlUmVjdC5oZWlnaHQo KSwgMSk7CiAgICAgY2hlY2tHTEVycm9yKCk7CiAK 63940 2010-08-09 15:30:04 -0700 2010-08-09 17:25:34 -0700 Trying again, this time with no tabs :) bluelines_43748_2.patch text/plain 3229 nduca SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTAwMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTAtMDgtMDkgIE5hdCBEdWNhICA8bmR1Y2FAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJv bWl1bV0gQmx1ZSBsaW5lIHZpc2libGUgYXQgdGhlIHJpZ2h0IGhhbmQgc2lkZSBvZiB0aGUgd2lu ZG93IHdpdGggYWNjZWxlcmF0ZWQgY29tcG9zaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM3NDgKKworICAgICAgICBDb3JyZWN0IHRoZSBvcnRo byBwcm9qZWN0aW9uIG1hdHJpeCBmb3IgdGhlIHJvb3QgbGF5ZXIsIHdoaWNoIHdhcworICAgICAg ICB0b28gbGFyZ2UgYnkgMC41cHggaW4gYm90aCB3aWR0aCBhbmQgaGVpZ2h0LiBGb3IgZXZlbiB2 aWV3IHNpemVzLAorICAgICAgICB0aGlzIHdvdWxkIGNhdXNlIHRoZSB2aWV3cG9ydCB0byBhcHBl YXIgMSBwaXhlbCB0b28gc21hbGwuCisKKyAgICAgICAgRml4aW5nIHRoaXMgcmVxdWlyZXMgcmVt b3ZhbCBvZiBzZXZlcmFsIDAuNSBjb3JyZWN0aW9uIGZhY3RvcnMKKyAgICAgICAgdGhhdCB3ZXJl IHByZXZpb3VzbHkgYWRkZWQgdG8gY29tcGVuc2F0ZSBmb3IgdGhlIHRvby1sYXJnZSB2aWV3cG9y dC4KKworICAgICAgICBGaW5hbGx5LCBjb21wdXRlIHRoZSB0cmFuc2xhdGlvbiBmb3IgdGhlIHJv b3QgbGF5ZXIgcXVhZCB1c2luZworICAgICAgICBmbG9hdGluZyBwb2ludCByYXRoZXIgdGhhbiBp bnRlZ2VyIGFyaXRobWV0aWMuIFRoaXMgYXZvaWRzIHVzIGxvc2luZworICAgICAgICBhIGtleSBo YWxmLXBpeGVsIG9mIHRyYW5zbGF0aW9uIHdoZW4gdGhlIHdpZHRoIG9mIHRoZSB3aW5kb3cgaXMg b2RkLgorCisgICAgICAgIFRvIHRlc3QsIHNpemUgd2luZG93IHRvIGV2ZW4vb2RkIGRpbWVuc2lv bnMuIE5vIGJsdWUgbGluZSBzaG91bGQgYmUgdmlzaWJsZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdMYXllcnMpOgorCiAyMDEwLTA4LTA5 ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGltaXRyaSBHbGF6a292LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcAkocmV2 aXNpb24gNjUwMDEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVy UmVuZGVyZXJDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzMyw3ICszMzMsNyBAQCB2 b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVycyhjCiAgICAgICAgIG1fcm9vdExh eWVyVGV4dHVyZVdpZHRoID0gdmlzaWJsZVJlY3Qud2lkdGgoKTsKICAgICAgICAgbV9yb290TGF5 ZXJUZXh0dXJlSGVpZ2h0ID0gdmlzaWJsZVJlY3QuaGVpZ2h0KCk7CiAKLSAgICAgICAgbV9wcm9q ZWN0aW9uTWF0cml4ID0gb3J0aG9NYXRyaXgoMCwgdmlzaWJsZVJlY3RXaWR0aCArIDAuNSwgdmlz aWJsZVJlY3RIZWlnaHQgKyAwLjUsIDAsIC0xMDAwLCAxMDAwKTsKKyAgICAgICAgbV9wcm9qZWN0 aW9uTWF0cml4ID0gb3J0aG9NYXRyaXgoMCwgdmlzaWJsZVJlY3RXaWR0aCwgdmlzaWJsZVJlY3RI ZWlnaHQsIDAsIC0xMDAwLCAxMDAwKTsKICAgICAgICAgZ2xUZXhJbWFnZTJEKEdMX1RFWFRVUkVf MkQsIDAsIEdMX1JHQkEsIG1fcm9vdExheWVyVGV4dHVyZVdpZHRoLCBtX3Jvb3RMYXllclRleHR1 cmVIZWlnaHQsIDAsIEdMX1JHQkEsIEdMX1VOU0lHTkVEX0JZVEUsIDApOwogCiAgICAgICAgIGNo ZWNrR0xFcnJvcigpOwpAQCAtMzkxLDggKzM5MSw4IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9t aXVtOjpkcmF3TGF5ZXJzKGMKICNlcnJvciAiTmVlZCB0byBpbXBsZW1lbnQgZm9yIHlvdXIgcGxh dGZvcm0uIgogI2VuZGlmCiAKLSAgICAgICAgc2Nyb2xsZWRMYXllck1hdHJpeC50cmFuc2xhdGUz ZCgoaW50KWZsb29yZigwLjUgKiB2aXNpYmxlUmVjdC53aWR0aCgpICsgMC41KSAtIHNjcm9sbERl bHRhLngoKSwKLSAgICAgICAgICAgIChpbnQpZmxvb3JmKDAuNSAqIHZpc2libGVSZWN0LmhlaWdo dCgpICsgMC41KSArIHNjYWxlRmFjdG9yICogc2Nyb2xsRGVsdGEueSgpLCAwKTsKKyAgICAgICAg c2Nyb2xsZWRMYXllck1hdHJpeC50cmFuc2xhdGUzZCgoaW50KWZsb29yZigwLjUgKiB2aXNpYmxl UmVjdC53aWR0aCgpKSAtIHNjcm9sbERlbHRhLngoKSwKKyAgICAgICAgICAgIChpbnQpZmxvb3Jm KDAuNSAqIHZpc2libGVSZWN0LmhlaWdodCgpKSArIHNjYWxlRmFjdG9yICogc2Nyb2xsRGVsdGEu eSgpLCAwKTsKICAgICAgICAgc2Nyb2xsZWRMYXllck1hdHJpeC5zY2FsZTNkKDEsIC0xLCAxKTsK IAogICAgICAgICAvLyBTd2l0Y2ggc2hhZGVycyB0byBhdm9pZCBSR0Igc3dpenpsaW5nLgpAQCAt NDU3LDcgKzQ1Nyw3IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzKGMK ICAgICBnbFVuaWZvcm0xaShtX3NhbXBsZXJMb2NhdGlvbiwgMCk7CiAgICAgY2hlY2tHTEVycm9y KCk7CiAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggbGF5ZXJNYXRyaXg7Ci0gICAgbGF5ZXJNYXRy aXgudHJhbnNsYXRlM2QodmlzaWJsZVJlY3Qud2lkdGgoKSAvIDIsIHZpc2libGVSZWN0LmhlaWdo dCgpIC8gMiwgMCk7CisgICAgbGF5ZXJNYXRyaXgudHJhbnNsYXRlM2QodmlzaWJsZVJlY3Qud2lk dGgoKSAqIDAuNWYsIHZpc2libGVSZWN0LmhlaWdodCgpICogMC41ZiwgMCk7CiAgICAgZHJhd1Rl eHR1cmVkUXVhZChsYXllck1hdHJpeCwgdmlzaWJsZVJlY3Qud2lkdGgoKSwgdmlzaWJsZVJlY3Qu aGVpZ2h0KCksIDEpOwogICAgIGNoZWNrR0xFcnJvcigpOwogCg==