43740 2010-08-09 12:55:09 -0700 Move HTMLViewSourceDocument from legacyParserAddChild to parserAddChild 2010-08-09 14:32:16 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth eric oldest_to_newest 262270 0 abarth 2010-08-09 12:55:09 -0700 Move HTMLViewSourceDocument from legacyParserAddChild to parserAddChild 262273 1 63918 abarth 2010-08-09 12:56:06 -0700 Created attachment 63918 Patch 262276 2 63918 eric 2010-08-09 12:59:14 -0700 Comment on attachment 63918 Patch LGTM. 262324 3 63918 eric 2010-08-09 14:32:11 -0700 Comment on attachment 63918 Patch Clearing flags on attachment: 63918 Committed r65004: <http://trac.webkit.org/changeset/65004> 262325 4 eric 2010-08-09 14:32:16 -0700 All reviewed patches have been landed. Closing bug. 63918 2010-08-09 12:56:06 -0700 2010-08-09 14:32:11 -0700 Patch bug-43740-20100809125605.patch text/plain 4922 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjNkZTRjOTBkNGQyNDhlMjY4NGE1MWY3OTIwN2Q0OTM5ZGU0ZGVmNi4uZjI4YjZjNmFhODg5MTky YTMxNzU5ODg1MmUxOWRmYjUxMmEwODdjNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOC0wOSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgSFRNTFZpZXdTb3VyY2VEb2N1bWVudCBmcm9tIGxl Z2FjeVBhcnNlckFkZENoaWxkIHRvIHBhcnNlckFkZENoaWxkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00Mzc0MAorCisgICAgICAgIFRoaXMgcmVtb3Zl cyB0aGUgRFREIGNoZWNrcywgd2hpY2ggYXJlbid0IG5lZWRlZCBmb3IgdmlldyBzb3VyY2UKKyAg ICAgICAgZG9jdW1lbnRzLgorCisgICAgICAgICogaHRtbC9IVE1MVmlld1NvdXJjZURvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxWaWV3U291cmNlRG9jdW1lbnQ6OmNyZWF0ZUNv bnRhaW5pbmdUYWJsZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlld1NvdXJjZURvY3VtZW50 OjphZGRTcGFuV2l0aENsYXNzTmFtZSk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MVmlld1NvdXJj ZURvY3VtZW50OjphZGRMaW5lKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxWaWV3U291cmNlRG9j dW1lbnQ6OmFkZFRleHQpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFZpZXdTb3VyY2VEb2N1bWVu dDo6YWRkTGluayk6CisKIDIwMTAtMDgtMDkgIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvaHRtbC9IVE1MVmlld1NvdXJjZURvY3VtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9I VE1MVmlld1NvdXJjZURvY3VtZW50LmNwcAppbmRleCA2Y2VlMjdjNjVmMTNlYjUyNDJjNmVlZDFi YWNhYjc0ZGVmMTFhODIxLi5jYTk1OWEyZjU1ZjQ2NmNmMmZkZTFhZjEyYThiMjlhYTFjNmY4N2U5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTFZpZXdTb3VyY2VEb2N1bWVudC5jcHAKKysr IGIvV2ViQ29yZS9odG1sL0hUTUxWaWV3U291cmNlRG9jdW1lbnQuY3BwCkBAIC02OSwxMCArNjks MTAgQEAgRG9jdW1lbnRQYXJzZXIqIEhUTUxWaWV3U291cmNlRG9jdW1lbnQ6OmNyZWF0ZVBhcnNl cigpCiB2b2lkIEhUTUxWaWV3U291cmNlRG9jdW1lbnQ6OmNyZWF0ZUNvbnRhaW5pbmdUYWJsZSgp CiB7CiAgICAgUmVmUHRyPEhUTUxIdG1sRWxlbWVudD4gaHRtbCA9IEhUTUxIdG1sRWxlbWVudDo6 Y3JlYXRlKHRoaXMpOwotICAgIGxlZ2FjeVBhcnNlckFkZENoaWxkKGh0bWwpOworICAgIHBhcnNl ckFkZENoaWxkKGh0bWwpOwogICAgIGh0bWwtPmF0dGFjaCgpOwogICAgIFJlZlB0cjxIVE1MQm9k eUVsZW1lbnQ+IGJvZHkgPSBIVE1MQm9keUVsZW1lbnQ6OmNyZWF0ZSh0aGlzKTsKLSAgICBodG1s LT5sZWdhY3lQYXJzZXJBZGRDaGlsZChib2R5KTsKKyAgICBodG1sLT5wYXJzZXJBZGRDaGlsZChi b2R5KTsKICAgICBib2R5LT5hdHRhY2goKTsKICAgICAKICAgICAvLyBDcmVhdGUgYSBsaW5lIGd1 dHRlciBkaXYgdGhhdCBjYW4gYmUgdXNlZCB0byBtYWtlIHN1cmUgdGhlIGd1dHRlciBleHRlbmRz IGRvd24gdGhlIGhlaWdodCBvZiB0aGUgd2hvbGUKQEAgLTgxLDE0ICs4MSwxNCBAQCB2b2lkIEhU TUxWaWV3U291cmNlRG9jdW1lbnQ6OmNyZWF0ZUNvbnRhaW5pbmdUYWJsZSgpCiAgICAgUmVmUHRy PE5hbWVkTm9kZU1hcD4gYXR0cnMgPSBOYW1lZE5vZGVNYXA6OmNyZWF0ZSgpOwogICAgIGF0dHJz LT5hZGRBdHRyaWJ1dGUoQXR0cmlidXRlOjpjcmVhdGVNYXBwZWQoY2xhc3NBdHRyLCAid2Via2l0 LWxpbmUtZ3V0dGVyLWJhY2tkcm9wIikpOwogICAgIGRpdi0+c2V0QXR0cmlidXRlTWFwKGF0dHJz LnJlbGVhc2UoKSk7Ci0gICAgYm9keS0+bGVnYWN5UGFyc2VyQWRkQ2hpbGQoZGl2KTsKKyAgICBi b2R5LT5wYXJzZXJBZGRDaGlsZChkaXYpOwogICAgIGRpdi0+YXR0YWNoKCk7CiAKICAgICBSZWZQ dHI8SFRNTFRhYmxlRWxlbWVudD4gdGFibGUgPSBIVE1MVGFibGVFbGVtZW50OjpjcmVhdGUodGhp cyk7Ci0gICAgYm9keS0+bGVnYWN5UGFyc2VyQWRkQ2hpbGQodGFibGUpOworICAgIGJvZHktPnBh cnNlckFkZENoaWxkKHRhYmxlKTsKICAgICB0YWJsZS0+YXR0YWNoKCk7CiAgICAgbV90Ym9keSA9 IEhUTUxUYWJsZVNlY3Rpb25FbGVtZW50OjpjcmVhdGUodGJvZHlUYWcsIHRoaXMpOwotICAgIHRh YmxlLT5sZWdhY3lQYXJzZXJBZGRDaGlsZChtX3Rib2R5KTsKKyAgICB0YWJsZS0+cGFyc2VyQWRk Q2hpbGQobV90Ym9keSk7CiAgICAgbV90Ym9keS0+YXR0YWNoKCk7CiAgICAgbV9jdXJyZW50ID0g bV90Ym9keTsKIH0KQEAgLTIxNCw3ICsyMTQsNyBAQCBQYXNzUmVmUHRyPEVsZW1lbnQ+IEhUTUxW aWV3U291cmNlRG9jdW1lbnQ6OmFkZFNwYW5XaXRoQ2xhc3NOYW1lKGNvbnN0IFN0cmluZyYgYwog ICAgIFJlZlB0cjxOYW1lZE5vZGVNYXA+IGF0dHJzID0gTmFtZWROb2RlTWFwOjpjcmVhdGUoKTsK ICAgICBhdHRycy0+YWRkQXR0cmlidXRlKEF0dHJpYnV0ZTo6Y3JlYXRlTWFwcGVkKGNsYXNzQXR0 ciwgY2xhc3NOYW1lKSk7CiAgICAgc3Bhbi0+c2V0QXR0cmlidXRlTWFwKGF0dHJzLnJlbGVhc2Uo KSk7Ci0gICAgbV9jdXJyZW50LT5sZWdhY3lQYXJzZXJBZGRDaGlsZChzcGFuKTsKKyAgICBtX2N1 cnJlbnQtPnBhcnNlckFkZENoaWxkKHNwYW4pOwogICAgIHNwYW4tPmF0dGFjaCgpOwogICAgIHJl dHVybiBzcGFuLnJlbGVhc2UoKTsKIH0KQEAgLTIyMyw3ICsyMjMsNyBAQCB2b2lkIEhUTUxWaWV3 U291cmNlRG9jdW1lbnQ6OmFkZExpbmUoY29uc3QgU3RyaW5nJiBjbGFzc05hbWUpCiB7CiAgICAg Ly8gQ3JlYXRlIGEgdGFibGUgcm93LgogICAgIFJlZlB0cjxIVE1MVGFibGVSb3dFbGVtZW50PiB0 cm93ID0gSFRNTFRhYmxlUm93RWxlbWVudDo6Y3JlYXRlKHRoaXMpOwotICAgIG1fdGJvZHktPmxl Z2FjeVBhcnNlckFkZENoaWxkKHRyb3cpOworICAgIG1fdGJvZHktPnBhcnNlckFkZENoaWxkKHRy b3cpOwogICAgIHRyb3ctPmF0dGFjaCgpOwogICAgIAogICAgIC8vIENyZWF0ZSBhIGNlbGwgdGhh dCB3aWxsIGhvbGQgdGhlIGxpbmUgbnVtYmVyIChpdCBpcyBnZW5lcmF0ZWQgaW4gdGhlIHN0eWxl c2hlZXQgdXNpbmcgY291bnRlcnMpLgpAQCAtMjMxLDcgKzIzMSw3IEBAIHZvaWQgSFRNTFZpZXdT b3VyY2VEb2N1bWVudDo6YWRkTGluZShjb25zdCBTdHJpbmcmIGNsYXNzTmFtZSkKICAgICBSZWZQ dHI8TmFtZWROb2RlTWFwPiBhdHRycyA9IE5hbWVkTm9kZU1hcDo6Y3JlYXRlKCk7CiAgICAgYXR0 cnMtPmFkZEF0dHJpYnV0ZShBdHRyaWJ1dGU6OmNyZWF0ZU1hcHBlZChjbGFzc0F0dHIsICJ3ZWJr aXQtbGluZS1udW1iZXIiKSk7CiAgICAgdGQtPnNldEF0dHJpYnV0ZU1hcChhdHRycy5yZWxlYXNl KCkpOwotICAgIHRyb3ctPmxlZ2FjeVBhcnNlckFkZENoaWxkKHRkKTsKKyAgICB0cm93LT5wYXJz ZXJBZGRDaGlsZCh0ZCk7CiAgICAgdGQtPmF0dGFjaCgpOwogCiAgICAgLy8gQ3JlYXRlIGEgc2Vj b25kIGNlbGwgZm9yIHRoZSBsaW5lIGNvbnRlbnRzCkBAIC0yMzksNyArMjM5LDcgQEAgdm9pZCBI VE1MVmlld1NvdXJjZURvY3VtZW50OjphZGRMaW5lKGNvbnN0IFN0cmluZyYgY2xhc3NOYW1lKQog ICAgIGF0dHJzID0gTmFtZWROb2RlTWFwOjpjcmVhdGUoKTsKICAgICBhdHRycy0+YWRkQXR0cmli dXRlKEF0dHJpYnV0ZTo6Y3JlYXRlTWFwcGVkKGNsYXNzQXR0ciwgIndlYmtpdC1saW5lLWNvbnRl bnQiKSk7CiAgICAgdGQtPnNldEF0dHJpYnV0ZU1hcChhdHRycy5yZWxlYXNlKCkpOwotICAgIHRy b3ctPmxlZ2FjeVBhcnNlckFkZENoaWxkKHRkKTsKKyAgICB0cm93LT5wYXJzZXJBZGRDaGlsZCh0 ZCk7CiAgICAgdGQtPmF0dGFjaCgpOwogICAgIG1fY3VycmVudCA9IG1fdGQgPSB0ZDsKIApAQCAt Mjc2LDcgKzI3Niw3IEBAIHZvaWQgSFRNTFZpZXdTb3VyY2VEb2N1bWVudDo6YWRkVGV4dChjb25z dCBTdHJpbmcmIHRleHQsIGNvbnN0IFN0cmluZyYgY2xhc3NOYW1lCiAgICAgICAgIGlmIChtX2N1 cnJlbnQgPT0gbV90Ym9keSkKICAgICAgICAgICAgIGFkZExpbmUoY2xhc3NOYW1lKTsKICAgICAg ICAgUmVmUHRyPFRleHQ+IHQgPSBUZXh0OjpjcmVhdGUodGhpcywgc3Vic3RyaW5nKTsKLSAgICAg ICAgbV9jdXJyZW50LT5sZWdhY3lQYXJzZXJBZGRDaGlsZCh0KTsKKyAgICAgICAgbV9jdXJyZW50 LT5wYXJzZXJBZGRDaGlsZCh0KTsKICAgICAgICAgdC0+YXR0YWNoKCk7CiAgICAgICAgIGlmIChp IDwgc2l6ZSAtIDEpCiAgICAgICAgICAgICBtX2N1cnJlbnQgPSBtX3Rib2R5OwpAQCAtMzA0LDcg KzMwNCw3IEBAIFBhc3NSZWZQdHI8RWxlbWVudD4gSFRNTFZpZXdTb3VyY2VEb2N1bWVudDo6YWRk TGluayhjb25zdCBTdHJpbmcmIHVybCwgYm9vbCBpc0FuCiAgICAgYXR0cnMtPmFkZEF0dHJpYnV0 ZShBdHRyaWJ1dGU6OmNyZWF0ZU1hcHBlZCh0YXJnZXRBdHRyLCAiX2JsYW5rIikpOwogICAgIGF0 dHJzLT5hZGRBdHRyaWJ1dGUoQXR0cmlidXRlOjpjcmVhdGVNYXBwZWQoaHJlZkF0dHIsIHVybCkp OwogICAgIGFuY2hvci0+c2V0QXR0cmlidXRlTWFwKGF0dHJzLnJlbGVhc2UoKSk7Ci0gICAgbV9j dXJyZW50LT5sZWdhY3lQYXJzZXJBZGRDaGlsZChhbmNob3IpOworICAgIG1fY3VycmVudC0+cGFy c2VyQWRkQ2hpbGQoYW5jaG9yKTsKICAgICBhbmNob3ItPmF0dGFjaCgpOwogICAgIHJldHVybiBh bmNob3IucmVsZWFzZSgpOwogfQo=