43728 2010-08-09 09:54:42 -0700 [Qt] No need for PageClientImpl 2010-08-09 11:01:40 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kbalazs webkit-unassigned eric oldest_to_newest 262193 0 kbalazs 2010-08-09 09:54:42 -0700 In http://trac.webkit.org/changeset/64122 I have created a PageClientImpl class by moving the WebKit::PageClient implementation from QWKPagePrivate to the new class. The reason of this change is written in bug 42974. However, after http://trac.webkit.org/changeset/64155 the new class has became useless. I think it would be better to take back the change by making QWKPagePrivate the PageClient since it is more logical. 262196 1 63905 kbalazs 2010-08-09 10:01:12 -0700 Created attachment 63905 proposed patch 262223 2 63905 eric 2010-08-09 11:01:35 -0700 Comment on attachment 63905 proposed patch Clearing flags on attachment: 63905 Committed r64992: <http://trac.webkit.org/changeset/64992> 262224 3 eric 2010-08-09 11:01:40 -0700 All reviewed patches have been landed. Closing bug. 63905 2010-08-09 10:01:12 -0700 2010-08-09 11:01:35 -0700 proposed patch land_no_pageclientimpl.diff text/plain 3846 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg OTcyNmQ1Ny4uZjFmZTI0NCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wOC0wOSAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBObyBuZWVkIGZvciBQYWdlQ2xpZW50SW1wbAorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzcyOAorCisgICAg ICAgIFJlbW92ZSBQYWdlQ2xpZW50SW1wbCwgdGFrZSB0aGUgaW1wbGVtZW50YXRpb24gb2YgV2Vi S2l0OjpQYWdlQ2xpZW50IGludG8gUVdLUGFnZVByaXZhdGUuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3F3a3BhZ2UuY3BwOgorICAgICAgICAoUVdLUGFnZVByaXZhdGU6OlFXS1BhZ2VQ cml2YXRlKToKKyAgICAgICAgKFFXS1BhZ2VQcml2YXRlOjp0b29sVGlwQ2hhbmdlZCk6CisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaDoKKyAgICAgICAgKFFXS1BhZ2VQcml2 YXRlOjpwYWdlRGlkRW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nKToKKyAgICAgICAgKFFXS1Bh Z2VQcml2YXRlOjpwYWdlRGlkTGVhdmVBY2NlbGVyYXRlZENvbXBvc2l0aW5nKToKKyAgICAgICAg KFFXS1BhZ2VQcml2YXRlOjpwcm9jZXNzRGlkRXhpdCk6CisgICAgICAgIChRV0tQYWdlUHJpdmF0 ZTo6cHJvY2Vzc0RpZFJldml2ZSk6CisgICAgICAgIChRV0tQYWdlUHJpdmF0ZTo6c2V0Q3Vyc29y KToKKyAgICAgICAgKFFXS1BhZ2VQcml2YXRlOjp0YWtlRm9jdXMpOgorCiAyMDEwLTA4LTA3ICBT YW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJz IENhcmxzc29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2Uu Y3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCmluZGV4IGQxN2EzYzIu LjcwNTJmNTcgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNw cAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKQEAgLTM3LDQwICsz NywxMyBAQAogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3Jl OwogCi1jbGFzcyBQYWdlQ2xpZW50SW1wbCA6IHB1YmxpYyBXZWJLaXQ6OlBhZ2VDbGllbnQgewot cHVibGljOgotICAgIFBhZ2VDbGllbnRJbXBsKFFXS1BhZ2UqIHBhZ2UpCi0gICAgICAgIDogbV9w YWdlKHBhZ2UpCi0gICAgewotICAgIH0KLQotI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElO RykKLSAgICB2b2lkIHBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KLSAg ICB2b2lkIHBhZ2VEaWRMZWF2ZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KLSNlbmRpZiAv LyBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgdmlydHVhbCB2b2lkIHByb2Nlc3NE aWRFeGl0KCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRSZXZpdmUoKSB7IH0KLSAg ICB2aXJ0dWFsIHZvaWQgc2V0Q3Vyc29yKGNvbnN0IFdlYkNvcmU6OkN1cnNvciYpIHsgfQotICAg IHZpcnR1YWwgdm9pZCB0YWtlRm9jdXMoYm9vbCBkaXJlY3Rpb24pIHsgfQotCi0gICAgdmlydHVh bCB2b2lkIHRvb2xUaXBDaGFuZ2VkKGNvbnN0IFdlYkNvcmU6OlN0cmluZyYsIGNvbnN0IFdlYkNv cmU6OlN0cmluZyYpOwotCi1wcml2YXRlOgotICAgIFFXS1BhZ2UqIG1fcGFnZTsKLX07Ci0KLXZv aWQgUGFnZUNsaWVudEltcGw6OnRvb2xUaXBDaGFuZ2VkKGNvbnN0IFN0cmluZyYsIGNvbnN0IFN0 cmluZyYgbmV3VG9vbHRpcCkKLXsKLSAgICBlbWl0IG1fcGFnZS0+c3RhdHVzQmFyTWVzc2FnZShR U3RyaW5nKG5ld1Rvb2x0aXApKTsKLX0KLQogUVdLUGFnZVByaXZhdGU6OlFXS1BhZ2VQcml2YXRl KFFXS1BhZ2UqIHFxLCBXS1BhZ2VOYW1lc3BhY2VSZWYgbmFtZXNwYWNlUmVmKQogICAgIDogcShx cSkKICAgICAsIGNyZWF0ZU5ld1BhZ2VGbigwKQogewogICAgIG1lbXNldChhY3Rpb25zLCAwLCBz aXplb2YoYWN0aW9ucykpOwogICAgIHBhZ2UgPSB0b1dLKG5hbWVzcGFjZVJlZiktPmNyZWF0ZVdl YlBhZ2UoKTsKLSAgICBwYWdlLT5zZXRQYWdlQ2xpZW50KG5ldyBQYWdlQ2xpZW50SW1wbChxcSkp OyAvLyBPd25lcnNoaXAgaXMgcGFzc2VkIHRvIHRoZSBwYWdlLgorICAgIHBhZ2UtPnNldFBhZ2VD bGllbnQodGhpcyk7CiB9CiAKIFFXS1BhZ2VQcml2YXRlOjp+UVdLUGFnZVByaXZhdGUoKQpAQCAt ODMsNiArNTYsMTEgQEAgdm9pZCBRV0tQYWdlUHJpdmF0ZTo6aW5pdChjb25zdCBRU2l6ZSYgdmll d3BvcnRTaXplLCBEcmF3aW5nQXJlYVByb3h5KiBwcm94eSkKICAgICBwYWdlLT5pbml0aWFsaXpl V2ViUGFnZShJbnRTaXplKHZpZXdwb3J0U2l6ZSksIHByb3h5KTsKIH0KIAordm9pZCBRV0tQYWdl UHJpdmF0ZTo6dG9vbFRpcENoYW5nZWQoY29uc3QgU3RyaW5nJiwgY29uc3QgU3RyaW5nJiBuZXdU b29sdGlwKQoreworICAgIGVtaXQgcS0+c3RhdHVzQmFyTWVzc2FnZShRU3RyaW5nKG5ld1Rvb2x0 aXApKTsKK30KKwogdm9pZCBRV0tQYWdlUHJpdmF0ZTo6cGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIs IFFSZWN0IGFyZWEpCiB7CiAgICAgcGFpbnRlci0+c2F2ZSgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2VfcC5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2VfcC5oCmluZGV4IDBjNjE3YTMuLmU3MjUzNzkgMTAwNjQ0Ci0tLSBhL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXdrcGFnZV9wLmgKQEAgLTMxLDcgKzMxLDcgQEAKICNpbmNsdWRlIDxRR3JhcGhpY3NWaWV3 PgogI2luY2x1ZGUgPFFLZXlFdmVudD4KIAotY2xhc3MgUVdLUGFnZVByaXZhdGUgeworY2xhc3Mg UVdLUGFnZVByaXZhdGUgOiBXZWJLaXQ6OlBhZ2VDbGllbnQgewogcHVibGljOgogICAgIFFXS1Bh Z2VQcml2YXRlKFFXS1BhZ2UqLCBXS1BhZ2VOYW1lc3BhY2VSZWYpOwogICAgIH5RV0tQYWdlUHJp dmF0ZSgpOwpAQCAtNDAsNiArNDAsMTcgQEAgcHVibGljOgogCiAgICAgdm9pZCBpbml0KGNvbnN0 IFFTaXplJiB2aWV3cG9ydFNpemUsIFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eSopOwogCisgICAg Ly8gUGFnZUNsaWVudAorI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICB2b2lk IHBhZ2VEaWRFbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KKyAgICB2b2lkIHBhZ2VE aWRMZWF2ZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmcoKSB7IH0KKyNlbmRpZiAvLyBVU0UoQUNDRUxF UkFURURfQ09NUE9TSVRJTkcpCisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRFeGl0KCkgeyB9 CisgICAgdmlydHVhbCB2b2lkIHByb2Nlc3NEaWRSZXZpdmUoKSB7IH0KKyAgICB2aXJ0dWFsIHZv aWQgc2V0Q3Vyc29yKGNvbnN0IFdlYkNvcmU6OkN1cnNvciYpIHsgfQorICAgIHZpcnR1YWwgdm9p ZCB0YWtlRm9jdXMoYm9vbCBkaXJlY3Rpb24pIHsgfQorICAgIHZpcnR1YWwgdm9pZCB0b29sVGlw Q2hhbmdlZChjb25zdCBXZWJDb3JlOjpTdHJpbmcmLCBjb25zdCBXZWJDb3JlOjpTdHJpbmcmKTsK KwogICAgIHZvaWQgcGFpbnQoUVBhaW50ZXIqIHBhaW50ZXIsIFFSZWN0KTsKIAogICAgIHZvaWQg a2V5UHJlc3NFdmVudChRS2V5RXZlbnQqKTsK