4372 2005-08-10 11:23:04 -0700 JavaScript document.write page form does not submit in Safari 2006-10-01 01:41:09 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 vicki webkit-unassigned ap gavin.sharp ian mitz oldest_to_newest 16356 0 vicki 2005-08-10 11:23:04 -0700 This bug is also in Radar as <rdar://4196379> Summary: Submitting an html form of a page that was written with a JavaScript document.write method does not work in Safari. We are concerned about this problem because we are using an encryption/decryption product that has the ability to decrypt a page and uses a document.write method to display the page. Steps to Reproduce: I have created a small page that demonstrates the problem. On load of the page it will use a document.write method to over write the current page with a page that has a form on it. Upon clicking on the submit button Safari does not submit the form; however Internet Explorer 6(WinXP) and Firefox (Mac) submits the form correctly. Example page writeform.html: <html> <head> <script> function writePage() { document.write("<html><head></head><body>" + "<form name='aform' action='servlet.html' method='post'>" + "<input type=submit></form>" + "</body></html>"); } </script> </head> <body onload="writePage()"> </body> </html> Expected Results: Safari would submit the form when clicking on the submit button. Actual Results: Safari does not submit the form and stays on current page. Regression: This problem occurred on the following platforms: Mac os X 10.3.9 Safari 1.3(v312) PowerBook G4 15-inch A1095. Mac os X 10.4.2 Safari 2.0(412.3) PowerBook G4 15-inch A1095. ------------------------------------------- 16357 1 3313 vicki 2005-08-10 11:23:50 -0700 Created attachment 3313 test case 26839 2 eric 2005-12-27 15:00:00 -0800 Odd. When I hit the back button (after having hit submit), it tries to take me to /servlet.html 54703 3 10379 ap 2006-09-03 10:37:50 -0700 Created attachment 10379 patch, without tests or ChangeLog All layout tests pass, but it might be just because the reason for the removed check isn't covered... So, I'm asking about validity of such approach. A workaround is to call document.close() after writing. 54716 4 10379 darin 2006-09-03 12:11:19 -0700 Comment on attachment 10379 patch, without tests or ChangeLog Oof! We *definitely* need tests for this one. I can't tell just from code inspection if this is OK or not. I'm not sure what to do about reviewing. 55506 5 ap 2006-09-14 08:38:35 -0700 The code in question appeared in WebCore in r1035: * src/kdelibs/khtml/khtml_part.cpp: Added. Not used yet, but maybe we'll use part of it some time soon. In the KDE repository, the condition has been tweaked many times, but the part I'm removing was introduced in r64718 six years ago: "applying stripped down version of my anti-tokenizer-crash-on-submit patch discussed on kfm-devel. It only prevents the crash. A complete solution for the form data has still to be found." http://websvn.kde.org/trunk/kdelibs/khtml/khtml_part.cpp?rev=64718&r1=64461&r2=64718 I couldn't find the mentioned kfm-devel discussion. 56280 6 mjs 2006-09-23 01:18:00 -0700 I think the approach is right but this needs a layout test. 56324 7 10730 ap 2006-09-23 20:34:50 -0700 Created attachment 10730 proposed fix 56660 8 mitz 2006-09-27 14:42:30 -0700 (In reply to comment #5) > I couldn't find the mentioned kfm-devel discussion. http://lists.kde.org/?l=kfm-devel&m=96644872718833&w=2 56720 9 10730 darin 2006-09-28 09:09:22 -0700 Comment on attachment 10730 proposed fix r=me 56861 10 ap 2006-10-01 01:41:09 -0700 Committed revision 16694. The fun begins! 3313 2005-08-10 11:23:50 -0700 2005-08-10 11:23:50 -0700 test case writeform.html text/html 279 vicki PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiB3cml0ZVBhZ2UoKSB7CiAgIGRvY3VtZW50 LndyaXRlKCI8aHRtbD48aGVhZD48L2hlYWQ+PGJvZHk+IiArCiAgICAiPGZvcm0gbmFtZT0nYWZv cm0nIGFjdGlvbj0nc2VydmxldC5odG1sJyBtZXRob2Q9J3Bvc3QnPiIgKwogICAgIjxpbnB1dCB0 eXBlPXN1Ym1pdD48L2Zvcm0+IiArCiAgICAiPC9ib2R5PjwvaHRtbD4iKTsKfQo8L3NjcmlwdD4K PC9oZWFkPgo8Ym9keSBvbmxvYWQ9IndyaXRlUGFnZSgpIj4KPC9ib2R5Pgo8L2h0bWw+ 10379 2006-09-03 10:37:50 -0700 2006-09-23 20:34:50 -0700 patch, without tests or ChangeLog 4372r0_patch.txt text/plain 531 ap SW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdl L0ZyYW1lLmNwcAkocmV2aXNpb24gMTYxOTcpCisrKyBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xNjA1LDcgKzE2MDUsNyBAQCB2b2lkIEZyYW1lOjpzdWJtaXRGb3Jt KGNvbnN0IGNoYXIgKmFjdGlvCiAgICAgICByZXF1ZXN0LnNldENvbnRlbnRUeXBlKCJDb250ZW50 LVR5cGU6ICIgKyBjb250ZW50VHlwZSArICI7IGJvdW5kYXJ5PSIgKyBib3VuZGFyeSk7CiAgIH0K IAotICBpZiAoZC0+bV9kb2MtPnBhcnNpbmcoKSB8fCBkLT5tX3J1bm5pbmdTY3JpcHRzID4gMCkg eworICBpZiAoZC0+bV9ydW5uaW5nU2NyaXB0cyA+IDApIHsKICAgICBpZiAoZC0+bV9zdWJtaXRG b3JtKQogICAgICAgICByZXR1cm47CiAgICAgZC0+bV9zdWJtaXRGb3JtID0gbmV3IEZyYW1lUHJp dmF0ZTo6U3VibWl0Rm9ybTsK 10730 2006-09-23 20:34:50 -0700 2006-09-28 09:09:22 -0700 proposed fix 4372r1_patch.txt text/plain 3687 ap SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE2NTQ0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDktMjQgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBueXBvcC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3df YnVnLmNnaT9pZD00MzcyCisgICAgICAgIEphdmFTY3JpcHQgZG9jdW1lbnQud3JpdGUgcGFnZSBm b3JtIGRvZXMgbm90IHN1Ym1pdCBpbiBTYWZhcmkKKworICAgICAgICAqIGZhc3QvZm9ybXMvZG9j dW1lbnQtd3JpdGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL2Rv Y3VtZW50LXdyaXRlLmh0bWw6IEFkZGVkLgorCiAyMDA2LTA5LTIzICBBbGV4ZXkgUHJvc2t1cnlh a292ICA8YXBAbnlwb3AuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RvY3VtZW50LXdyaXRlLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RvY3VtZW50LXdyaXRlLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvZG9jdW1lbnQtd3JpdGUt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKK1Rlc3QgZm9yIGJ1ZyA0 MzcyOiBKYXZhU2NyaXB0IGRvY3VtZW50LndyaXRlIHBhZ2UgZm9ybSBkb2VzIG5vdCBzdWJtaXQg aW4gU2FmYXJpIGlmIGRvY3VtZW50LmNsb3NlIGlzIG5vdCBjYWxsZWQuCisKK1NVQ0NFU1MKKwor CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2RvY3VtZW50LXdy aXRlLWV4cGVjdGVkLnR4dApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyB0ZXh0 L3BsYWluCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBuYXRpdmUKCkluZGV4OiBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2RvY3VtZW50LXdyaXRlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy9kb2N1bWVudC13cml0ZS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvZmFzdC9mb3Jtcy9kb2N1bWVudC13cml0ZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDMxIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKSB7Cisg IGlmIChkb2N1bWVudC5VUkwuaW5kZXhPZignPycpID09IC0xKSB7CisKKyAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1w QXNUZXh0KCk7CisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cisg ICAgfQorICAgIAorICAgIGRvY3VtZW50LndyaXRlKCI8aHRtbD48Ym9keT4iICsKKyAgICAiPGZv cm0gbmFtZT0nZicgYWN0aW9uPSc/JyBtZXRob2Q9J3Bvc3QnPiIgKworICAgICI8aW5wdXQgdHlw ZT1zdWJtaXQ+PC9mb3JtPjxzY3JpIiArCisgICAgInB0PmRvY3VtZW50LmYuc3VibWl0KCk7PC9z Y3JpIiArCisgICAgInB0PjwvYm9keT48L2h0bWw+Iik7CisgIH0gZWxzZSB7CisgICAgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlubmVySFRNTD0iU1VDQ0VTUyI7CisgICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKKyAgfQorICAKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25s b2FkPSJ0ZXN0KCkiPgorPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cDovL2J1Z3ppbGxhLm9wZW5k YXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD00MzcyIj5idWcgNDM3MjwvYT46CitKYXZhU2NyaXB0 IGRvY3VtZW50LndyaXRlIHBhZ2UgZm9ybSBkb2VzIG5vdCBzdWJtaXQgaW4gU2FmYXJpIGlmIGRv Y3VtZW50LmNsb3NlIGlzIG5vdCBjYWxsZWQuPC9wPgorPHAgaWQ9cmVzdWx0PkZBSUxVUkU8L3A+ Cis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2RvY3VtZW50LXdyaXRlLmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBl CiAgICsgdGV4dC9odG1sCgpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NTQ0KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwNi0wOS0yNCAgQWxleGV5IFByb3Nr dXJ5YWtvdiAgPGFwQG55cG9wLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcu Y2dpP2lkPTQzNzIKKyAgICAgICAgSmF2YVNjcmlwdCBkb2N1bWVudC53cml0ZSBwYWdlIGZvcm0g ZG9lcyBub3Qgc3VibWl0IGluIFNhZmFyaQorCisgICAgICAgIFRlc3Q6IGZhc3QvZm9ybXMvZG9j dW1lbnQtd3JpdGUuaHRtbAorCisgICAgICAgICogcGFnZS9GcmFtZS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpGcmFtZTo6c3VibWl0Rm9ybSk6IERvbid0IGNoZWNrIGZvciBwYXJzaW5nKCkuCisK IDIwMDYtMDktMjMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBueXBvcC5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYy4KSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAkocmV2aXNpb24gMTY1NDQpCisrKyBXZWJD b3JlL3BhZ2UvRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjUwLDcgKzE2NTAsNyBAQCB2 b2lkIEZyYW1lOjpzdWJtaXRGb3JtKGNvbnN0IGNoYXIgKmFjdGlvCiAgICAgICByZXF1ZXN0LnNl dENvbnRlbnRUeXBlKCJDb250ZW50LVR5cGU6ICIgKyBjb250ZW50VHlwZSArICI7IGJvdW5kYXJ5 PSIgKyBib3VuZGFyeSk7CiAgIH0KIAotICBpZiAoZC0+bV9kb2MtPnBhcnNpbmcoKSB8fCBkLT5t X3J1bm5pbmdTY3JpcHRzID4gMCkgeworICBpZiAoZC0+bV9ydW5uaW5nU2NyaXB0cyA+IDApIHsK ICAgICBpZiAoZC0+bV9zdWJtaXRGb3JtKQogICAgICAgICByZXR1cm47CiAgICAgZC0+bV9zdWJt aXRGb3JtID0gbmV3IEZyYW1lUHJpdmF0ZTo6U3VibWl0Rm9ybTsK