43698 2010-08-08 16:50:32 -0700 Web Inspector: Fix warning in WebCore/inspector/InspectorDebuggerAgent.cpp 2010-08-08 22:44:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 43191 1 ossy webkit-unassigned pfeldman yurys oldest_to_newest 261944 0 ossy 2010-08-08 16:50:32 -0700 gcc warning: ../../../WebCore/inspector/InspectorDebuggerAgent.cpp:132: warning: suggest parentheses around assignment used as truth value This warning introduced in http://trac.webkit.org/changeset/64846 . 261945 1 63852 ossy 2010-08-08 16:54:12 -0700 Created attachment 63852 proposed fix 261959 2 63852 tonikitoo 2010-08-08 19:34:08 -0700 Comment on attachment 63852 proposed fix You can either do it this way, or make perform the assignment before the if statement (which I personally would had done.). Either way is fine with me. 261978 3 63852 ossy 2010-08-08 22:43:57 -0700 Comment on attachment 63852 proposed fix Clearing flags on attachment: 63852 Committed r64964: <http://trac.webkit.org/changeset/64964> 261979 4 ossy 2010-08-08 22:44:05 -0700 All reviewed patches have been landed. Closing bug. 63852 2010-08-08 16:54:12 -0700 2010-08-08 22:43:57 -0700 proposed fix 1.patch text/plain 1414 ossy SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDk1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMTUgQEAKIDIwMTAtMDgtMDggIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBGaXggd2FybmluZyBpbiBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JEZWJ1Z2dlckFnZW50LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDM2OTgKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dl ckFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OmVk aXRTY3JpcHRTb3VyY2UpOiBBZGQgc3VnZ2VzdGVkIHBhcmVudGhlc2VzLgorCisyMDEwLTA4LTA4 ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCiAKICAgICAgICAgW1F0XSBGaXggd2FybmluZ3MgaW4gV2ViQ29y ZS9wbGF0Zm9ybS9XaW5kb3dzS2V5Ym9hcmRDb2Rlcy5oCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAkocmV2aXNpb24gNjQ5NTcpCisrKyBXZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTI5LDcgKzEyOSw3IEBACiAKIHZvaWQgSW5zcGVjdG9yRGVidWdnZXJBZ2VudDo6ZWRpdFNj cmlwdFNvdXJjZShsb25nLCBjb25zdCBTdHJpbmcmIHNvdXJjZUlELCBjb25zdCBTdHJpbmcmIG5l d0NvbnRlbnQsIGJvb2wqIHN1Y2Nlc3MsIFN0cmluZyogcmVzdWx0LCBSZWZQdHI8SW5zcGVjdG9y VmFsdWU+KiBuZXdDYWxsRnJhbWVzKQogewotICAgIGlmICgqc3VjY2VzcyA9IFNjcmlwdERlYnVn U2VydmVyOjpzaGFyZWQoKS5lZGl0U2NyaXB0U291cmNlKHNvdXJjZUlELCBuZXdDb250ZW50LCAq cmVzdWx0KSkKKyAgICBpZiAoKCpzdWNjZXNzID0gU2NyaXB0RGVidWdTZXJ2ZXI6OnNoYXJlZCgp LmVkaXRTY3JpcHRTb3VyY2Uoc291cmNlSUQsIG5ld0NvbnRlbnQsICpyZXN1bHQpKSkKICAgICAg ICAgKm5ld0NhbGxGcmFtZXMgPSBjdXJyZW50Q2FsbEZyYW1lcygpOwogfQogCg==