43687 2010-08-08 04:53:04 -0700 Web Inspector: speed-up Element.prototype.removeChildren 2010-08-08 10:45:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 me me bweinstein eric joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 261875 0 me 2010-08-08 04:53:04 -0700 The current Element.prototype.removeChildren is using `element.innerHTML = ""`. It's the slowest method in my benchmarks: http://jsperf.com/remove-all-child-nodes/2 (20x faster in WebKit, 35x in Chrome) http://jsperf.com/remove-all-child-nodes-5-childs/3 (1,6 faster in WebKit, 2x in Chrome) http://jsperf.com/remove-all-child-nodes-zero-childs (1,6 faster in WebKit, 2x in Chrome) 261876 1 63840 me 2010-08-08 04:57:39 -0700 Created attachment 63840 patch 261877 2 63840 pfeldman 2010-08-08 05:11:36 -0700 Comment on attachment 63840 patch In fact I've done the opposite optimization earlier: https://bugs.webkit.org/show_bug.cgi?id=31160 Timeline was lagging visually on scrolling and clearing + shark was showing this to be the slow operation. I'd suggest that you try those. Wrt benchmarks, I think they lack listeners - adding those would change the WebKit picture a lot. I know that the bindings have improved, but still, single call to native will always be ways faster. 261880 3 me 2010-08-08 05:17:58 -0700 (In reply to comment #2) > (From update of attachment 63840 [details]) > In fact I've done the opposite optimization earlier: > https://bugs.webkit.org/show_bug.cgi?id=31160 > > Timeline was lagging visually on scrolling and clearing + shark was showing this to be the slow operation. I'd suggest that you try those. Wrt benchmarks, I think they lack listeners - adding those would change the WebKit picture a lot. I know that the bindings have improved, but still, single call to native will always be ways faster. Oh, I didn't think about reflow. At this case `element.textContent = ""` would be faster. By the way, what are Wrt benchmarks? 261882 4 63842 me 2010-08-08 06:59:23 -0700 Created attachment 63842 this.textContent = "" http://elv1s.ru/files/js/removeChildren.html Now innerHTML and textContent works the same. removeFirstChild is a little slower. When inspecting the DOM, there are many calls of removeChildren while an element already doesn't have children. So I added `if (this.firstChild)` check. 261889 5 63842 pfeldman 2010-08-08 09:29:15 -0700 Comment on attachment 63842 this.textContent = "" Thanks for doing this! 261902 6 63842 eric 2010-08-08 10:45:31 -0700 Comment on attachment 63842 this.textContent = "" Clearing flags on attachment: 63842 Committed r64952: <http://trac.webkit.org/changeset/64952> 261903 7 eric 2010-08-08 10:45:37 -0700 All reviewed patches have been landed. Closing bug. 63840 2010-08-08 04:57:39 -0700 2010-08-08 06:59:23 -0700 patch removeChildren.patch text/plain 1045 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2E5MjFjMS4uYmI3NWEwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0wOCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc3BlZWQtdXAgRWxlbWVudC5wcm90b3R5cGUucmVt b3ZlQ2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQzNjg3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qczoK KyAgICAgICAgKEVsZW1lbnQucHJvdG90eXBlLnJlbW92ZUNoaWxkcmVuKToKKwogMjAxMC0wOC0w OCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0 aWxpdGllcy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKaW5k ZXggZDI0ODA3MS4uOWU5M2EzOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL3V0aWxpdGllcy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0 aWVzLmpzCkBAIC0yNzQsNyArMjc0LDEwIEBAIEVsZW1lbnQucHJvdG90eXBlLnF1ZXJ5ID0gZnVu Y3Rpb24ocXVlcnkpCiAKIEVsZW1lbnQucHJvdG90eXBlLnJlbW92ZUNoaWxkcmVuID0gZnVuY3Rp b24oKQogewotICAgIHRoaXMuaW5uZXJIVE1MID0gIiI7CisgICAgdmFyIGNoaWxkOworICAgIHdo aWxlIChjaGlsZCA9IHRoaXMuZmlyc3RDaGlsZCkgeworICAgICAgICB0aGlzLnJlbW92ZUNoaWxk KGNoaWxkKTsKKyAgICB9CiB9CiAKIEVsZW1lbnQucHJvdG90eXBlLmlzSW5zZXJ0aW9uQ2FyZXRJ bnNpZGUgPSBmdW5jdGlvbigpCg== 63842 2010-08-08 06:59:23 -0700 2010-08-08 10:45:31 -0700 this.textContent = "" removeChildren.patch text/plain 1006 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2E5MjFjMS4uYmI3NWEwMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0wOCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc3BlZWQtdXAgRWxlbWVudC5wcm90b3R5cGUucmVt b3ZlQ2hpbGRyZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQzNjg3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qczoK KyAgICAgICAgKEVsZW1lbnQucHJvdG90eXBlLnJlbW92ZUNoaWxkcmVuKToKKwogMjAxMC0wOC0w OCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0 aWxpdGllcy5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKaW5k ZXggZDI0ODA3MS4uZGQzZTc2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL3V0aWxpdGllcy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0 aWVzLmpzCkBAIC0yNzQsNyArMjc0LDggQEAgRWxlbWVudC5wcm90b3R5cGUucXVlcnkgPSBmdW5j dGlvbihxdWVyeSkKIAogRWxlbWVudC5wcm90b3R5cGUucmVtb3ZlQ2hpbGRyZW4gPSBmdW5jdGlv bigpCiB7Ci0gICAgdGhpcy5pbm5lckhUTUwgPSAiIjsKKyAgICBpZiAodGhpcy5maXJzdENoaWxk KQorICAgICAgICB0aGlzLnRleHRDb250ZW50ID0gIiI7CiB9CiAKIEVsZW1lbnQucHJvdG90eXBl LmlzSW5zZXJ0aW9uQ2FyZXRJbnNpZGUgPSBmdW5jdGlvbigpCg==