43686 2010-08-08 00:51:04 -0700 WebKitTestRunner should add the QuickTime dir to the PATH environment variable 2010-08-08 01:33:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar P2 Normal --- 43379 1 jhoneycutt jhoneycutt oldest_to_newest 261856 0 jhoneycutt 2010-08-08 00:51:04 -0700 WebKitTestRunner should add the QT dir to the PATH environment variable to match DRT. 261857 1 jhoneycutt 2010-08-08 00:52:57 -0700 <rdar://problem/8285392> 261858 2 63839 jhoneycutt 2010-08-08 00:55:20 -0700 Created attachment 63839 Patch 261863 3 63839 mitz 2010-08-08 01:19:27 -0700 Comment on attachment 63839 Patch > + WebKitTestRunner should add the QT dir to the PATH environment variable Please change QT to QuickTime. r=me 261865 4 jhoneycutt 2010-08-08 01:33:13 -0700 Changed and landed in r64948. Thanks for the review! 63839 2010-08-08 00:55:20 -0700 2010-08-08 01:19:26 -0700 Patch 0001-WebKitTestRunner-should-add-the-QT-dir-to-the-PATH-e.patch text/plain 6269 jhoneycutt RnJvbSAxMmY2MjkxMWM2MTY1ZDkyNTkzMGRkYjI3MzkxNjgxNTI5MGM1YjZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb24gSG9uZXljdXR0IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K RGF0ZTogU3VuLCA4IEF1ZyAyMDEwIDAwOjUzOjM3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gV2Vi S2l0VGVzdFJ1bm5lciBzaG91bGQgYWRkIHRoZSBRVCBkaXIgdG8gdGhlIFBBVEggZW52aXJvbm1l bnQgdmFyaWFibGUKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MzY4 NgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIFdlYktpdFRlc3RSdW5uZXIvd2luL1Rl c3RDb250cm9sbGVyV2luLmNwcDoKKFdUUjo6YWRkUVREaXJUb1BBVEgpOgpDb3BpZWQgZnJvbSBE UlQuCihXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemUpOgpDYWxsIGFkZFFU RGlyVG9QYXRoKCkuCiogV2ViS2l0VGVzdFJ1bm5lci93aW4vV2ViS2l0VGVzdFJ1bm5lci52Y3By b2o6CkxpbmsgdG8gc2hsd2FwaS5saWIgZm9yIFNIR2V0VmFsdWUuCi0tLQogV2ViS2l0VG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKwogLi4u L1dlYktpdFRlc3RSdW5uZXIvd2luL1Rlc3RDb250cm9sbGVyV2luLmNwcCAgICAgfCAgIDQ2ICsr KysrKysrKysrKysrKysrKysrCiAuLi4vV2ViS2l0VGVzdFJ1bm5lci93aW4vV2ViS2l0VGVzdFJ1 bm5lci52Y3Byb2ogICB8ICAgIDggKystLQogMyBmaWxlcyBjaGFuZ2VkLCA2NSBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBi L1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA4ZDYxYmI3Li4xZDZjNjNiIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTggQEAKKzIwMTAtMDgtMDggIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxl LmNvbT4KKworICAgICAgICBXZWJLaXRUZXN0UnVubmVyIHNob3VsZCBhZGQgdGhlIFFUIGRpciB0 byB0aGUgUEFUSCBlbnZpcm9ubWVudCB2YXJpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM2ODYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvd2luL1Rlc3RDb250cm9s bGVyV2luLmNwcDoKKyAgICAgICAgKFdUUjo6YWRkUVREaXJUb1BBVEgpOgorICAgICAgICBDb3Bp ZWQgZnJvbSBEUlQuCisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRp YWxpemUpOgorICAgICAgICBDYWxsIGFkZFFURGlyVG9QYXRoKCkuCisgICAgICAgICogV2ViS2l0 VGVzdFJ1bm5lci93aW4vV2ViS2l0VGVzdFJ1bm5lci52Y3Byb2o6CisgICAgICAgIExpbmsgdG8g c2hsd2FwaS5saWIgZm9yIFNIR2V0VmFsdWUuCisKIDIwMTAtMDgtMDUgIEpvbiBIb25leWN1dHQg IDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXRUZXN0UnVubmVyIG5lZWRz IHRvIGJlIGFibGUgdG8gc2V0IHRoZSBmb250IHNtb290aGluZyB0eXBlCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9UZXN0Q29udHJvbGxlcldpbi5jcHAgYi9X ZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9UZXN0Q29udHJvbGxlcldpbi5jcHAKaW5k ZXggMTc2ZGRiNC4uZjY1MGQ3ZiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci93aW4vVGVzdENvbnRyb2xsZXJXaW4uY3BwCisrKyBiL1dlYktpdFRvb2xzL1dlYktpdFRl c3RSdW5uZXIvd2luL1Rlc3RDb250cm9sbGVyV2luLmNwcApAQCAtMjcsOCArMjcsMTMgQEAKIAog I2luY2x1ZGUgPGZjbnRsLmg+CiAjaW5jbHVkZSA8aW8uaD4KKyNpbmNsdWRlIDxzaGx3YXBpLmg+ CisjaW5jbHVkZSA8c3RyaW5nPgogI2luY2x1ZGUgPFdlYktpdDIvV0tTdHJpbmdDRi5oPgogI2lu Y2x1ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KKyNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CisKK3VzaW5n IG5hbWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXVFIgewogCkBAIC0zOCwxMCArNDMsNTEgQEAg Y29uc3QgTFBXU1RSIHRlc3RQbHVnaW5EaXJlY3RvcnlOYW1lID0gTCJUZXN0TmV0c2NhcGVQbHVn aW5fRGVidWciOwogY29uc3QgTFBXU1RSIHRlc3RQbHVnaW5EaXJlY3RvcnlOYW1lID0gTCJUZXN0 TmV0c2NhcGVQbHVnaW4iOwogI2VuZGlmCiAKK3N0YXRpYyB2b2lkIGFkZFFURGlyVG9QQVRIKCkK K3sKKyAgICBzdGF0aWMgTFBDV1NUUiBwYXRoRW52aXJvbm1lbnRWYXJpYWJsZSA9IEwiUEFUSCI7 CisgICAgc3RhdGljIExQQ1dTVFIgcXVpY2tUaW1lS2V5TmFtZSA9IEwiU29mdHdhcmVcXEFwcGxl IENvbXB1dGVyLCBJbmMuXFxRdWlja1RpbWUiOworICAgIHN0YXRpYyBMUENXU1RSIHF1aWNrVGlt ZVN5c0RpciA9IEwiUVRTeXNEaXIiOworICAgIHN0YXRpYyBib29sIGluaXRpYWxpemVkOworCisg ICAgaWYgKGluaXRpYWxpemVkKQorICAgICAgICByZXR1cm47CisgICAgaW5pdGlhbGl6ZWQgPSB0 cnVlOworCisgICAgLy8gR2V0IHRoZSBRdWlja1RpbWUgZGxsIGRpcmVjdG9yeSBmcm9tIHRoZSBy ZWdpc3RyeS4gVGhlIGtleSBjYW4gYmUgaW4gZWl0aGVyIEhLTE0gb3IgSEtDVS4KKyAgICBXQ0hB UiBxdFBhdGhbTUFYX1BBVEhdOworICAgIERXT1JEIHF0UGF0aEJ1ZmZlckxlbiA9IHNpemVvZihx dFBhdGgpOworICAgIERXT1JEIGtleVR5cGU7CisgICAgSFJFU1VMVCByZXN1bHQgPSA6OlNIR2V0 VmFsdWVXKEhLRVlfTE9DQUxfTUFDSElORSwgcXVpY2tUaW1lS2V5TmFtZSwgcXVpY2tUaW1lU3lz RGlyLCAma2V5VHlwZSwgKExQVk9JRClxdFBhdGgsICZxdFBhdGhCdWZmZXJMZW4pOworICAgIGlm IChyZXN1bHQgIT0gRVJST1JfU1VDQ0VTUyB8fCAhcXRQYXRoQnVmZmVyTGVuIHx8IGtleVR5cGUg IT0gUkVHX1NaKSB7CisgICAgICAgIHF0UGF0aEJ1ZmZlckxlbiA9IHNpemVvZihxdFBhdGgpOwor ICAgICAgICByZXN1bHQgPSA6OlNIR2V0VmFsdWVXKEhLRVlfQ1VSUkVOVF9VU0VSLCBxdWlja1Rp bWVLZXlOYW1lLCBxdWlja1RpbWVTeXNEaXIsICZrZXlUeXBlLCAoTFBWT0lEKXF0UGF0aCwgJnF0 UGF0aEJ1ZmZlckxlbik7CisgICAgICAgIGlmIChyZXN1bHQgIT0gRVJST1JfU1VDQ0VTUyB8fCAh cXRQYXRoQnVmZmVyTGVuIHx8IGtleVR5cGUgIT0gUkVHX1NaKQorICAgICAgICAgICAgcmV0dXJu OworICAgIH0KKworICAgIC8vIFJlYWQgdGhlIGN1cnJlbnQgUEFUSC4KKyAgICBEV09SRCBwYXRo U2l6ZSA9IDo6R2V0RW52aXJvbm1lbnRWYXJpYWJsZVcocGF0aEVudmlyb25tZW50VmFyaWFibGUs IDAsIDApOworICAgIFZlY3RvcjxXQ0hBUj4gb2xkUGF0aChwYXRoU2l6ZSk7CisgICAgaWYgKCE6 OkdldEVudmlyb25tZW50VmFyaWFibGVXKHBhdGhFbnZpcm9ubWVudFZhcmlhYmxlLCBvbGRQYXRo LmRhdGEoKSwgb2xkUGF0aC5zaXplKCkpKQorICAgICAgICByZXR1cm47CisKKyAgICAvLyBBbmQg YWRkIHRoZSBRdWlja1RpbWUgZGxsLgorICAgIHdzdHJpbmcgbmV3UGF0aDsKKyAgICBuZXdQYXRo LmFwcGVuZChxdFBhdGgpOworICAgIG5ld1BhdGguYXBwZW5kKEwiOyIpOworICAgIG5ld1BhdGgu YXBwZW5kKG9sZFBhdGguZGF0YSgpLCBvbGRQYXRoLnNpemUoKSk7CisgICAgOjpTZXRFbnZpcm9u bWVudFZhcmlhYmxlVyhwYXRoRW52aXJvbm1lbnRWYXJpYWJsZSwgbmV3UGF0aC5kYXRhKCkpOwor fQorCiB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemUoKQogewogICAgIF9z ZXRtb2RlKDEsIF9PX0JJTkFSWSk7CiAgICAgX3NldG1vZGUoMiwgX09fQklOQVJZKTsKKworICAg IC8vIEFkZCB0aGUgUXVpY2tUaW1lIGRsbCBkaXJlY3RvcnkgdG8gUEFUSCBvciBRVCA3LjYgd2ls bCBmYWlsIHRvIGluaXRpYWxpemUgb24gc3lzdGVtcworICAgIC8vIGxpbmtlZCB3aXRoIG9sZGVy IHZlcnNpb25zIG9mIHF0bWxjbGllbnRsaWIuZGxsLgorICAgIGFkZFFURGlyVG9QQVRIKCk7CiB9 CiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemVJbmplY3RlZEJ1bmRsZVBhdGgoKQpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci93aW4vV2ViS2l0VGVzdFJ1 bm5lci52Y3Byb2ogYi9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9XZWJLaXRUZXN0 UnVubmVyLnZjcHJvagppbmRleCA0ODAyYzNhLi43Mzc1YmQ0IDEwMDY0NAotLS0gYS9XZWJLaXRU b29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9XZWJLaXRUZXN0UnVubmVyLnZjcHJvagorKysgYi9X ZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3dpbi9XZWJLaXRUZXN0UnVubmVyLnZjcHJvagpA QCAtNTYsNyArNTYsNyBAQAogCQkJPFRvb2wNCiAJCQkJTmFtZT0iVkNMaW5rZXJUb29sIg0KIAkJ CQlBZGRpdGlvbmFsT3B0aW9ucz0iL05YQ09NUEFUIg0KLQkJCQlBZGRpdGlvbmFsRGVwZW5kZW5j aWVzPSJKYXZhU2NyaXB0Q29yZSQoV2ViS2l0RExMQ29uZmlnU3VmZml4KS5saWIgV2ViS2l0JChX ZWJLaXRETExDb25maWdTdWZmaXgpLmxpYiBDb3JlRm91bmRhdGlvbiQoTGlicmFyeUNvbmZpZ1N1 ZmZpeCkubGliIg0KKwkJCQlBZGRpdGlvbmFsRGVwZW5kZW5jaWVzPSJKYXZhU2NyaXB0Q29yZSQo V2ViS2l0RExMQ29uZmlnU3VmZml4KS5saWIgV2ViS2l0JChXZWJLaXRETExDb25maWdTdWZmaXgp LmxpYiBDb3JlRm91bmRhdGlvbiQoTGlicmFyeUNvbmZpZ1N1ZmZpeCkubGliIHNobHdhcGkubGli Ig0KIAkJCQlTdWJTeXN0ZW09IjEiDQogCQkJCVRhcmdldE1hY2hpbmU9IjEiDQogCQkJLz4NCkBA IC0xMjgsNyArMTI4LDcgQEAKIAkJCTxUb29sDQogCQkJCU5hbWU9IlZDTGlua2VyVG9vbCINCiAJ CQkJQWRkaXRpb25hbE9wdGlvbnM9Ii9OWENPTVBBVCINCi0JCQkJQWRkaXRpb25hbERlcGVuZGVu Y2llcz0iSmF2YVNjcmlwdENvcmUkKFdlYktpdERMTENvbmZpZ1N1ZmZpeCkubGliIFdlYktpdCQo V2ViS2l0RExMQ29uZmlnU3VmZml4KS5saWIgQ29yZUZvdW5kYXRpb24kKExpYnJhcnlDb25maWdT dWZmaXgpLmxpYiINCisJCQkJQWRkaXRpb25hbERlcGVuZGVuY2llcz0iSmF2YVNjcmlwdENvcmUk KFdlYktpdERMTENvbmZpZ1N1ZmZpeCkubGliIFdlYktpdCQoV2ViS2l0RExMQ29uZmlnU3VmZml4 KS5saWIgQ29yZUZvdW5kYXRpb24kKExpYnJhcnlDb25maWdTdWZmaXgpLmxpYiBzaGx3YXBpLmxp YiINCiAJCQkJU3ViU3lzdGVtPSIxIg0KIAkJCQlUYXJnZXRNYWNoaW5lPSIxIg0KIAkJCS8+DQpA QCAtMTk5LDcgKzE5OSw3IEBACiAJCQk8VG9vbA0KIAkJCQlOYW1lPSJWQ0xpbmtlclRvb2wiDQog CQkJCUFkZGl0aW9uYWxPcHRpb25zPSIvTlhDT01QQVQiDQotCQkJCUFkZGl0aW9uYWxEZXBlbmRl bmNpZXM9IkphdmFTY3JpcHRDb3JlJChXZWJLaXRETExDb25maWdTdWZmaXgpLmxpYiBXZWJLaXQk KFdlYktpdERMTENvbmZpZ1N1ZmZpeCkubGliIENvcmVGb3VuZGF0aW9uJChMaWJyYXJ5Q29uZmln U3VmZml4KS5saWIiDQorCQkJCUFkZGl0aW9uYWxEZXBlbmRlbmNpZXM9IkphdmFTY3JpcHRDb3Jl JChXZWJLaXRETExDb25maWdTdWZmaXgpLmxpYiBXZWJLaXQkKFdlYktpdERMTENvbmZpZ1N1ZmZp eCkubGliIENvcmVGb3VuZGF0aW9uJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIgc2hsd2FwaS5s aWIiDQogCQkJCVN1YlN5c3RlbT0iMSINCiAJCQkvPg0KIAkJCTxUb29sDQpAQCAtMjY5LDcgKzI2 OSw3IEBACiAJCQk8VG9vbA0KIAkJCQlOYW1lPSJWQ0xpbmtlclRvb2wiDQogCQkJCUFkZGl0aW9u YWxPcHRpb25zPSIvTlhDT01QQVQiDQotCQkJCUFkZGl0aW9uYWxEZXBlbmRlbmNpZXM9IkphdmFT Y3JpcHRDb3JlJChXZWJLaXRETExDb25maWdTdWZmaXgpLmxpYiBXZWJLaXQkKFdlYktpdERMTENv bmZpZ1N1ZmZpeCkubGliIENvcmVGb3VuZGF0aW9uJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIi DQorCQkJCUFkZGl0aW9uYWxEZXBlbmRlbmNpZXM9IkphdmFTY3JpcHRDb3JlJChXZWJLaXRETExD b25maWdTdWZmaXgpLmxpYiBXZWJLaXQkKFdlYktpdERMTENvbmZpZ1N1ZmZpeCkubGliIENvcmVG b3VuZGF0aW9uJChMaWJyYXJ5Q29uZmlnU3VmZml4KS5saWIgc2hsd2FwaS5saWIiDQogCQkJCVN1 YlN5c3RlbT0iMSINCiAJCQkvPg0KIAkJCTxUb29sDQotLSAKMS42LjUuMi4xNDMuZzhjYzYyCgo=