43658 2010-08-06 17:46:59 -0700 Calling window.print() before the page is loaded results in a blank printed page 2011-01-20 15:52:19 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://leiz.org/chromium/25027.htm P2 Normal --- 1 thestig webkit-unassigned ap commit-queue darin dglazkov hamaji mitz tony webkit-ews webkit.review.bot oldest_to_newest 261596 0 63790 thestig 2010-08-06 17:46:59 -0700 Created attachment 63790 Patch to fix the bug. This is http://code.google.com/p/chromium/issues/detail?id=25027 I've included a minimal test case above. The expect result is a printed page with the words "Print me". The current result with Chrome and Safari is a blank page. I believe the solution is to defer printing until the page has finished loading. Attached is a patch to do this. 261597 1 webkit.review.bot 2010-08-06 17:52:14 -0700 Attachment 63790 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/loader/FrameLoader.cpp:2231: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] WebCore/page/DOMWindow.h:93: print_deferred is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebCore/page/DOMWindow.h:401: m_print_deferred is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 261603 2 webkit-ews 2010-08-06 18:02:25 -0700 Attachment 63790 did not build on qt: Build output: http://queues.webkit.org/results/3598897 261606 3 63791 thestig 2010-08-06 18:23:06 -0700 Created attachment 63791 Patch to fix the bug. (try 2) 261608 4 webkit.review.bot 2010-08-06 18:28:49 -0700 Attachment 63791 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/loader/FrameLoader.cpp:2234: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 261615 5 webkit.review.bot 2010-08-06 18:50:59 -0700 Attachment 63790 did not build on chromium: Build output: http://queues.webkit.org/results/3668045 261625 6 tony 2010-08-06 19:33:47 -0700 Hamaji might be able to review. He also might have some ideas on how to write a layout test for this. There are some general notes about layout tests here: http://trac.webkit.org/wiki/CreatingLayoutTests http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree 261630 7 63791 dglazkov 2010-08-06 19:49:09 -0700 Comment on attachment 63791 Patch to fix the bug. (try 2) It needs a ChangeLog and a layout test (if possible). Tony's right; Hamaji-san is the right person to help here. 261632 8 mitz 2010-08-06 19:51:35 -0700 Is this change compatible with what other browsers do? Is it expected that if the script calls print() multiple times while loading, printing will only happen once at most. What happens if the script has called print() while loading, and before the page is done loading, the user closes the page or navigates to another page? 262313 9 thestig 2010-08-09 14:03:36 -0700 (In reply to comment #8) > Is this change compatible with what other browsers do? Is it expected that if the script calls print() multiple times while loading, printing will only happen once at most. What happens if the script has called print() while loading, and before the page is done loading, the user closes the page or navigates to another page? I tried changing the test page to call print() multiple times. On Windows, we have the following behavior: IE 8: prompts once always FF 3.6: prompts once always Chrome 5: prompts once if you hit cancel, multiple prompts if you hit ok Safari 4: prompts multiple times always Opera 10.60: does not prompt at all Based on this, I'd say it's ok if the WebKit based browser match IE/FF. It doesn't make sense to me to prompt multiple times on initial load. If you know of any cases where one would want to do that, please let me know. For the question of what happens when a script calls printing while the page is loading, but then the user navigates away, I made a simple html page that calls print(), followed by a few MBs of text. I restricted the bandwidth on the web server to 10 kbps to simulate slow rendering and found the following: IE 8: If you navigate away before the page loads, the print prompt never shows up. FF 3.6: If you navigate away, FF will pop up a print prompt and print out what it has loaded - which can be blank or a partial page. This behavior is also a bit weird because you could have closed the last FF window, but you'd get a lone print dialog. There's no clear defined behavior here either. For WebKit, with my patch, we'd match IE's behavior. Since the page never finished loading, we wouldn't get a print prompt. It appears I'd need to add a layout test to LayoutTests/printing ? I'll take a look there. 262456 10 63966 thestig 2010-08-09 19:47:34 -0700 Created attachment 63966 Defer printing patch 3 - add a changelog entry and pass check-webkit-style. Just a clean up patch, no real code change. I looked at the printing layout tests and it's not obvious to me how we can test the behavior in this bug. I'm open to suggestions. 264227 11 63966 hamaji 2010-08-13 00:52:46 -0700 Comment on attachment 63966 Defer printing patch 3 - add a changelog entry and pass check-webkit-style. Oops. Sorry for the latency. I think the test method I've added cannot help testing window.print(). I think we can add WebCore/manual-tests for this test. This change looks good to me as the new behavior sounds more compatible to other browsers. I hesitate to r+ this change now because this patch is related to loader which I don't know well. WebCore/loader/FrameLoader.cpp:2233 + window->print(); A question: don't we need to reset m_printDeferred? 264488 12 64371 thestig 2010-08-13 13:48:24 -0700 Created attachment 64371 Defer printing patch 3 - add a manual test. (In reply to comment #11) > (From update of attachment 63966 [details]) > Oops. Sorry for the latency. I think the test method I've added cannot help testing window.print(). I think we can add WebCore/manual-tests for this test. Ok, I added a copy of 25027.htm to manual-tests. See try 4. > This change looks good to me as the new behavior sounds more compatible to other browsers. I hesitate to r+ this change now because this patch is related to loader which I don't know well. > > WebCore/loader/FrameLoader.cpp:2233 > + window->print(); > A question: don't we need to reset m_printDeferred? DOMWindow::print() resets m_printDeferred. 268990 13 64371 hamaji 2010-08-24 20:10:43 -0700 Comment on attachment 64371 Defer printing patch 3 - add a manual test. Looks good. As I wrote in Comment 11, I'm not sure I'm a good reviewer for loader code. Could you wait for a few days before you land this to see if no one objects? > DOMWindow::print() resets m_printDeferred. Ah, I see. Thanks for clarification! 271772 14 64371 commit-queue 2010-08-30 17:02:56 -0700 Comment on attachment 64371 Defer printing patch 3 - add a manual test. Clearing flags on attachment: 64371 Committed r66428: <http://trac.webkit.org/changeset/66428> 271773 15 commit-queue 2010-08-30 17:03:01 -0700 All reviewed patches have been landed. Closing bug. 271813 16 darin 2010-08-30 17:48:14 -0700 I see multiple problems with this patch: It’s not good how this patch spreads the feature over two classes. The code in both FrameLoader and DOMWindow is inelegant. All the code should be in one class, with the other class calling over as needed. That way you would not have to expose a printDeferred function. The name printDeferred is not a good boolean function or data member name. It sounds like a verb "print deferred". I would name it "should print when finished loading": m_shouldPrintWhenFinishedLoading Also, I think FrameLoader::finishedLoading may not be the right place to call this. That's the function called when the main resources is loaded, not when the entire page is loaded. 271850 17 thestig 2010-08-30 18:42:21 -0700 (In reply to comment #16) > I see multiple problems with this patch: > > It’s not good how this patch spreads the feature over two classes. The code in both FrameLoader and DOMWindow is inelegant. All the code should be in one class, with the other class calling over as needed. That way you would not have to expose a printDeferred function. > > The name printDeferred is not a good boolean function or data member name. It sounds like a verb "print deferred". I would name it "should print when finished loading": > > m_shouldPrintWhenFinishedLoading > > Also, I think FrameLoader::finishedLoading may not be the right place to call this. That's the function called when the main resources is loaded, not when the entire page is loaded. I'd be happy to fix this to address your concerns. Should I post a follow up patch to this bug / a separate bug, or revert? If FrameLoader::finishedLoading is the wrong place, then do you know where the right place is? 271857 18 darin 2010-08-30 18:53:25 -0700 (In reply to comment #17) > I'd be happy to fix this to address your concerns. Should I post a follow up patch to this bug / a separate bug, or revert? I think a separate bug is the cleanest way to attack it. > If FrameLoader::finishedLoading is the wrong place, then do you know where the right place is? It would take a little thought to be sure. I would want it to be a place that exactly corresponded to whatever test we're doing to check if it should be deferred. So if the test is "isLoading" then it should be the place that makes isLoading false. Or if the test is "did not fire load event yet", then it should be the place that the load event is fired. Sorry, I don’t have time to do the research myself right now. 337498 19 ap 2011-01-20 12:16:06 -0800 > I tried changing the test page to call print() multiple times. On Windows, we have the following behavior: > > IE 8: prompts once always > FF 3.6: prompts once always <...> > Based on this, I'd say it's ok if the WebKit based browser match IE/FF. This is not what I see in Firefox 3.6 on Mac or Windows. What I see is that window.print() is always synchronous in Firefox, just like in Safari 5 - as evidenced by the included test case, which fails in Firefox. So, this patch has changed WebKit from matching Firefox to matching IE. What am I missing? Why does the original issue with Bank of America not occur with Firefox? 337571 20 thestig 2011-01-20 13:41:57 -0800 (In reply to comment #19) > > I tried changing the test page to call print() multiple times. On Windows, we have the following behavior: > > > > IE 8: prompts once always > > FF 3.6: prompts once always > <...> > > Based on this, I'd say it's ok if the WebKit based browser match IE/FF. > > This is not what I see in Firefox 3.6 on Mac or Windows. What I see is that window.print() is always synchronous in Firefox, just like in Safari 5 - as evidenced by the included test case, which fails in Firefox. > > So, this patch has changed WebKit from matching Firefox to matching IE. What am I missing? Why does the original issue with Bank of America not occur with Firefox? Which test case did you try exactly? On Windows XP, with Firefox 3.6.12 and a CutePDF dummy printer, I loaded up http://leiz.org/chromium/25027_test2.html, which calls window.print() 3 times, but only pops up the print dialog once. screen capture of what I described above: http://leiz.org/chromium/25027_ff.avi 337609 21 ap 2011-01-20 14:31:19 -0800 I've been testing with local files, and your test case also results in three synchronous print dialogs when loaded from a local file. Can you confirm that the regression test that went to manual-tests fails in Firefox for you? Looks like Firefox has a special case for file:///, or maybe it just has some kind of timing issue. Interesting. 337621 22 thestig 2011-01-20 14:50:06 -0800 (In reply to comment #21) > I've been testing with local files, and your test case also results in three synchronous print dialogs when loaded from a local file. Can you confirm that the regression test that went to manual-tests fails in Firefox for you? > > Looks like Firefox has a special case for file:///, or maybe it just has some kind of timing issue. Interesting. Yes, I do see the different behavior from Firefox when using a file:// url rather than http://. Perhaps some kind of safeguard against malicious webpages? The regression test did not fail for me with Firefox. When I loaded print-before-load.html, the CutePDF 'printer' output had the text from the webpage. Same for both file:// and http://. 337646 23 ap 2011-01-20 15:21:20 -0800 > The regression test did not fail for me with Firefox. That's still strange, but is less important than the fact that Firefox also delays printing web pages until the page is loaded. 337653 24 mitz 2011-01-20 15:29:59 -0800 (In reply to comment #23) > That's still strange, but is less important than the fact that Firefox also delays printing web pages until the page is loaded. As far as I can tell from <http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#printing>, the user agent may delay printing, but if it does so, it should still print the page as it was when print() was called. At any rate, it may not defer the printing prompt. It appears as if Firefox (and perhaps WebKit browsers after this fix) or not in compliance with HTML. 337654 25 mitz 2011-01-20 15:30:30 -0800 s/or not/are not/ 337661 26 thestig 2011-01-20 15:41:15 -0800 Then that means IE / FF / Webkit all violates the WHATWG spec, but at least they are consistent with respect to each other. 337675 27 ap 2011-01-20 15:52:19 -0800 I've sent an e-mail to WHATWG about this. 63790 2010-08-06 17:46:59 -0700 2010-08-06 18:23:06 -0700 Patch to fix the bug. defer_printing.patch text/plain 2696 thestig SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDg4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMDYgIExlaSBaaGFuZyAgPHRoZXN0aWdAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERl ZmVyIHByaW50aW5nIHVudGlsIHRoZSBGcmFtZUxvYWRlciBmaW5pc2hlcyBsb2FkaW5nLgorCisg ICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l TG9hZGVyOjpmaW5pc2hlZExvYWRpbmcpOgorICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6RE9NV2luZG93KToKKyAgICAgICAgKFdlYkNv cmU6OkRPTVdpbmRvdzo6cHJpbnQpOgorICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmg6CisgICAg ICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnByaW50X2RlZmVycmVkKToKKwogMjAxMC0wOC0wNiAg RXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCByZWxlYXNlIFF0IGJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJl dmlzaW9uIDY0ODg1KQorKysgV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yMjI4LDYgKzIyMjgsMTAgQEAgdm9pZCBGcmFtZUxvYWRlcjo6ZmluaXNoZWRM b2FkaW5nKCkKICAgICBkbC0+c2V0UHJpbWFyeUxvYWRDb21wbGV0ZSh0cnVlKTsKICAgICBtX2Ns aWVudC0+ZGlzcGF0Y2hEaWRMb2FkTWFpblJlc291cmNlKGRsLmdldCgpKTsKICAgICBjaGVja0xv YWRDb21wbGV0ZSgpOworICAgIGlmIChET01XaW5kb3cqIHdpbmRvdyA9IG1fZnJhbWUtPmV4aXN0 aW5nRE9NV2luZG93KCkgJiYKKyAgICAgICAgd2luZG93LT5wcmludF9kZWZlcnJlZCgpKSB7Cisg ICAgICAgIHdpbmRvdy0+cHJpbnQoKTsKKyAgICB9CiB9CiAKIGJvb2wgRnJhbWVMb2FkZXI6Omlz SG9zdGVkQnlPYmplY3RFbGVtZW50KCkgY29uc3QKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5k b3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCShyZXZpc2lv biA2NDg4NSkKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNzksNyArMzc5LDggQEAgYm9vbCBET01XaW5kb3c6OmNhblNob3dNb2RhbERpYWxvZ05vdyhj bwogfQogCiBET01XaW5kb3c6OkRPTVdpbmRvdyhGcmFtZSogZnJhbWUpCi0gICAgOiBtX2ZyYW1l KGZyYW1lKQorICAgIDogbV9wcmludF9kZWZlcnJlZChmYWxzZSksCisgICAgICBtX2ZyYW1lKGZy YW1lKQogewogfQogCkBAIC04NjEsNiArODYyLDExIEBAIHZvaWQgRE9NV2luZG93OjpwcmludCgp CiAgICAgaWYgKCFwYWdlKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAobV9mcmFtZS0+bG9h ZGVyKCktPmlzTG9hZGluZygpKSB7CisgICAgICAgIG1fcHJpbnRfZGVmZXJyZWQgPSB0cnVlOwor ICAgICAgICByZXR1cm47CisgICAgfQorICAgIG1fcHJpbnRfZGVmZXJyZWQgPSBmYWxzZTsKICAg ICBwYWdlLT5jaHJvbWUoKS0+cHJpbnQobV9mcmFtZSk7CiB9CiAKSW5kZXg6IFdlYkNvcmUvcGFn ZS9ET01XaW5kb3cuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgJKHJl dmlzaW9uIDY0ODg1KQorKysgV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCSh3b3JraW5nIGNvcHkp CkBAIC05MCw2ICs5MCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCBE T01XaW5kb3cqIHRvRE9NV2luZG93KCkgeyByZXR1cm4gdGhpczsgfQogICAgICAgICB2aXJ0dWFs IFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdDsK IAorICAgICAgICBib29sIHByaW50X2RlZmVycmVkKCkgY29uc3QgeyByZXR1cm4gbV9wcmludF9k ZWZlcnJlZDsgfQogICAgICAgICBGcmFtZSogZnJhbWUoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1l OyB9CiAgICAgICAgIHZvaWQgZGlzY29ubmVjdEZyYW1lKCk7CiAKQEAgLTM5Nyw2ICszOTgsNyBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4gbV9z ZWN1cml0eU9yaWdpbjsKICAgICAgICAgS1VSTCBtX3VybDsKIAorICAgICAgICBib29sIG1fcHJp bnRfZGVmZXJyZWQ7CiAgICAgICAgIEZyYW1lKiBtX2ZyYW1lOwogICAgICAgICBtdXRhYmxlIFJl ZlB0cjxTY3JlZW4+IG1fc2NyZWVuOwogICAgICAgICBtdXRhYmxlIFJlZlB0cjxET01TZWxlY3Rp b24+IG1fc2VsZWN0aW9uOwo= 63791 2010-08-06 18:23:06 -0700 2010-08-13 13:48:24 -0700 Patch to fix the bug. (try 2) defer_printing.patch text/plain 1997 thestig SW5kZXg6IFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJKHJldmlzaW9uIDY0ODg1KQorKysgV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjI4LDYgKzIyMjgsMTEg QEAgdm9pZCBGcmFtZUxvYWRlcjo6ZmluaXNoZWRMb2FkaW5nKCkKICAgICBkbC0+c2V0UHJpbWFy eUxvYWRDb21wbGV0ZSh0cnVlKTsKICAgICBtX2NsaWVudC0+ZGlzcGF0Y2hEaWRMb2FkTWFpblJl c291cmNlKGRsLmdldCgpKTsKICAgICBjaGVja0xvYWRDb21wbGV0ZSgpOworICAgIGlmIChET01X aW5kb3cqIHdpbmRvdyA9IG1fZnJhbWUtPmV4aXN0aW5nRE9NV2luZG93KCkpIHsKKyAgICAgICAg aWYgKHdpbmRvdy0+cHJpbnREZWZlcnJlZCgpKSB7CisgICAgICAgICAgICB3aW5kb3ctPnByaW50 KCk7CisgICAgICAgIH0KKyAgICB9CiB9CiAKIGJvb2wgRnJhbWVMb2FkZXI6OmlzSG9zdGVkQnlP YmplY3RFbGVtZW50KCkgY29uc3QKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCShyZXZpc2lvbiA2NDg4NSkK KysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzksNyAr Mzc5LDggQEAgYm9vbCBET01XaW5kb3c6OmNhblNob3dNb2RhbERpYWxvZ05vdyhjbwogfQogCiBE T01XaW5kb3c6OkRPTVdpbmRvdyhGcmFtZSogZnJhbWUpCi0gICAgOiBtX2ZyYW1lKGZyYW1lKQor ICAgIDogbV9wcmludERlZmVycmVkKGZhbHNlKSwKKyAgICAgIG1fZnJhbWUoZnJhbWUpCiB7CiB9 CiAKQEAgLTg2MSw2ICs4NjIsMTEgQEAgdm9pZCBET01XaW5kb3c6OnByaW50KCkKICAgICBpZiAo IXBhZ2UpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChtX2ZyYW1lLT5sb2FkZXIoKS0+aXNM b2FkaW5nKCkpIHsKKyAgICAgICAgbV9wcmludERlZmVycmVkID0gdHJ1ZTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKyAgICBtX3ByaW50RGVmZXJyZWQgPSBmYWxzZTsKICAgICBwYWdlLT5jaHJv bWUoKS0+cHJpbnQobV9mcmFtZSk7CiB9CiAKSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgJKHJldmlzaW9uIDY0ODg1 KQorKysgV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5 MCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdmlydHVhbCBET01XaW5kb3cqIHRv RE9NV2luZG93KCkgeyByZXR1cm4gdGhpczsgfQogICAgICAgICB2aXJ0dWFsIFNjcmlwdEV4ZWN1 dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSBjb25zdDsKIAorICAgICAgICBi b29sIHByaW50RGVmZXJyZWQoKSBjb25zdCB7IHJldHVybiBtX3ByaW50RGVmZXJyZWQ7IH0KICAg ICAgICAgRnJhbWUqIGZyYW1lKCkgY29uc3QgeyByZXR1cm4gbV9mcmFtZTsgfQogICAgICAgICB2 b2lkIGRpc2Nvbm5lY3RGcmFtZSgpOwogCkBAIC0zOTcsNiArMzk4LDcgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICBSZWZQdHI8U2VjdXJpdHlPcmlnaW4+IG1fc2VjdXJpdHlPcmlnaW47 CiAgICAgICAgIEtVUkwgbV91cmw7CiAKKyAgICAgICAgYm9vbCBtX3ByaW50RGVmZXJyZWQ7CiAg ICAgICAgIEZyYW1lKiBtX2ZyYW1lOwogICAgICAgICBtdXRhYmxlIFJlZlB0cjxTY3JlZW4+IG1f c2NyZWVuOwogICAgICAgICBtdXRhYmxlIFJlZlB0cjxET01TZWxlY3Rpb24+IG1fc2VsZWN0aW9u Owo= 63966 2010-08-09 19:47:34 -0700 2010-08-13 13:48:24 -0700 Defer printing patch 3 - add a changelog entry and pass check-webkit-style. defer_printing.patch text/plain 2620 thestig SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTAzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDgtMDkgIExlaSBaaGFuZyAgPHRoZXN0aWdAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERl ZmVyIHByaW50aW5nIHVudGlsIHRoZSBGcmFtZUxvYWRlciBmaW5pc2hlcyBsb2FkaW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM2NTgKKworICAg ICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6ZmluaXNoZWRMb2FkaW5nKToK KyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5k b3c6OkRPTVdpbmRvdyk6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnByaW50KToKKyAg ICAgICAgKiBwYWdlL0RPTVdpbmRvdy5oOgorICAgICAgICAoV2ViQ29yZTo6RE9NV2luZG93Ojpw cmludERlZmVycmVkKToKKwogMjAxMC0wOC0wOSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNs b3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUXQgYnVpbGQgZml4IElJSS4KSW5kZXg6IFdlYkNv cmUvcGFnZS9ET01XaW5kb3cuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93 LmgJKHJldmlzaW9uIDY1MDMzKQorKysgV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCSh3b3JraW5n IGNvcHkpCkBAIC05MCw2ICs5MCw3IEBACiAgICAgICAgIHZpcnR1YWwgRE9NV2luZG93KiB0b0RP TVdpbmRvdygpIHsgcmV0dXJuIHRoaXM7IH0KICAgICAgICAgdmlydHVhbCBTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkgY29uc3Q7CiAKKyAgICAgICAgYm9v bCBwcmludERlZmVycmVkKCkgY29uc3QgeyByZXR1cm4gbV9wcmludERlZmVycmVkOyB9CiAgICAg ICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fZnJhbWU7IH0KICAgICAgICAgdm9p ZCBkaXNjb25uZWN0RnJhbWUoKTsKIApAQCAtMzk3LDYgKzM5OCw3IEBACiAgICAgICAgIFJlZlB0 cjxTZWN1cml0eU9yaWdpbj4gbV9zZWN1cml0eU9yaWdpbjsKICAgICAgICAgS1VSTCBtX3VybDsK IAorICAgICAgICBib29sIG1fcHJpbnREZWZlcnJlZDsKICAgICAgICAgRnJhbWUqIG1fZnJhbWU7 CiAgICAgICAgIG11dGFibGUgUmVmUHRyPFNjcmVlbj4gbV9zY3JlZW47CiAgICAgICAgIG11dGFi bGUgUmVmUHRyPERPTVNlbGVjdGlvbj4gbV9zZWxlY3Rpb247CkluZGV4OiBXZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAko cmV2aXNpb24gNjUwMzMpCisrKyBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzc5LDcgKzM3OSw4IEBACiB9CiAKIERPTVdpbmRvdzo6RE9NV2luZG93KEZyYW1l KiBmcmFtZSkKLSAgICA6IG1fZnJhbWUoZnJhbWUpCisgICAgOiBtX3ByaW50RGVmZXJyZWQoZmFs c2UpLAorICAgICAgbV9mcmFtZShmcmFtZSkKIHsKIH0KIApAQCAtODYxLDYgKzg2MiwxMSBAQAog ICAgIGlmICghcGFnZSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKG1fZnJhbWUtPmxvYWRl cigpLT5pc0xvYWRpbmcoKSkgeworICAgICAgICBtX3ByaW50RGVmZXJyZWQgPSB0cnVlOworICAg ICAgICByZXR1cm47CisgICAgfQorICAgIG1fcHJpbnREZWZlcnJlZCA9IGZhbHNlOwogICAgIHBh Z2UtPmNocm9tZSgpLT5wcmludChtX2ZyYW1lKTsKIH0KIApJbmRleDogV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAkocmV2aXNpb24gNjUwMzMpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIyMjcsNiArMjIyNywxMCBAQAogICAgIGRsLT5zZXRQcmltYXJ5 TG9hZENvbXBsZXRlKHRydWUpOwogICAgIG1fY2xpZW50LT5kaXNwYXRjaERpZExvYWRNYWluUmVz b3VyY2UoZGwuZ2V0KCkpOwogICAgIGNoZWNrTG9hZENvbXBsZXRlKCk7CisKKyAgICBET01XaW5k b3cqIHdpbmRvdyA9IG1fZnJhbWUtPmV4aXN0aW5nRE9NV2luZG93KCk7CisgICAgaWYgKHdpbmRv dyAmJiB3aW5kb3ctPnByaW50RGVmZXJyZWQoKSkKKyAgICAgICAgd2luZG93LT5wcmludCgpOwog fQogCiBib29sIEZyYW1lTG9hZGVyOjppc0hvc3RlZEJ5T2JqZWN0RWxlbWVudCgpIGNvbnN0Cg== 64371 2010-08-13 13:48:24 -0700 2010-08-30 17:02:56 -0700 Defer printing patch 3 - add a manual test. defer_printing.patch text/plain 3418 thestig SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTMzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDgtMTMgIExlaSBaaGFuZyAgPHRoZXN0aWdAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERl ZmVyIHByaW50aW5nIHVudGlsIHRoZSBGcmFtZUxvYWRlciBmaW5pc2hlcyBsb2FkaW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM2NTgKKworICAg ICAgICAqIG1hbnVhbC10ZXN0cy9wcmludC1iZWZvcmUtbG9hZC5odG1sOiBBZGRlZC4KKworICAg ICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxv YWRlcjo6ZmluaXNoZWRMb2FkaW5nKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OkRPTVdpbmRvdyk6CisgICAgICAgIChXZWJDb3Jl OjpET01XaW5kb3c6OnByaW50KToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5oOgorICAgICAg ICAoV2ViQ29yZTo6RE9NV2luZG93OjpwcmludERlZmVycmVkKToKKwogMjAxMC0wOC0xMyAgTGVh bmRybyBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBbRUZMXSBV bnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgJKHJldmlzaW9uIDY1MzM3KQorKysg V2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCSh3b3JraW5nIGNvcHkpCkBAIC05MCw2ICs5MCw3IEBA CiAgICAgICAgIHZpcnR1YWwgRE9NV2luZG93KiB0b0RPTVdpbmRvdygpIHsgcmV0dXJuIHRoaXM7 IH0KICAgICAgICAgdmlydHVhbCBTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBzY3JpcHRFeGVjdXRp b25Db250ZXh0KCkgY29uc3Q7CiAKKyAgICAgICAgYm9vbCBwcmludERlZmVycmVkKCkgY29uc3Qg eyByZXR1cm4gbV9wcmludERlZmVycmVkOyB9CiAgICAgICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0 IHsgcmV0dXJuIG1fZnJhbWU7IH0KICAgICAgICAgdm9pZCBkaXNjb25uZWN0RnJhbWUoKTsKIApA QCAtMzk3LDYgKzM5OCw3IEBACiAgICAgICAgIFJlZlB0cjxTZWN1cml0eU9yaWdpbj4gbV9zZWN1 cml0eU9yaWdpbjsKICAgICAgICAgS1VSTCBtX3VybDsKIAorICAgICAgICBib29sIG1fcHJpbnRE ZWZlcnJlZDsKICAgICAgICAgRnJhbWUqIG1fZnJhbWU7CiAgICAgICAgIG11dGFibGUgUmVmUHRy PFNjcmVlbj4gbV9zY3JlZW47CiAgICAgICAgIG11dGFibGUgUmVmUHRyPERPTVNlbGVjdGlvbj4g bV9zZWxlY3Rpb247CkluZGV4OiBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2aXNpb24gNjUzMzcpCisrKyBXZWJD b3JlL3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc5LDcgKzM3OSw4IEBA CiB9CiAKIERPTVdpbmRvdzo6RE9NV2luZG93KEZyYW1lKiBmcmFtZSkKLSAgICA6IG1fZnJhbWUo ZnJhbWUpCisgICAgOiBtX3ByaW50RGVmZXJyZWQoZmFsc2UpLAorICAgICAgbV9mcmFtZShmcmFt ZSkKIHsKIH0KIApAQCAtODYxLDYgKzg2MiwxMSBAQAogICAgIGlmICghcGFnZSkKICAgICAgICAg cmV0dXJuOwogCisgICAgaWYgKG1fZnJhbWUtPmxvYWRlcigpLT5pc0xvYWRpbmcoKSkgeworICAg ICAgICBtX3ByaW50RGVmZXJyZWQgPSB0cnVlOworICAgICAgICByZXR1cm47CisgICAgfQorICAg IG1fcHJpbnREZWZlcnJlZCA9IGZhbHNlOwogICAgIHBhZ2UtPmNocm9tZSgpLT5wcmludChtX2Zy YW1lKTsKIH0KIApJbmRleDogV2ViQ29yZS9tYW51YWwtdGVzdHMvcHJpbnQtYmVmb3JlLWxvYWQu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL21hbnVhbC10ZXN0cy9wcmludC1iZWZvcmUtbG9h ZC5odG1sCShyZXZpc2lvbiAwKQorKysgV2ViQ29yZS9tYW51YWwtdGVzdHMvcHJpbnQtYmVmb3Jl LWxvYWQuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxNiBAQAorPCFET0NUWVBFIEhUTUwg UFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFsLy9FTiI+Cis8aHRtbD4K KzxoZWFkPgorPHRpdGxlPlByaW50IFRlc3QgUGFnZTwvdGl0bGU+Cis8Ym9keT4KKworPHNjcmlw dCBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK3dpbmRvdy5w cmludCgpOworPC9zY3JpcHQ+CisKK1RoaXMgd2VicGFnZSBzaG91bGQgcG9wIHVwIGEgcHJpbnQg ZGlhbG9nLiBJZiB5b3UgcHJpbnQgZnJvbSB0aGF0IGRpYWxvZywgeW91CitzaG91bGQgc2VlIHRo aXMgb3V0cHV0IG9uIHBhcGVyLgorCis8L2JvZHk+Cis8L2h0bWw+CisKClByb3BlcnR5IGNoYW5n ZXMgb246IFdlYkNvcmUvbWFudWFsLXRlc3RzL3ByaW50LWJlZm9yZS1sb2FkLmh0bWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpBZGRlZDogc3ZuOmVvbC1zdHlsZQogICArIExGCgpJbmRleDogV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAkocmV2aXNpb24gNjUzMzcpCisrKyBXZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIxNjIsNiArMjE2MiwxMCBAQAogICAgIGRsLT5zZXRQcmltYXJ5 TG9hZENvbXBsZXRlKHRydWUpOwogICAgIG1fY2xpZW50LT5kaXNwYXRjaERpZExvYWRNYWluUmVz b3VyY2UoZGwuZ2V0KCkpOwogICAgIGNoZWNrTG9hZENvbXBsZXRlKCk7CisKKyAgICBET01XaW5k b3cqIHdpbmRvdyA9IG1fZnJhbWUtPmV4aXN0aW5nRE9NV2luZG93KCk7CisgICAgaWYgKHdpbmRv dyAmJiB3aW5kb3ctPnByaW50RGVmZXJyZWQoKSkKKyAgICAgICAgd2luZG93LT5wcmludCgpOwog fQogCiBib29sIEZyYW1lTG9hZGVyOjppc0hvc3RlZEJ5T2JqZWN0RWxlbWVudCgpIGNvbnN0Cg==