43646 2010-08-06 15:00:28 -0700 [CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas. 2010-08-10 17:02:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco abarth eric sam webkit.review.bot oldest_to_newest 261510 0 senorblanco 2010-08-06 15:00:28 -0700 [CHROMIUM] Prefer the medium-quality (bilinear) image resampling for 2D canvas. 261513 1 63765 senorblanco 2010-08-06 15:10:27 -0700 Created attachment 63765 Patch 261666 2 sam 2010-08-06 22:40:50 -0700 Is there a way to do this without throwing an #ifdef in the middle of that file? Is this something other ports should consider? 261707 3 senorblanco 2010-08-07 04:52:23 -0700 (In reply to comment #2) > Is there a way to do this without throwing an #ifdef in the middle of that file? Is this something other ports should consider? Another way it could be done would be to define a "CanvasImageInterpolationQuality" in graphics.h, which could be #defined'ed by each platform. Then at least the platform #if would be in platform/graphics, rather than here at this level. Whether other ports want to do it is really up to their maintainers -- the canvas spec does not specify any particular algorithm for image resampling. 262225 4 63909 senorblanco 2010-08-09 11:02:59 -0700 Created attachment 63909 Patch 262226 5 senorblanco 2010-08-09 11:03:51 -0700 (In reply to comment #4) > Created an attachment (id=63909) [details] > Patch Here's a version with the platform-specific stuff pushed into GraphicsContext.h. 262877 6 senorblanco 2010-08-10 15:02:54 -0700 Committed r65097: <http://trac.webkit.org/changeset/65097> 262912 7 webkit.review.bot 2010-08-10 17:02:19 -0700 http://trac.webkit.org/changeset/65097 might have broken GTK Linux 32-bit Release 63765 2010-08-06 15:10:27 -0700 2010-08-09 11:02:54 -0700 Patch bug-43646-20100806181025.patch text/plain 2474 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDg3MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDgtMDYgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUHJlZmVyIHRoZSBtZWRpdW0tcXVhbGl0eSAoYmlsaW5lYXIpIGltYWdlIHJlc2FtcGxp bmcgZm9yIDJECisgICAgICAgIGNhbnZhcyBvbiBDaHJvbWl1bS4gIFRoaXMgaXMgd2hhdCB0aGUg YWNjZWxlcmF0ZWQgcGF0aCBpcyBnb2luZyB0byBkbywKKyAgICAgICAgc28gZG8gaXQgaW4gdGhl IHNvZnR3YXJlIHBhdGggYXMgd2VsbC4KKworICAgICAgICAqIGh0bWwvSFRNTENhbnZhc0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1lbnQ6OmNyZWF0ZUltYWdl QnVmZmVyKToKKwogMjAxMC0wOC0wNiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KSW5kZXg6IFdlYkNv cmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1s L0hUTUxDYW52YXNFbGVtZW50LmNwcAkocmV2aXNpb24gNjQ4NzIpCisrKyBXZWJDb3JlL2h0bWwv SFRNTENhbnZhc0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDMsNiArNDAzLDkgQEAg dm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6Y3JlYXRlSW1hZ2VCdWZmZQogICAgICAgICByZXR1cm47 CiAgICAgbV9pbWFnZUJ1ZmZlci0+Y29udGV4dCgpLT5zY2FsZShGbG9hdFNpemUoc2l6ZS53aWR0 aCgpIC8gdW5zY2FsZWRTaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkgLyB1bnNjYWxlZFNpemUu aGVpZ2h0KCkpKTsKICAgICBtX2ltYWdlQnVmZmVyLT5jb250ZXh0KCktPnNldFNoYWRvd3NJZ25v cmVUcmFuc2Zvcm1zKHRydWUpOworI2lmIFBMQVRGT1JNKENIUk9NSVVNKQorICAgIG1faW1hZ2VC dWZmZXItPmNvbnRleHQoKS0+c2V0SW1hZ2VJbnRlcnBvbGF0aW9uUXVhbGl0eShJbnRlcnBvbGF0 aW9uTWVkaXVtKTsKKyNlbmRpZgogfQogCiBHcmFwaGljc0NvbnRleHQqIEhUTUxDYW52YXNFbGVt ZW50OjpkcmF3aW5nQ29udGV4dCgpIGNvbnN0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2NDg3MikKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDExIEBACisy MDEwLTA4LTA2ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlbXBvcmFyaWx5 IG1hcmsgaHRtbC9jYW52YXMvaW1hZ2Utb2JqZWN0LWluLWNhbnZhcy5odG1sIGFzIGZhaWxpbmcu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisK IDIwMTAtMDgtMDYgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVw ZGF0ZSBjaHJvbWl1bSB0ZXN0IHJlc3VsdHMuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA2NDg3MikK KysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAko d29ya2luZyBjb3B5KQpAQCAtMzE4OSwzICszMTg5LDYgQEAgQlVHU0FUSVNIOiBmYXN0L3NwZWVj aC9pbnB1dC10ZXh0LXNwZWVjaAogQlVHNTE0MTYgOiBmYXN0L2RvbS9EZXZpY2VNb3Rpb24vY3Jl YXRlLWV2ZW50Lmh0bWwgPSBURVhUCiBCVUc1MTQxNiA6IGZhc3QvZG9tL0RldmljZU1vdGlvbi9v cHRpb25hbC1ldmVudC1wcm9wZXJ0aWVzLmh0bWwgPSBURVhUCiBCVUc1MTQxNiA6IGZhc3QvZG9t L0RldmljZU1vdGlvbi93aW5kb3ctcHJvcGVydHkuaHRtbCA9IFRFWFQKKworLy8gV2lsbCBuZWVk IHJlYmFzZWxpbmUuCitCVUdfU0VOT1JCTEFOQ08gOiBmYXN0L2NhbnZhcy9pbWFnZS1vYmplY3Qt aW4tY2FudmFzLmh0bWwgPSBJTUFHRQo= 63909 2010-08-09 11:02:59 -0700 2010-08-10 07:01:48 -0700 Patch bug-43646-20100809140257.patch text/plain 3230 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NDk4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMDkgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUHJlZmVyIHRoZSBtZWRpdW0tcXVhbGl0eSAoYmlsaW5lYXIpIGltYWdlIHJlc2FtcGxp bmcgZm9yIDJEIGNhbnZhcyBvbgorICAgICAgICBDaHJvbWl1bS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNjQ2CisgICAgICAgIAorICAgICAgICBU aGlzIGlzIHdoYXQgdGhlIGFjY2VsZXJhdGVkIHBhdGggaXMgZ29pbmcgdG8gZG8sCisgICAgICAg IHNvIGRvIGl0IGluIHRoZSBzb2Z0d2FyZSBwYXRoIGFzIHdlbGwuCisKKyAgICAgICAgKiBodG1s L0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVt ZW50OjpjcmVhdGVJbWFnZUJ1ZmZlcik6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NDb250ZXh0Lmg6CisKIDIwMTAtMDgtMDkgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3Nl dEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4uCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAJKHJldmlzaW9uIDY0OTgx KQorKysgV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDA1LDYgKzQwNSw3IEBAIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmNyZWF0ZUltYWdlQnVm ZmUKICAgICAgICAgcmV0dXJuOwogICAgIG1faW1hZ2VCdWZmZXItPmNvbnRleHQoKS0+c2NhbGUo RmxvYXRTaXplKHNpemUud2lkdGgoKSAvIHVuc2NhbGVkU2l6ZS53aWR0aCgpLCBzaXplLmhlaWdo dCgpIC8gdW5zY2FsZWRTaXplLmhlaWdodCgpKSk7CiAgICAgbV9pbWFnZUJ1ZmZlci0+Y29udGV4 dCgpLT5zZXRTaGFkb3dzSWdub3JlVHJhbnNmb3Jtcyh0cnVlKTsKKyAgICBtX2ltYWdlQnVmZmVy LT5jb250ZXh0KCktPnNldEltYWdlSW50ZXJwb2xhdGlvblF1YWxpdHkoQ2FudmFzSW50ZXJwb2xh dGlvblF1YWxpdHkpOwogfQogCiBHcmFwaGljc0NvbnRleHQqIEhUTUxDYW52YXNFbGVtZW50Ojpk cmF3aW5nQ29udGV4dCgpIGNvbnN0CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv R3JhcGhpY3NDb250ZXh0LmgJKHJldmlzaW9uIDY0OTgxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAkod29ya2luZyBjb3B5KQpAQCAtOTYsNiArOTYsMTIg QEAgdHlwZWRlZiB1bnNpZ25lZCBjaGFyIFVJbnQ4OwogI2VuZGlmCiAjZW5kaWYKIAorI2lmIFBM QVRGT1JNKENIUk9NSVVNKQorI2RlZmluZSBDYW52YXNJbnRlcnBvbGF0aW9uUXVhbGl0eSBJbnRl cnBvbGF0aW9uTWVkaXVtCisjZWxzZQorI2RlZmluZSBDYW52YXNJbnRlcnBvbGF0aW9uUXVhbGl0 eSBJbnRlcnBvbGF0aW9uRGVmYXVsdAorI2VuZGlmCisKICNpZiBQTEFURk9STShRVCkgJiYgZGVm aW5lZChRX1dTX1dJTikKICNpbmNsdWRlIDx3aW5kb3dzLmg+CiAjZW5kaWYKSW5kZXg6IExheW91 dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDY0OTg0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTAtMDgtMDkgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGVtcG9yYXJpbHkgbWFyayBodG1sL2NhbnZhcy9pbWFnZS1vYmplY3QtaW4tY2FudmFz Lmh0bWwgYXMgZmFpbGluZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQzNjQ2CisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVj dGF0aW9ucy50eHQ6CisKIDIwMTAtMDgtMDkgIEZyYW7Dp29pcyBTYXVzc2V0ICA8c2F1c3NldEBn bWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9u cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9l eHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA2NDk4MSkKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMzE4NSw1 ICszMTg1LDggQEAgQlVHNTE0MTYgOiBmYXN0L2RvbS9EZXZpY2VNb3Rpb24vY3JlYXRlLQogQlVH NTE0MTYgOiBmYXN0L2RvbS9EZXZpY2VNb3Rpb24vb3B0aW9uYWwtZXZlbnQtcHJvcGVydGllcy5o dG1sID0gVEVYVAogQlVHNTE0MTYgOiBmYXN0L2RvbS9EZXZpY2VNb3Rpb24vd2luZG93LXByb3Bl cnR5Lmh0bWwgPSBURVhUCiAKKy8vIFdpbGwgbmVlZCByZWJhc2VsaW5lLgorQlVHX1NFTk9SQkxB TkNPIDogZmFzdC9jYW52YXMvaW1hZ2Utb2JqZWN0LWluLWNhbnZhcy5odG1sID0gSU1BR0UKKwog Ly8gU2xvdyB0ZXN0IGludHJvZHVjZWQgaW4gcjY0ODE3CiBCVUc1MTU3MSA6IGh0dHAvdGVzdHMv bWlzYy9iYWQtY2hhcnNldC1hbGlhcy5odG1sID0gVElNRU9VVAo=