43644 2010-08-06 14:29:05 -0700 [chromium] GraphicsContext3D should bypass the software rendering path when doing accelerated compositing 2010-08-09 10:40:03 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 vangelis vangelis dglazkov eric oldest_to_newest 261465 0 vangelis 2010-08-06 14:29:05 -0700 As the code currently stands, during gpu compositing, the graphics layer corresponding to a WebGL context can be asked to render its contents into a canvas backed GraphicsContext, resulting in an expensive GL readback operation that's not necessary. In the chromium code this happens when calling GraphicsContext3D::beginPaint() which was implemented for the software compositing path. 261517 1 63767 vangelis 2010-08-06 15:14:25 -0700 Created attachment 63767 Proposed patch 262204 2 63767 dglazkov 2010-08-09 10:15:02 -0700 Comment on attachment 63767 Proposed patch ok. 262214 3 63767 eric 2010-08-09 10:39:58 -0700 Comment on attachment 63767 Proposed patch Clearing flags on attachment: 63767 Committed r64990: <http://trac.webkit.org/changeset/64990> 262215 4 eric 2010-08-09 10:40:03 -0700 All reviewed patches have been landed. Closing bug. 63767 2010-08-06 15:14:25 -0700 2010-08-09 10:39:58 -0700 Proposed patch skipBeginPaint_43644.txt text/plain 2829 vangelis SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjQ4NjgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMDYgIFZhbmdl bGlzIEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNraXAgdGhlIHNsb3cgc29mdHdhcmUgcmVu ZGVyaW5nIHBhdGggb2YgR3JhcGhpY3NDb250ZXh0M0QgaWYgYWNjZWxlcmF0ZWQKKyAgICAgICAg Y29tcG9zaXRpbmcgaXMgYWN0aXZlLiBUaGlzIGZpeGVzIGFuIGlzc3VlIHdpdGggV2ViR0wgYW5k IHRoZSBjb21wb3NpdG9yCisgICAgICAgIGluIHdoaWNoIHRoZSBzb2Z0d2FyZSByZW5kZXJpbmcg b2YgV2ViR0wgd291bGQgY2F1c2UgdGhlIGN1cnJlbnQgR0wgY29udGV4dAorICAgICAgICB0byBj aGFuZ2Ugd2hpbGUgdGhlIGNvbXBvc2l0b3Igd2FzIHByb2Nlc3NpbmcgbGF5ZXJzLiBUZXN0ZWQg YnkgcnVubmluZworICAgICAgICBzZXZlcmFsIFdlYkdMIHNhbXBsZXMgYm90aCB3aXRoIHRoZSBj b21wb3NpdG9yIGVuYWJsZWQgYW5kIGRpc2FibGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDM2NDQKKworICAgICAgICAqIHNyYy9HcmFwaGljc0Nv bnRleHQzRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzREludGVybmFs OjpHcmFwaGljc0NvbnRleHQzREludGVybmFsKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dDNESW50ZXJuYWw6OmluaXRpYWxpemUpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhp Y3NDb250ZXh0M0RJbnRlcm5hbDo6YmVnaW5QYWludCk6CisKIDIwMTAtMDgtMDYgIEplc3NpZSBC ZXJsaW4gIDxqYmVybGluQGFwcGxlLmNvbT4KIAogICAgICAgICBSb2xsIG91dCBodHRwOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC82NDgwMSwgd2hpY2ggYnJva2UgdGhlIFNhZmFyaSBXaW5k b3dzIEJ1aWxkLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRleHQzRC5j cHAJKHJldmlzaW9uIDY0NzY1KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRl eHQzRC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwMyw2ICszMDMsNyBAQCBwdWJsaWM6CiAKIHBy aXZhdGU6CiAgICAgT3duUHRyPFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0Q+IG1faW1wbDsK KyAgICBXZWJLaXQ6OldlYlZpZXdJbXBsKiBtX3dlYlZpZXdJbXBsOwogI2lmIFVTRShBQ0NFTEVS QVRFRF9DT01QT1NJVElORykKICAgICBSZWZQdHI8V2ViR0xMYXllckNocm9taXVtPiBtX2NvbXBv c2l0aW5nTGF5ZXI7CiAjZW5kaWYKQEAgLTMyMSw5ICszMjIsMTAgQEAgcHJpdmF0ZToKIH07CiAK IEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OkdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWwoKQor ICAgIDogbV93ZWJWaWV3SW1wbCgwKQogI2lmIFBMQVRGT1JNKFNLSUEpCiAjZWxpZiBQTEFURk9S TShDRykKLSAgICA6IG1fcmVuZGVyT3V0cHV0KDApCisgICAgLCBtX3JlbmRlck91dHB1dCgwKQog I2Vsc2UKICNlcnJvciBNdXN0IHBvcnQgdG8geW91ciBwbGF0Zm9ybQogI2VuZGlmCkBAIC0zNTQs MTEgKzM1NiwxMSBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OmluaXRpYWxpCiAg ICAgQ2hyb21lKiBjaHJvbWUgPSBzdGF0aWNfY2FzdDxDaHJvbWUqPihob3N0V2luZG93KTsKICAg ICBXZWJLaXQ6OkNocm9tZUNsaWVudEltcGwqIGNocm9tZUNsaWVudEltcGwgPSBzdGF0aWNfY2Fz dDxXZWJLaXQ6OkNocm9tZUNsaWVudEltcGwqPihjaHJvbWUtPmNsaWVudCgpKTsKIAotICAgIFdl YktpdDo6V2ViVmlld0ltcGwqIHdlYlZpZXcgPSBjaHJvbWVDbGllbnRJbXBsLT53ZWJWaWV3KCk7 CisgICAgbV93ZWJWaWV3SW1wbCA9IGNocm9tZUNsaWVudEltcGwtPndlYlZpZXcoKTsKIAotICAg IGlmICghd2ViVmlldykKKyAgICBpZiAoIW1fd2ViVmlld0ltcGwpCiAgICAgICAgIHJldHVybiBm YWxzZTsKLSAgICBpZiAoIXdlYkNvbnRleHQtPmluaXRpYWxpemUod2ViQXR0cmlidXRlcywgd2Vi VmlldykpIHsKKyAgICBpZiAoIXdlYkNvbnRleHQtPmluaXRpYWxpemUod2ViQXR0cmlidXRlcywg bV93ZWJWaWV3SW1wbCkpIHsKICAgICAgICAgZGVsZXRlIHdlYkNvbnRleHQ7CiAgICAgICAgIHJl dHVybiBmYWxzZTsKICAgICB9CkBAIC00NTMsNiArNDU1LDEwIEBAIHZvaWQgR3JhcGhpY3NDb250 ZXh0M0RJbnRlcm5hbDo6cGFpbnRSZW4KIAogdm9pZCBHcmFwaGljc0NvbnRleHQzREludGVybmFs OjpiZWdpblBhaW50KENhbnZhc1JlbmRlcmluZ0NvbnRleHQqIGNvbnRleHQpCiB7CisgICAgLy8g SWYgdGhlIGdwdSBjb21wb3NpdG9yIGlzIG9uIHRoZW4gc2tpcCB0aGUgcmVhZGJhY2sgYW5kIHNv ZnR3YXJlIHJlbmRlcmluZyBwYXRoLgorICAgIGlmIChtX3dlYlZpZXdJbXBsLT5pc0FjY2VsZXJh dGVkQ29tcG9zaXRpbmdBY3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgcGFpbnRSZW5k ZXJpbmdSZXN1bHRzVG9DYW52YXMoY29udGV4dCk7CiB9CiAK