43631 2010-08-06 11:19:21 -0700 add "const" to WebChromeClient::webView(). 2010-08-06 14:23:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED P2 Normal --- 0 yongjun_zhang webkit-unassigned joepeck yongjun_zhang oldest_to_newest 261366 0 yongjun_zhang 2010-08-06 11:19:21 -0700 ChromeClient::didReceiveViewportArguments() has changed to be a "const" method. If we call WebChromeClient::webView() inside port-specific didReceiveViewportArguments() const, the compiler won't be happy because currently webView() is not const. We need to change WebChromeClient()::webView() to be "const". 261367 1 yongjun_zhang 2010-08-06 11:20:04 -0700 It is blocking <rdar://problem/8274174>. 261368 2 63744 yongjun_zhang 2010-08-06 11:28:10 -0700 Created attachment 63744 Change WebChromeClient::webView() to be const. 261409 3 63744 eric 2010-08-06 13:15:44 -0700 Comment on attachment 63744 Change WebChromeClient::webView() to be const. OK. 261463 4 joepeck 2010-08-06 14:23:38 -0700 Committed r64868 M WebKit/mac/WebCoreSupport/WebChromeClient.h M WebKit/mac/ChangeLog r64868 = aa39e0ac7d3f2dd39f182bef3818b79e35d8db2e (refs/remotes/trunk) http://trac.webkit.org/changeset/64868 63744 2010-08-06 11:28:10 -0700 2010-08-06 13:15:44 -0700 Change WebChromeClient::webView() to be const. const_webview.patch text/plain 1363 yongjun_zhang SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA2NDg1OSkKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDgtMDYgIFlvbmdqdW4gWmhhbmcgIDx5b25n anVuX3poYW5nQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBhZGQgImNvbnN0IiB0byBXZWJDaHJvbWVDbGllbnQ6OndlYlZpZXcoKS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQzNjMxCisK KyAgICAgICAgQ2hhbmdlIFdlYkNocm9tZUNsaWVudDo6d2ViVmlldygpIHRvIGJlIGNvbnN0IGJl Y2F1c2UgQ2hyb21lQ2xpZW50OjpkaWRSZWNlaXZlVmlld3BvcnRBcmd1bWVudHMKKyAgICAgICAg aXMgY29uc3QgbWV0aG9kIG5vdywgYW5kIGNhbGxpbmcgd2ViVmlldygpIGluc2lkZSBwb3J0LXNw ZWNpZmljIGRpZFJlY2VpdmVWaWV3cG9ydEFyZ3VtZW50cworICAgICAgICBpbXBsZW1lbnRhdGlv biBmYWlscyBjb21waWxpbmcgaWYgd2ViVmlldygpIGlzIG5vdCBjb25zdC4KKworICAgICAgICAq IFdlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5oOgorICAgICAgICAoV2ViQ2hyb21lQ2xp ZW50Ojp3ZWJWaWV3KToKKwogMjAxMC0wOC0wNSAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIEtpbHplci4KSW5kZXg6IFdl YktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuaAkocmV2aXNpb24gNjQ4 NTYpCisrKyBXZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNocm9tZUNsaWVudC5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0zNiw3ICszNiw3IEBACiBjbGFzcyBXZWJDaHJvbWVDbGllbnQgOiBwdWJs aWMgV2ViQ29yZTo6Q2hyb21lQ2xpZW50IHsKIHB1YmxpYzoKICAgICBXZWJDaHJvbWVDbGllbnQo V2ViVmlldyAqd2ViVmlldyk7Ci0gICAgV2ViVmlldyAqd2ViVmlldygpIHsgcmV0dXJuIG1fd2Vi VmlldzsgfQorICAgIFdlYlZpZXcgKndlYlZpZXcoKSBjb25zdCB7IHJldHVybiBtX3dlYlZpZXc7 IH0KICAgICAKICAgICB2aXJ0dWFsIHZvaWQgY2hyb21lRGVzdHJveWVkKCk7CiAgICAgCg==