43620 2010-08-06 07:11:20 -0700 NPAPI headers should be included through npruntime_internal.h 2010-08-07 06:51:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 kbalazs webkit-unassigned abarth abecsi andersca eric sam webkit.review.bot oldest_to_newest 261234 0 kbalazs 2010-08-06 07:11:20 -0700 npruntime_internal.h says "If you need to include npapi.h or npruntime.h when building on X11, include this file instead of the actual npapi.h or npruntime.h." Currently in the WebKit2 directory there are files that includes npapi.h and npruntime.h directly. This brakes the build of the qt port. I would suggest to observe the rule everywhere. 261240 1 63720 kbalazs 2010-08-06 07:19:03 -0700 Created attachment 63720 proposed patch Change includes in WebKit2 261487 2 eric 2010-08-06 14:44:39 -0700 Looks non-harmful. 261706 3 abecsi 2010-08-07 04:48:14 -0700 Committed r64905: <http://trac.webkit.org/changeset/64905> 261717 4 webkit.review.bot 2010-08-07 06:20:05 -0700 http://trac.webkit.org/changeset/64905 might have broken Leopard Intel Debug (Tests) 261719 5 63720 kbalazs 2010-08-07 06:51:03 -0700 Comment on attachment 63720 proposed patch Clearing flags on committed patch. 63720 2010-08-06 07:19:03 -0700 2010-08-07 06:51:03 -0700 proposed patch land_np_build_fix_qt.diff text/plain 2502 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg YWZmZjNlYi4uM2E3MzQ0OSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wOC0wNiAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTlBBUEkgaGVhZGVycyBzaG91bGQgYmUgaW5jbHVkZWQgdGhyb3Vn aCBucHJ1bnRpbWVfaW50ZXJuYWwuaAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MzYyMAorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMucHJvOgor ICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OUEpTT2JqZWN0Lmg6CisgICAgICAgICogV2Vi UHJvY2Vzcy9QbHVnaW5zL05QUnVudGltZVV0aWxpdGllcy5oOgorICAgICAgICAqIFdlYlByb2Nl c3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVhbS5oOgorCiAyMDEwLTA4LTA1 ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5k ZXJzIENhcmxzc29uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9EZXJpdmVkU291cmNlcy5wcm8gYi9X ZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLnBybwppbmRleCA4MGZiMGE3Li45YmYyYjY4IDEwMDY0NAot LS0gYS9XZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLnBybworKysgYi9XZWJLaXQyL0Rlcml2ZWRTb3Vy Y2VzLnBybwpAQCAtOCw4ICs4LDcgQEAgV0VCQ09SRV9IRUFERVJTX0ZPUl9XRUJLSVQyICs9IFwK ICAgICBiaW5kaW5ncy9qcy9HQ0NvbnRyb2xsZXIuaCBcCiAgICAgYmluZGluZ3MvanMvSlNQbHVn aW5FbGVtZW50RnVuY3Rpb25zLmggXAogICAgIGJyaWRnZS9JZGVudGlmaWVyUmVwLmggXAotICAg IGJyaWRnZS9ucGFwaS5oIFwKLSAgICBicmlkZ2UvbnBydW50aW1lLmggXAorICAgIGJyaWRnZS9u cHJ1bnRpbWVfaW50ZXJuYWwuaCBcCiAgICAgY29uZmlnLmggXAogICAgIGNzcy9DU1NDb21wdXRl ZFN0eWxlRGVjbGFyYXRpb24uaCBcCiAgICAgZG9tL0V2ZW50LmggXApkaWZmIC0tZ2l0IGEvV2Vi S2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTlBKU09iamVjdC5oIGIvV2ViS2l0Mi9XZWJQcm9jZXNz L1BsdWdpbnMvTlBKU09iamVjdC5oCmluZGV4IDA4YWM5ZDQuLjY3MzdiZDQgMTAwNjQ0Ci0tLSBh L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05QSlNPYmplY3QuaAorKysgYi9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9OUEpTT2JqZWN0LmgKQEAgLTI3LDcgKzI3LDcgQEAKICNkZWZpbmUg TlBKU09iamVjdF9oCiAKICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9Qcm90ZWN0Lmg+Ci0jaW5j bHVkZSA8V2ViQ29yZS9ucHJ1bnRpbWUuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL25wcnVudGltZV9p bnRlcm5hbC5oPgogI2luY2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogCiBuYW1lc3BhY2UgSlND IHsKZGlmZiAtLWdpdCBhL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05QUnVudGltZVV0aWxp dGllcy5oIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTlBSdW50aW1lVXRpbGl0aWVzLmgK aW5kZXggYjI5MzBiMy4uMzkzY2IzOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTlBSdW50aW1lVXRpbGl0aWVzLmgKKysrIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdp bnMvTlBSdW50aW1lVXRpbGl0aWVzLmgKQEAgLTI2LDcgKzI2LDcgQEAKICNpZm5kZWYgTlBSdW50 aW1lVXRpbGl0aWVzX2gKICNkZWZpbmUgTlBSdW50aW1lVXRpbGl0aWVzX2gKIAotI2luY2x1ZGUg PFdlYkNvcmUvbnBydW50aW1lLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9ucHJ1bnRpbWVfaW50ZXJu YWwuaD4KIAogc3RydWN0IE5QQ2xhc3M7CiBzdHJ1Y3QgTlBPYmplY3Q7CmRpZmYgLS1naXQgYS9X ZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVhbS5o IGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW5TdHJl YW0uaAppbmRleCA0YjZmZmFjLi5iMmMwNjE4IDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nl c3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpblN0cmVhbS5oCisrKyBiL1dlYktpdDIv V2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luU3RyZWFtLmgKQEAgLTI4 LDcgKzI4LDcgQEAKIAogI2luY2x1ZGUgIlJ1bkxvb3AuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0Zp bGVTeXN0ZW0uaD4KLSNpbmNsdWRlIDxXZWJDb3JlL25wYXBpLmg+CisjaW5jbHVkZSA8V2ViQ29y ZS9ucHJ1bnRpbWVfaW50ZXJuYWwuaD4KICNpbmNsdWRlIDx3dGYvRm9yd2FyZC5oPgogI2luY2x1 ZGUgPHd0Zi9QYXNzUmVmUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4K